Commit Graph

25 Commits

Author SHA1 Message Date
Alexander Aprelev 6b3abe0a98 [vm/concurrency] Add --experimental_enable_isolate_groups_jit flag, make --enable_isolate_groups AOT only.
Issue b/177800357.

TEST=existing test suite
Change-Id: Id6b113932ab7014b8fa6c105845c5c490b60f5e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181320
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2021-01-27 17:11:29 +00:00
Michal Terepeta 4237fda6a5 Check for IN_MODIFY in file_system_watcher_linux.cc
This allows to detect changes to a file due to `write` or `truncate`
syscalls.

Change-Id: I095d842367a56121cd87c2176dde0a4feb5e3d7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161177
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Auto-Submit: Michal Terepeta <michalt@google.com>
2020-09-08 17:57:45 +00:00
Lasse R.H. Nielsen 8760283247 New implementation of runZoned.
A combination of `runZoned` and `runZonedGuarded` where only the latter allows an `onError` parameter,
and only that has a nullable return type.

Retains the `onError` parameter on `runZoned` for now because it's too breaking to remove it until packages have been migrated off of it.
It will be removed in a follow-up CL.

Change-Id: If0e86c8d14e13fa089c66f4af975aeacb2616cf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137302
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2020-03-25 00:24:33 +00:00
Jonas Termansen 3433d8cfc3 [nnbd] Migrate standalone/io to NNBD.
The tests are also now dartfmt.

Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-02-07 14:41:36 +00:00
Siva Annamalai bc4860b0cb Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2.
This CL removes these redundant tests from the standalone directory.

Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-11-07 23:00:00 +00:00
William Hesse 7bf2788bcc Restore all deleted tests to tests/standalone from migration to standalone_2
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
2017-10-09 10:46:55 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory.
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-07 01:29:36 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move"
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-06 17:07:34 +00:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
ajohnsen@google.com 79cf8dc61f Don't report file-system move events on Mac OS, and use no-defer to avoid past events.
Mac OS does not have a proper way to report 'from' and 'to', thus making it impossible to reason the move direction, as other events may shuffle the order, events are received in.

BUG=https://code.google.com/p/dart/issues/detail?id=14806,https://code.google.com/p/dart/issues/detail?id=14793,https://code.google.com/p/dart/issues/detail?id=14849
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//88063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30710 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 11:48:14 +00:00
ajohnsen@google.com e70ae87df1 Fire event and close the stream when the watched directory is moved.
BUG=https://code.google.com/p/dart/issues/detail?id=14598
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//52123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29532 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 11:35:33 +00:00
ajohnsen@google.com 7a1fdfe99a Fix file-system-entity watching on Windows.
This includes disabling a test, as Windows have no way of detecting when the watched directory is deleted.

BUG=

Review URL: https://codereview.chromium.org//47213007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29379 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 17:57:22 +00:00
ajohnsen@google.com 2101ba9c12 Add 'isDir' to FileSystemEvent.
BUG=https://code.google.com/p/dart/issues/detail?id=14425
R=whesse@google.com

Review URL: https://codereview.chromium.org//48613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29371 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 17:14:43 +00:00
ajohnsen@google.com 268a3ce38a Disable test on mac, as it allows listening on non-existing paths.
BUG=

Review URL: https://codereview.chromium.org//48713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29359 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 13:22:46 +00:00
ajohnsen@google.com 9ffff34ddb Correctly pass errors to the stream, when watching file system entities.
BUG=https://code.google.com/p/dart/issues/detail?id=14470
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//47723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29356 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 12:08:49 +00:00
ajohnsen@google.com fdea26c768 Close file watcher when target is deleted.
BUG=http://code.google.com/p/dart/issues/detail?id=14374
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//39613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29159 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 08:12:16 +00:00
whesse@google.com 2a987cceea Modify tests to use Directory.systemTemp.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//25471003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28219 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 13:28:35 +00:00
ajohnsen@google.com a86f11f4ab IssueRead for DirectoryWatcherHandle as soon as the watcher starts.
This makes sure we don't miss any initial events.

BUG=https://code.google.com/p/dart/issues/detail?id=13228
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//25687003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28148 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 11:10:13 +00:00
ajohnsen@google.com f55580a137 Relax expectations for events on mac, and allow move events to not have a destination.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23537021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27184 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 09:31:35 +00:00
ajohnsen@google.com 58e5923de2 Run file system operations in file_system_watcher_test after a runAsync delay.
This fixes the flakyness seen on Windows.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//23668006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27065 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 16:07:06 +00:00
ajohnsen@google.com 7c53dfaf3f Make file system watcher compile on Mac OS 106, and add a runtime-call to test if the system supports the feature.
BUG=
R=kustermann@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23483030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27064 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 15:42:02 +00:00
ajohnsen@google.com 7f25bcad1a Make multi-test less strict, to avoid oddly-delayed errors on Windows.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23506025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27055 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 13:49:49 +00:00
ajohnsen@google.com 82e0b66a40 Remove unused line from file_system_watcher_test.
BUG=

Review URL: https://codereview.chromium.org//23895002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27052 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 13:21:09 +00:00
ajohnsen@google.com 38bae0af02 Add FileSystemWatcher class to dart:io.
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//19263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27048 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-03 12:43:08 +00:00