dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

30 Commits

Author SHA1 Message Date
Jonas Termansen e725e8edf2 [nnbd] Fix regressions in the standalone/io migration. 
Closes https://github.com/dart-lang/sdk/issues/40571.

Change-Id: I38704ab2583f4e856866f091ac652a8a652abe54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137101
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
 2020-03-18 20:38:52 +00:00
Jonas Termansen 3433d8cfc3 [nnbd] Migrate standalone/io to NNBD. 
The tests are also now dartfmt.

Bug: https://github.com/dart-lang/sdk/issues/40040
Change-Id: I8dece8097b37b70d47a5374dae2f3fadb0fc4b90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134338
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2020-02-07 14:41:36 +00:00
Siva Annamalai bc4860b0cb Most VM specific tests in standalone have been moved to standalone_2 and are being run in the regular bot tests. These tests are for VM functionality like io, process API etc. and have no strong mode implications. Currently we are running these tests twice once from standalone and once from standalone_2. 
This CL removes these redundant tests from the standalone directory.

Bug:
Change-Id: Ib0adfa67fffa4de486e847698e18353fb4dd8a46
Reviewed-on: https://dart-review.googlesource.com/18429
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-07 23:00:00 +00:00
William Hesse 7bf2788bcc Restore all deleted tests to tests/standalone from migration to standalone_2 
We are no longer deleting tests from the Dart 1 test directories when we
add them to the _2 directories. This reverts the part of change
https://dart-review.googlesource.com/c/sdk/+/12240 that modifies
the tests/standlone directory.
Bug:
Change-Id: Ie26b185234d0d18736a2fa13b77c5fd42cbb7e92
Reviewed-on: https://dart-review.googlesource.com/12287
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-09 10:46:55 +00:00
Siva Annamalai bd2a8e1d60 Reland migrate most of the tests in standalone to be strong mode clean and move them to standalone_2 directory. 
Bug:
Change-Id: I4ca50f315361422db1d4356055862463bfe1d6f3
Reviewed-on: https://dart-review.googlesource.com/12240
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-07 01:29:36 +00:00
Siva Annamalai ff32187145 Revert "Migrate most of the tests in standalone to be strong mode clean and move" 
This reverts commit c85563f582.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Migrate most of the tests in standalone to be strong mode clean and move
> them to standalone_2 directory.
> 
> Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
> Reviewed-on: https://dart-review.googlesource.com/6080
> Reviewed-by: Ben Konyi <bkonyi@google.com>

TBR=bkonyi@google.com,asiva@google.com

Change-Id: I3c7b6081f17fca45e7828603538f50d06417e2be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/12020
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2017-10-06 17:24:20 +00:00
Siva Annamalai c85563f582 Migrate most of the tests in standalone to be strong mode clean and move 
them to standalone_2 directory.

Change-Id: I9887b8d6d4d86001e4660b400224b881205e6273
Reviewed-on: https://dart-review.googlesource.com/6080
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-06 17:07:34 +00:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
lrn@google.com f0a1c922a2 Reapply "Remove @deprecated features." 
R=scheglov@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//50413005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29535 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 12:09:15 +00:00
whesse@google.com eac99db65d Fix remaining uses of Directory.systemTemp outside test scripts. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//25666015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28576 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 10:53:12 +00:00
whesse@google.com 2a987cceea Modify tests to use Directory.systemTemp. 
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//25471003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28219 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 13:28:35 +00:00
sgjesse@google.com 18c75d3dc2 Update dart:io tests to use asyncStart/asyncEnd 
R=ajohnsen@google.com
BUG=http://dartbug.com/12977

Review URL: https://codereview.chromium.org//23886004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27054 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-03 13:42:56 +00:00
ajohnsen@google.com c57845f756 Clean up dart:io warnings/errors found by analyzer tests. 
BUG=https://code.google.com/p/dart/issues/detail?id=11665
R=whesse@google.com

Review URL: https://codereview.chromium.org//18496011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24764 260f80e4-7a28-3924-810f-c04153c831b5
 2013-07-04 08:17:43 +00:00
sgjesse@google.com 7841206de5 Change File.directory to not do any IO 
Removed the File.directory and File.directorySync methods and added a
File.directory getter. The File.directory getter does not do any IO,
but just calculates the directory of the file from the path.

R=whesse@google.com
BUG=http://dartbug.com/9926

Review URL: https://codereview.chromium.org//15832003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23349 260f80e4-7a28-3924-810f-c04153c831b5
 2013-05-29 12:38:27 +00:00
ajohnsen@google.com b4eacbf8aa Rename RandomAccessFile.readList and RandomAccessFile.writeList to RandomAccessFile.readInto and RandomAccessFile.writeFrom. 
BUG=

Review URL: https://codereview.chromium.org//14018007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21466 260f80e4-7a28-3924-810f-c04153c831b5
 2013-04-15 15:44:41 +00:00
sgjesse@google.com 49dec76806 Change all File APIs to make the mode and encoding arguments named 
R=ager@google.com, ajohnsen@google.com, whesse@google.com, floitsch@google.com

BUG=

Review URL: https://codereview.chromium.org//12609004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20153 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-18 12:10:32 +00:00
sgjesse@google.com b6096848b1 Make IOSink implement StringSink 
Besides adding the StringSink methods I also added writeBytes and
deprecated both add and addString.

To handle the encoding of strings the IOSike has an encoding
property. This property is mutable in situation when it makes sense to
change encoding of what is written. The exception here is for HTTP
where the encoding is determined from the header and the encoding
cannot be changed.

R=ajohnsen@google.com, ager@google.com, nweiz@google.com

BUG=

Review URL: https://codereview.chromium.org//12504006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19676 260f80e4-7a28-3924-810f-c04153c831b5
 2013-03-08 10:06:28 +00:00
sgjesse@google.com 488b016a2f Merge IO v2 branch to bleeding edge 
R=ager@google.com, ajohnsen@google.com, whesse@google.com

BUG=

Review URL: https://codereview.chromium.org//12316036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18820 260f80e4-7a28-3924-810f-c04153c831b5
 2013-02-21 11:58:11 +00:00
lrn@google.com 4868ee2110 Remove Futures class, move methods to Future. 
Optimize Future.forEach, Future.delay.

Review URL: https://codereview.chromium.org//11865005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16954 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-11 09:46:45 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge. 
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
 2013-01-07 11:23:16 +00:00
whesse@google.com e128dd9f14 Remove old #import, #source, and #library syntax from tests/standalone. 
BUG=dart:7066

Review URL: https://codereview.chromium.org//11570005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16106 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-13 13:06:04 +00:00
ager@google.com 3fb41705e5 Rename File.readAsText to File.readAsString. There is no Text type in Dart 
and the methods return Strings.

R=sgjesse@google.com
BUG=

Review URL: https://codereview.chromium.org//11412033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15011 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-16 13:10:15 +00:00
ager@google.com b61bebe636 Allow Directory.create to create all missing path components. 
Unified Directory.create/list/delete to take a named 'recursive'
argument.

Fixed bug in Path implementation on Windows.

R=sgjesse@google.com
BUG=dartbug.com/6024

Review URL: https://codereview.chromium.org//11364097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14572 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-06 15:00:54 +00:00
ager@google.com 379695ee2b Implement File.lastModified. 
R=sgjesse@google.com,ajohnsen@google.com
BUG=dartbug/2988
TEST=standalone/io/file*

Review URL: https://chromiumcodereview.appspot.com//10443008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7945 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-24 13:10:02 +00:00
ager@google.com 6b503da4f9 Fuzzing of dart:io Directory API. 
Uncovered one issue where an usupported value was posted back
through a native port on a failed directory listing operation.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10408060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7894 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-23 08:22:09 +00:00
ager@google.com 169e2ae549 Finish file 'fuzzer' and fix issues. 
- One integer extraction issue.
- Changed to using nativeport.call().transform to make sure that exceptions during the processing of the reply are propagated to the future.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10411053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7843 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-22 09:52:36 +00:00
ager@google.com a47410bbed Reland: Add more API fuzzing and fix the issues encountered. 
Only change from original code review is the closing of files
opened in the test.

- Fixed integer checks in a couple of places.
- Added closed checks to async operations.

More changes like this coming but I'm splitting the work up to not
make the review too large.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10414021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7790 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-21 10:52:01 +00:00
ager@google.com 330aa1ab66 Revert "Add more API fuzzing and fix the issues encountered." 
I know what is wrong but don't have the time to fix it right now.
I open a lot of files that are not closed and therefore the directory
cannot be deleted on Windows. Will fix ASAP.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10398053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7684 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-16 13:02:48 +00:00
ager@google.com ceb6a9b621 Add more API fuzzing and fix the issues encountered. 
- Fixed integer checks in a couple of places.
- Added closed checks to async operations.

More changes like this coming but I'm splitting the work up to not
make the review too large.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10382194

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7683 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-16 12:52:10 +00:00
ager@google.com 4a698f9fb3 Start 'fuzzing' of dart:io APIs and fix first issue found. 
Deserialize unsupported Dart objects to Dart_CObject of type
kUnsupported instead of NULL pointers. That way the normal
Dart_CObject validation that tests for supported types will
work out of the box and not crash the VM.

R=sgjesse@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//10383179

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7645 260f80e4-7a28-3924-810f-c04153c831b5
 2012-05-15 10:40:44 +00:00