Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.
Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
This moves Http code into dart:_http. dart:io then imports and
re-exports dart:_http. This is the first stage of moving
dart:_http into its own pub package.
This CL was reverted due to a failure in the Flutter engine build
which happened due to an incomplete change in gen_snapshot.cc, and to
update sdk/lib/libraries.yaml and sdk/lib/libraries.json
Change-Id: Ie90c77ef631aea7a163774b58e8ccbaf71a24d3c
Reviewed-on: https://dart-review.googlesource.com/7588
Reviewed-by: Zach Anderson <zra@google.com>
Reverting for broken Flutter build and kernel platform compilation test. It looks like the new _http library is missing from various snapshots. Not sure why this didn't fail locally.
This reverts commit ac9ff3f3af.
Change-Id: I7fbc2f842cf1380793e7af9fb869cacd14682885
Reviewed-on: https://dart-review.googlesource.com/7600
Reviewed-by: Zach Anderson <zra@google.com>
This moves Http code into dart:_http. dart:io then imports and
re-exports dart:_http. This is the first stage of moving
dart:_http into its own pub package.
Change-Id: Icd33232a97b3d75511ef7ec88b01fd47cdcf5a23
Reviewed-on: https://dart-review.googlesource.com/6420
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
Adjusted lib_2/mirrors/initializing_formals_test.dart to match new rule
for static checking on type annotations of initializing formals.
Added language_2/initializing_formals_type_annotation_test.dart to
check the 4 main situations directly.
Change-Id: Icf763c79c99274645f7967b8c3e3a3c3f6536763
Reviewed-on: https://dart-review.googlesource.com/7268
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
Fixed some errors in other_declarations_location_test, removed checks
for TypeError when passing invalid arguments to a method in
private_symbol_test.
Bug:
Change-Id: I82030f1189a7a370d15bef4fd284d92b0b2de5bb
Reviewed-on: https://dart-review.googlesource.com/3791
Reviewed-by: Ryan Macnak <rmacnak@google.com>
lazy_static_test needed a field changed from var -> dynamic. Otherwise,
simple block.
Bug:
Change-Id: I5d685b5802da906d22f524466eb6794b75c0da62
Reviewed-on: https://dart-review.googlesource.com/3784
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Updated invoke_call_through* tests to make them strong mode clean, which
mostly involved changing var -> dynamic in some places.
Bug:
Change-Id: I3ac946bdfadd09d6459c7f104068be4cb0c49c1d
Reviewed-on: https://dart-review.googlesource.com/3781
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This is a reland of 77a7ca98a2
Original change's description:
> Migrate test batch 226 to Dart 2.0
>
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
>
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Change-Id: I083c07c08333909aaf5bce763601445ff9f0413f
Reviewed-on: https://dart-review.googlesource.com/3920
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This reverts commit 77a7ca98a2.
Reason for revert: Migrated a test file that's still being used by the unmigrated tests.
Original change's description:
> Migrate test batch 226 to Dart 2.0
>
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
>
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
TBR=jakobr@google.com,lrn@google.com
Change-Id: If4d0b44f81cfadf290bf72b23765fa85a6580937
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/3900
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
Specifically skipped formatting these files, since there are tests that depend
on non-standard source formatting.
Bug:
Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
Reviewed-on: https://dart-review.googlesource.com/3440
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Fairly simple block, with only minor changes made to lib_2/mirrors tests
needed for strong mode compliance.
BUG=
Review-Url: https://codereview.chromium.org/2997283003 .
Lasse R.H. Nielsen