dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

156 Commits

Author SHA1 Message Date
Terry Lucas 67441509ec Updated status file to match bot failures. 
TBR=vsm@google.com

Change-Id: I499bfc623e42e78d1ff79aa90d97874763c0b2f9
Reviewed-on: https://dart-review.googlesource.com/39100
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2018-02-06 14:15:47 +00:00
Terry Lucas 6ac51102a0 Include more info to track down bot failure. 
TBR=vsm@google.com

Change-Id: I50ae861f99b4c35c37596a6b3372d54cf7942070
Reviewed-on: https://dart-review.googlesource.com/39000
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-06 02:51:49 +00:00
Terry Lucas 7d7bb9c2fd Fix bots failures. 
TBR=vsm@google.com

Change-Id: I1f67df27b7b00ab7e9e6cc6fee6f0d678e1d5fc6
Reviewed-on: https://dart-review.googlesource.com/38901
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2018-02-06 00:50:53 +00:00
Terry Lucas d7a8aa155f Fixed a number of File API methods in DDC. 
R=vsm@google.com

Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-02-05 22:29:00 +00:00
Jenny Messerly 5013b28bbe fix #31999, remove fuzzy arrow runtime support from DDC 
Also updates tests that relied on fuzzy arrows.

Change-Id: Ia8df1d8d421e43dfada589223d5e46182b92fa67
Reviewed-on: https://dart-review.googlesource.com/37425
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-31 22:20:38 +00:00
Lasse R.H. Nielsen 5d84d683a8 Update status files for more Safari breakage. 
Actually document the Expect.throws behavior.

Change-Id: I4cfd540c5908fa6df8920cd87a327b1eded63f4d
Reviewed-on: https://dart-review.googlesource.com/36940
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-01-26 14:35:43 +00:00
Lasse R.H. Nielsen c10d7f402c Update tests to not assume Expect.throws catches ExpectException. 
Change-Id: I283a5286b15e479eb3fa507b1dc69189f5f42888
Reviewed-on: https://dart-review.googlesource.com/36882
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-01-26 12:25:03 +00:00
Lasse R.H. Nielsen 87e7861ec8 Make Expect.throws not accept an expectation error as a throw. 
Some small clean-up, and fixing one test that relies on the changed behavior.

Change-Id: Ibfed0c41c3121f2dc13a0d67b7534693165eb5e2
Reviewed-on: https://dart-review.googlesource.com/36620
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-25 13:24:03 +00:00
Vijay Menon bbcb34c3aa Fix mocks on js types 
Change-Id: I4b07fd0fc5d3771d93f250b5ba51261ea5bef001
Reviewed-on: https://dart-review.googlesource.com/35480
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-01-20 00:04:37 +00:00
Terry Lucas 0a02050867 Fixed DirectoryReader returned from createReader to exist in DDC. 
R=vsm@google.com

Change-Id: I6761da70b2f51f235534ee10fa0b7cb7a7a98659
Reviewed-on: https://dart-review.googlesource.com/36020
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-01-19 18:14:05 +00:00
Terry Lucas 476b1e02a9 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test. 
Also, updated status files to correctly fix failures in FF, IE and removed other spurious status entries.

R=alanknight@google.com,vsm@google.com

Change-Id: Ic965103d892ff4d5d119712e3187e829f57cd022
Reviewed-on: https://dart-review.googlesource.com/31800
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-29 23:51:02 +00:00
Terry Lucas 0af98266ab Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test." 
This reverts commit 0c8294e4a0.

Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-12-23 01:59:38 +00:00
Terry Lucas 0c8294e4a0 Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test. 
R=alanknight@google.com,vsm@google.com

Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
 2017-12-22 22:57:34 +00:00
Bob Nystrom 4d5bcd5958 Make minitest.dart a little more resilient against misues. 
We don't want to silently pass tests that think they are async when
the test framework doesn't know it's async.

Change-Id: I6556f8223d8d930ba252496adf233a5cb1108929
Reviewed-on: https://dart-review.googlesource.com/27923
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-12-13 21:32:54 +00:00
Vijay Menon e9d03b4120 Forward native static methods 
We don't generate these.  Rather than do that, this CL forwards to the
actual JS method instead.

This is the diff on the generated dart_sdk.js:

59732c59732

<     return html$.LengthValue._fromDictionary_1(dictionary_1);

---

>     return dart.global.LengthValue.fromDictionary(dictionary_1);

59894c59894

<     html$.MediaStreamTrack._getSources(dart.fn(value => {

---

>     dart.global.MediaStreamTrack.getSources(dart.fn(value => {

80232c80232

<     html$.Notification._requestPermission(dart.fn(value => {

---

>     dart.global.Notification.requestPermission(dart.fn(value => {

Change-Id: I9e857a808557e4702fb2b99aa518c25b49ff3db7
Reviewed-on: https://dart-review.googlesource.com/29020
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Vijay Menon <vsm@google.com>
 2017-12-13 13:38:36 +00:00
Terry Lucas 529add3834 DDC fix to expose classes which are only created inside of the browser. 
R=vsm@google.com

Change-Id: I27ede73ac84a72ee9b5e8b3b0a706ade82b2aa59
Reviewed-on: https://dart-review.googlesource.com/25500
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2017-12-13 03:03:09 +00:00
Bob Nystrom a53e4dd504 Finish migrating stuff out of lib_strong. 
Some of these are data files that weren't picked up by the migration
script. Some are files that slipped between blocks of tests.

Change-Id: I184dc4701758b280444d54ec55c225ade30f3276
Reviewed-on: https://dart-review.googlesource.com/26423
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-12-11 23:45:23 +00:00
Bob Nystrom a80b71fc15 Fix issues around "utils.dart" and "util.dart" in lib_2/html. 
- "util.dart" is completely unused, so deleted.

- We had two copies of "utils.dart" in two directories. It needs to
  exist in both places, but doesn't need to be copy/pasted. Replaced
  one with an export of the other.

- Fixed bad import paths to "../utils.dart" in html/custom/ tests.
  These were causing those tests to crash DDC. (Now most are instead
  failing because of #31577, so it's not a *huge* improvement, but it's
  a step in the right direction.)

- Don't use unittest in utils.dart.

Change-Id: I28c432b53c992a5ec790f5804453cddb0f44cbe5
Reviewed-on: https://dart-review.googlesource.com/27301
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2017-12-07 19:35:58 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase. 
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase." 
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase. 
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-11-14 11:13:04 +00:00
Emily Fortuna ef68e359a2 Deal with JS-interop default argument values. 
Bug:
Change-Id: I9f0c26f8716473b445922aac43248b717ce45bb3
Reviewed-on: https://dart-review.googlesource.com/19120
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-08 23:24:01 +00:00
Jacob Richman 8b221d13a4 Fix ddc debugger_test Fix regression in custom formatters due to change in metadata signatures to use Object.__proto__ instead of a null __proto__. 
Bug:
Change-Id: I68fdb980e777b7c3f335fd6b57181134e3159cc3
Reviewed-on: https://dart-review.googlesource.com/17060
Commit-Queue: Jacob Richman <jacobr@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-31 19:45:27 +00:00
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests. 
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-17 23:37:15 +00:00
Ben Konyi 41bda23a77 Migrated test block 214 to Dart 2.0. 
wrapping_collections_test was modified since JSNative is deprecated and
was causing the test to fail ('class js has no getter for JSNative').

Bug:
Change-Id: Icc8951bce4be1152984b66769676080f89e5f1f7
Reviewed-on: https://dart-review.googlesource.com/9420
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-11 20:22:31 +00:00
Terry Lucas 213830e122 Migrated Block 188 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I3a450b04becaef007cc81fda1dbca1fda58b3d19
Reviewed-on: https://dart-review.googlesource.com/12361
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-11 14:42:22 +00:00
Bob Nystrom 307742d07e Move tests from package "test" (back) to "unittest". 
Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.

Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-10 19:46:12 +00:00
Terry Lucas 8611852b81 Migrated Block 199 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic52e7afb489b15b2f2e45f5ad9191cf5e441c047
Reviewed-on: https://dart-review.googlesource.com/11342
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-10 13:53:24 +00:00
Terry Lucas 83ff87e4a3 Migrated Block 204 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I032f25969e75fb9966222da969e73a665bf35f44
Reviewed-on: https://dart-review.googlesource.com/12321
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-10 13:00:01 +00:00
Terry Lucas 0319fb1e87 Migrated Block 200 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I9d998f61c2bc3d4b9c6ea71cb1111c00983a80a5
Reviewed-on: https://dart-review.googlesource.com/11347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-09 02:45:04 +00:00
Terry Lucas 16b6ba6a04 Splitout another set of group tests. 
TBR=rnystrom@google.com

Change-Id: I6d9aea59eac88de07b76b9597cf6ceac32350b55
Reviewed-on: https://dart-review.googlesource.com/12305
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-09 01:07:37 +00:00
Terry Lucas a15c9c2d89 Need to remove test group as part of split. 
TBR=rnystrom@google.com

Change-Id: Ie1b03e9472048162f2f1c8b3f64976c3c8675bf2
Reviewed-on: https://dart-review.googlesource.com/12304
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-08 23:49:18 +00:00
Terry Lucas 61e6389f8a Migrated Block 202 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ibca90f46788ef86fdc57f746f48e8fd85b78aa5a
Reviewed-on: https://dart-review.googlesource.com/11361
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-08 23:19:49 +00:00
Terry Lucas 960fff771d Migrated Block 203 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I1f2769da1511570fa55e883a2997b8ceb4932217
Reviewed-on: https://dart-review.googlesource.com/11362
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-07 15:34:17 +00:00
Ben Konyi 7ea539a4c5 Migrated test block 190 to Dart 2.0. 
Migrated multiple tests from unittest->test, fixed small strong mode
issue in cross_frame_test.

Bug:
Change-Id: I1c504ab4ac45e487ff3d3d156416e579978adc20
Reviewed-on: https://dart-review.googlesource.com/4820
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-05 22:00:26 +00:00
Terry Lucas 949fda879a Restored keygen element test, not in chrome but other browsers support. 
In addition, split out all the group tests to individual ones - unable to detect group failures in DDC.

TBR=bkonyi@google.com

Change-Id: I80b4a146e9bea3fb959d56ec3123667bfec122bd
Reviewed-on: https://dart-review.googlesource.com/11365
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-05 19:15:35 +00:00
Terry Lucas aeb7995355 Migrated Block 201 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Iad6df128725ffc81bbf352b02efc0412aa83272f
Reviewed-on: https://dart-review.googlesource.com/11360
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 18:01:10 +00:00
Terry Lucas 0beb87c853 Migrated Block 197 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5ab3a1a5f300cc6df757ea03119595eac9dafc2
Reviewed-on: https://dart-review.googlesource.com/11340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 10:46:21 +00:00
Terry Lucas c886f96a8a Migrated Block 198 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I2280e12ba6d01a40df735083820c0ba96874ded5
Reviewed-on: https://dart-review.googlesource.com/11341
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 08:41:08 +00:00
Jakob Roland Andersen 42e28ca782 Migrated test batch 213 to Dart 2.0. 
Bug:
Change-Id: I31f519c18ab62cc0aef969f60116ed518bcb77e3
Reviewed-on: https://dart-review.googlesource.com/11061
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 07:56:30 +00:00
Terry Lucas bd588dda54 Migrated Block 196 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I1c59698b9cb2d5fd7aac4dec4ddff3cf1a851478
Reviewed-on: https://dart-review.googlesource.com/8742
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:33:42 +00:00
Terry Lucas bbbb548e0a Migrated Block 195 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5622d23d3159016625cfc17785f140ba9df409e
Reviewed-on: https://dart-review.googlesource.com/8739
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:08:10 +00:00
Jakob Roland Andersen a46ee1294a Migrated test batch 212 to Dart 2.0. 
Bug:
Change-Id: I2a062b9c1c2889355cc85884243bac580f3dce09
Reviewed-on: https://dart-review.googlesource.com/10480
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 05:16:20 +00:00
Terry Lucas 7f137ca921 Migrated Block 194 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I4e77f837a26d37e2d8f650c941f72454e6536b8d
Reviewed-on: https://dart-review.googlesource.com/8737
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 04:19:10 +00:00
Jakob Roland Andersen 0955c0ca9e Migrated test batch 211 to Dart 2.0. 
Bug:
Change-Id: Iee8198332fd94ef708eab1aa34867c5d68054c6a
Reviewed-on: https://dart-review.googlesource.com/10420
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 21:27:40 +00:00
Jakob Roland Andersen 7091266045 Migrated test batch 207 to Dart 2.0. 
Bug:
Change-Id: Ia0bfee80bf788a6eda83813fc986182a0d56a648
Reviewed-on: https://dart-review.googlesource.com/9980
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 20:14:19 +00:00
Ben Konyi 83cc4dc365 Added back HTML related unittest code to a test modified in block 191. 
Bug:
Change-Id: Idb5b98c6af2128aac38e8effe88dbf4cf724c0f5
Reviewed-on: https://dart-review.googlesource.com/10800
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-03 22:33:52 +00:00
Ben Konyi b4d5cbda31 Migrated test block 191 to Dart 2.0. 
WIP.

Fixed status file migration issues for html and isolate directories.

Bug:
Change-Id: Id84c7ee89a7eb283d3202f3018d008cede0fda56
Reviewed-on: https://dart-review.googlesource.com/4920
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-03 21:54:44 +00:00
Jakob Roland Andersen 7f34184508 Migrated test batch 210 to Dart 2.0. 
Bug:
Change-Id: I8552149b85676cba497d78a9f6e3861257b746bc
Reviewed-on: https://dart-review.googlesource.com/10361
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-03 14:39:09 +00:00
Jakob Roland Andersen d2cd2a4720 Migrated test batch 209 to Dart 2.0. 
Bug:
Change-Id: If23630da318547e3beaf417a5ad97b30f6ffcbd3
Reviewed-on: https://dart-review.googlesource.com/10340
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-03 13:02:49 +00:00