Commit Graph

4 Commits

Author SHA1 Message Date
Srujan Gaddam 47e495a89a Migrate indexeddb_* tests to async_minitest
Change-Id: Ie43d3f4610eb01cfc800556f30e93514a7ac1ac5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139498
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-03-16 17:48:48 +00:00
Srujan Gaddam 6ae9dedc60 Migrate html tests off of unittest.dart
Changed tests either use expect/minitest or async_helper/async_minitest
as a replacement. There are still a few outstanding tests that need to
be migrated off of unittest.dart.

Change-Id: I9231d453f61507110b5a89360dfb9e5647a5b4c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135420
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-02-15 05:01:30 +00:00
Terry Lucas 9f09ef0af3 - Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used).  The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.

Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter.  The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:

     Uncaught TypeError: t1.get$target is not a function


R=vsm@google.com,gabrielchow@google.com,sra@google.com

Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-23 14:29:45 +00:00
Terry Lucas aeb7995355 Migrated Block 201 to Dart 2.0
R=bkonyi@google.com

Change-Id: Iad6df128725ffc81bbf352b02efc0412aa83272f
Reviewed-on: https://dart-review.googlesource.com/11360
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-05 18:01:10 +00:00