Commit Graph

7 Commits

Author SHA1 Message Date
Srujan Gaddam 1ea7d52d63 Migrate the rest of html tests off unittest
Migrated to minitest where possible and async_minitest elsewhere,
but kept the same import for file suites (e.g. history_*).

Change-Id: Iecd16dfbbcf0691d290fcb82555ff53d715e8500
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139827
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-03-17 22:40:05 +00:00
Srujan Gaddam 5237bcb12d Revert fileapi_entry_test to use unittest.dart
Bug: https://github.com/dart-lang/sdk/issues/40659

This behavior is similar to other tests where removing the dependency on
unittest leads to unhandled rejections.

Change-Id: Iba9eed271b839c764e544cc7200a132f0fb8e92b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136480
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-02-19 21:00:44 +00:00
Srujan Gaddam 6ae9dedc60 Migrate html tests off of unittest.dart
Changed tests either use expect/minitest or async_helper/async_minitest
as a replacement. There are still a few outstanding tests that need to
be migrated off of unittest.dart.

Change-Id: I9231d453f61507110b5a89360dfb9e5647a5b4c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135420
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
2020-02-15 05:01:30 +00:00
Terry Lucas 6ac51102a0 Include more info to track down bot failure.
TBR=vsm@google.com

Change-Id: I50ae861f99b4c35c37596a6b3372d54cf7942070
Reviewed-on: https://dart-review.googlesource.com/39000
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-06 02:51:49 +00:00
Terry Lucas 7d7bb9c2fd Fix bots failures.
TBR=vsm@google.com

Change-Id: I1f67df27b7b00ab7e9e6cc6fee6f0d678e1d5fc6
Reviewed-on: https://dart-review.googlesource.com/38901
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-06 00:50:53 +00:00
Terry Lucas d7a8aa155f Fixed a number of File API methods in DDC.
R=vsm@google.com

Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-02-05 22:29:00 +00:00
Terry Lucas 8611852b81 Migrated Block 199 to Dart 2.0
R=bkonyi@google.com

Change-Id: Ic52e7afb489b15b2f2e45f5ad9191cf5e441c047
Reviewed-on: https://dart-review.googlesource.com/11342
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-10 13:53:24 +00:00