Commit Graph

5 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 8760283247 New implementation of runZoned.
A combination of `runZoned` and `runZonedGuarded` where only the latter allows an `onError` parameter,
and only that has a nullable return type.

Retains the `onError` parameter on `runZoned` for now because it's too breaking to remove it until packages have been migrated off of it.
It will be removed in a follow-up CL.

Change-Id: If0e86c8d14e13fa089c66f4af975aeacb2616cf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137302
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2020-03-25 00:24:33 +00:00
Sigmund Cherem fb29d0e96d Move async_minitest to package:async_helper.
This allows to break a circular dependency between package:expect and

package:async_helper, which will simplify the support for modular tests using
package:modular_test.
Change-Id: Ie48723d3f35d51a8fbe622e0158450e8104fe3f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/102140
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-05-10 19:43:58 +00:00
Lasse R.H. Nielsen b1eeacc30a Remove usage of unittest package from a number of tests.
Add simplified unittest replacement to package:expect.
(It is used in multi-tests, so it needs to be in an accessible place without using ".." in its path).

Change-Id: I60aa212ed67ffbdda17ca18fce1cdff16237f4fe
Reviewed-on: https://dart-review.googlesource.com/65700
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-07-20 13:26:38 +00:00
Bob Nystrom 307742d07e Move tests from package "test" (back) to "unittest".
Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.

Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-10 19:46:12 +00:00
Ben Konyi 72df7029fb Migrated test block 177 to Dart 2.0.
Minor changes, all related to moving from unittest->test.

Bug:
Change-Id: Ie85eccf43c775211cf9d1eb58417ec3b3cc7f9a5
Reviewed-on: https://dart-review.googlesource.com/3704
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-09-09 01:44:40 +00:00