dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2071 Commits

Author SHA1 Message Date
Florian Schneider e013aaa511 Fix DBC double comparisons for NaN. 
Because NaN is not handled in a separate branch (like on other architetures -
e.g. branch-on-parity-flag on ia32), and every comparison with NaN returns false,
except "!=" we can't flip the branch condition in the same way for double
compares like we do for integer compares.

We could re-order blocks to always make the false-successor the fall-through, but
for now I just disable flipping the branch condition for double compares.

BUG=#27481
R=zra@google.com

Review URL: https://codereview.chromium.org/2400103002 .
 2016-10-07 15:30:21 -07:00
William Hesse b3d354238c Update status for Windows browser tests 
BUG=

Review URL: https://codereview.chromium.org/2402553004 .
 2016-10-07 11:42:37 +02:00
Florian Schneider 8a7dabe522 Temporarily update status for 2 tests on SIMDBC. 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2388363002 .
 2016-10-04 09:25:44 -07:00
Florian Loitsch 70c48b9a2e Don't propagate synchronous Future.wait errors immediately. 
Fixes #27249.

R=lrn@google.com

Review URL: https://codereview.chromium.org/2311923002 .
 2016-09-06 11:57:43 +02:00
Florian Loitsch 6255638cd0 Return futures on Stream.cancel when possible. 
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .

Committed: https://github.com/dart-lang/sdk/commit/395e7aaa696126b82862a9f75e7ebf742c354b56
Reverted: https://github.com/dart-lang/sdk/commit/99e5328eaca7f98641a5c6e523e80b7297792817
Committed: https://github.com/dart-lang/sdk/commit/1905ddafaa242883891e2fb2d706e2dfa059a71b
Reverted: https://github.com/dart-lang/sdk/commit/46a8579c1eb58f6a36a7d094d9b7824c92873de4
 2016-09-05 17:41:22 +02:00
William Hesse b39fa1d58d Update status for chrome 53 on linux 
BUG=

Review URL: https://codereview.chromium.org/2303263002 .
 2016-09-02 14:08:42 +02:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
 2016-08-29 08:14:33 -07:00
Sigmund Cherem 2efdf57c92 more status updates: many tests that import mirrors also "pass" because they expect compile-time failures 
BUG=

Review URL: https://codereview.chromium.org/2284743003 .
 2016-08-26 12:56:11 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup 
Review URL: https://codereview.chromium.org/2285823002 .
 2016-08-26 10:04:41 -07:00
Florian Loitsch 33b7b45252 Deal with synchronous errors in Future.wait. 
Synchronous errors are caught and piped into the returned future. This makes handling errors in Future.wait uniform.

Fixes #23656
BUG= http://dartbug.com/23656
R=lrn@google.com

Review URL: https://codereview.chromium.org/2252823004 .
 2016-08-18 14:09:20 +02:00
Florian Schneider 1a357a4f40 Add flow-graph generated SIMD array intrinsics. 
Also fix usage of a command-line flag used in tests.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2249853002 .
 2016-08-16 16:17:53 -07:00
Florian Schneider 2d5e87482c Fix a test to not expect NaNs to be bitwise identical. 
Different implementations may use different bit-patterns for NaN. e.g. NAN from math.h can be different from 0.0/0.0 (which is used in double.dart)

We should assert that NaNs are bitwise identical in general.

BUG=#26887
R=lrn@google.com

Review URL: https://codereview.chromium.org/2247553002 .
 2016-08-16 15:57:45 -07:00
Florian Loitsch 46a8579c1e Revert "Return futures on Stream.cancel when possible." 
This reverts commit 1905ddafaa.

Review URL: https://codereview.chromium.org/2223133002 .
 2016-08-08 19:31:04 +02:00
Florian Loitsch 1905ddafaa Return futures on Stream.cancel when possible. 
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/395e7aaa696126b82862a9f75e7ebf742c354b56

Review URL: https://codereview.chromium.org/2202533003 .

Reverted: https://github.com/dart-lang/sdk/commit/99e5328eaca7f98641a5c6e523e80b7297792817
 2016-08-08 17:30:36 +02:00
Florian Loitsch 99e5328eac Revert "Return futures on Stream.cancel when possible." 
This reverts commit 395e7aaa69.

Review URL: https://codereview.chromium.org/2213193004 .
 2016-08-05 14:32:14 +02:00
Florian Loitsch 395e7aaa69 Return futures on Stream.cancel when possible. 
Deprecate returning `null`.

Also, fixes cases where transformations on a stream didn't forward the cancel future

Fixes #26777.

BUG= http://dartbug.com/26777.
R=lrn@google.com

Review URL: https://codereview.chromium.org/2202533003 .
 2016-08-05 13:58:45 +02:00
John McCutchan af46b9dc55 Fix typo in status file 
BUG=

Review URL: https://codereview.chromium.org/2203163003 .
 2016-08-03 08:34:11 -07:00
John McCutchan 6a23dda952 Mark double_pow_test as failing with a runtime error for reload 
BUG=

Review URL: https://codereview.chromium.org/2209683003 .
 2016-08-03 08:03:16 -07:00
John McCutchan 35146c688e Fix reload handling of unwind / stackoverflow errors 
BUG=

Review URL: https://codereview.chromium.org/2201283002 .
 2016-08-02 18:27:35 -07:00
John McCutchan b8500cdd2d More reload status and bug fixes 
TBR=rmacnak

Review URL: https://codereview.chromium.org/2209513003 .
 2016-08-02 17:26:13 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
 2016-08-02 11:03:44 -07:00
Jacob Richman 410cde6023 Fix analyzer warnings in js_util_test, skip js_util_test in csp mode and baseline expectations for analyze_library.status 
Update pkg/js CHANGELOG.md to address comment from previous CL.

BUG=

Review URL: https://codereview.chromium.org/2179153002 .
 2016-07-25 13:20:25 -07:00
John McCutchan f79756b88d Hot reload status file updates 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2164063002 .
 2016-07-20 11:02:23 -07:00
Alan Knight 30b489578d Revert "Reapply zone tasks." 
This reverts commit 6a7c037aa6.

BUG=

Review URL: https://codereview.chromium.org/2162643002 .
 2016-07-18 13:12:36 -07:00
John McCutchan c6141005a9 More status file updates for hot reload 
BUG=

Review URL: https://codereview.chromium.org/2151743003 .
 2016-07-14 07:14:25 -07:00
Todd Turnidge 77b99396e8 Disallow deferred loading when using isolate reloading. 
Update status files.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2144113002 .
 2016-07-13 15:25:06 -07:00
John McCutchan 80cca0ec0e More status file updates for reload bots 
BUG=

Review URL: https://codereview.chromium.org/2146043002 .
 2016-07-13 09:19:20 -07:00
Ryan Macnak b7539aaf11 Triage hot reload mirrors failures. 
BUG=http://dartbug.com/26836
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2136283003 .
 2016-07-12 11:15:27 -07:00
John McCutchan 24a0988df6 Hot reload fixes for isolate tests 
- [x] Bump maximum number of vm arguments (fixes a bunch of reload crashes....)
- [x] Only check that an isolate has reload if it was ever runnable.
- [x] Skip some isolate tests that use deferred libraries or are checking for closure identity.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2141763002 .
 2016-07-11 13:58:26 -07:00
John McCutchan ef71bc1834 Improve hot reload test mode 
- [x] Start reloading even earlier.
- [x] Keep the value of FLAG_reload_every per-isolate (so spawned isolates reload eagerly too).
- [x] Adjust the reload every back off curve to be linear in the beginning.
- [x] Cap the reload every threshold at 1,000,000
- [x] Test status file updates.
- [x] Stop disabling the background compiler / OSR when running tests.
- [x] Skip multi tests with compilation errors when reloading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2133823002 .
 2016-07-11 12:29:13 -07:00
John McCutchan 4ef89ec4e9 Do not reload when we are evaluating a constants during compilation 
- [x] Add a NoReloadScope to `Parser::RunStaticFieldInitializer`
- [x] Add a NoReloadScope to `Parser::EvaluateConstConstructorCall`
- [x] Add a NoReloadScope to `Parser::Interpolate`
- [x] Add a NoReloadScope to `Parser::EvaluateConstExpr`

Fixes #26837

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2135683002 .
 2016-07-08 10:05:20 -07:00
John McCutchan dc1b2bf580 Small tweaks to hot reload testing 
- [x] Start reloading 5x sooner in test mode.
- [x] Skip mirrors tests for now.
- [x] Skip reloading tests that expect compile time errors.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2128923003 .
 2016-07-08 06:51:21 -07:00
Florian Loitsch 6a7c037aa6 Reapply zone tasks. 
This reverts commit 34d3c37233.

Committed: https://github.com/dart-lang/sdk/commit/f746f8f77e93fd93cb4ff3b4ed644c96a432947a

R=lrn@google.com

Review URL: https://codereview.chromium.org/2119243002 .

Reverted: https://github.com/dart-lang/sdk/commit/dae392291595fa394d601d2d0baa77b66d85533f
 2016-07-05 17:33:09 +02:00
Florian Loitsch dae3922915 Revert "Reapply zone tasks." 
This reverts commit f746f8f77e.

Review URL: https://codereview.chromium.org/2123593002 .
 2016-07-04 21:58:15 +02:00
Florian Loitsch f746f8f77e Reapply zone tasks. 
This reverts commit 34d3c37233.

Review URL: https://codereview.chromium.org/2119243002 .
 2016-07-04 19:55:58 +02:00
Florian Loitsch 34d3c37233 Revert zone tasks. 
Revert "Add tasks to zones."

This reverts commit 85cccde717.

Revert "Make Dom events run through zone tasks."

This reverts commit 6d1f6b2af6.

Revert "Add zone task support for request-anim."

This reverts commit 726b9f8dc7.

Revert "Add zone task support to http-requests."

This reverts commit b40cfcb57f.

Revert "Update status file for jsshell."

This reverts commit 5e05ee9b5f.

Review URL: https://codereview.chromium.org/2120063002 .
 2016-07-01 22:36:52 -07:00
Florian Loitsch 5e05ee9b5f Update status file for jsshell. 
Review URL: https://codereview.chromium.org/2121523002 .
 2016-07-01 20:15:08 -07:00
Florian Loitsch 85cccde717 Add tasks to zones. 
R=lrn@google.com, misko@google.com

Review URL: https://codereview.chromium.org/1848933002 .
 2016-07-01 19:42:22 -07:00
Ryan Macnak eb20b68e87 Add --hot-reload to the test harness. 
./tools/build.py -mdebug,release runtime
./tools/test.py -mdebug,release --checked --hot-reload

BUG=http://dartbug.com/26809
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2114083002 .
 2016-07-01 11:28:00 -07:00
Florian Schneider 60cba24f86 Make timer test more robust. 
This would fail, if the cancel() call would not be executed in time.

Give it a little extra time to make intermittent failures go away.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2075793002 .
 2016-06-16 14:30:11 -07:00
John McCutchan 6d0c97114f Mark convert/streamed_conversion_json_utf8_decode_test as slow 
Hopefully we'll stop seeing these failures:

https://build.chromium.org/p/client.dart/builders/vm-mac-debug-x64-be/builds/8604/steps/checked%20vm%20tests/logs/stdio

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org/2071583004 .
 2016-06-16 11:17:58 -07:00
Florian Loitsch e1bf3506d1 Make linked-list non-circular. 
This bug was introduced when making the collection library strong-mode clean.

Fixes #26522
BUG= http://dartbug.com/26522
R=lrn@google.com

Review URL: https://codereview.chromium.org/2015513006 .
 2016-06-01 14:19:37 +02:00
Ryan Macnak ef8baa8760 Add test harness option for app snapshots with unoptimized code. 
./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs

Rename 'dart_product' runtime to 'dart_app'.

Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation.

Remove out-of-date scripts in tools/precompilation.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1992703005 .
 2016-05-26 10:37:47 -07:00
Ryan Macnak df4e0d5ac6 ARM/ARM64: Fix smashed CODE_REG in intrinsics with InvokeMathCFunctionInstrs. 
X64: Fix smashed ARGS_DESC_REG.

IA32: Remove unnecessary preservation of ICREG.

BUG=http://dartbug.com/26516
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2003403003 .
 2016-05-25 10:02:21 -07:00
Lasse R.H. Nielsen 0554fedc2e Fix typed_data_iterable_test to not assume 0 can be added to toList result. 
That's not true for float-lists.

Review URL: https://codereview.chromium.org/2004823002.
 2016-05-23 11:18:09 +02:00
Ryan Macnak 7d3cd143f7 Update status for 
./tools/test.py -mall
  ./tools/test.py -mdebug,release --checked
  ./tools/test.py -mrelease,product -cdart2app -rdart_product
  ./tools/test.py -mrelease --checked -cdart2app -rdart_product

Missing
  ./tools/test.py -mdebug -cdart2app -rdart_product
  ./tools/test.py -mdebug --checked -cdart2app -rdart_product

R=asiva@google.com

Review URL: https://codereview.chromium.org/1991543002 .
 2016-05-18 12:54:34 -07:00
Florian Loitsch fe1fda0766 Make dart:convert strong mode clean. 
Also removes the ChunkedConverter.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1964953003 .
 2016-05-11 16:15:31 +02:00
Lasse R.H. Nielsen 06676c4719 Implement everything in test Future-class to avoid analyzer warnings. 
Review URL: https://codereview.chromium.org/1968033002 .
 2016-05-11 13:43:51 +02:00
Lasse R.H. Nielsen 63b71b4c24 Make _Future._chainForeignFuture not cause an assert. 
If the foreign future completes with a future, the following call to
_Future._completeWithValue would hit an assert in checked mode
(value is! Future). This change makes the _Future._completeWithValue flatten
incoming nesting futures before completing the _Future, ensuring that a
_Future never has a Future as value.

An alternative is to throw if the value of a future is another future.
That's what the assert does in checked mode, but we shouldn't be able to hit
an assert.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1966523003 .
 2016-05-11 13:10:46 +02:00
Johnni Winther 24c548f5bd Skip spurious constants in deferred computation. 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1955403002 .
 2016-05-10 09:41:19 +02:00