Commit Graph

54 Commits

Author SHA1 Message Date
Robert Nystrom 0d34bf5571 Remove another one of the unittest-like libraries.
This one was literally only used for a single test. :-/

Change-Id: I316e17ecaf9a839b3c6f27ec86971a67ab52bbfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135782
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
2020-02-13 23:36:13 +00:00
Ryan Macnak 00b2e580a3 [test] Fork mirrors tests.
Bug: https://github.com/dart-lang/sdk/issues/40045
Change-Id: I597259b38684de87016f1e136723d24f4ac05420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132440
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-01-22 18:46:23 +00:00
Bob Nystrom f6ca2c1d8f Remove the Dart 1 tests.
This deletes:

tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib

It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)

I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)

"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."

- Ray Bradbury, Fahrenheit 451

Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-10-11 23:45:18 +00:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
floitsch@google.com c5702b1784 dart2js: add --preserve-uris flag.
R=blois@google.com, johnniwinther@google.com, nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41205
Reverted: https://code.google.com/p/dart/source/detail?r=41206

Review URL: https://codereview.chromium.org//582753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41244 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-22 09:05:26 +00:00
floitsch@google.com bcb3c3e8ba Don't hide interceptors in mirrors.
The special code for mirrors was brittle and was the reason for several bugs.

BUG= http://dartbug.com/18076
BUG= http://dartbug.com/15405
BUG= http://dartbug.com/14025
BUG= http://dartbug.com/13842
BUG= http://dartbug.com/16804
BUG= http://dartbug.com/15555
R=karlklose@google.com

Review URL: https://codereview.chromium.org//236313012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35586 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-30 18:21:11 +00:00
floitsch@google.com 47a1edad2b Move mirrors-test from dart2js_extra to lib/mirrors.
R=ahe@google.com

Review URL: https://codereview.chromium.org//223673007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34728 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-04 09:48:31 +00:00
rmacnak@google.com 5e310f4e31 Update mirror tests for removed API and other analyzer warnings.
BUG=http://dartbug.com/14695
R=gbracha@google.com

Review URL: https://codereview.chromium.org//64793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30290 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-14 19:55:05 +00:00
iposva@google.com 1cae21b556 - Reverting mirror changes.
Review URL: https://codereview.chromium.org//62373008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30029 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 02:07:37 +00:00
iposva@google.com a2d280501e - Reverting mirror changes.
Review URL: https://codereview.chromium.org//63563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30027 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:48:45 +00:00
rmacnak@google.com bc897425e1 Cascaded mirror removal revert.
Review URL: https://codereview.chromium.org//63363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30024 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 01:20:51 +00:00
rmacnak@google.com 1caa73df59 Remove implementations of mirror methods not in the API from the VM. Update tests.
R=iposva@google.com

Review URL: https://codereview.chromium.org//63063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30005 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 22:30:45 +00:00
rmacnak@google.com 07c3de9310 Mirror implementation removals: async invoke, mirrorSystemOf(port), Mirror.mirrors.
(API was removed in r29492)

R=ahe@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//23460050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29698 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 21:01:59 +00:00
ahe@google.com 36e2df1a1d Mirrors overhaul.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//23455028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 14:58:58 +00:00
rmacnak@google.com 0d23dbc1e2 Make TypedefMirror a direct descendant of TypeMirror.
BUG=http://dartbug.com/11616
R=ahe@google.com, asiva@google.com

Review URL: https://codereview.chromium.org//24005002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28862 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 16:59:55 +00:00
zarah@google.com 7d93dd8b28 Support typeVariables in ClassMirror.
R=ahe@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//24197003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27753 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 11:17:55 +00:00
zarah@google.com 3766edd713 Change return type of get typeVariables and typeArguments in ClassMirror.
R=ahe@google.com, gbracha@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//23890036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27641 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 07:01:19 +00:00
ngeoffray@google.com 8b0ff9c615 Implement redirecting factories in mirrors.
R=ahe@google.com

Review URL: https://codereview.chromium.org//23450040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27561 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 12:05:40 +00:00
ahe@google.com eca46b2d0a Implement top-level invoke and operators.
BUG=http://dartbug.com/11861
BUG=http://dartbug.com/6490
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//19568005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25283 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-22 16:17:00 +00:00
ahe@google.com c17ca9d9b3 Implement top-level accessors.
Also, implement top-level fields in minified mode.

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//19676002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25276 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-22 14:52:39 +00:00
rmacnak@google.com f85d1df63e Fix regression in TypedefMirror.owner introduced when making ClassMirror.owner lazy.
R=asiva@google.com

Review URL: https://codereview.chromium.org//19749008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25244 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 21:16:29 +00:00
ahe@google.com bea82f4ef5 Implement invocation of statics.
BUG=http://dartbug.com/6490
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//19576003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25102 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 15:37:44 +00:00
rmacnak@google.com 347bc08877 Fix test that fails in checked mode: a factory must return a subtype of its defining class.
Review URL: https://codereview.chromium.org//19267007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25026 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 22:13:02 +00:00
rmacnak@google.com 39bf0aca44 Implement the invoke methods (invoke, getField, setField, newInstance, apply) as internal natives.
R=asiva@google.com

Review URL: https://codereview.chromium.org//18463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25024 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-15 21:14:43 +00:00
ahe@google.com 8e6f665fac ClassMirror.newInstance in minified mode.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//17422004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24169 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 07:47:44 +00:00
ahe@google.com 0598d208c7 Implement InstanceMirror.getField/setField (minified).
R=kasperl@google.com

Review URL: https://codereview.chromium.org//15934017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23676 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-06 11:55:51 +00:00
ahe@google.com 90651648af Implement InstanceMirror.invoke (minified).
R=kasperl@google.com

Review URL: https://codereview.chromium.org//15979020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23596 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 14:21:34 +00:00
sgjesse@google.com 9d6a64e81b Merge the dart:uri library into dart:core and update the Uri class
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.

* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization

R=floitsch@google.com, lrn@google.com, nweiz@google.com, scheglov@google.com
BUG=

Review URL: https://codereview.chromium.org//16019002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
ahe@google.com 2ce688b7d1 Implement simple name and qualified name.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//16097002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23225 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 13:58:12 +00:00
ahe@google.com 398cc689a2 Implement ClassMirror.owner and LibraryMirror.uri.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//15861005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23211 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 10:28:09 +00:00
ahe@google.com d830696e00 Implement newInstance on ClassMirror.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//15857005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23137 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 12:05:09 +00:00
ahe@google.com 86c80bd2e5 Implement ClosureMirror.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//15895002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23135 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-24 12:00:37 +00:00
ahe@google.com f029dc2d31 Implement get/set field in library and class mirrors.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//15858005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23070 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-23 14:23:58 +00:00
ahe@google.com 843e4121be Implement invoke, setField, and getField (unminified).
R=johnniwinther@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//14646031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22722 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-15 08:11:25 +00:00
johnniwinther@google.com f721629103 Change libraries map to use Uri.
Review URL: https://codereview.chromium.org//14178010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21929 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 08:19:24 +00:00
johnniwinther@google.com b6b309de52 Change url to uri on LibraryMirror.
Review URL: https://codereview.chromium.org//14251005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21803 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 10:27:41 +00:00
iposva@google.com 5b369cc1c4 - Implement reflectClass.
Review URL: https://codereview.chromium.org//14118011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21610 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-17 10:11:21 +00:00
iposva@google.com 54d56ca5d8 - Add synchronous mirror API. Resurrects invoke, apply, newInstance,
getField and setField as synchronous calls that accept isolate-local
  object as arguments.

Originally reviewed as https://codereview.chromium.org/14044007/

Review URL: https://codereview.chromium.org//13942008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21591 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-16 23:19:30 +00:00
ahe@google.com 45ad548837 Update dart:mirrors to use Symbol.
Review URL: https://codereview.chromium.org//14173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21460 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:00:45 +00:00
gbracha@google.com e08647bfd3 BREAKING CHANGE: Rename InstanceMIrror.invoke, .getField, .setField to invokeAsync, getFieldAsync, setFieldAsync. Likewise ClosureMirror.apply and ClassMIrror.newInstance. This is in preparation of new synchronous versions of the originals.
Review URL: https://codereview.chromium.org//13967003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21242 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-10 23:58:22 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
ahe@google.com 6254729761 Revert "Parts must start with 'part of'" and "Attempt to fix VM build"
This reverts r13961 and r13963.

Review URL: https://codereview.chromium.org//11233061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13967 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 14:24:04 +00:00
scheglov@google.com 50b5b6e1a8 Parts must start with 'part of'
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13961 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 13:20:50 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
turnidge@google.com a28d475ff3 Implement more of the mirrors library, primarily stuff to do with types.
Highlights:

- Implement FunctionClassMirror, used to reflect on the class of
  function objects.

- Implement TypeVariableMirror, used to reflect on type variables.

- Implement TypedefMirror, used to reflect on typedefs.

- Implement returnType for MethodMirror

- Implement type for VariableMirror/ParameterMirror

- Added supporting functions to the dart embedding api:
  - Dart_ClassIsTypedef
  - Dart_ClassGetTypedefReferent
  - Dart_ClassIsFunctionClass
  - Dart_ClassGetFunctionClassSignature
  - Dart_FunctionReturnType
  - Dart_FunctionParameterType
  - Dart_VariableType
  - Dart_GetTypeVariableNames
  - Dart_LookupTypeVariable
  - Dart_IsTypeVariable
  - Dart_TypeVariableOwner
  - Dart_TypeVariableUpperBound

Other stuff:

- Fixed bug in Function::NumberOfImplicitParameters for signature
  functions.

- Chnaged the default upper bound for type variables to Object from
  Dynamic.  Discussed this with Gilad and Regis.

- Fixed some smaller problems in mirrors_impl.dart.
Review URL: https://chromiumcodereview.appspot.com//10916252

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12342 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 17:47:25 +00:00
turnidge@google.com 1da7c97936 A round of edits to make mirrors.dart more like our current working
proposal.
Review URL: https://chromiumcodereview.appspot.com//10854197

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10918 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-17 19:56:50 +00:00
dgrove@google.com c265902bea Move unittest from lib to pkg.
Review URL: https://chromiumcodereview.appspot.com//10836241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10685 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-14 22:36:59 +00:00