Commit Graph

20 Commits

Author SHA1 Message Date
Ryan Macnak 00b2e580a3 [test] Fork mirrors tests.
Bug: https://github.com/dart-lang/sdk/issues/40045
Change-Id: I597259b38684de87016f1e136723d24f4ac05420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132440
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-01-22 18:46:23 +00:00
Bob Nystrom f6ca2c1d8f Remove the Dart 1 tests.
This deletes:

tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib

It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)

I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)

"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."

- Ray Bradbury, Fahrenheit 451

Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-10-11 23:45:18 +00:00
Florian Loitsch 46ba54e315 Add @MirrorsUsed annotations to speed up tests.
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2727323002 .
2017-03-31 12:46:31 +02:00
Jacob Richman 14531fa62d Re-land "Format all multitests"
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests"
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests"
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
2017-03-21 12:39:28 -07:00
Jacob Richman 6a7d6c385e Add comments
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
2017-03-20 21:03:12 -07:00
floitsch@google.com 5708ec2d9e Allow delegate calls even though the target is not reflectable.
BUG= http://dartbug.com/15138
BUG= http://dartbug.com/17451
R=karlklose@google.com

Review URL: https://codereview.chromium.org//294293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36621 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-26 08:56:44 +00:00
floitsch@google.com 07b6c4739e Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556

Committed: https://code.google.com/p/dart/source/detail?r=34779
Reverted: https://code.google.com/p/dart/source/detail?r=34782

Committed: https://code.google.com/p/dart/source/detail?r=34818
Reverted: https://code.google.com/p/dart/source/detail?r=34820

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34823 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:27:37 +00:00
floitsch@google.com 8cdf6bde8e Revert "Add support for closure calls through getters."
This reverts commit r34818.

Review URL: https://codereview.chromium.org//228023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34820 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 13:06:15 +00:00
floitsch@google.com 6c9c0642a0 Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556

Committed: https://code.google.com/p/dart/source/detail?r=34779
Reverted: https://code.google.com/p/dart/source/detail?r=34782

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34818 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:27:00 +00:00
floitsch@google.com b7fefddf34 Revert "Add support for closure calls through getters."
This reverts commit r34779.

Review URL: https://codereview.chromium.org//227203007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34782 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 15:58:49 +00:00
floitsch@google.com 569e0f50ed Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34555
Reverted: https://code.google.com/p/dart/source/detail?r=34556

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34779 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-07 15:02:01 +00:00
floitsch@google.com ff402648a2 Revert "Add support for closure calls through getters."
This reverts commit r4555.

Review URL: https://codereview.chromium.org//219493003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34556 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 15:21:27 +00:00
floitsch@google.com 86303df642 Add support for closure calls through getters.
Support reflect(o).invoke(#bar) where bar is a getter.
library.getField(#foo) where `foo` is a method.

BUG= http://dartbug.com/15138
R=karlklose@google.com

Review URL: https://codereview.chromium.org//195793013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34555 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-31 14:22:42 +00:00
rmacnak@google.com 8c0e1a602e Fix LibraryMirror.invoke to call through the contents of an implicit getter.
BUG=http://dartbug.com/17452
R=asiva@google.com, gbracha@google.com

Review URL: https://codereview.chromium.org//196953007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33682 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 01:14:06 +00:00
rmacnak@google.com 0bc05d6c3c VM: Make ObjectMirror.invoke support getters returning functions.
BUG=http://dartbug.com/15138
R=asiva@google.com

Review URL: https://codereview.chromium.org//112193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31076 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 19:43:48 +00:00