dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

26 Commits

Author SHA1 Message Date
Regis Crelier b3bca1821c [VM/runtime] Decouple representation of function signatures from Function objects. 
This fixes issue https://github.com/dart-lang/sdk/issues/43088

This CL improves on https://dart-review.googlesource.com/c/sdk/+/166920 by keeping the names of type parameters.

See go/dart-vm-signatures for motivation for this change.

TEST=existing suites

Change-Id: Ia82f1d322f72d07b2fb253cf914f9b868025c71e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176981
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2021-01-07 23:45:37 +00:00
Ryan Macnak 00b2e580a3 [test] Fork mirrors tests. 
Bug: https://github.com/dart-lang/sdk/issues/40045
Change-Id: I597259b38684de87016f1e136723d24f4ac05420
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132440
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2020-01-22 18:46:23 +00:00
Bob Nystrom f6ca2c1d8f Remove the Dart 1 tests. 
This deletes:

tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib

It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)

I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)

"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."

- Ray Bradbury, Fahrenheit 451

Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-10-11 23:45:18 +00:00
Florian Loitsch 46ba54e315 Add @MirrorsUsed annotations to speed up tests. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2727323002 .
 2017-03-31 12:46:31 +02:00
Jacob Richman 14531fa62d Re-land "Format all multitests" 
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
 2017-03-23 12:40:21 -07:00
Jacob Richman 44d8be0ed3 Revert "Format all multitests" 
This reverts commit 312b66dd5f.

BUG=

Review-Url: https://codereview.chromium.org/2770063002 .
 2017-03-23 10:49:40 -07:00
Jacob Richman 312b66dd5f Format all multitests 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2768073002 .
 2017-03-23 10:26:44 -07:00
Jacob Richman 88eb557b65 Fix warnings_checker.dart handling of multitests 
Update all tests

Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com
BUG=

Review-Url: https://codereview.chromium.org/2765693002 .
Review-Url: https://codereview.chromium.org/2765893003 .
 2017-03-21 17:29:56 -07:00
Jacob Richman bf2b545150 Revert "Update all tests" 
This reverts commit ce76e9c30beaf9a193d3677b88c20a1ebb3fae8c.
 2017-03-21 16:33:18 -07:00
Jacob Richman 3c7353d987 Update all tests 
Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2765693002 .
 2017-03-21 12:39:28 -07:00
Jacob Richman 6a7d6c385e Add comments 
Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Review-Url: https://codereview.chromium.org/2763823002 .
 2017-03-20 21:03:12 -07:00
zarah@google.com 6fc7361c23 Remove multitest in lib/mirror/generics_test. 
R=karlklose@google.com

Review URL: https://codereview.chromium.org//91113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30701 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-27 09:44:03 +00:00
zarah@google.com f7dd88c13e Support reflection on generics with dynamic types. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//88473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30700 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-27 09:09:26 +00:00
rmacnak@google.com 5e310f4e31 Update mirror tests for removed API and other analyzer warnings. 
BUG=http://dartbug.com/14695
R=gbracha@google.com

Review URL: https://codereview.chromium.org//64793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30290 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-14 19:55:05 +00:00
iposva@google.com 1cae21b556 - Reverting mirror changes. 
Review URL: https://codereview.chromium.org//62373008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30029 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 02:07:37 +00:00
iposva@google.com a2d280501e - Reverting mirror changes. 
Review URL: https://codereview.chromium.org//63563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30027 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 01:48:45 +00:00
rmacnak@google.com bc897425e1 Cascaded mirror removal revert. 
Review URL: https://codereview.chromium.org//63363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30024 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-07 01:20:51 +00:00
rmacnak@google.com 1caa73df59 Remove implementations of mirror methods not in the API from the VM. Update tests. 
R=iposva@google.com

Review URL: https://codereview.chromium.org//63063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30005 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-06 22:30:45 +00:00
rmacnak@google.com 56ce946cbf Re-triage mirror test failures on the analyzer. 
R=kustermann@google.com, regis@google.com

Review URL: https://codereview.chromium.org//49083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29407 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-29 00:15:57 +00:00
rmacnak@google.com b444bb86a9 Add missing test coverage for constructor kinds, generic function typedefs, generic mixin applications, delegate, type arguments are type variables. 
BUG=
R=gbracha@google.com

Review URL: https://codereview.chromium.org//25609003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28270 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-04 17:32:21 +00:00
zarah@google.com 7d93dd8b28 Support typeVariables in ClassMirror. 
R=ahe@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//24197003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27753 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-23 11:17:55 +00:00
zarah@google.com e36ac8f125 Mark generics_test.dart as failing when run with the analyzer. 
Review URL: https://codereview.chromium.org//23465031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27665 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-19 15:52:40 +00:00
zarah@google.com 317bb49282 Support typeArguments, isOriginalDeclaration, and get originalDeclaration in ClassMirror. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//23707046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27662 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-19 14:54:52 +00:00
zarah@google.com 3766edd713 Change return type of get typeVariables and typeArguments in ClassMirror. 
R=ahe@google.com, gbracha@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//23890036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27641 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-19 07:01:19 +00:00
mlippautz@google.com 187ec3d4fc Fix ClassMirror.typeArguments handling for dynamic only type arguments. 
Addresses an issue where we did not return the appropriate type arguments for instances with all dynamic type arguments.

Example:
Class <E> {}

main() {
  var cm = reflectClass(new C()).type;
  print(cm.typeArguments);
  // now prints: {Symbol("E"): TypeMirror on 'dynamic'}
  // previously: crashed
}

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//23133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26135 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-14 18:41:30 +00:00
rmacnak@google.com fe85bf84bb Reflection on generics. 
BUG=
R=ahe@google.com, regis@google.com

Review URL: https://codereview.chromium.org//22292002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25942 260f80e4-7a28-3924-810f-c04153c831b5
 2013-08-08 20:06:56 +00:00