Commit Graph

86 Commits

Author SHA1 Message Date
lrn@google.com e2e17c3f26 Make JSON parsing work as a chunked conversion sink.
This allows JSON parsing to work on individual chunks of source instead
of collecting and concatenating all the parts before parsing.

This is made in anticipation of having a UTF-8 version that parses directly
on the input codes, without creating a String first.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//649113005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41311 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-27 12:11:39 +00:00
lrn@google.com e41bf80fbb Update test expectation for Safari to account for JSON.parse bug.
Also use num.parse now that we have it.

R=ahe@google.com

Review URL: https://codereview.chromium.org//391003005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38223 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 08:01:43 +00:00
lrn@google.com 4feb28b5c2 Fix error message for unexpected characters in JSON.
The current version treats any unexpected character as a number
error.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38184

Review URL: https://codereview.chromium.org//387323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38185 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 11:08:36 +00:00
lrn@google.com cf8ac68c0d Make VM JSON parser parse doubles without doing substring.
R=fschneider@google.com

Review URL: https://codereview.chromium.org//385163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38155 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-11 12:14:23 +00:00
kevmoo@google.com 7aad450550 dart:convert: support indented output w/ JsonEncoder
BUG= https://code.google.com/p/dart/issues/detail?id=7846
R=lrn@google.com

Review URL: https://codereview.chromium.org//224093007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34758 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-05 20:09:21 +00:00
kevmoo@google.com 6e3128596c lib/convert: removed unused import, removed redundant test
Re-enabled checks in existing test

R=ricow@google.com

Review URL: https://codereview.chromium.org//223053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34703 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-03 13:41:55 +00:00
kevmoo@google.com 441bd85c9f Fix JSON tests, re-enable in all cases - 2nd try
R=lrn@google.com

Review URL: https://codereview.chromium.org//212813006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34457 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 23:11:40 +00:00
sra@google.com 789cb16956 Revert "Fix JSON tests, re-enable in all cases"
TBR=kevmoo@google.com
BUG=

Review URL: https://codereview.chromium.org//212643007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34441 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 18:16:06 +00:00
kevmoo@google.com 38b0d362b5 Fix JSON tests, re-enable in all cases
R=lrn@google.com

Review URL: https://codereview.chromium.org//208273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34440 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 17:43:23 +00:00
floitsch@google.com f5e2b355f7 Improve Json constructor.
R=lrn@google.com

Review URL: https://codereview.chromium.org//133923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32502 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 15:51:30 +00:00
lrn@google.com 1bb616d0ce Fix JSON encoder accepting NaN and Infinity.
BUG= http://dartbug.com/16038
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//136373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31731 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 10:00:08 +00:00
floitsch@google.com 30c9633145 Copy utf-pkg test to lib/convert.
R=lrn@google.com

Review URL: https://codereview.chromium.org//72863005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30452 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 10:26:35 +00:00
floitsch@google.com 35e9ae50d9 Fix warnings in library-tests.
R=lrn@google.com

Review URL: https://codereview.chromium.org//54723007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29756 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:01:11 +00:00
floitsch@google.com 79e82f80ce Reapply utf85_test.
Bug in VM has been fixed. It shouldn't take that long anymore.

This test was originally LGTMed in https://chromiumcodereview.appspot.com/25463003/

R=fschneider@google.com

Review URL: https://codereview.chromium.org//25539006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28198 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 08:51:43 +00:00
floitsch@google.com 37b31bcbd6 Remove utf85_test for now. It's too slow.
Review URL: https://codereview.chromium.org//25548003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28098 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 15:41:36 +00:00
floitsch@google.com c1460894d6 Fix UTF8 encoder for Unicode runes > 0xFFFF.
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//25463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28095 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 12:11:02 +00:00
floitsch@google.com 00752e7e24 Escape slash since it helps to end an HTML entity.
Escaping a slash is recommended by the OWASP.

Replace "'" in HTML escaping by "'" since "'" isn't supported in the HTML4 spec.

BUG= http://dartbug.com/13364
R=efortuna@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//24339002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27945 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 12:19:40 +00:00
kevmoo@j832.com 85e045313e adding HtmlEscape to dart:convert
BUG=https://code.google.com/p/dart/issues/detail?id=1657
R=blois@google.com, floitsch@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//23492002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27211 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 20:30:56 +00:00
floitsch@google.com 1866e87ddd Switch to async_helper package.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23701010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26918 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 14:19:57 +00:00
lrn@google.com 788c569e9c Convert HashMap and LinkedHashMap to closed addressing hash tables.
R=regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//23056002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26863 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 12:13:32 +00:00
lrn@google.com 3408c5bc88 Make the result of JSON.decode be marked by "null" in the reviver.
They are currently marked by "", which can match a property as well.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//23688003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26768 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 08:25:34 +00:00
floitsch@google.com 35d7140e66 Remove Encoding-enum from dart:io and add interface in dart:convert.
BUG= http://dartbug.com/6284
BUG= http://dartbug.com/7966
R=nweiz@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//22872012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26632 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 10:37:25 +00:00
floitsch@google.com a30cffbf77 Treat negative utf8-units the same way as other broken encodings.
R=lrn@google.com

Review URL: https://codereview.chromium.org//22929022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26528 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 15:40:41 +00:00
floitsch@google.com 109280c8f9 Make utf8 decoder non-buffered.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23361015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26526 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 14:33:34 +00:00
lrn@google.com 43bf48fa0e Add ASCII encoding to lib/convert.
Reuses part of LATIN1 encoding.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//22875034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26518 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 13:05:29 +00:00
lrn@google.com d0bc320298 Add Latin-1 converters to convert library.
I plan to modify this to a generic version and make Ascii and Latin1
special cases that only differ in the mask (0x7f vs 0xff), or maybe
a few other cases.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//23224014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26508 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 08:28:37 +00:00
floitsch@google.com 0b68743ae8 Fix off-by-one error in UTF-8 encoding.
R=lrn@google.com

Review URL: https://codereview.chromium.org//22854028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26355 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 14:03:35 +00:00
kevmoo@j832.com 7d09ae0e3b nits from cr 22070003
R=lrn@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//22860004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26076 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 18:53:36 +00:00
kevmoo@j832.com b68699b8a1 add a const ctor to Converter
Nice to have const converter subclasses

R=lrn@google.com

Review URL: https://codereview.chromium.org//22979003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26072 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-13 18:31:55 +00:00
kevmoo@j832.com 0565d6762f convert: new LineSplitter, (io: Deprecate LineTransformer)
R=floitsch@google.com

Review URL: https://codereview.chromium.org//22070003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25899 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-07 20:25:42 +00:00
floitsch@google.com a34421fd66 Add transformer support to Converters.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//20374003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25517 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-26 10:35:42 +00:00
floitsch@google.com 69ed3ee100 Make utf88_test faster.
Review URL: https://codereview.chromium.org//20300004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25469 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 14:54:30 +00:00
floitsch@google.com efe4781eed Add chunked conversion to converters.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//19883003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25466 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-25 13:26:09 +00:00
floitsch@google.com 15c7882e7d Add UTF-8 encoder.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//19593010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25342 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-23 14:41:21 +00:00
floitsch@google.com f601233af9 Remove dart:codec and move classes into dart:convert.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//19941002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25267 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-22 12:25:16 +00:00
floitsch@google.com d0768e543f Replace old utf8 decoder with new one.
R=lrn@google.com

Review URL: https://codereview.chromium.org//19187002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25089 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-17 11:35:12 +00:00