Commit Graph

319 Commits

Author SHA1 Message Date
lrn@google.com 30683bdc79 Fix typo in failure-branch of stream iterator test.
Also increment pkg/async version to fix broken first upload.

Review URL: https://codereview.chromium.org//94013005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31322 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 07:58:49 +00:00
lrn@google.com d4be6ccd68 Update stream iterator doc and add test.
BUG= http://dartbug.com/15449
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//99463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31317 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-20 07:14:37 +00:00
lrn@google.com 70f6617532 Revert "Fix VM timer firing too early."
Committed: https://code.google.com/p/dart/source/detail?r=30987

R=floitsch@google.com

Review URL: https://codereview.chromium.org//101293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31009 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-10 08:40:56 +00:00
lrn@google.com dd6ee012d1 Revert "Fix VM timer firing too early."
Review URL: https://codereview.chromium.org//101293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30987 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 13:43:52 +00:00
lrn@google.com 2aa9f026f2 Change Future.timeout callback to a named parameter.
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30790

Review URL: https://codereview.chromium.org//96643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30985 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-09 12:06:12 +00:00
lrn@google.com c5a3337ae3 Change the zone that late-added stream subscription callbacks are registered in.
They are always called in the subscription's zone, but they were
registered in the current zone.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//104543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30896 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 14:45:46 +00:00
lrn@google.com 6af11cac37 Add Stream.timeout method.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//96473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30895 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 13:32:31 +00:00
lrn@google.com 8744794212 Change other futures to also have timeout take a named parameter.
Review URL: https://codereview.chromium.org//98683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30792 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-02 09:13:49 +00:00
lrn@google.com 3d819ee9cb Change Future.timeout callback to a named parameter.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//96643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30790 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-02 08:48:00 +00:00
lrn@google.com e0314a6117 Add Future.timeout.
R=floitsch@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//91213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30745 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 08:16:01 +00:00
lrn@google.com 726b72771e Make the root zone's schduleMicrotask and create[Periodic]Timer bind the callback.
BUG= http://dartbug.com/15232
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30708

Review URL: https://codereview.chromium.org//87283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30711 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 11:55:35 +00:00
lrn@google.com 1d9e1d5b93 Make the root zone's schduleMicrotask and create[Periodic]Timer bind the callback.
BUG= http://dartbug.com/15232
R=floitsch@google.com

Review URL: https://codereview.chromium.org//87283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30708 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 11:42:04 +00:00
lrn@google.com f3a501e7c6 Make Future.wait have an eagerError option that defaults to false.
This means that Future.wait will, by default, wait for all futures to
complete, even if there is an error.
All but the first error are dropped, and the future completes with the
first error.

If eagerError is set to true, the returned future completes immediately
on the first error.

BUG= http://dartbug.com/14794
R=floitsch@google.com

Review URL: https://codereview.chromium.org//68523005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30443 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 09:28:48 +00:00
floitsch@google.com 91b5e131ee Make catch_errors13_test non-flaky.
Was flaky on buildbot:
http://build.chromium.org/p/client.dart/builders/dartium-mac-debug-be/builds/410/steps/drt_core_checked_tests/logs/stdio

R=sra@google.com

Review URL: https://codereview.chromium.org//60013013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30087 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-08 00:19:57 +00:00
floitsch@google.com 6bdd901604 Add test that makes sure print deals with broken toStrings.
R=ahe@google.com

Review URL: https://codereview.chromium.org//60553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29994 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-06 20:40:03 +00:00
floitsch@google.com 8fdee3bb18 Propagate stack trace when using Future.wait.
BUG= http://dartbug.com/14755
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//56123012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29923 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-05 18:42:48 +00:00
floitsch@google.com 1532e6db73 Add safety margin to timer_isolate_test.dart
Should make the test less flaky.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//58843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29921 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-05 18:20:34 +00:00
floitsch@google.com 35e9ae50d9 Fix warnings in library-tests.
R=lrn@google.com

Review URL: https://codereview.chromium.org//54723007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29756 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:01:11 +00:00
floitsch@google.com 7006de6f23 Remove deprecated parts of dart:async.
Attempt to fix most uses of the deprecated features.

R=floitsch@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//48483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29628 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 02:24:29 +00:00
regis@google.com 3fa7a61efc Implement latest spec changes regarding malformed types (see issue 14006):
- a malformed type used in a is, as, or catch type test results in a dynamic
  type error being thrown.
- a malformed type is not mapped to dynamic anymore.

For now, this applies to type tests in checked mode as well, but discussion is
still on-going.

R=hausner@google.com

Review URL: https://codereview.chromium.org//53583003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29608 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 23:30:32 +00:00
lrn@google.com 72e6685c6a Change and documentat how completer handles futures.
Completer.complete changes signature to accept 'var' and chain if the
argument is a future.
Completer.completeError throws if error is a future or null.
Documentation updated to match.
Fix error in implementation of completeError which dropped listeners when
chained. If the chained-to future is not a _Future, the listeners cannot
be forwarded.

BUG= http://dartbug.com/14211 http://dartbug.com/14212 http://dartbug.com/14435
R=floitsch@google.com

Review URL: https://codereview.chromium.org//50373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29518 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 09:22:29 +00:00
lrn@google.com c0bbe6e388 Expose the cancelOnError in the StreamController.addStream.
Type tests, so this would have been caught.

R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//50373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29434 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 11:28:29 +00:00
lrn@google.com 5b0ac43e80 Fix bugs in StreamController.addStream.
Add optional 'cancelOnError' to addStream method. It still defaults
to true.
Resume the added stream when adding a listener (14332).
Handle cancel-on-error correctly, so the future completes as well (14334).

BUG= http://dartbug.com/14332 http://dartbug.com/14334
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//48733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29419 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:59:52 +00:00
lrn@google.com 4e69511eac Make Stream.fromIterable only accept a single listen call.
BUG= http://dartbug.com/13722
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//48543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29357 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 12:18:00 +00:00
floitsch@google.com 6a72655d1b Very simple version of Isolates.
R=ajohnsen@google.com, iposva@google.com, kasperl@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//27215002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
floitsch@google.com 930cf81a5a Fix indentation.
Review URL: https://codereview.chromium.org//44113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29250 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 13:08:43 +00:00
floitsch@google.com d8ebf58a39 Remove default value in factory constructor.
BUG= http://dartbug.com/14284
R=lrn@google.com

Review URL: https://codereview.chromium.org//32553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29064 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 08:27:15 +00:00
ajohnsen@google.com a969c5297b Don't use non-0 Timers for async tests.
BUG=

Review URL: https://codereview.chromium.org//30663005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28930 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 13:03:52 +00:00
ajohnsen@google.com eb64b2486f Let StreamSubscription.cancel return a Future.
This gives the ability mark a subscription cancel as asynchrouns. Thiw
now means that StreamController's onCancel takes either a value (null in
    most cases) and a Future, just like 'new Future(() => value)'.

BUG=
R=floitsch@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//18915008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28925 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 12:09:41 +00:00
floitsch@google.com af06e8ba5a Fix scheduleImmediate in Dartium.
BUG= http://dartbug.com/14146
R=blois@google.com

Review URL: https://codereview.chromium.org//27543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28792 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 08:59:32 +00:00
lrn@google.com a2e03e5463 Fix flaky stream_controller_async_test.
BUG= http://dartbug.com/163608
R=floitsch@google.com

Review URL: https://codereview.chromium.org//27499002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28719 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 11:29:13 +00:00
ajohnsen@google.com 732ab1ce4d Add factory-method for scheduleMicrotask, as well as a (failing) test.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//26993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28653 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:22:04 +00:00
floitsch@google.com 10e9a799d1 Make print interceptable.
BUG= http://dartbug.com/3486
R=lrn@google.com

Review URL: https://codereview.chromium.org//27112002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28650 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 16:02:07 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask.
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 15:52:17 +00:00
floitsch@google.com dc9c5f42ed Redo StreamTransformers so they work with Stack traces.
Since this involved a breaking change I cleaned up more of the
StreamTransformer API.

This CL also deprecates the getAttachedStackTrace method.

R=ajohnsen@google.com, lrn@google.com, nweiz@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//25354003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28562 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 12:34:34 +00:00
floitsch@google.com 4be547c705 Adapt streams for additional stackTrace argument.
R=lrn@google.com

Review URL: https://codereview.chromium.org//25094002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28511 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 12:02:20 +00:00
floitsch@google.com 956243966a Add second argument to Future error handlers.
R=lrn@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//25027004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28510 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 11:42:39 +00:00
floitsch@google.com 146150ac51 Wait for the pause-event to have finished.
BUG= http://dartbug.com/13608
R=lrn@google.com

Review URL: https://codereview.chromium.org//24457003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27943 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 12:12:42 +00:00
floitsch@google.com 35e2ed1e57 Expose Zones.
BUG= http://dartbug.com/11279
R=lrn@google.com

Review URL: https://codereview.chromium.org//23875032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27802 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 09:22:26 +00:00
kevmoo@j832.com 1a9178abe0 Handle Future result from Future.sync computation
BUG= https://code.google.com/p/dart/issues/detail?id=13368
R=floitsch@google.com

Review URL: https://codereview.chromium.org//23793006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27619 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 13:42:52 +00:00
floitsch@google.com 68a9727c52 Rewrite Futures.
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27375
Reverted: https://code.google.com/p/dart/source/detail?r=27376

Review URL: https://codereview.chromium.org//23926011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27383 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 14:00:20 +00:00
floitsch@google.com d035cbd825 Revert "Rewrite Futures."
This reverts commit r27375.

Review URL: https://codereview.chromium.org//23967011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27376 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:16:41 +00:00
floitsch@google.com 42e3d1db85 Rewrite Futures.
R=lrn@google.com

Review URL: https://codereview.chromium.org//23926011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27375 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 12:02:37 +00:00
floitsch@google.com 7cf1fa8d26 Don't wait for asynchronous error handlers.
R=lrn@google.com

Review URL: https://codereview.chromium.org//23534043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27182 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 09:25:32 +00:00
floitsch@google.com 113c812877 Replace ReceivePorts with asyncStart|End in some tests.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23522012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26996 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-02 08:23:21 +00:00
floitsch@google.com 89373813f9 Make async stream test less flaky.
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23444026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26923 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 15:53:23 +00:00
floitsch@google.com 8e7d24a2c5 Fix run_zoned6 and run_zoned9 test.
Review URL: https://codereview.chromium.org//23450011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26787 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 13:43:45 +00:00
floitsch@google.com 003cfdc910 Fix run_zoned6|9_test.
BUG= http://dartbug.com/12817
R=kustermann@google.com

Review URL: https://codereview.chromium.org//23694002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26784 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 12:20:34 +00:00
floitsch@google.com a9cefff022 elementAt throws a RangeError not StateError.
Review URL: https://codereview.chromium.org//23429002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26651 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-26 14:56:26 +00:00
lrn@google.com 76d4625ccd Fixed bug in _ControllerStream.operator==.
Make _BroacastStream extends _ControllerStream to get same
equality behavior.

Add regression tests.

BUG= http://dartbug.com/11904
R=floitsch@google.com

Review URL: https://codereview.chromium.org//19775015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@25205 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-19 11:58:08 +00:00