Commit Graph

9 Commits

Author SHA1 Message Date
Robert Nystrom a2b556b937 Migrate lib_2/async to NNBD.
Change-Id: Ia5c41dda6503e1fbb8cc6099835d07588425e2ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128310
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2020-01-09 22:04:37 +00:00
Bob Nystrom f6ca2c1d8f Remove the Dart 1 tests.
This deletes:

tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib

It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)

I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)

"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."

- Ray Bradbury, Fahrenheit 451

Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-10-11 23:45:18 +00:00
Jacob Richman 2dcd56ef43 Format all tests.
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests"
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
2017-01-25 11:06:58 -08:00
Zachary Anderson dde47b2aad Remove package:unittest from some tests
package:unittest is deprecated in favor of package:test.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2656743002 .
2017-01-25 08:50:02 -08:00
lrn@google.com 34cc8411a3 Fix behavior when listening multiple times to a broadcast take/skip stream.
Turns out the existing behavior was badly broken.
A broadcastStream.take(10) would only produce ten events total, no matter how
many listeners were attached, beacuse the counter was on the stream, not the
subscription.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//920373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43755 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-13 13:59:41 +00:00
lrn@google.com de280d96af Make Stream.where, etc., be documented as inheriting broadcast state.
Very few changes were necessary because it was already the behavior in most
cases.

BUG= http://dartbug.com/18586
R=ajohnsen@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36344

Review URL: https://codereview.chromium.org//295913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36475 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 08:44:21 +00:00
lrn@google.com 55d24213f6 Revert "Make Stream.where, etc., be documented as inheriting broadcast state."
There were ... complications.

Review URL: https://codereview.chromium.org//299623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36347 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 08:30:34 +00:00
lrn@google.com 33bcf9755c Make Stream.where, etc., be documented as inheriting broadcast state.
Very few changes were necessary because it was already the behavior in most
cases.

BUG= http://dartbug.com/18586
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//295913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36344 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 07:28:12 +00:00