428b3c4473
[nnbd] Fix some async tests in strong mode
...
Fixes:
lib/async/catch_errors6_test
lib/async/catch_errors7_test
lib/async/catch_errors8_test
lib/async/catch_errors_test
lib/async/intercept_print1_test
lib/async/intercept_schedule_microtask1_test
lib/async/intercept_schedule_microtask2_test
lib/async/intercept_schedule_microtask3_test
lib/async/intercept_schedule_microtask4_test
lib/async/intercept_schedule_microtask5_test
lib/async/intercept_schedule_microtask6_test
lib/async/run_zoned7_test
lib/async/run_zoned8_test
lib/async/stream_controller_test
lib/async/stream_event_transformed_test
lib/async/stream_from_iterable_test
lib/async/stream_single_test
lib/async/stream_single_to_multi_subscriber_test
lib/async/stream_state_nonzero_timer_test
lib/async/stream_state_test
lib/async/stream_transform_test
lib/async/stream_transformation_broadcast_test
lib/async/stream_transformer_from_bind_test
lib/async/stream_transformer_from_handlers_test
lib/async/zone_future_schedule_microtask_test
lib/async_star/await_for_test
lib/async_star/await_pauses_test
Change-Id: I9d5d92938c28cc8131c70665ead4d44ffcff6bc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143001
Commit-Queue: Liam Appelbe <liama@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-04-09 22:01:42 +00:00
684c53a6f1
[tests] Fixing some null-safe strong mode tests.
...
Change-Id: I131754d0183bed52e6443c2511197ed3b1e63b04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138887
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-03-11 15:41:59 +00:00
a2b556b937
Migrate lib_2/async to NNBD.
...
Change-Id: Ia5c41dda6503e1fbb8cc6099835d07588425e2ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128310
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-01-09 22:04:37 +00:00
f6ca2c1d8f
Remove the Dart 1 tests.
...
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-10-11 23:45:18 +00:00
0db8403cca
Replaced helper files that were accidentally removed during migration.
...
TBR=rnystrom@google.com
Migrated test block 168 to Dart 2.0.
Migrated some tests off of package:test to packages async_helper and
expect.
BUG=
Review-Url: https://codereview.chromium.org/2999323002 .
2017-08-21 01:11:29 -07:00
42d354c91d
Migrated test block 168 to Dart 2.0.
...
This block felt trickier than others, mostly due to random errors that I
wasn't able to find a cause for. Tests that I'm uncertain about are:
-first_regression_test
-future_timeout_test
-future_or_bad_type_test/implements
These all have status entries to prevent failures, but I think these
tests need another set of eyes.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2999943002 .
2017-08-21 00:59:34 -07:00
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
35e9ae50d9
Fix warnings in library-tests.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//54723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29756 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:01:11 +00:00
d8ebf58a39
Remove default value in factory constructor.
...
BUG= http://dartbug.com/14284
R=lrn@google.com
Review URL: https://codereview.chromium.org//32553003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29064 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 08:27:15 +00:00
a2e03e5463
Fix flaky stream_controller_async_test.
...
BUG= http://dartbug.com/163608
R=floitsch@google.com
Review URL: https://codereview.chromium.org//27499002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28719 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 11:29:13 +00:00
dc9c5f42ed
Redo StreamTransformers so they work with Stack traces.
...
Since this involved a breaking change I cleaned up more of the
StreamTransformer API.
This CL also deprecates the getAttachedStackTrace method.
R=ajohnsen@google.com , lrn@google.com , nweiz@google.com , rnystrom@google.com
Review URL: https://codereview.chromium.org//25354003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28562 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 12:34:34 +00:00
57291fed77
Address more bot-redness.
...
Review URL: https://codereview.chromium.org//18841002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24794 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 12:24:31 +00:00
d02d106430
Make StreamController be a StreamSink, not just an EventSink.
...
Reverts r24590
Review URL: https://codereview.chromium.org//18080019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24791 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 08:27:27 +00:00
df2bcb893f
Revert "Make StreamController be a StreamSink, not just an EventSink."
...
Revert "Remove type variable to work around dart2js bug."
This reverts commit r24587.
This reverts commit r24588.
Review URL: https://codereview.chromium.org//18080015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24590 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 15:07:09 +00:00
a15e02cc6a
Make StreamController be a StreamSink, not just an EventSink.
...
BUG=http://dartbug.com/10677
R=floitsch@google.com
Review URL: https://codereview.chromium.org//16240008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24587 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 12:56:29 +00:00
5431a5af54
Remove AsyncError with Expando.
...
Review URL: https://codereview.chromium.org//14251006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21498 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 18:58:32 +00:00
e2ee353940
Rename unsubscribeOnError to cancelOnError.
...
Review URL: https://codereview.chromium.org//14251013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21469 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 16:07:36 +00:00
bead146749
Renamed StreamSink to EventSink. Renamed signalError to addError.
...
Review URL: https://codereview.chromium.org//12610006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19683 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 11:31:19 +00:00
cb10990e5a
Remove Sink and move CollectionSink to async.
...
Committed: https://code.google.com/p/dart/source/detail?r=18063
Reverted: https://code.google.com/p/dart/source/detail?r=18067
Review URL: https://codereview.chromium.org//12154006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18144 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 15:32:18 +00:00
cb1bff12b6
Revert "Remove Sink and move CollectionSink to async."
...
This reverts commit 18063.
Review URL: https://codereview.chromium.org//12192021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18067 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 19:30:15 +00:00
02f6b1835d
Remove Sink and move CollectionSink to async.
...
Review URL: https://codereview.chromium.org//12154006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18063 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 19:03:55 +00:00
df8d47e895
Fix various warnings from the analyzer.
...
Review URL: https://codereview.chromium.org//12089066
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17836 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 11:35:29 +00:00
aa7cbb2b41
Remove Signal class and use Future/.whenComplete instead.
...
Review URL: https://codereview.chromium.org//11794043
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16792 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 12:59:00 +00:00
4a7dfd2da3
Big merge from experimental to bleeding edge.
...
Review URL: https://codereview.chromium.org//11783009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
Liam Appelbe