32d4ac903b
[vm/aot/tfa] Fix crash while getting static type context for signature shaking
...
Fixes https://github.com/flutter/flutter/issues/56479
Change-Id: I3e308382bf64b1b1aa39174c2095ee7a465907a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/146980
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-05-07 00:56:02 +00:00
b955271e51
Migrate language_2/function_subtype to NNBD.
...
Change-Id: I8d41ad649c83cd97253006693a0cf3676de418e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145542
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-05-05 16:52:30 +00:00
018dab4568
Analyzer: Report a constructor which redirects to a constructor of an abstract class
...
Fixes https://github.com/dart-lang/sdk/issues/37552 and
fixes https://github.com/dart-lang/sdk/issues/34370
Change-Id: I75e68157cf7e6e9824353c307a8e9f6669f8ea82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145571
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-05-02 03:53:55 +00:00
a9b81e18d9
[cfe] Handle dynamic return in async
...
Closes #41437
Change-Id: I493b516f0b72fc1da097b92bd75150aea8e60ba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145042
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-30 12:39:04 +00:00
d2ae466056
[vm/aot] Update references from types to mixin applications after deduplication
...
CFE may use anonymous mixin application classes in types after
applying LUB (Least Upper Bound) algorithm in conditional expressions,
and then those types can spread via type inference.
After anonymous mixin application classes are deduplicated, all
references to removed mixin applications from types should be
updated to point to the remaining mixin application.
Fixes https://github.com/flutter/flutter/issues/55345
Change-Id: I7860b2868cb153d125fec363c1653b7aa16521e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145501
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Martin Kustermann <kustermann@google.com >
2020-04-29 23:54:08 +00:00
3da1591253
[ddc] Fix function type casts in weak mode
...
Allow null to be cast as function types in weak mode.
Change-Id: I42084250c428b7e6a18ce343305d43603b4e1ec4
Fixes: https://github.com/dart-lang/sdk/issues/41680
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144995
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Mark Zhou <markzipan@google.com >
2020-04-28 21:19:54 +00:00
3e26a5d0dd
Issue 40957. Report the language feature, and recommend to set SDK constraint.
...
...but don't recommend to enabled any experiment.
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/40957
Change-Id: I556ce9952b28d0b079521ac46558f8e3adf352c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144982
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-27 22:11:46 +00:00
23cbe39355
[ddc] Remove error handler from number parse helpers
...
This copies the logic from dart2js and brings the two patches closer
together. There is no need to pass the error handler to the helper
function shared between `parse()` and `tryParse()`.
Update JS foreign function types in parseDouble to match the NNBD
version.
Fixes: https://github.com/dart-lang/sdk/issues/41613
Change-Id: I85d39f8ba6bd76459cf6263099983b8b96d3a669
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144304
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-04-22 16:07:29 +00:00
ad8ed8bd46
Add test: await voidExpression is an error iff null-safety is enabled.
...
Change-Id: Ibdd201b595b8835015a1a17417ee1d6e76030676
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144140
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-04-21 15:30:03 +00:00
ec3dd52462
The type 'dynamic' is defined in dart:core.
...
This makes fixes to analyzer and update the test for updated spec.
Change-Id: Ie5222bcf9056d5cbb7f18437dec04d5af21ff314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-13 17:55:36 +00:00
c9710e5059
analyzer: Do not report on a bad type of return expression if function has illegal return type
...
Fixes #38188 and fixes #41439
Change-Id: Id6339529afba331750858fb34771bed627ece0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143248
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-04-13 03:42:35 +00:00
450ae848f6
Applying a mixin replaces corresponding names in the interface.
...
Change-Id: I5e2ada71af50aa580f5d236773ccb122fca5591c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143060
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-10 15:57:44 +00:00
5f655a8c27
Migrate language_2/covariant to NNBD.
...
Change-Id: Icb4eae77fab5257ea00ff948d3f775725398e6ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142067
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-04-07 01:05:28 +00:00
bac08fb339
Implement interfaces subtyping check using allSupertypes.
...
Change-Id: I43a4b98bae913895c7e176dd24a17fc5df7666e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-04-06 00:20:10 +00:00
a7f1a5e677
[cfe] Handle A extends FutureOr<B> <: FutureOr<B>
...
Change-Id: Ib5580328f006b033b2c004083b575a2cf5aed551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141541
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-04-05 06:31:19 +00:00
2e0bec389b
Add tests static_extension_constant_...
...
Testing that it is a compile-time error to invoke an extension method
during constant expression evaluation.
Change-Id: I52404d87c7da977451411f6cfc10c7059864fba4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123580
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2020-04-04 10:20:48 +00:00
9be92b28f1
Migrate language_2/double to NNBD.
...
Change-Id: I72b95b7d84847c1b7c4e89ba607dfca6d9069854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142212
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-04-04 00:25:17 +00:00
a4b09ac192
Migrate language_2/control_flow_collections to NNBD.
...
Change-Id: I8b9b7d70abc47d672c68db65bc67d08beb7d41a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142089
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-04-04 00:04:27 +00:00
f41de20d46
[vm] Fix unsound code motion through checks.
...
Fixes https://github.com/dart-lang/sdk/issues/40765
Change-Id: If3b239c832c5137ad6999ab6e6ff3196bf54a6af
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137970
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2020-04-03 15:55:15 +00:00
e736495eb7
Migrate language_2/const to NNBD.
...
Change-Id: I464275799b3e7a21326d35503b776f9c1101a599
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141764
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-04-03 00:56:36 +00:00
0579a9250a
[cfe] Pass typeArguments from parser
...
This is the "next step" mentioned in
https://dart-review.googlesource.com/c/sdk/+/141240 .
`List<UnresolvedType> typeArguments` were dropped (and null was passed)
in several cases in `handleSend`, but they are needed in
BodyBuilder.buildConstructorInvocation in the case where the receiver
of the constructor invocation is a type alias.
This CL ensures that the `typeArguments` are passed when needed, and a
named parameter `isTypeArgumentsInForest` is passed in order to preserve
the information about whether or not they have been to the `forest`.
The CL also adjusts tests '{generic_,}usage_type_variable_*' to fit the
decision made in language issue 848 that a type alias cannot be used
for constructor invocations when it (directly or indirectly) denotes
a type variable.
Change-Id: I8d831457e35a7455f8fcfe461a10872c61555748
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141543
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-04-01 16:57:15 +00:00
f180511499
Add implementation of several parts of non-function type aliases
...
Generalize `TypeAliasBuilder.unaliasDeclaration` such that it takes
an argument `typeArguments` and uses that to handle the case where
a type alias application ultimately expands to a type variable (e.g.,
with `typedef F<X> = X`, `F<int>` expands to `int`), and also to
emit a compile-time error in the case where such a type alias is
used to invoke a constructor or invoke/tear-off a static member.
Next step: Pass `List<UnresolvedType> typeArguments` from `handleSend`
to `finishSend` etc. to `BodyBuilder.buildConstructorInvocation`,
which seems to be a somewhat larger refactoring; needed in order to
make `generic_usage_class_test` pass. Some other fix is needed in
order to make `generic_usage_type_variable_test` pass.
Change-Id: Icd3593f03c6348c50b1ec3d7c9676f1bd7c56daf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141240
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-28 09:35:02 +00:00
7afb23a7d9
Added new tests.
...
One test verifies that the default values of fromEnvironment
constructors are the values false/0/''.
The other new test verifies that it is allowed to invoke an expression
whose static type is a proper subtype of a function type (X extends F,
where F is a function type), cf.
https://github.com/dart-lang/language/issues/896 .
Change-Id: I4ee32df7c5950be07b800027f000a486bf3af61c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141249
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2020-03-27 19:02:52 +00:00
99f619907e
[vm/aot/tfa] Fix tracking of parameters in async_op closures
...
Issue: https://github.com/flutter/flutter/issues/51828
Change-Id: I9b99c74eda66f180261f4cb25361b8fe8eaef561
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141340
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-03-27 15:47:11 +00:00
4ab3bda5db
[parser] Change recovery for constructor; report errors in bad constructors
...
Change-Id: I3d656afce4a3ec14c7c099893a434abba3945ebf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140862
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2020-03-27 11:57:56 +00:00
81f5bf98b1
Correct non-function type alias tests
...
Change-Id: I49a04bc294a65a252ba1d99a1c5aac3835632449
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140659
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-25 10:19:39 +00:00
9ea09ce17b
[cfe] Improve message on final variable assignment
...
Closes #40242
Change-Id: Iccdfbf01da18ddd501dc705b678358c974003551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140654
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-03-24 13:11:29 +00:00
e3af7e724f
Update usage of int/String fromEnvironment
...
Breaking change 40678 requires the constructors int.fromEnvironment and
String.fromEnvironment to get new default values for the named
parameter `defaultValue`. This CL changes usages of these constructors
such that they do not depend on the default value, such that it
becomes a non-breaking change for code in the SDK repo to perform the
change in sdk and in sdk_nnbd.
Change-Id: I82af0e1f92d6cd3618b65c0c50d754ae8c39eb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140284
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-24 11:19:14 +00:00
b8544e8220
[cfe] Don't report nnbd errors/warnings in top level inference
...
Closes #41102
Change-Id: Ieede171d92aa28b0ad9478a1b4293ddf35418d7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140040
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-23 16:39:03 +00:00
2049335af3
[cfe] Improve message on ambiguous extension member access
...
Closes #40862
Change-Id: I7cc2c0cfbbc878709dc3ad645d8a4b37094056c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140520
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Jens Johansen <jensj@google.com >
2020-03-23 09:33:20 +00:00
7aace6fa60
Make StackTrace generally not nullable in migrated NNBD library.
...
Bug: https://github.com/dart-lang/sdk/issues/40130
Change-Id: I13aba0c2a3fa5b1c3d3995f075ffd38f03aca897
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139880
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2020-03-19 23:31:30 +00:00
568255dbec
Change tests to expect new behavior of fromEnvironment
...
Constructors int.fromEnvironment and String.fromEnvironment will now
yield 0 or '' rather than null in the case where the requested
environment declaration does not exist, so various expectations needed
to be updated accordingly.
Change-Id: Ie6f3b9ee18a970e50520ac84c2741b4875ada3c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139804
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-17 13:43:17 +00:00
330ec173a9
Add bool.hasEnvironment constructor and tests
...
Change-Id: I65ebfcb48bf46292d5ae611ecb7431e0666f753c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139286
Reviewed-by: Martin Kustermann <kustermann@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2020-03-16 11:17:58 +00:00
a5eb0b559c
[cfe] Handle callable extension getters
...
Closes #40596
Closes #40713
Closes #39889
Change-Id: I183560b912e2f6f2c02d51278c0d28c8a6d67f99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139203
Reviewed-by: Jens Johansen <jensj@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-03-13 10:46:39 +00:00
6c6144bb74
[cfe] Implement consolidated in ClassHierarchyBuilder
...
Closes #40414 and #40156
Change-Id: I066aa8ceef4f998230215fd9e9b446b2281cc3bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138294
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2020-03-13 08:16:49 +00:00
5e9be81d5e
Make all CastErrors be TypeErrors.
...
This makes CastError implement TypeError, and changes all test
expectations to look for TypeError. A followup CL will deprecate
CastError.
Bug: https://github.com/dart-lang/language/issues/787
Bug: https://github.com/dart-lang/sdk/issues/34097
Change-Id: I7102c6260901317572d2df08c4be9c4c48197688
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138670
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2020-03-11 23:31:06 +00:00
c07d5d84b8
[cfe] Allow uninitialized non-nullable late fields
...
Change-Id: If0d1450c317b488e3299cfa031ab1a3d6953a7ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137787
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-03-03 09:50:27 +00:00
16f072c783
Migrate language_2/async to NNBD.
...
Change-Id: Id66e712eaf52fda2069ce5177aa091e373ad52c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134244
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-27 23:04:03 +00:00
82236bd6ab
[vm] Fix incorrect inference of non-nullability from 'is' checks
...
Fixes https://github.com/dart-lang/sdk/issues/40792
Fixes https://github.com/dart-lang/sdk/issues/40795
Change-Id: I0af455040e05265a025b1a424c1aac30f3476f95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137426
Reviewed-by: Ryan Macnak <rmacnak@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2020-02-27 03:35:34 +00:00
9c05fde96b
[Cleanup] Removes deprecated --gc_at_instance_allocation.
...
The flag only appears in two tests and a comment.
Flag was removed in https://dart-review.googlesource.com/c/sdk/+/83120
Change-Id: I2a5d828c8ec7909a3d16579f9a9771176aabb65e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136974
Reviewed-by: Daco Harkes <dacoharkes@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-02-26 15:00:26 +00:00
250f0e83ea
[Cleanup] Removes deprecated --enable-inlining-annotations; updates annotation.
...
The --enable-inlining-annotations flag was removed a while ago and the uses
were attempted removed in https://dart-review.googlesource.com/c/sdk/+/99148
but was later reverted in https://dart-review.googlesource.com/c/sdk/+/109320 .
This removes the two last cases of this flag.
Change-Id: I157dd7bce0a49ab01100fa6f48d96eeefdb06b45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136969
Reviewed-by: Teagan Strickland <sstrickl@google.com >
Commit-Queue: Clement Skau <cskau@google.com >
2020-02-25 12:09:10 +00:00
98b4635aa9
Make TypeError no longer implement AssertionError.
...
This means that TypeError no longer inherits a spurious `message` member.
The message of a platform-thrown TypeError is still available as `toString()`.
Fixes #40317
Bug: http://dartbug.com/40317
Change-Id: I77312859ebae3f92c2e56aeea6283b075b71c8d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136129
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-02-21 14:02:57 +00:00
fd20c7b92b
[VM/nnbd] Print nullability of types by default.
...
Only '?' is shown by default.
To print '*' and '%', use debugging flag --show-internal-names.
Fix expectations in tests.
Change-Id: Idc60fbfb4d477602eb0c713f4bdcc1e573a3328a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135790
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
2020-02-20 21:43:25 +00:00
c7b501625e
Validate not only errors, but also warnings.
...
Change-Id: I2c03711061ccd40d1609cf9148f3169b4df847d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135600
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-13 21:31:59 +00:00
ddef611e04
Copy over the README.
...
That's the only thing in language_2/async_no_suspend.
A little weird, but I think it's worth copying it just to minimize the
diff between the two test directories.
Change-Id: Iac7078d8e44ac63331c38bd6465a654880bbeb98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134905
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-12 23:45:07 +00:00
688801cb27
Migrate language_2/assert to NNBD.
...
Change-Id: I4daa09afa52f76076374591b3e3f3420a46b169b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134240
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2020-02-06 22:47:25 +00:00
bf66cba15e
[tests] Updating tests to not depend on type variable names being conserved.
...
Change-Id: Id34fb4bbc4bb88241fd984acc490097e604d16cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134410
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Mark Zhou <markzipan@google.com >
2020-02-05 19:18:49 +00:00
c5cba24124
Migrate language_2/argument to NNBD.
...
Change-Id: Ic1963eb1962bc1341a68783e9c44f3e04bfbc43a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134223
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2020-02-04 15:07:11 +00:00
3183573a79
[cfe] Account for signatures when inserting noSuchMethod forwarders
...
It is possible for an abstract member to be overridden with another
abstract member with different signature (that has, for example, more
optional parameters). In such cases, the noSuchMethod forwarders should
be generated for each distinct signature.
Closes #40248 .
Bug: http://dartbug.com/40248
Change-Id: I7974415f0ecb78f05d7265ecf9d57cc0d38e6c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132661
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-02-04 07:58:00 +00:00
ed441e48d0
Update all Slow tests to be Slow, Pass.
...
Change-Id: I610b272355b045eab80cf941210774fb12d775eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134103
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2020-02-01 00:17:42 +00:00
Alexander Markov