61251c2c4e
[VM] Ensure that the constant right-hand side of operator ?? is canonicalized ( fixes #31066 ).
...
Add regression test.
Change-Id: I48f33b91b75f372e14ed5aa9185e79e105307573
Reviewed-on: https://dart-review.googlesource.com/16330
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2017-10-24 23:50:09 +00:00
8291ae9d59
Update dart2js status files for crashes for invalid part directives and annotations.
...
TBR
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug:
Change-Id: I062372cb1bccdaa4f9bbf157921a876dab96c66f
Reviewed-on: https://dart-review.googlesource.com/16329
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-24 22:34:13 +00:00
e2e3934b62
Add status entries for dartk and dartkp in strong mode
...
This is an initial step and some entries say "Pass", which indicates
that the test was marked earlier in some other (more general) section and that
we should split that section.
Change-Id: I0417d55dcdec352f730c298bb155d112eb341711
Reviewed-on: https://dart-review.googlesource.com/16322
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2017-10-24 21:49:19 +00:00
ccbed2d33c
Parse metadata for part directives and resynthesize in Analyzer.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: Id869144a6fce170dbc74b0595b545238595be84d
Reviewed-on: https://dart-review.googlesource.com/15983
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-10-24 19:40:08 +00:00
df4bd6c398
Don't check for cycles in constructors in const evaluation
...
You can use the same constructor multiple times in a single constant
evaluation. For example:
class A {
final List<A> deps;
const A({this.deps: const []});
}
const a = const A();
const b = const A(deps: const [a]);
main() { print(b); }
The program above will evaluate the 'A' constructor multiple times
when compiling the constant for 'b', but that's okay, as long as
we don't examine the same field (or local) multiple times.
Change-Id: Icda198ccb47ea91a046134f55deba9041fcf1f4a
Reviewed-on: https://dart-review.googlesource.com/15989
Commit-Queue: Harry Terkelsen <het@google.com >
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-24 16:31:08 +00:00
89e43cdd41
[VM] Ensure that constant arguments to super initializer are canonicalized ( fixes #31106 ).
...
Add regression test.
Change-Id: I6d4aa8148766ceab02bb7be071d55f0e0415bbbf
Reviewed-on: https://dart-review.googlesource.com/16081
Commit-Queue: Régis Crelier <regis@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
2017-10-24 00:37:58 +00:00
6504f342ab
[VM] Remove obsolete flags.
...
--generic_method_syntax
--assert_initializer
--warn_super
--initializing_formal_access
Change-Id: Id2e9f15b1dfecb933df97fb954618ce122cb3e4b
Reviewed-on: https://dart-review.googlesource.com/15643
Reviewed-by: Zach Anderson <zra@google.com >
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2017-10-20 18:13:00 +00:00
7a540d2f85
Remove VMOptions in tests for options that are now on by default.
...
Change-Id: Ic12edd3e76ba1f8b9fb096c96e310e7253cc6ac6
Reviewed-on: https://dart-review.googlesource.com/14722
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2017-10-19 16:19:16 +00:00
37eaf1cdb1
Also skip deep_nesting1_negative_test
...
R=whesse@google.com
Bug: 31158
Change-Id: I1dcf37c07fdaafea6394e746b7e2558112334dff
Reviewed-on: https://dart-review.googlesource.com/15160
Reviewed-by: William Hesse <whesse@google.com >
2017-10-19 15:53:31 +00:00
2b3c7ef7dd
Disable deep_nesting2_negative_test on precompiled runtime
...
Started failing after
https://github.com/dart-lang/sdk/commit/b85a7fecd02c309fa70e466a11c7f0bac14d10db
R=hesse@google.com
Bug: 31158
Change-Id: I80ee69bac34f50d6c8d2764891ebd39df59f0bc1
Reviewed-on: https://dart-review.googlesource.com/15126
Reviewed-by: William Hesse <whesse@google.com >
2017-10-19 12:37:22 +00:00
0e5efbda08
Implicitly pass --reify-generic-functions option to the VM when testing Dart 2.0
...
Fix migrated Dart 1.0 tests for Dart 2.0
Update status files
Change-Id: I41c8a6d06008ec0213e78cdc578b24b24668d312
Reviewed-on: https://dart-review.googlesource.com/14940
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2017-10-18 22:18:46 +00:00
f36b1f49d6
Only set model.scopeInfo for the outer member, not nested closures
...
Change-Id: I848e18e1000158b4a198782227bfb2524104e805
Reviewed-on: https://dart-review.googlesource.com/14700
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-18 21:00:06 +00:00
2b33f79dd1
Update localsMap when inlining or looking at super constructors.
...
Bug:
Change-Id: I60b2d0d87d84901817d7d03b685a068c9d2f6100
Reviewed-on: https://dart-review.googlesource.com/14621
Commit-Queue: Emily Fortuna <efortuna@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-18 17:58:32 +00:00
601e822ce9
Update status for Chrome 62 stable
...
Bug:
Change-Id: I3c554583dbd9fabc01664e21d86248768db551a4
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/14765
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
2017-10-18 12:02:56 +00:00
32bc278aed
Update status file for dart2js kernel
...
Status file update for dartbug.com/31128
Bug:
Change-Id: I7f539c77327fd7ad6ef4f725b3155d9f3aa5f143
Reviewed-on: https://dart-review.googlesource.com/14761
Reviewed-by: Jens Johansen <jensj@google.com >
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2017-10-18 08:35:45 +00:00
07b9df22ac
Use the Expect.throws___() helper methods throughout tests.
...
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.
Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2017-10-17 23:37:15 +00:00
cac79d8db9
Fix some tests to be better Dart 2.0 tests.
...
async_await_test was correct, but was using a misleading name. It really
cares about assertions being enabled, not "checked mode".
The setter tests originally validated the runtime type checks but were
changed to compile time checks. Used a little judicious dynamic to get
back to testing the runtime type checking.
Change-Id: I0e121bd1443376e885777d609f5d6507537c0b8c
Reviewed-on: https://dart-review.googlesource.com/14161
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2017-10-17 23:11:25 +00:00
8a2a9e4622
Reland "Error on setter having not exactly one parameter"
...
Rewrite setter with invalid parameters into one with one parameter
and a body throwing a compile-time error.
Some analyzer tests fail until we sort out the expected form of the
generated kernel code in situations like this. This is tracked in
https://github.com/dart-lang/sdk/issues/31096
Closes https://github.com/dart-lang/sdk/issues/31069
Original CL: https://dart-review.googlesource.com/13080
Change-Id: I432240c33d6daf0ec6bfe2b73c609ab4762cda8c
Reviewed-on: https://dart-review.googlesource.com/14381
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2017-10-17 13:16:30 +00:00
c74829f644
Simplify language_2 status files
...
language_2_vm.status, language_2_precompiled.status, and
language_2_flutter.status have had disjunctions removed,
sections moved to the right file, identical sections merged,
sections ordered by header, section expressions sorted,
section contents alphabetized, and redundant lines removed.
Bug:
Change-Id: I5d35fe6ec747197e5750b81213803ad4b0de1e9d
Reviewed-on: https://dart-review.googlesource.com/14062
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-10-17 08:34:25 +00:00
dd0d299dcb
[kernel] Un-revert support for generic function types and removing type erasure.
...
Change-Id: I8032e4622a0756199528a61fdb59f3d0ec132d1f
Reviewed-on: https://dart-review.googlesource.com/14202
Commit-Queue: Samir Jindel <sjindel@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
2017-10-16 23:17:09 +00:00
eb93a62c6a
update dart2js kernel status files
...
TBR=rnystrom@google.com
Change-Id: I530adcf643f11229d6101014631621c2aa85a35a
Reviewed-on: https://dart-review.googlesource.com/14340
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-16 23:00:37 +00:00
390c80234a
[VM generic functions] Properly instantiate generic signatures by providing the
...
number of free function type parameters.
Add test and mark status files.
Change-Id: I081de7674693c5ac2071a33948d25aadfc65f4ae
Reviewed-on: https://dart-review.googlesource.com/13901
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2017-10-16 21:57:05 +00:00
fe22055f1c
[VM] Capture instantiator when type parameter is referenced via string
...
interpolation in local function (fixes #31057 ).
Add regression test and mark status files.
Change-Id: I1258da09bd67f9c2ed9596b4ff93a1ad744cc505
Reviewed-on: https://dart-review.googlesource.com/13925
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Régis Crelier <regis@google.com >
2017-10-16 21:06:32 +00:00
c7f6fea83f
Update assertion_initializer_const_function[_error]_test.
...
Both of these were 1.0 tests that tested how a function argument to an
assert in an intiailizer were handled.
In 2.0, assert() no longer supports functions as their initial
parameter. I updated the test to reflect that. After that, the two tests
are identical, so I removed
assertion_initializer_const_function_error_test.
Change-Id: I41768c4c64459cfa80c817bf9a6c9dea3efd7fb0
Reviewed-on: https://dart-review.googlesource.com/14160
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2017-10-16 19:19:27 +00:00
25dc42f5d8
Revert "Error on setter having not exactly one parameter"
...
This reverts commit 4bb83e9311f1b07b2789https://dart-review.googlesource.com/14061
Reviewed-by: Martin Kustermann <kustermann@google.com >
2017-10-16 16:32:13 +00:00
f1b07b2789
Error on setter having not exactly one parameter
...
Rewrite setter with invalid parameters into one with one parameter
and a body throwing a compile-time error.
Some analyzer tests fail until we sort out the expected form of the
generated kernel code in situations like this. This is tracked in
https://github.com/dart-lang/sdk/issues/31096
Closes https://github.com/dart-lang/sdk/issues/31069
Change-Id: I65033709813671ecb933e6a4dc00d1ff3b504661
Reviewed-on: https://dart-review.googlesource.com/13080
Reviewed-by: Peter von der Ahé <ahe@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Aske Simon Christensen <askesc@google.com >
2017-10-16 15:07:49 +00:00
dca67b6d54
Update status for regression tests on vm-precompiled
...
Bug:
Change-Id: Ia00a0594b797d7402466e4fe9464fea6f939b44c
Reviewed-on: https://dart-review.googlesource.com/13984
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com >
2017-10-16 14:43:34 +00:00
2e0261dddf
Update status for recursive_generic_test on dart2js
...
Alphebetize and merge sections in language_2/language_2_dart2js.status
Bug:
Change-Id: I57a2b6d1ce8442c7a8a6686a9f465af1d8224aa3
TBR=rnystrom@google.com
Reviewed-on: https://dart-review.googlesource.com/13982
Reviewed-by: William Hesse <whesse@google.com >
2017-10-16 10:15:36 +00:00
e01e4f692c
recursive_mixin_test: dart2js checks only in --checked mode
...
TBR=rnystrom@google.com
Bug:
Change-Id: I39d197a311174482ef4ee94b3a16da2d7236774c
Reviewed-on: https://dart-review.googlesource.com/13961
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-14 02:11:09 +00:00
015d3450ed
update dart2js kernel status
...
TBR=efortuna@google.com
Bug:
Change-Id: I829f5b7f4a2d0042eab213049a1cd6760dc6b83d
Reviewed-on: https://dart-review.googlesource.com/13960
Reviewed-by: Stephen Adams <sra@google.com >
2017-10-14 01:54:56 +00:00
eead460367
Fixing build failure on DDC-windows.
...
Bug:
Change-Id: I137f4075f83864edffd8187add21a1c93b49b83a
Reviewed-on: https://dart-review.googlesource.com/13935
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-10-14 00:14:44 +00:00
9ab66f726f
Fix up language2 status changes as result of https://dart-review.googlesource.com/c/sdk/+/13620
...
Bug:
Change-Id: I576d403b76192252e15e8e235fcc613a5e2a178d
Reviewed-on: https://dart-review.googlesource.com/13933
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-10-14 00:14:11 +00:00
73e13aefe6
Migrated block 145 to Dart 2.0.
...
Various changes made for strong mode.
Bug:
Change-Id: I7d57cba0ec0420b68f7c1cf3d31fb4c8577e9898
Reviewed-on: https://dart-review.googlesource.com/13201
Commit-Queue: Ben Konyi <bkonyi@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2017-10-13 23:52:14 +00:00
087ea1eb28
Updated test with the correct status.
...
TBR=rnystrom@google.com
Change-Id: Iccb72b8d38b2d4bf2834efc3d0d0db2cdbd5c19c
Reviewed-on: https://dart-review.googlesource.com/13931
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 23:23:44 +00:00
e2cc730067
Migrate blocks 51 and 52.
...
It looks like some of the tests in this block were already migrated,
but I re-migrated them and made a few tweaks that I think make them
better 2.0 tests.
Change-Id: I6d9058a53408f046d7db34f2244eeeb2c5eda625
Reviewed-on: https://dart-review.googlesource.com/13620
Reviewed-by: Ben Konyi <bkonyi@google.com >
2017-10-13 22:46:23 +00:00
0ef4de3f0c
Updated jsshell tests failures.
...
TBR=rnystrom@google.com
Change-Id: I01215d93895d75481063a90e5101d06c470c30d1
Reviewed-on: https://dart-review.googlesource.com/13930
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 22:44:17 +00:00
461d5338ce
Update status file for jsshell failure.
...
TBR=rnystrom@google.com
Change-Id: Ia852ca2c2b998ca4edc44da00b59bf670dea2330
Reviewed-on: https://dart-review.googlesource.com/13928
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 22:20:32 +00:00
cbfb3b642d
Treat async-for-in statements as if they are wrapped in a try-finally
...
Change-Id: Ide40e69f93db199e2b452a4ee5acbbabe331bcbf
Reviewed-on: https://dart-review.googlesource.com/13921
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-13 22:19:46 +00:00
f92a9787ba
Fixes a couple of analyzer non-strong failures and vm-app failures.
...
TBR=asiva@google.com ,rnystrom@google.com
Change-Id: I118929724d8a2306db92535992f560d1f1927d12
Reviewed-on: https://dart-review.googlesource.com/13927
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 22:17:16 +00:00
7eb00ea45d
Migrated Block 146 to Dart 2.0
...
R=bkonyi@google.com
Change-Id: If6c7c2ebd8a4e3a3b724ada3967fc5836123732d
Reviewed-on: https://dart-review.googlesource.com/13621
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-10-13 21:27:17 +00:00
f7c70a4bd2
Bring back import_combinators_negative_test.
...
I turned it into a normal positive multitest to better capture where the
error is.
Change-Id: I69a1ddbf38b594d6b8270e28f32e018878eee755
Reviewed-on: https://dart-review.googlesource.com/13922
Reviewed-by: Ben Konyi <bkonyi@google.com >
Commit-Queue: Bob Nystrom <rnystrom@google.com >
2017-10-13 21:21:55 +00:00
10bc3abaa4
Migrate test block 155 to Dart 2.0.
...
Bug:
Change-Id: Ic0f21c64f43f4e1b914ae4b2ceb576f2a5f6b92a
Reviewed-on: https://dart-review.googlesource.com/13100
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-10-13 17:11:42 +00:00
d162f26e77
Update dart2js-with-kernel status on a migrated language_2 test
...
TBR=terry@google.com
Bug:
Change-Id: I4082b429a84aefae61a151fee821de24fc77d6a7
Reviewed-on: https://dart-review.googlesource.com/13720
Reviewed-by: William Hesse <whesse@google.com >
2017-10-13 08:53:09 +00:00
fb8099fc42
Fix precompiler tests
...
TBR=bkonyi@google.com
Change-Id: I167c8894886b495e1e239c0ff7072dbf2f601622
Reviewed-on: https://dart-review.googlesource.com/13685
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 05:41:22 +00:00
07920cb852
Updated for strong mode tests only.
...
TBR=bkonyi@google.com
Change-Id: Ica922201af78bff8897ffd5659d352fe11a6b746
Reviewed-on: https://dart-review.googlesource.com/13684
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 05:30:30 +00:00
d64f62df27
Fixed status for analyzer w/o strong mode.
...
TBR=bkonyi@google.com
Change-Id: Id966134cd589f0eeffe5781b2e5ec886ac41fe03
Reviewed-on: https://dart-review.googlesource.com/13683
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 04:55:03 +00:00
aa768ee6bc
Fixed status file for arm64
...
TBR=bkonyi@google.com
Change-Id: Ibc4f8faa1d30c0c5d9a2d78d7cc5c25badbf7003
Reviewed-on: https://dart-review.googlesource.com/13682
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 04:31:45 +00:00
dfa7916418
Migrated block 148 to Dart 2.0
...
R=bkonyi@google.com
Change-Id: I2f455fd681b66c43cbcd873f3d3d278a5ff5c843
Reviewed-on: https://dart-review.googlesource.com/12762
Commit-Queue: Terry Lucas <terry@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 04:27:03 +00:00
0975c0f948
Updated status files
...
TBR=bkonyi@google.com
Change-Id: I00fe74bda01e6d8478251767053e4ba945527c49
Reviewed-on: https://dart-review.googlesource.com/13680
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 01:04:28 +00:00
9cf013a802
Revert "Revert "Migrated Block 150 to Dart 2.0""
...
This reverts commit a80fecfa20TBR=alanknight@google.com
Change-Id: I448a808c0dcf67209c2981732f8829723b959c52
Reviewed-on: https://dart-review.googlesource.com/13663
Reviewed-by: Terry Lucas <terry@google.com >
2017-10-13 00:06:32 +00:00
Régis Crelier