dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Kevin Millikin 1b6433b1f0 Status file updated for dartdevk 
Whatever reason we needed to have Pass expectations in the status
files, they seem to be unnecessary after recent refactoring.  Also
triage a run-time error.

Bug:
Change-Id: I9e596aca29509f99cae3e34f8377e5388518d80b
Reviewed-on: https://dart-review.googlesource.com/23679
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-28 09:55:14 +00:00
Vyacheslav Egorov 0aa2cfd44b [gardening] Update dartk/dartkp status files to make bots green. 
TBR=paulberry@google.com

Change-Id: Ic7989026ddcf8bb51f8dc637bf1c3031ed7af8ac
Reviewed-on: https://dart-review.googlesource.com/24104
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-28 09:03:12 +00:00
Morten Krogh-Jespersen 39907272f6 Remove comments from status files. 
This will allow for having automatic tools to alphabetize sections and entries.

Bug:
Change-Id: Ia7b7a100ca33197c4f3b1c50c11f24873dfbc09b
Reviewed-on: https://dart-review.googlesource.com/23675
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 07:56:20 +00:00
Paul Berry a36da30529 Insert implicit downcasts for indexed assignments. 
Change-Id: Ic6b5732100908fe6ce5abfc8c577e9f5ad8245b7
Reviewed-on: https://dart-review.googlesource.com/24021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-28 01:28:06 +00:00
Emily Fortuna 6557792b5b Add information about what types are instantiated when dealing with 
factories and reified generics.

Bug:
Change-Id: Ia34b08859f1e54e7dc8fc3f8d51a1e78a1fa0e41
Reviewed-on: https://dart-review.googlesource.com/24022
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-28 01:00:53 +00:00
Paul Berry 0eefa06d14 Insert implicit downcasts for the conditions of while statements. 
Change-Id: Ieb1bc13de5afb16e75ab810de35002bb3b966ea8
Reviewed-on: https://dart-review.googlesource.com/23742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-27 17:07:41 +00:00
Kevin Millikin faff6876ca Fix a bug in nullability of fields 
The simple nullability predicate would report that static fields are always
non-nullable.  Change this to report that they are always nullable.

Bug:
Change-Id: I47336bc9686c3bee90d77e6130bd5cddfb9f8a68
Reviewed-on: https://dart-review.googlesource.com/23674
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-27 14:15:11 +00:00
Morten Krogh-Jespersen a9a5081e10 Remove duplicate entries in same section from status files. 
If two sections are syntactically equal, they are considered same section.

The discovery of duplicate entries was perfomed by the test in the CL:
https://dart-review.googlesource.com/#/c/sdk/+/21341

All removals has been done by hand to make sure the best comment was chosen.

Bug:
Change-Id: I105f6375adc1b5f555eb7c2af7d7d1e4e1922a32
Reviewed-on: https://dart-review.googlesource.com/21340
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-11-27 11:07:18 +00:00
Kevin Millikin 05426fe0f5 Fix an issue in constructors 
Static fields should not be initialized in constructors.

Bug:
Change-Id: I34cb16a1eaa1c38b13266883199b6541f35fe340
Reviewed-on: https://dart-review.googlesource.com/23600
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-27 09:39:11 +00:00
Paul Berry b47ef6bdeb Insert implicit downcasts for the conditions of assert statements. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: Ife1531ee029dda32e91f7aa0d5720353de7996d5
Reviewed-on: https://dart-review.googlesource.com/23726
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-26 17:06:00 +00:00
Paul Berry 419a8c342e Insert implicit downcasts for field initializers. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I0ea8fcf94728e70d92f4be771f3ca5d10c366375
Reviewed-on: https://dart-review.googlesource.com/23725
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-26 06:33:50 +00:00
Kevin Millikin f84f656d56 Fix a bug in compilation of try/finally 
Compilation of Kernel's try/finally included a flattening optimization
when the body was a JS try/catch.  This optimization duplicated the
catch block, which changes the semantics of exceptions thrown from the
catch block.

Bug:
Change-Id: I65aefa798d7f9026ab24ed6d1d484dea53235955
Reviewed-on: https://dart-review.googlesource.com/23560
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-24 15:29:47 +00:00
Dmitry Stefantsov 68f2c12756 [ddc-kernel] Remove type parameters from function types of constructors 
Bug:
Change-Id: I62a078d5c406358f2037dfc40900b7d957487e93
Reviewed-on: https://dart-review.googlesource.com/22081
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
 2017-11-24 13:39:07 +00:00
Kevin Millikin fed1e4bd49 Fix a bug in compilation of while loops 
Unlabeled while loops in Kernel (these are ones that are not the
target of a break) did not shadow labeled ones.  The compiler would
generate a break without a label in JS which would target the wrong
loop.

Bug:
Change-Id: Ib060ab66326a3ea0779eaceccaf1ca06ccfafb75
Reviewed-on: https://dart-review.googlesource.com/23421
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-23 20:53:06 +00:00
Paul Berry 5ce5811216 Insert implicit downcasts for the conditions of for statements. 
Change-Id: I213617cb4ea1a5c29f8a6a56f54792c59cc4e132
Reviewed-on: https://dart-review.googlesource.com/23221
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-23 16:47:32 +00:00
Paul Berry 9255de668e Insert implicit downcasts for constructor initializer expressions. 
Change-Id: Ic258db9c353a4a0ab33a96c3847b174937fcf9e5
Reviewed-on: https://dart-review.googlesource.com/23220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-23 16:39:28 +00:00
Kevin Millikin fa1d2c896d Fix order of arguments to Expect.equals in some tests 
Expect.equals (and Expect.listEquals) takes expected first and actual
second.  When these are flipped in tests, the failure message can be super
hard to understand.

Bug:
Change-Id: I1d3c5a31365fa41ee7bcc7781474d76de9184cd5
Reviewed-on: https://dart-review.googlesource.com/23420
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-23 14:45:46 +00:00
Kevin Millikin 16ec97c0bb Update dartdevk test status files again 
Bug:
Change-Id: I836d69b5e142d6fb287597e4829c596f9ed77420
Reviewed-on: https://dart-review.googlesource.com/23340
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-23 11:45:46 +00:00
Dmitry Stefantsov 92d59a67a7 [ddc-kernel] Update status file for dartdevk 
More tests are passing due to 8cdd9d323c

Bug:
Change-Id: Ia871cc46638caa145394f14fd6ec66bf6ea5dbba
Reviewed-on: https://dart-review.googlesource.com/23040
Reviewed-by: Karl Klose <karlklose@google.com>
 2017-11-23 09:21:35 +00:00
Paul Berry 501872471c Insert implicit downcasts for the conditions of do statements. 
Change-Id: I8bfffa0796775434cea767ec9ad13cf5697812d2
Reviewed-on: https://dart-review.googlesource.com/23140
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 21:47:14 +00:00
Emily Fortuna d3eef66367 Add function parameter type checks in checked mode with constructors and loop variables. 
Bug:
Change-Id: Ib3245eb59c9f23b31e4a0b1c65a25f1c2ad3188f
Reviewed-on: https://dart-review.googlesource.com/23143
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-22 19:57:04 +00:00
Paul Berry 245340dd7f Insert implicit downcasts for the conditions of if statements. 
Change-Id: I788d50dc3d95bb4652ff122a993cd092d7262c31
Reviewed-on: https://dart-review.googlesource.com/23160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-22 19:29:24 +00:00
Paul Berry 6786f1944a Insert implicit downcasts for the operands of "not" expressions. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I3d29a1058af5ba43bc2868d85de1e9d87b666ee2
Reviewed-on: https://dart-review.googlesource.com/23080
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 17:55:27 +00:00
Paul Berry 9693e47d89 Insert implicit downcasts for the expressions in a return or yield statement. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: Id570bf354583a3780087ffc820eefc3619573af4
Reviewed-on: https://dart-review.googlesource.com/22842
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 15:33:07 +00:00
Dmitry Stefantsov b277f548bd [ddc-kernel] Update status file for dartdevk due to dartbug.com/31402 
Bug:
Change-Id: I9d77b34b28403ba97c382ae4cacccac783c0a208
Reviewed-on: https://dart-review.googlesource.com/23000
Reviewed-by: Karl Klose <karlklose@google.com>
 2017-11-22 11:49:15 +00:00
Paul Berry d22b6950c1 Insert implicit downcasts for the operands of logical expressions. 
Change-Id: I25a2ca31d09d3577d1d056ca156146472c999c97
Reviewed-on: https://dart-review.googlesource.com/22900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-22 04:49:28 +00:00
Paul Berry 2f93a29176 Create additional tests for implicit downcasts in invocations. 
Change-Id: I0c2f07e93f0910ee6bca1abaedb8be61b1304f38
Reviewed-on: https://dart-review.googlesource.com/22882
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-22 04:49:19 +00:00
Paul Berry ffdae2fd4d Insert implicit downcast checks for the expressions in a map literal. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I40b4b45d5ea32dc34aee68bfe39912141e4d7d35
Reviewed-on: https://dart-review.googlesource.com/22806
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-22 01:18:38 +00:00
Paul Berry 2d00ba15b3 Insert implicit downcast checks for the expressions in a list literal. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I1a4a2eed0f7b8ebb5cab0a993d7cf26e925b9425
Reviewed-on: https://dart-review.googlesource.com/22802
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-22 00:03:56 +00:00
Paul Berry 00bf0d3136 Insert implicit downcast checks for the argument to a combiner in a compound assignment. 
Change-Id: I4827013dc060f530e553b95932db8cbacebc2bfc
Reviewed-on: https://dart-review.googlesource.com/22603
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-21 20:03:31 +00:00
Paul Berry e28d041d45 Add a language_2 test of implicit downcasts in conditional expressions 
Change-Id: I2f346ce2ee1cc8b6d6b61d63750b2ae909fdf456
Reviewed-on: https://dart-review.googlesource.com/22602
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-21 18:45:28 +00:00
Samir Jindel e0e0760fc0 [kernel] Crash nicely in DDK. 
Bug:
Change-Id: I90f8aca8ae394a7795f72ac0c63e1d6cb96ce2ed
Reviewed-on: https://dart-review.googlesource.com/22540
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2017-11-21 15:50:28 +00:00
Karl Klose 367135f436 Update dartdevk status file for tests failing after 8cdd9d323c 
R=dmitryas@google.com

Change-Id: Ie9a81ac15eef49413ccb7d15dc218468852ca537
Reviewed-on: https://dart-review.googlesource.com/22481
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2017-11-21 12:41:48 +00:00
Jens Johansen 194f797a2b Mark constructor13_test/0[12] as MissingCompileTimeError for analyzer 
Bug:
Change-Id: I90c9dad9a8f98fd5495af00c1e427c3ddb86f6d2
Reviewed-on: https://dart-review.googlesource.com/22440
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
 2017-11-21 10:26:07 +00:00
Jens Johansen 9d044e4765 Mark implicit_downcast_during_invocation_test as RuntimeError for dart2js-with-kernel 
Bug:
Change-Id: I125fb491a9a22a90946f320d648c484dcaac6106
Reviewed-on: https://dart-review.googlesource.com/22420
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-11-21 09:43:48 +00:00
Jens Johansen 61565bcecd Mark constructor13_test/0[12] as MissingCompileTimeError on precompiler 
Bug:
Change-Id: Id8ca8248fd5b1a4395edb18eee8b7b17735c0d84
Reviewed-on: https://dart-review.googlesource.com/22380
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-11-21 08:58:47 +00:00
Paul Berry a51c69c9e5 Fix kernel/precomp status files after 8cdd9d323c 
A few status entries weren't updated automatically by scripts.

Change-Id: Ib30f08ca587caa99ef6955cd0b3b52abfceaa765
Reviewed-on: https://dart-review.googlesource.com/22360
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-21 05:44:17 +00:00
Emily Fortuna 9e5ad7af1a Populate field setter method body for checked mode. 
Bug:
Change-Id: I802fc425b998ce1ff1110a7e48215b557035d442
Reviewed-on: https://dart-review.googlesource.com/22300
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-21 01:11:07 +00:00
Bob Nystrom b63f00d674 Move a batch of negative tests into multitests or runtime tests. 
Change-Id: I7358e807da6b3bc8c44d7f9e76ad349b6bd9424e
Reviewed-on: https://dart-review.googlesource.com/19520
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-21 00:50:57 +00:00
Paul Berry 8cdd9d323c Insert implicit downcast checks for invocation arguments. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I1fa7490f6143bd6ceca80f831e0196b16c497966
Reviewed-on: https://dart-review.googlesource.com/20907
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 00:17:37 +00:00
Paul Berry 5f633852af Add a language_2 test for implicit downcasts in variable declarations. 
Change-Id: I8ca6b3446895537c1fde33ae7152c9f29038f05f
Reviewed-on: https://dart-review.googlesource.com/22205
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-20 22:59:27 +00:00
Ryan Macnak f77cf1c60e [vm] Verify canonical objects before taking a snapshot or shutting down. 
Don't verify recursive types.

Bug: https://github.com/dart-lang/sdk/issues/31376
Bug: https://github.com/dart-lang/sdk/issues/27003
Change-Id: I783bcc45d55c78141dccb1b479c1d15234a9b363
Reviewed-on: https://dart-review.googlesource.com/21221
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2017-11-20 18:54:56 +00:00
Paul Berry a2109ee71c Insert implicit downcast checks for conditional expressions. 
Change-Id: If5a2add32129800f14e6da03593ce6cafc173ba5
Reviewed-on: https://dart-review.googlesource.com/22100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-20 15:50:57 +00:00
Kevin Millikin a9a0f10d28 Update precompiled test status file 
A test introduced in https://dart-review.googlesource.com/c/sdk/+/21080
still did not have the correct expectations for the VM precompiler.

The test was marked as crashing except on arm and simarm64, but it does not
crash on x64 except in debug mode.  (I'm not actually sure that it crashes
in all the other configurations that we say it crashes in, but it definitely
does not crash in x64 release or product modes.)

Bug:
Change-Id: I25a8f3cf6cb91cf128cd715d1aaeca2e87d26be4
Reviewed-on: https://dart-review.googlesource.com/22080
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2017-11-20 15:04:07 +00:00
Kevin Millikin d674fa3718 Update test expectations for DDC 
This change to the status files should enable running all combinations of
compilers from {dartdevc, dartdevk} and runtimes from {none, chrome}.

Bug:
Change-Id: I88827496c4bff7ed556cc555ce3a1932f0e829b7
Reviewed-on: https://dart-review.googlesource.com/21642
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2017-11-20 11:37:07 +00:00
Paul Berry f043446962 Insert implicit downcast checks for the RHS of variable declarations. 
Tests that have begun failing due to this change are marked with a
reference to issue #31402.

Change-Id: I5be5fb6f47430d390d53d9f195b6a75ca566f8b9
Reviewed-on: https://dart-review.googlesource.com/21701
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-18 15:35:45 +00:00
Sigmund Cherem 134dd443e5 Renormalize corelib_2 dartk/dartkp sections. 
Normalize the dartk sections in corelib_2.status so that our tools can process
them. Also add some documentation for others.

TBR=paulberry@google.com

Change-Id: I6f67dd0b505a22e4438a30bc7407e4d19ac75912
Reviewed-on: https://dart-review.googlesource.com/21791
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-18 04:17:25 +00:00
Régis Crelier 98befc92a4 Fix vm-precomp and vm-kernel status files. 
Change-Id: Ia8be26091a24dec307e931708a1447b550be8bb2
Reviewed-on: https://dart-review.googlesource.com/21790
Reviewed-by: Régis Crelier <regis@google.com>
 2017-11-18 02:50:46 +00:00
Régis Crelier f91f67a5be [VM] Emit type checks for incoming function arguments in strong mode. 
Change-Id: Icd64913f0fc6ba54a0b8517bf05ae4babfae3bdc
Reviewed-on: https://dart-review.googlesource.com/19287
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-11-18 00:31:35 +00:00
Emily Fortuna e1ba12535a Dart gardening: fix status files as a result of https://dart-review.googlesource.com/c/sdk/+/21080 again. 
Bug:
Change-Id: I7dcc098577c151200dfa17850df6d6f9f6ecb72d
Reviewed-on: https://dart-review.googlesource.com/21782
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-11-17 21:30:41 +00:00