Commit Graph

2317 Commits

Author SHA1 Message Date
Erik Corry 3f299c18ca Small cleanup of dart2js status files on Dart2 tests
R=whesse@google.com

Change-Id: I91163f895723ba0c5c79b6e75bd1c5eb4566ac61
Reviewed-on: https://dart-review.googlesource.com/40000
Reviewed-by: William Hesse <whesse@google.com>
2018-02-09 01:02:36 +00:00
Mike Fairhurst ef421661dc Fix status files and ref #32100 for staticwarning/compiletimeerror weirdness
Change-Id: I991ffffa37b21cffc5f14528a303e86b14a393ba
Reviewed-on: https://dart-review.googlesource.com/40106
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-09 00:04:52 +00:00
Mike Fairhurst 56d59dd967 Reland https://dart-review.googlesource.com/c/sdk/+/37441 with fixes
Change-Id: If8e2ec2ca1ac4f533dcb56b0c95d55e4a13e0598
Reviewed-on: https://dart-review.googlesource.com/39881
Reviewed-by: Paul Berry <paulberry@google.com>
2018-02-08 20:46:19 +00:00
Dan Rubel d4f2f9cef2 Update fasta parser to report constructor initializer errors
This CL updates the fasta parser to report three additional
errors in constructor initializers:

* ExpectedAnInitializer
* MissingAssignmentInInitializer
* RedirectingConstructorWithBody

I also added a comment from a discussion about
https://dart-review.googlesource.com/c/sdk/+/39320

Change-Id: Iecb6fe97e3612a11ccc89864a4fc9f353846504c
Reviewed-on: https://dart-review.googlesource.com/40040
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-08 18:08:40 +00:00
William Hesse be2e6c4f82 Update status for new dartk and dartkp builders
Change-Id: Ie5ed3cade049d1d7831440adece520dd09ad13d7
Reviewed-on: https://dart-review.googlesource.com/39985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-02-08 16:52:56 +00:00
Johnni Winther df4453bbb4 Update dart2js_with_kernel status
Change-Id: I08b8cf15ffb034958729b5c07561e9eec98aba0f
Reviewed-on: https://dart-review.googlesource.com/39961
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-02-08 10:51:37 +00:00
Stephen Adams 2868ded182 Update dart2js status
Main problem - there were dart2js entries outside the dart2js file.

TBR=sigmund@google.com

Change-Id: If86bd49bcd6dd0d5b4c9951053775de4e39508e5
Reviewed-on: https://dart-review.googlesource.com/39901
Reviewed-by: Stephen Adams <sra@google.com>
2018-02-08 06:51:09 +00:00
Régis Crelier e64f37614e [VM runtime] Fix TypeArguments::IsUninstantiatedIdentity() not to return true
for a still unfinalized type argument vector (fixes #31944).
Update status files.

Change-Id: Ib603cd702891dc93775a5fbd09c341bb36922ab3
Reviewed-on: https://dart-review.googlesource.com/39855
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-02-08 02:03:24 +00:00
Stephen Adams 92af8a938a Use length argument only for allocating Array
Change-Id: I051ec7bf3e34162e55212c6f734ceb0d531d04bb
Reviewed-on: https://dart-review.googlesource.com/39853
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2018-02-08 00:41:59 +00:00
Emily Fortuna a87bd928ff Fix test status for async test in strong mode. For some reason this got missed.
Change-Id: Idb204b42bf6b344371e5e143a8275481c2851343
Reviewed-on: https://dart-review.googlesource.com/39854
Reviewed-by: Emily Fortuna <efortuna@google.com>
2018-02-08 00:37:45 +00:00
Emily Fortuna ef3c271542 Generate signature function in strong mode (previously was behind a flag).
Change-Id: Ia99623beb4f5cbba719833af2d710702d2caaa6d
Reviewed-on: https://dart-review.googlesource.com/38902
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-02-07 23:02:40 +00:00
Mike Fairhurst ec58f5646a Revert "Make void a static warning to use almost everywhere."
This reverts commit 09eed74a8a.

Reason for revert: Too much SDK code is not yet compliant.

Original change's description:
> Make `void` a static warning to use almost everywhere.
> 
> Changed the hint to a StaticWarningCode, since that's the new spec'd
> error type and the hint is no longer needed.
> 
> Added a new set of methods to test the cases.
> 
> Didn't try to solve the problem generally ("all usages except ... are
> errors" means it easier, in theory, to make a ReportVoidExpressions
> style visitor that catches absolutely all types) because most of the
> work is actually about suppressing errors that are no longer needed.
> Ie, from NO_SUCH_METHOD to USAGE_OF_VOID_RESULT which means we have to
> put the void handling logic into each AST method specially anyway.
> 
> Some redundant tests removed.
> 
> Don't flag: ternaries, void -> void assignments, void returns in
> dynamic.
> 
> Change-Id: Ief8035dcfe582b36b6372180ddcf4e453d320d9c
> Reviewed-on: https://dart-review.googlesource.com/37441
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=leafp@google.com,scheglov@google.com,mfairhurst@google.com

Change-Id: I13ee4c6939468d35506779ade637a040833632f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39848
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
2018-02-07 22:32:51 +00:00
Mike Fairhurst 09eed74a8a Make void a static warning to use almost everywhere.
Changed the hint to a StaticWarningCode, since that's the new spec'd
error type and the hint is no longer needed.

Added a new set of methods to test the cases.

Didn't try to solve the problem generally ("all usages except ... are
errors" means it easier, in theory, to make a ReportVoidExpressions
style visitor that catches absolutely all types) because most of the
work is actually about suppressing errors that are no longer needed.
Ie, from NO_SUCH_METHOD to USAGE_OF_VOID_RESULT which means we have to
put the void handling logic into each AST method specially anyway.

Some redundant tests removed.

Don't flag: ternaries, void -> void assignments, void returns in
dynamic.

Change-Id: Ief8035dcfe582b36b6372180ddcf4e453d320d9c
Reviewed-on: https://dart-review.googlesource.com/37441
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-07 21:36:01 +00:00
Alexander Markov c81f76ce64 [Gardening] Update test status after fix
This is the follow-up to 32396138ff
which fixed crash in ClassHierarchy due to ambiguous supertypes.

Change-Id: I53e664574011e5fe67139326ae22aaa90724ea81
Reviewed-on: https://dart-review.googlesource.com/39842
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-02-07 21:13:39 +00:00
Ben Konyi 6338914d31 - Removed dead code (pulled from review 36121)
- Enabled incremental compiler in the dart frontend for the command-line VM
- Added method to update in-memory file system with in-memory sources provided by tests

Change-Id: Ica26b7235383185dbb6b4b41064193d432dfcba0
Reviewed-on: https://dart-review.googlesource.com/36126
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-02-07 19:35:39 +00:00
Brian Wilkerson 217110c2db Use TypedLiteralNode.isConst in more places and fix a bug to improve the optional new/const support
Change-Id: I2839b0c269796fedb7a3e7340388bb3576ac6b59
Reviewed-on: https://dart-review.googlesource.com/39424
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
2018-02-07 17:00:51 +00:00
William Hesse 2f9caa23c7 Update status for dart2js-with-kernel
Bug: https://github.com/dart-lang/sdk/issues/32078
Change-Id: If167667e16db1dd200aed649ac43071404d4feb9
TBR=johnniwinther@google.com
Reviewed-on: https://dart-review.googlesource.com/39780
Reviewed-by: William Hesse <whesse@google.com>
2018-02-07 16:03:35 +00:00
Peter von der Ahé 8815bbe90e Update status files for $compiler == fasta
Change-Id: I09761d12b98864d9a9abcc7abe6f046e45951715
Reviewed-on: https://dart-review.googlesource.com/36642
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-02-07 15:38:09 +00:00
Aske Simon Christensen da3bbd7d0f Fix crash when referring to type variables on local functions.
Closes https://github.com/dart-lang/sdk/issues/32012

Change-Id: I5d7861e1cc34a98972c1feb766702bbca58b325c
Reviewed-on: https://dart-review.googlesource.com/39160
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2018-02-07 13:49:32 +00:00
Paul Berry d9d2dc405b Infer mixin types in the analyzer.
This follows Leaf's simplified suggestion.  As a temporary hack it
assumes that the mixin passes its type parameters through to its
superclass constraint unchanged.

Change-Id: I091b44005d6364a91e20578f2ff6340334b1fab6
Reviewed-on: https://dart-review.googlesource.com/38040
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-02-07 10:45:39 +00:00
Lasse R.H. Nielsen 6f78471687 New methods on Iterable, List, Set, Queue, Map.
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: I7a12fea533d42b0fc8357086649df38ad01f3cdd
Reviewed-on: https://dart-review.googlesource.com/39140
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-07 06:12:53 +00:00
Régis Crelier 9a36711149 [Kernel] Insert argument type check in implicit setters (fixes #32065).
Update status file.

Change-Id: I4c7e1b5352ba40e1f571bd3e8eb6f8d7623a1e80
Reviewed-on: https://dart-review.googlesource.com/39422
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2018-02-07 01:35:24 +00:00
Brian Wilkerson 8a61901a4a More status file changes to get the bots green
Change-Id: I02c2234f22fa91661d71e9aa2e2f86fc2fb28a80
Reviewed-on: https://dart-review.googlesource.com/39361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-06 22:11:54 +00:00
Dan Rubel b2c5415db9 Rework parseClassMember to remove findMemberName
This CL finishes the process of removing findMemberName from parsing
class members and sets the stage for improved recovery.
In addition, this CL:

* Revises the `endMethod` event to include a beforeParam token
    so that the parser can revise the token stream before the parameters
    during recovery.

* Reworks insertSyntheticIdentifer for use in more places

Change-Id: If5bcd6f554053f72429e938b5cd5e7021e03d5b3
Reviewed-on: https://dart-review.googlesource.com/39320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-02-06 21:01:53 +00:00
Brian Wilkerson b7f61f5801 Fix some of the optional new and const tests
Change-Id: Idcdadb0b26c2fc187a90dd60f11b634a84c12b9f
Reviewed-on: https://dart-review.googlesource.com/38920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-06 18:04:33 +00:00
Brian Wilkerson a0cfe5aa65 Fix more issues related to optional new and const
Change-Id: I0c1302c9b0505694853175f2b756c134e0caba19
Reviewed-on: https://dart-review.googlesource.com/38900
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
2018-02-06 16:10:53 +00:00
William Hesse 9c35cff5cd Revert "New methods on Iterable, List, Set, Queue, Map."
This reverts commit 0b59f24f97.

Reason for revert: Creates crashes in dart2js with kernel, see
https://luci-milo.appspot.com/buildbot/client.dart/dart2js-linux-d8-minified-1-5-be/9751

Original change's description:
> New methods on Iterable, List, Set, Queue, Map.
> Changes signature of Iterable.singleWhere.
> Makes LinkedHashMap no longer be a HashMap.
> 
> Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
> Reviewed-on: https://dart-review.googlesource.com/32541
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=lrn@google.com,leafp@google.com

Change-Id: Iab904f5885a5213ae2e16ef496eed0b6843185f3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/39060
Reviewed-by: William Hesse <whesse@google.com>
2018-02-06 13:32:19 +00:00
Lasse R.H. Nielsen 0b59f24f97 New methods on Iterable, List, Set, Queue, Map.
Changes signature of Iterable.singleWhere.
Makes LinkedHashMap no longer be a HashMap.

Change-Id: Ibd7e56e1ac03cb9fb10d19d1328d452fcd06d89f
Reviewed-on: https://dart-review.googlesource.com/32541
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-06 11:17:46 +00:00
pq e1f4a9a533 Analyzer status updates (in quest for greenness) [TBR].
This should get us at least part of the way back to green.

(nosuchmethod_forwarding_test next)


Change-Id: I21e98dd6739b6d9f4d94373a647451d05e637840
Reviewed-on: https://dart-review.googlesource.com/38860
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2018-02-05 21:25:34 +00:00
Brian Wilkerson 6b23aec701 Correctly resolve constructors in generic classes
Change-Id: I88a30b151b3177d6ae628c50bb51aceb48a70e7a
Reviewed-on: https://dart-review.googlesource.com/38780
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-05 19:19:37 +00:00
Brian Wilkerson 27c4418f2d Generate an error when the first argument of an assert is a function
Change-Id: Ie6eaddaab827936a1127275b325dc6d4a3357e24
Reviewed-on: https://dart-review.googlesource.com/31963
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-02-05 16:53:26 +00:00
Erik Ernst aa53767a0c Simplified sectioning of status entry for issue23244_test
Change-Id: I884b86056a2a59e82995e51910ef6f41047085d6
Reviewed-on: https://dart-review.googlesource.com/38700
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2018-02-05 15:50:16 +00:00
Brian Wilkerson e8a43ecd56 Make ConstantAstCloner insert a const keyword where one is implied
Change-Id: I9056d408c3d58ff684534553e544a249ceb68591
Reviewed-on: https://dart-review.googlesource.com/38400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-05 13:36:48 +00:00
Erik Ernst 261062e8d0 Gardening: Adjusted dart2js status for language_2/issue23244_test
Now indicates that the test incurs a dynamic error.

Change-Id: I9428af2d75fd99b166593c6390525ee1cb094f58
Reviewed-on: https://dart-review.googlesource.com/38581
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2018-02-05 12:48:02 +00:00
Vijay Menon b071229ff5 Fix DDC status
Change-Id: I84fae8d6c7f5333b7ecc9c6bd20496941532ff5d
Reviewed-on: https://dart-review.googlesource.com/38442
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-02-03 23:39:42 +00:00
Sigmund Cherem f1663c8241 Fix status of dart2js strong tests
TBR=floitsch@google.com

Change-Id: Ia84faf0b0666d8a8bb0c44ecbf09bbcd6f417e4f
Reviewed-on: https://dart-review.googlesource.com/38344
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-02-02 22:18:59 +00:00
Sigmund Cherem f541f060ee [fe] deferred access checks for several access patterns of classes.
This adds checks for allocations and type values, and provides a compile
time error for type declarations, is-checks, and as-casts.

Change-Id: I3bfed41b0dd45abeb02158f0537102c779511998
Reviewed-on: https://dart-review.googlesource.com/36383
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-02-02 20:44:16 +00:00
Jenny Messerly 85cfbebd76 Fix constKeyword usage in DDC in preparation for implicit new/const
Change-Id: Iad3d38449dbe5bbb71d470cf085c2c071432abf5
Reviewed-on: https://dart-review.googlesource.com/38147
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-02 20:33:46 +00:00
Florian Loitsch 3b8e4d41a7 Reapply "Run async functions immediately."
Which was reverted in commit 032be73dbe.
Originally commited in commit 67bac0bce6.
Original review URL: https://dart-review.googlesource.com/5263

Change-Id: Ic7333c29e502a3924dc6aade8ffa46fc8aa5b04a
Reviewed-on: https://dart-review.googlesource.com/38120
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-02 15:50:16 +00:00
Florian Loitsch 7bd76a466a Update status files.
Change-Id: I83ee3e48b8923aa5ae9497e8d1042ada7f3678c8
Reviewed-on: https://dart-review.googlesource.com/38240
Reviewed-by: Florian Loitsch <floitsch@google.com>
2018-02-02 14:42:28 +00:00
Florian Loitsch d858eea600 Update status files.
Change-Id: I85e9f25c5d87b7cf87ed848f4a71919ab07f5790
Reviewed-on: https://dart-review.googlesource.com/37762
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
2018-02-02 11:55:02 +00:00
Florian Loitsch 5ec65552d5 Update status files.
Change-Id: I3c569645ebac013ac2d72b9d9da0eeb6f2609fcd
Reviewed-on: https://dart-review.googlesource.com/38200
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
2018-02-02 09:46:12 +00:00
Sigmund Cherem 5428a12b84 Ensure that env includes the actual mixin application fields and procedures.
From the docs of mixedInClass and mixin: the former is the direct thing that is
mixed in, but if it is a named mixin application it may not contain the actual
fields and procedures, instead the `.mixin` class does.

Change-Id: I049ced771925431d613b0b661154c1761fbe0a51
Reviewed-on: https://dart-review.googlesource.com/38161
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2018-02-02 07:10:30 +00:00
Florian Loitsch 032be73dbe Revert "Run async functions immediately."
This reverts commit 67bac0bce6.

Reason for revert: broke the bot.

Original change's description:
> Run async functions immediately.
> 
> Migrated from https://codereview.chromium.org/2478703003/
> 
> Change-Id: I1d678c01ba5876490b12c676c500171328361d31
> Reviewed-on: https://dart-review.googlesource.com/5263
> Commit-Queue: Florian Loitsch <floitsch@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

TBR=whesse@google.com,rnystrom@google.com,vegorov@google.com,kustermann@google.com,zra@google.com,floitsch@google.com,jmesserly@google.com,vsm@google.com,regis@google.com,sigmund@google.com

Change-Id: I20c948057423c3fa5aa8c72843f8f2a17e086ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/37981
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-01 15:01:21 +00:00
Aske Simon Christensen caabeaa618 Add type variables to scope before their bounds are resolved.
Closes https://github.com/dart-lang/sdk/issues/31766

Change-Id: I9be63fa04a083a5a7aaedb21829c77287d61b615
Reviewed-on: https://dart-review.googlesource.com/37742
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2018-02-01 14:49:47 +00:00
Florian Loitsch 67bac0bce6 Run async functions immediately.
Migrated from https://codereview.chromium.org/2478703003/

Change-Id: I1d678c01ba5876490b12c676c500171328361d31
Reviewed-on: https://dart-review.googlesource.com/5263
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-02-01 14:08:57 +00:00
William Hesse a42135073d Update status for generic_test on dart2js and analyzer
TBR=jmesserly@google.com

Change-Id: I81879562e200f882ad4d2057a27a7336195e6a39
Reviewed-on: https://dart-review.googlesource.com/37663
Reviewed-by: William Hesse <whesse@google.com>
2018-02-01 10:53:02 +00:00
Erik Corry 209959fe97 Fix status files to refer to correct deferred loading bug
R=kmillikin@google.com

Bug: 30273
Change-Id: Ib6e0ecf0d68d575680cb45a9208ea93cd94551b8
Reviewed-on: https://dart-review.googlesource.com/37823
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-02-01 09:54:35 +00:00
Jenny Messerly 8489a843db fix generic_test and generics_test for Dart 2
Change-Id: I831b5b0b6ade4cb099447e6a09058eb5c6745afa
Reviewed-on: https://dart-review.googlesource.com/36562
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-02-01 02:15:25 +00:00
Jenny Messerly 68ea5433fd implement assert initializers for DDC, fixes #27809
also fixes #31058, DDC failed to execute all field initializers
(already fixed this in DDK when porting code_generator).

also fixes assertion_initializer_test, it was not strong mode clean, so
it was not giving any meaningful results for runtime behavior.

Change-Id: I290b266ad77ed92851cc2d0617690c6c021182a3
Reviewed-on: https://dart-review.googlesource.com/37866
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
2018-02-01 01:12:17 +00:00