cadc4c33ca
[vm/compiler] Improved integer power specialized inlining.
...
Rationale:
"Inlines" special cases of int pow() in strong mode
(viz. x^y for either small constant x or y).
https://github.com/dart-lang/sdk/issues/33861
Change-Id: I2e52784f82e39bb0ce33733aef70cbc56f27e451
Reviewed-on: https://dart-review.googlesource.com/65576
Commit-Queue: Aart Bik <ajcbik@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-07-20 20:14:28 +00:00
b1eeacc30a
Remove usage of unittest package from a number of tests.
...
Add simplified unittest replacement to package:expect.
(It is used in multi-tests, so it needs to be in an accessible place without using ".." in its path).
Change-Id: I60aa212ed67ffbdda17ca18fce1cdff16237f4fe
Reviewed-on: https://dart-review.googlesource.com/65700
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Jenny Messerly <jmesserly@google.com >
2018-07-20 13:26:38 +00:00
660ea995ad
Update analyzer status file
...
Change-Id: I0ebe05e0f47e39d0cc322397231df3e6bee347b4
Reviewed-on: https://dart-review.googlesource.com/65860
Reviewed-by: Dan Rubel <danrubel@google.com >
2018-07-20 00:51:59 +00:00
11001793a2
Check void usage and invalid returns
...
Closes https://github.com/dart-lang/sdk/issues/30470
Change-Id: I2ed5b54c74e0bba2771036774bbe2197ce29109d
Reviewed-on: https://dart-review.googlesource.com/65141
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2018-07-18 10:18:52 +00:00
7d1f3b358a
[fasta] Update test status after the fixes for #32613
...
Change-Id: Idd473d5105237bcb57c2c051e3a1903c041ec323
Reviewed-on: https://dart-review.googlesource.com/65323
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-07-18 10:00:08 +00:00
c6f525634f
Normalize status files
...
Change-Id: I2668ec23b5fe83623acefcf53110499ecf30dcb9
Reviewed-on: https://dart-review.googlesource.com/65502
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2018-07-18 09:54:33 +00:00
d0510501d2
[build] Add -a kbc for interpreter
...
This CL adds support to build.py and test.py for building/testing
a VM with the interpreter on x64, e.g.:
$ ./tools/gn.py -m release -a x64 --bytecode
$ ./tools/build.py -m release -a x64 --bytecode runtime
$ ./tools/test.py -m release -a x64 -r vm -c dartkb language_2
Change-Id: I956d23790636609d4a2e71129481fcbd7afef9a0
Reviewed-on: https://dart-review.googlesource.com/65206
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Régis Crelier <regis@google.com >
Reviewed-by: Alexander Markov <alexmarkov@google.com >
2018-07-17 21:51:41 +00:00
cc1a7b35d0
Update SDK wrt to void and invalid returns
...
Change-Id: Ia1a6b056351beb9faddc2c6e86280983a2395d45
Reviewed-on: https://dart-review.googlesource.com/65140
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-07-17 13:37:47 +00:00
c137fe2fbe
Update tests related to generalized void
...
Change-Id: Iac43d86759e0ae958940bbfd2ce53286762b7207
Reviewed-on: https://dart-review.googlesource.com/64381
Reviewed-by: Peter von der Ahé <ahe@google.com >
Commit-Queue: Peter von der Ahé <ahe@google.com >
2018-07-17 10:25:25 +00:00
31bed29d6e
[fasta] Correct override check for methods with covariant parameters
...
Bug: #32613
Change-Id: Id69e793afd2c933294299d796a28b66db6b5de17
Reviewed-on: https://dart-review.googlesource.com/64840
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-07-16 15:00:05 +00:00
48a258a4a5
[Fasta] Additional override checks
...
Checks override on fields and for methods with type parameters.
Bug: 32613
Change-Id: Ia32d1080959bc706fd72a075fb6ba724fa93fd58
Reviewed-on: https://dart-review.googlesource.com/64542
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2018-07-16 15:00:05 +00:00
7d6cd21706
CFE and member conflict rules
...
See https://github.com/dart-lang/sdk/issues/32613
and https://github.com/dart-lang/sdk/issues/33235#issue-326617285
Bug: #32613 , #33235 , #33237
Change-Id: I0d1432185b6811137e31135ac2c7f58c4de2de6c
Reviewed-on: https://dart-review.googlesource.com/64500
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Reviewed-by: Erik Ernst <eernst@google.com >
2018-07-16 14:09:01 +00:00
af27e106ee
Update safari .status lines for flaky tests
...
TBR=johnniwinther@google.com
Change-Id: I28e27ccbd71094e4127343cfb84651b5de59de10
Reviewed-on: https://dart-review.googlesource.com/64804
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-07-12 21:58:19 +00:00
d34c8b6650
Add some invalid tests as expected to fail.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: If12c90ab5f31a2d84e9ff62c98104308c679dec7
Reviewed-on: https://dart-review.googlesource.com/64801
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-07-12 21:01:38 +00:00
b0600a2d4b
Report inference err for C<<T>()> for some C and some function with params
...
Fix #33661
Bug: 33343
Change-Id: I8478a6f0ba3f3d57bcdb3415aa5c9b9a485e4ff2
Reviewed-on: https://dart-review.googlesource.com/64644
Reviewed-by: Jenny Messerly <jmesserly@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-07-12 19:37:11 +00:00
52f359ca83
[Gardening] Update status files for target-arm64 builder
...
This builder runs still in --checked mode and has different outcomes.
Change-Id: Iac869ab77c627124334f518fcc2dc7b6c5ee48c2
Reviewed-on: https://dart-review.googlesource.com/64681
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-07-12 09:47:14 +00:00
6b01ba7112
Update status for vm --checked (enable asserts) tests.
...
Remove accidental legacy test section from front_end bots.
Remove no-op --strong arg from test matrix.
Change-Id: Icafc7eeb3c25f5816596affeaf8f75a7328fb907
Reviewed-on: https://dart-review.googlesource.com/64520
Reviewed-by: Jonas Termansen <sortie@google.com >
2018-07-12 09:31:10 +00:00
30d0785be2
Update Firefox status for Dart 2
...
Cq-Include-Trybots: luci.dart.try: dart2js-strong-linux-x64-ff-try, dart2js-strong-win-x64-ff-try
Change-Id: I9e04c74fc44976488cacad5b73036c0c8487462e
Reviewed-on: https://dart-review.googlesource.com/64543
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2018-07-12 08:58:47 +00:00
f601b9cd45
fix #33287 , error in dartdevc if an int cannot be represented in JS
...
Also fixes #32585 , Analyzer's int64 validation was rejecting integers
that are accepted by CFE/VM/int.parse.
Refactors DDC to allow us to emit errors from the CodeGenerator
(previously unsupported).
Change-Id: Ifd24ab90848cc42b226961e375167c557299c0b7
Reviewed-on: https://dart-review.googlesource.com/63023
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-07-12 00:47:01 +00:00
85e35a74cf
[gardening] Update flaky test status
...
Test language_2/symbol_conflict_test sometimes times out on
vm-kernel-reload-rollback bots in release mode, so marking it as
'Pass, Slow'.
Change-Id: I0018b68217310dbb1ca491ef988bc03add454547
Reviewed-on: https://dart-review.googlesource.com/64662
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-07-11 23:07:05 +00:00
7952cf0b8d
[vm] In the reload stress test, reload from the script uri instead of the root library's uri, which are different when not running from source.
...
Assumes the embedder has properly set the script URI hook, which is true of the standalone embedder that we run the reload stress tests on.
Bug: https://github.com/dart-lang/sdk/issues/33291
Bug: https://github.com/dart-lang/sdk/issues/32134
Change-Id: I18ec87081b584e47cde84590ebf6670bee6d5fdb
Reviewed-on: https://dart-review.googlesource.com/64181
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2018-07-11 22:35:43 +00:00
cd11ca1591
[gardening] Update status for flaky tests
...
Change-Id: I6fbf812c1c44c1e70e0de9007126501b5cccefb2
Reviewed-on: https://dart-review.googlesource.com/64645
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-07-11 20:20:03 +00:00
63b0bf3478
Re-add accidentally removed status file entries during merge
...
Change-Id: I2b578a256306552d93f5a4fc9bd9effcc5360be5
Reviewed-on: https://dart-review.googlesource.com/64260
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2018-07-10 00:00:36 +00:00
21258299d7
Reland "Fix #32227 export dynamic from dart:core in analyzer."
...
This reverts commit d3b4ba3a0b#32227 export dynamic from dart:core in analyzer."
>
> This CL caused a breakage in angular code generation.
>
> This reverts commit 6f965a94e2https://dart-review.googlesource.com/63680
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Paul Berry <paulberry@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com ,mfairhurst@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: If0a03148db5e88724f3498a1fa2d46a9c42d7f1f
Reviewed-on: https://dart-review.googlesource.com/64120
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2018-07-09 22:30:49 +00:00
4aacaeb684
[vm/compiler] Fix handling of exception-throwing instructions in DSE
...
Fixes https://github.com/dart-lang/sdk/issues/33794
Change-Id: Icf87eb79d5afd15112079964aaba5d0ed41e2476
Reviewed-on: https://dart-review.googlesource.com/64182
Commit-Queue: Alexander Markov <alexmarkov@google.com >
Reviewed-by: Aart Bik <ajcbik@google.com >
2018-07-09 21:28:55 +00:00
4ff4620f68
Adjust status lines for safari (take 2)
...
Change-Id: I231d449097dc01824e2f05443ce2a63d86b946b4
Reviewed-on: https://dart-review.googlesource.com/64100
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-07-09 21:11:55 +00:00
1c673b1046
Include bounds in type literals
...
Change-Id: Ieb3e5b09e88c98f8943a6e7ca9031c8a6ab776e1
Reviewed-on: https://dart-review.googlesource.com/63820
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-07-09 12:24:04 +00:00
3a1b09dc63
Fix for bug #33660
...
Fix for #33660 that doesn't try to use fewer temporaries.
This fix could be revisited and possibly improved later.
Bug: #33660
Change-Id: I966d2756d74e9f041d043e839487bee8a3cc5aa2
Reviewed-on: https://dart-review.googlesource.com/63823
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-07-09 12:20:54 +00:00
810cdf8649
Add tests for bug #33660
...
Change-Id: I46ddc241ff4b9f33380f80ca641b27089ccbd736
Reviewed-on: https://dart-review.googlesource.com/63821
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
2018-07-09 11:38:17 +00:00
6dfc4ef663
Remove old dart2analyzer not strong status file entries.
...
Change-Id: I8e7775ce9a3d6fd14ee9d1b9d79be2f6df23cd01
Reviewed-on: https://dart-review.googlesource.com/63801
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-07-07 04:14:20 +00:00
32d208d8b0
Revert "Adjust status lines for safari"
...
This reverts commit 5da24bbec2TBR=athom@google.com ,johnniwinther@google.com
>
> Change-Id: I020de6d0f543fe96d8f93fa3a810b649ce587046
> Reviewed-on: https://dart-review.googlesource.com/63705
> Commit-Queue: Sigmund Cherem <sigmund@google.com >
> Reviewed-by: Sigmund Cherem <sigmund@google.com >
TBR=athom@google.com ,johnniwinther@google.com ,sigmund@google.com
Change-Id: I4a106337fc8490bd0d60cc535475e360726afdd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/64000
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-07-07 02:07:28 +00:00
5da24bbec2
Adjust status lines for safari
...
TBR=athom@google.com ,johnniwinther@google.com
Change-Id: I020de6d0f543fe96d8f93fa3a810b649ce587046
Reviewed-on: https://dart-review.googlesource.com/63705
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-07-07 00:57:29 +00:00
f5a3af4fcd
[VM] A const bool.fromEnvironment() with an explicit defaultValue of null should default to null
...
Closes https://github.com/dart-lang/sdk/issues/33628
Change-Id: I89ab411df0e113776364485ec9e2b6f7177dc024
Reviewed-on: https://dart-review.googlesource.com/63947
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Martin Kustermann <kustermann@google.com >
2018-07-06 16:26:06 +00:00
1a08800dd6
Run analyzer --use-fasta-parser on the language2 tests; update status file.
...
Change-Id: I35ca9dceb211a30f7e211177956e3e62575f7e57
Reviewed-on: https://dart-review.googlesource.com/63686
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-07-06 14:20:26 +00:00
11123b774a
Adjust status lines for firefox
...
TBR=johnniwinther@google.com ,athom@google.com
Change-Id: Idf7d90da1e649e0d73df92f952e2384b4b0ebb58
Reviewed-on: https://dart-review.googlesource.com/63694
Commit-Queue: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-07-04 00:34:26 +00:00
d50fa68176
Update strong status in host-checked mode
...
TBR=sra@google.com
Change-Id: I09a98a414da3356158efdb5d24d67128cfdf7f88
Reviewed-on: https://dart-review.googlesource.com/63690
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-07-03 21:46:06 +00:00
45eee81252
Check another case of StaticWarningCode.TYPE_PARAMETER_REFERENCED_BY_STATIC.
...
The analyzer was missing cases where the reference to the type
parameter was in an ordinary SimpleIdentifier, not part of a TypeName.
Fixes #21565 .
Change-Id: I6be21b296c8c60777238c89a4e5e15a8c0ca8a6e
Reviewed-on: https://dart-review.googlesource.com/63660
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-03 19:58:31 +00:00
d3b4ba3a0b
Revert "Fix #32227 export dynamic from dart:core in analyzer."
...
This CL caused a breakage in angular code generation.
This reverts commit 6f965a94e2https://dart-review.googlesource.com/63680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2018-07-03 19:50:26 +00:00
b7b24e9bbe
Update dart2js-strong status across several suites
...
Change-Id: I7550e3221bcfdb4f9281b2be96af8579848c5a69
Reviewed-on: https://dart-review.googlesource.com/63504
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Sigmund Cherem <sigmund@google.com >
2018-07-03 00:27:31 +00:00
69db5c104a
Check local constants
...
Closes #33707
Change-Id: I8046b45aac8eeef60dca405a47a573724af8bfe8
Reviewed-on: https://dart-review.googlesource.com/63280
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-06-29 22:30:39 +00:00
6f965a94e2
Fix #32227 export dynamic from dart:core in analyzer.
...
Assign dynamic to dart:core in NamespaceBuilder & LibraryScope
This seems to be the best two places to hit up all cases. We need two to
handle the case of where code imports dart:core, vs code that is itself
the definition of dart:core.
Includes a member sort of compile_time_error_code_kernel_test, so that
pollutes the diff a bit, but not importantly so and its good to get that
sorted.
Bug: 32227
Change-Id: Ibe620f4b66a35d088355f36da042a5d82380772c
Reviewed-on: https://dart-review.googlesource.com/62730
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-29 19:24:41 +00:00
43c8d18154
fix #27477 , compile time constants cannot use type params in Dart 2
...
This reverts the strong mode experimental behavior. Also this restores the
errors that we need to issue for incorrectly using type parameters from
static contexts (#27477 ).
Change-Id: Ibe0bb68d400f75e1a9209a310f4d32fee4be7069
Reviewed-on: https://dart-review.googlesource.com/62724
Commit-Queue: Jenny Messerly <jmesserly@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-28 22:03:29 +00:00
74ba5c3705
Remove the analyzer & fasta section from the status file.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I9da274247503fd9b12b66382836ec38b90a0dac5
Reviewed-on: https://dart-review.googlesource.com/62889
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-28 21:52:18 +00:00
d9911b8a8a
Add language_2 test status entries for -cdart2analyzer --use-cfe
...
Some of these tests are flaky. The tests can be run locally with
tools/test.py -mrelease -cdart2analyzer --use-cfe language_2
Some test status entries come from language_2_kernel.status which has
shared entries for all $fasta configurations. These are mostly
missing compile-time errors.
Change-Id: I628cb5124000b027a3466526e2ea393c9d2830a3
Reviewed-on: https://dart-review.googlesource.com/62803
Commit-Queue: Kevin Millikin <kmillikin@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Aske Simon Christensen <askesc@google.com >
2018-06-28 12:53:03 +00:00
90e27b19ea
Check for conflicts between a static setter and a constructor or static method.
...
Bug: https://github.com/dart-lang/sdk/issues/33237
Change-Id: I44c69f32039de9b024c942706e96bf1998217350
Reviewed-on: https://dart-review.googlesource.com/60583
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Kevin Millikin <kmillikin@google.com >
2018-06-28 11:47:33 +00:00
bd9aa5139a
Error on cyclic constructor redirect.
...
Fixes https://github.com/dart-lang/sdk/issues/30856
Change-Id: Ib0cb851904fdcb12fff11bae92fe177739fe793f
Reviewed-on: https://dart-review.googlesource.com/60429
Commit-Queue: Aske Simon Christensen <askesc@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2018-06-28 10:37:23 +00:00
bef0eca2e3
[gardening] Update status after a7f0f7ea89
...
This is a follow-up status file update for app_jitk configurations
after https://github.com/dart-lang/sdk/commit/a7f0f7ea899fe7812f54eea8f957a92153e3176e
Change-Id: I749cb99eb112a7b1c568d9c2ff0f2191a69cc0e2
Reviewed-on: https://dart-review.googlesource.com/62661
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-06-27 18:24:16 +00:00
a7f0f7ea89
[vm] Add source positions to stack traces of bool checks
...
If a condition has a source position in kernel, this source position is
now used in stack traces for bool checks.
Issue: https://github.com/dart-lang/sdk/issues/33584
Change-Id: Idb833abbaeaa32e6c5deb0d383cc4215642d3f2a
Reviewed-on: https://dart-review.googlesource.com/62360
Reviewed-by: Samir Jindel <sjindel@google.com >
Commit-Queue: Alexander Markov <alexmarkov@google.com >
2018-06-27 16:54:39 +00:00
7d1642e081
[gardening] Mark large_class_declaration_test Slow.
...
This is follow-up to https://dart.googlesource.com/sdk/+/008aa729c53eec41a949d61e3d9f225dc5cb9254 .
Change-Id: I70a05011b6b6287c0be9b879fb581511e9141287
Reviewed-on: https://dart-review.googlesource.com/62621
Reviewed-by: Régis Crelier <regis@google.com >
Commit-Queue: Alexander Aprelev <aam@google.com >
2018-06-27 16:18:47 +00:00
46167dfd88
It is OK to declare a const constructor in a class with a mixin, if it has no fields.
...
R=brianwilkerson@google.com
Change-Id: I76c427fe24b8f06711c3adcac8bacd45900240b1
Reviewed-on: https://dart-review.googlesource.com/62482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-06-27 14:23:59 +00:00
Aart Bik