dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

2317 Commits

Author SHA1 Message Date
Mark Zhou 3cf7d6a9c7 [tests] Changing expected cast errors to type errors for collections tests 
Change-Id: I0e48dba7b1612994075629c43331794bfb2d2530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96421
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
 2019-03-11 21:56:41 +00:00
Dmitry Stefantsov 1ce3e8af71 Reland "[cfe] Handle spread map entries of static type Null" 
This is a reland of ccd2c85a1a

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

Change-Id: I4519970d8259481e137424f3506b7fb97307b14a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96134
Reviewed-by: Régis Crelier <regis@google.com>
 2019-03-08 19:05:19 +00:00
Nicholas Shahan d2d098405f [tests] Fix some control flow collections tests 
- Remove tests that expect ForElements in const collections.
- Add missing value (or was it the key) in map.

Change-Id: Ic61cbb4326a105618ae4ea169655411359c52045
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96020
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-03-08 17:27:38 +00:00
Régis Crelier afccd8cbc7 Revert "[cfe] Handle spread map entries of static type Null" 
This reverts commit ccd2c85a1a.

Reason for revert: very red bots, gardener not going to blindly approve all redness

Original change's description:
> [cfe] Handle spread map entries of static type Null
> 
> Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=dmitryas@google.com,askesc@google.com,kmillikin@google.com

Change-Id: Ia8f60993222851a73291662f75556b2e4111a6f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96123
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
 2019-03-08 17:19:35 +00:00
Dmitry Stefantsov ccd2c85a1a [cfe] Handle spread map entries of static type Null 
Change-Id: I164b3fa471deb65da93ecfd60ee836ec22eb93e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96080
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 15:46:31 +00:00
Dmitry Stefantsov 52ff930338 [cfe] Desugar map spread entries in non-const map literals 
Change-Id: Ie8f6cc0294888716f4e0349ba07320e684e26e1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95640
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-08 12:08:42 +00:00
Brian Wilkerson a47ffd2b50 Fix some errors in the control flow collections tests 
Change-Id: I87ba6b3d2860439c33b62c02e8f9294d65d31abc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95900
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-03-07 21:54:55 +00:00
Aart Bik 5c7b07f783 [dart/vm] Fix bug in kernel binary flow graph builder 
Rationale:
Found by DartFuzz. One of the trickier bugs I had to debug.
While building the flow graph from kernel, the finalizer
builder expects the program context to be in the same state
as when the finalizer was seen first, not the context seen
by the breaking/continuing statement. This was done partially,
but only partially. Finding loop context or breakable
and switchable blocks was missing. Something only
a fuzzer can find :-)

https://github.com/dart-lang/sdk/issues/36076

Change-Id: Ie63912c5fad4d3c15f6559b60cc102b237949957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95720
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-03-07 20:16:18 +00:00
Bob Nystrom 57f16820cd Add tests for "await" inside spread, if, and for. 
These don't try to comprehensively cover every interaction of async
and the new syntax, but they should test that an implementation handles
an await appearing in all the various places in the new syntax where an
expression is permitted.

Change-Id: I4852815002fcad6697f3bad4103693b1d4288d06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-03-06 00:10:04 +00:00
Johnni Winther 204651f3ab Replace package:expect annotations with @pragma 
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 11:00:17 +00:00
Aske Simon Christensen 99093c0610 [fasta] Required but not inferred constant context. 
Add a new kind of constant context in the body builder for expressions
that must be constant but where constness is not inferred.

This context is used for parameter default values and initializing
expressions for non-final fields in classes containing at least one
const constructor.

Fixes https://github.com/dart-lang/sdk/issues/34191

Change-Id: I200ca88586b19335b185dad0839dfad4eef1f75f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93520
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Aske Simon Christensen 822ebdd1e0 [fasta] Wrap non-const variable accesses inside const expressions. 
Change-Id: I8761031da2419a47a947a02721d4ffd86ac7c531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/93504
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-03-05 09:23:57 +00:00
Bob Nystrom b88e6dd910 Fix the type argument on the deep flattening spread test. 
Change-Id: Icba0904c88a18901c0a2d423a8ce7ab7af8413fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94941
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-03-04 19:20:53 +00:00
Dmitry Stefantsov 2c8f70cde3 [cfe] Add type inference for spreads in set literals 
Change-Id: I60250ec4ba7dba2381d84328095d38cf47b4ea8b
Reviewed-on: https://dart-review.googlesource.com/c/94548
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-01 15:17:13 +00:00
Brian Wilkerson 48ee388791 Fix a typo in a shared test 
Change-Id: I096e459ffeae70f944d03715081c3b9f653b01a6
Reviewed-on: https://dart-review.googlesource.com/c/94843
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2019-02-28 21:25:49 +00:00
Aart Bik a10b0d8763 [vm/compiler] LICM and CSE improvements 
Several improvements
(1) makes implicit control dependence of a null check
    explicit by means of data dependence (already
    done for bounds checks); also see the doc in
    runtime/docs/compiler/data_dep_for_control_dep.md
(2) improves CSE properties of various IL nodes
(3) allows LICM on invariant code that may-throw
    as long as the visible behavior is preserved

https://github.com/dart-lang/sdk/issues/35323
https://github.com/dart-lang/sdk/issues/34684

Change-Id: Icb4520a649da38eddc3d7c85af21427d3c64d22e
Reviewed-on: https://dart-review.googlesource.com/c/93822
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-28 19:29:06 +00:00
Kevin Millikin 5f095b7039 [Fasta] Add support for spread in map literals 
Spreads are compiled as if they were spread elements in list or set
literals.  When one occurs in a map literal it is translated to a new
spread map entry.

Change-Id: Ic618b1e85e595b4c2cd65e184b9d2c49e9c34b79
Reviewed-on: https://dart-review.googlesource.com/c/94547
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-28 06:05:00 +00:00
Kevin Millikin d7a7de31bf Update dartkb test expectations 
Change-Id: I8137e49fc7982a65c857c206763ffecacd141cac
Reviewed-on: https://dart-review.googlesource.com/c/94545
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-02-27 14:26:02 +00:00
Kevin Millikin a9ef31ba43 [Fasta] Add Kernel syntax for spread elements 
Add spread elements to the Kernel syntax.  They are currently replaced
by an invalid expression during type inference.

Change-Id: Icdb489e2c9993c6517983cfafdefc801ebb378ab
Reviewed-on: https://dart-review.googlesource.com/c/94501
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-27 11:48:12 +00:00
Aske Simon Christensen dc8a56bc0e Rename set literal tests to end in _test 
Change-Id: Ifc33abb2279554373bdfb9c1c54f468d7fd683c2
Reviewed-on: https://dart-review.googlesource.com/c/94480
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-02-27 08:14:12 +00:00
Aart Bik fa0ba2220e [vm/compiler] Fix bug in Cid range computation 
Rationale:
Make sure open range is closed when skipping
special cids. This bug was probably undetected
for a while, since only kByteBufferCid is adjacent
to kNullCid.

https://github.com/flutter/flutter/issues/28260

Change-Id: Ic22c83aeb26c3130132dc901004a0ad818246dbc
Reviewed-on: https://dart-review.googlesource.com/c/93926
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-02-25 22:31:24 +00:00
Aske Simon Christensen e7d263b05f [fasta] Transform set literals in annotations. 
Change-Id: I23e60cb85e1df728fc3be3b38be43e31a1795d1d
Reviewed-on: https://dart-review.googlesource.com/c/93941
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-02-25 10:30:14 +00:00
Nicholas Shahan 646c1f679a [tests] Minor fixes in control flow collections for tests 
Change-Id: I61bbe247b8474a6eeb2d63f9acbd99218f2d04e6
Reviewed-on: https://dart-review.googlesource.com/c/94140
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-23 01:37:41 +00:00
Dan Rubel 58cea93953 Update BodyBuilder to use handleLiteralSetOrMap 
This is the second of several CLs updating the parser and its listeners
to conform to the unified collection spec:
https://github.com/dart-lang/language/pull/200

Change-Id: I5c277d05a3726a3f5a40823cf878f025167340e6
Reviewed-on: https://dart-review.googlesource.com/c/93741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-02-22 17:31:24 +00:00
Aske Simon Christensen 6f8415245d [fasta] Transform set literals in initializers and default values. 
The set literal desugaring was missing set literals in constructor
initializers and parameter default values. Furthermore, it assumed
that a constructor that contained a set literal had a body.

Fixes https://github.com/dart-lang/sdk/issues/35989

Change-Id: I42c77b96bbe751ee6f7c7ba7921e9b9df24c16e9
Reviewed-on: https://dart-review.googlesource.com/c/93660
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-02-20 15:38:54 +00:00
Samir Jindel c635896e1b [vm] Fix langauge_2_kernel.status after 93301 
Change-Id: I79f57caea89356e7505a07ebd911c8732fccd816
Reviewed-on: https://dart-review.googlesource.com/c/93542
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
Auto-Submit: Samir Jindel <sjindel@google.com>
 2019-02-20 10:24:10 +00:00
Bob Nystrom 6cf71022a8 Add a test for type promotion in "if" collection elements. 
Change-Id: Ibdb5002fc7646b80978ea447fedd97606476630d
Reviewed-on: https://dart-review.googlesource.com/c/93301
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2019-02-20 02:03:01 +00:00
Nicholas Shahan 80798fad97 [tests] Add missing parenthesis on <list|map|set>Equals() calls 
Change-Id: I2d4fc114ad01ba075c644285d7e87b89570f626b
Reviewed-on: https://dart-review.googlesource.com/c/92661
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-13 23:51:37 +00:00
Konstantin Shcheglov f841096701 Fix for crash if MixinDeclaration has a const constructor. 
R=brianwilkerson@google.com

Bug: https://buganizer.corp.google.com/issues/124304191
Change-Id: I78f07338c3ac4c254986fb2b19a00bb5fd4201b7
Reviewed-on: https://dart-review.googlesource.com/c/92860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-02-12 22:16:12 +00:00
Nicholas Shahan d93ef933d5 [tests] Add 'spread-collections' flag 
Some of the new control flow collections tests are using the spread operator.

Change-Id: Id050025342692a5e3d88471840c4f0ca5cdab5da
Reviewed-on: https://dart-review.googlesource.com/c/92480
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-02-11 19:52:19 +00:00
Aart Bik 32603d5626 [vm/compiler] improve equality constant folding 
Rationale:
Static calls were formerly unexplored in our constant
folding. This is a first step towards making the
constant folder aware of semantics of recognized methods.

https://github.com/dart-lang/sdk/issues/35882

Change-Id: Id6e366f4d25f08a618931fc3c8a8c065f6358feb
Reviewed-on: https://dart-review.googlesource.com/c/92410
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-02-09 01:09:39 +00:00
Kevin Millikin be79eb4517 Ship experiment 'set-literals' 
Change-Id: Ief182017752b87ef099ac5140ff781cbb14d76a9
Reviewed-on: https://dart-review.googlesource.com/c/92125
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-02-08 16:17:55 +00:00
Aart Bik 9c0a73f943 [dart/vm] Skip finalization error for now 
https://github.com/dart-lang/sdk/issues/35885

Change-Id: I79a1c77459b1cf1cdae563cd6e29697e641a57ff
Reviewed-on: https://dart-review.googlesource.com/c/92385
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2019-02-07 23:38:08 +00:00
Johnni Winther 33bc628235 Treeshake unread fields 
Change-Id: I188df5fd18163e5b32213a364d0fc163300db7b9
Reviewed-on: https://dart-review.googlesource.com/c/92130
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-07 09:58:19 +00:00
Kevin Millikin 8f821d408e Fix status files for dartkp 
These expectations were for a stale version of the precompiled
runtime.

Change-Id: Ie4bafb50b89e76df4e782d240674968f078a6c6c
Reviewed-on: https://dart-review.googlesource.com/c/92135
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-06 13:38:21 +00:00
Kevin Millikin 6b73a02937 Fix status files for simarm and simarm64 
Change-Id: I965b0eef9566a5c35e3b94dbe2a5cd1f86eaa250
Reviewed-on: https://dart-review.googlesource.com/c/92133
Reviewed-by: Samir Jindel <sjindel@google.com>
 2019-02-06 13:16:00 +00:00
Kevin Millikin c2778062e7 Add UI as code status file entries for simarm 
Change-Id: I54076c4f0350e325729e780bbf0a191e46ca36cd
Reviewed-on: https://dart-review.googlesource.com/c/92127
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-02-06 12:02:18 +00:00
Kevin Millikin 2b8560f4b2 [Fasta] Add spread and control-flow collection flags 
Also stop skipping the corresponding tests.  Add status file entries
for Fasta and VM configurations.

Change-Id: Iecc1e048915df598ba69ac79261cfc836d38f95a
Reviewed-on: https://dart-review.googlesource.com/c/92045
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-06 10:30:18 +00:00
Kevin Millikin 0828d2c786 [Fasta] Implement exact types for Set literals 
Set literals have an exact type of Set<T> for some T.  An implicit
downcast to a subtype is a static error.

Change-Id: I922b078b1b9e595243520e73c7130c23fe91f454
Reviewed-on: https://dart-review.googlesource.com/c/91640
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2019-02-05 07:43:52 +00:00
Bob Nystrom c4dcd85b3a Tests for control flow collections. 
Change-Id: I41050143611bdb816b5d91a6cd6f668536b613df
Reviewed-on: https://dart-review.googlesource.com/c/91600
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-02-02 00:34:01 +00:00
Bob Nystrom ec343169e7 Skip the spread tests on platforms that aren't using the new test workflow. 
These statuses should be more specific, but this should get the bots
green first.

Change-Id: Ifa734f74f866974332b2926398f2a01eb0707ac7
Reviewed-on: https://dart-review.googlesource.com/c/91767
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-02-01 00:30:38 +00:00
Bob Nystrom 9f8a9dc9f4 First stab at tests for "Spread Collections". 
I'm sure there's mistakes since I can't parse the tests, much less run
them, but I did my best.

Is there anything else you think we should add? I feel like the tests
around inference are weak, but I don't know what else would help.

Change-Id: If4b573acad4395310ad6fc3477861f8d28c16255
Reviewed-on: https://dart-review.googlesource.com/c/89085
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-01-31 22:09:15 +00:00
Aart Bik 40fca03d07 [vm/compiler] fix assert failure on minint64 
Rationale:
The new modulo optimization assert fails when doing
the power-of-two-of-abs test on minint64 (since abs
of minint64 is minint64). Note that we could actually
optimize this case by masking with maxint64 pattern
but since it bails for non-smi masks right now, this
fix does the same.

https://github.com/dart-lang/sdk/issues/35815

Change-Id: Ic592dad89ff6ffcd84dba9e17d4bccd79dc01f18
Reviewed-on: https://dart-review.googlesource.com/c/91704
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-01-31 00:55:01 +00:00
Liam Appelbe c167cd3572 [VM] Experimental flags in dartkp tests 
Plumb experimental flags found in a test's SharedOptions through to the
gen_kernel command invoked in dartkp tests. Also enable a whole bunch
of tests that are now passing.

Bug: https://github.com/dart-lang/sdk/issues/35602
Change-Id: I425f55ea6c84d28e085ab2c848376e396e68a225
Reviewed-on: https://dart-review.googlesource.com/c/90860
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-25 19:47:40 +00:00
asiva 0a41a2d292 [ Test ] Remove support for flutter runtime from the test framework 
Support for the flutter runtime (sky_shell) was added to the Dart
test framework in the hope that one could run the flutter engine
through the Dart test suite. We never got around to running these
tests on the build bots, the sky_shell executable has been deprecated
and there are plans in the flutter engine team to have their own
unit test frame work.

See Issue https://github.com/flutter/flutter/issues/9115 for more
details.

Change-Id: I6ee9e8c919721dccecf4202ab0778939aeb79174
Reviewed-on: https://dart-review.googlesource.com/c/91103
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2019-01-25 04:16:43 +00:00
Paul Berry f0793a937c Fix analyzer status for const_constructor3_test. 
The test passes now.

Change-Id: Id121e108c2b2585bb1a553383f76edd983a90c72
Reviewed-on: https://dart-review.googlesource.com/c/90600
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2019-01-23 00:34:32 +00:00
asiva 292ce7a1b8 Fix build breakage. 
Change-Id: I54b7545831d2d3d8bf82b0d8611aff8bce4ae1bc
Reviewed-on: https://dart-review.googlesource.com/c/90323
Auto-Submit: Siva Annamalai <asiva@google.com>
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-01-18 21:50:53 +00:00
asiva df7823aa7d [VM] Enable set literal tests in dartk mode. 
Change-Id: I9bb0d16c9fd9d8ec4b69804d197bf035dfa9939d
Reviewed-on: https://dart-review.googlesource.com/c/90122
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-18 18:29:29 +00:00
William Hesse a533753bec Remove --fast-startup flag support from testing scripts and status files 
Change-Id: Icfb4aa228c0f13bf9fce25aeb7bacbf1e38497ee
Reviewed-on: https://dart-review.googlesource.com/c/89582
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-01-16 11:32:44 +00:00
Sigmund Cherem e636e1fa6f Accept experimental flags in dart2js and enable set-literal tests, now supported 
once we accept the flag.

Note: 3 tests are missing compile-time errors from the CFE. This is a known CFE
issue, we need to mark the tests as failng using the new workflow before we land
the CL.
Change-Id: I0eaf6c1d7e903e035c83d3338054a8f92d2d9296
Reviewed-on: https://dart-review.googlesource.com/c/88763
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-01-11 19:32:46 +00:00