Commit Graph

156 Commits

Author SHA1 Message Date
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests.
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-17 23:37:15 +00:00
Bob Nystrom 307742d07e Move tests from package "test" (back) to "unittest".
Since unittest is known to work with test.dart as a test runner and is
strong mode clean, it's a safer bet than test.

Change-Id: Id120d4f871827b1f131dff2a5ef2f7efb15a8382
Reviewed-on: https://dart-review.googlesource.com/12125
Reviewed-by: Terry Lucas <terry@google.com>
2017-10-10 19:46:12 +00:00
Ben Konyi a87493f8ca Migrated test block 165 to Dart 2.0.
Minor changes to a couple of tests to make them strong-mode clean.

Bug:
Change-Id: Id0cac7a120dbdf940d101c3e5de8c206a0ad6342
Reviewed-on: https://dart-review.googlesource.com/4613
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-21 19:00:36 +00:00
Ben Konyi 01e5f01cfc Migrated test block 164 to Dart 2.0.
Fairly simple block with the exception of the
causal_async_exception_stack* tests needing to be refactored to be
migrated from unittest->test.

Bug:
Change-Id: I8f4879a10730b6186bdd1b392084a2e4055262eb
Reviewed-on: https://dart-review.googlesource.com/4641
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2017-09-14 21:49:59 +00:00
Ben Konyi cdc7a16d8e Migrated test block 166 to Dart 2.0.
Bug:
Change-Id: Ib21357cf328ec25c1acc58c3b37a4a7bf2910fa1
Reviewed-on: https://dart-review.googlesource.com/4612
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2017-09-12 19:22:08 +00:00
Janice Collins fe7c2acd4e Migrate block 163 to Dart 2.0.
Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
vm/async_await_catch_stacktrace_test

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/3008723002 .
2017-08-30 08:05:12 -07:00