Commit Graph

3 Commits

Author SHA1 Message Date
Kallen Tu 78fac5afc1 Added additional language tests for sound variant classes extending legacy classes.
Change-Id: I214a8869dba527671b52c275d2302155382ba45f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124140
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
2019-11-07 17:49:38 +00:00
Kallen Tu 94e312f7a6 Added errors for variance positions in method members.
When an explicitly defined type variable is used in an incorrect
variance position in a method (whether in the return or the
parameters), an error is emitted.

Change-Id: I7e49687579bb2ce6e293b052b657b98741cb04f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122740
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-10-31 18:26:43 +00:00
Kallen Tu 9461df2084 Language tests for variance modifiers.
These test basic correct usages of variance modifiers in fields
and methods.

Erroneous usages will come in a future CL, as well as more complex
examples + subclassing.


Change-Id: I05d547ac1db9e22235a0bf64b05fcb3e119e3157
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119169
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2019-10-05 01:18:42 +00:00