dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

8 Commits

Author SHA1 Message Date
Aske Simon Christensen 88c0c11612 Remove constant-update-2018 flag from tests. 
Change-Id: I85d3d0180bb7f5973ad2da946a3519c553fc7f92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113991
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-08-22 11:00:54 +00:00
Kevin Millikin 64b0ce5b58 Remove UI as code experimental flags from our tests 
The features control-flow-collections and spread-collections have been
shipped and it is no longer necessary for tests to explicitly opt into
them.

Change-Id: I074b91d12e4e485ee4a64147947bb1113899ecdc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104780
Auto-Submit: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-06-06 13:17:49 +00:00
Nicholas Shahan 9d15138c91 [tests] Revert the previous deletion of UI-as-Code const tests 
Returning since they should be valid with the `constant-update-2018` experiment
flag:
* control_flow_collections/if_const_test.dart
* control_flow_collections/if_const_error_test.dart
* spread_collections/const_test.dart
* spread_collections/const_error_test.dart

Should be deleted when UI-as-Code is supported in constant collections:
* control_flow_collections/if_const_syntax_error_test.dart
* spread_collections/const_syntax_error_test.dart

Change-Id: I595333782630122ae4f3d021841b062b27e1cccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99600
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-04-16 23:04:37 +00:00
Nicholas Shahan 6dc209e858 [tests] UI-as-Code in const collections is a compile time error 
* Update tests to expect compilation errors when `if` `for` or `...` are used in
  const collections.
* Remove constant-update-2018 flag from tests.

Change-Id: I477c30f07c7e3da6139f263e1855c3908c1bce2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99485
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-04-16 20:02:29 +00:00
Nicholas Shahan add5a27120 [infra] Add constant-update-2018 flag to v2.3 lang features tests 
Patched changes from https://dart-review.googlesource.com/c/sdk/+/97939

Removed the change to the language_2_kernel.status

Kernel team can update as needed.

Change-Id: Icc347081e6c00fb2ae7616afb452e2c652f9d6b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97942
Reviewed-by: Vijay Menon <vsm@google.com>
 2019-03-28 01:35:53 +00:00
Kevin Millikin 495b9c4519 Remove set-literals experimental flag from tests 
The set-literals feature has shipped and is on be default.  There is
no longer any need to pass it as an option to tests and the tools
cannot remove support for the flag while it is used in tests.

Change-Id: Ibf105ec01193ebb08d6e22600e6c7748897cc2ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96941
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2019-03-15 07:41:11 +00:00
Bob Nystrom b88e6dd910 Fix the type argument on the deep flattening spread test. 
Change-Id: Icba0904c88a18901c0a2d423a8ce7ab7af8413fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94941
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
 2019-03-04 19:20:53 +00:00
Bob Nystrom 9f8a9dc9f4 First stab at tests for "Spread Collections". 
I'm sure there's mistakes since I can't parse the tests, much less run
them, but I did my best.

Is there anything else you think we should add? I feel like the tests
around inference are weak, but I don't know what else would help.

Change-Id: If4b573acad4395310ad6fc3477861f8d28c16255
Reviewed-on: https://dart-review.googlesource.com/c/89085
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-01-31 22:09:15 +00:00