These tests acted as a guard to make sure we didn't unintentionally enable control flow and spread
in const collections when we initially shipped the features. Now that we are getting close to
enabling them for const they no longer valid.
Added a few more compile-time errors to the const spread error suite.
Change-Id: I52e215d4c1c4394f1a1b868c05241277b0d58d2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108680
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Returning since they should be valid with the `constant-update-2018` experiment
flag:
* control_flow_collections/if_const_test.dart
* control_flow_collections/if_const_error_test.dart
* spread_collections/const_test.dart
* spread_collections/const_error_test.dart
Should be deleted when UI-as-Code is supported in constant collections:
* control_flow_collections/if_const_syntax_error_test.dart
* spread_collections/const_syntax_error_test.dart
Change-Id: I595333782630122ae4f3d021841b062b27e1cccb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99600
Reviewed-by: Sigmund Cherem <sigmund@google.com>
* Update tests to expect compilation errors when `if` `for` or `...` are used in
const collections.
* Remove constant-update-2018 flag from tests.
Change-Id: I477c30f07c7e3da6139f263e1855c3908c1bce2d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99485
Reviewed-by: Sigmund Cherem <sigmund@google.com>
These don't try to comprehensively cover every interaction of async
and the new syntax, but they should test that an implementation handles
an await appearing in all the various places in the new syntax where an
expression is permitted.
Change-Id: I4852815002fcad6697f3bad4103693b1d4288d06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94121
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
I'm sure there's mistakes since I can't parse the tests, much less run
them, but I did my best.
Is there anything else you think we should add? I feel like the tests
around inference are weak, but I don't know what else would help.
Change-Id: If4b573acad4395310ad6fc3477861f8d28c16255
Reviewed-on: https://dart-review.googlesource.com/c/89085
Reviewed-by: Leaf Petersen <leafp@google.com>
Aske Simon Christensen