dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

225 Commits

Author SHA1 Message Date
Florian Loitsch 354a4ec420 Migrate test block 149. 
Change-Id: I6529a9ac0ad6557dc751be5c6f7bf14c9d45f909
Reviewed-on: https://dart-review.googlesource.com/11400
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 10:36:11 +00:00
Jakob Roland Andersen d7c5584976 Migrate test block 143. 
Change-Id: I843937de387436e07b289ccc35efa6776d59c142
Reviewed-on: https://dart-review.googlesource.com/11280
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 07:27:28 +00:00
Florian Loitsch 3b64211ab2 Migrate test block 127. 
Change-Id: I05a4baa3c641d71ccee1fce1e7f680f3fd9f42fc
Reviewed-on: https://dart-review.googlesource.com/9041
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 06:43:21 +00:00
Florian Loitsch ec69c47c12 Migration of test block 126. 
Change-Id: I8bbccbfae0194f246b8305ea4ca7bb02b5b6a9ec
Reviewed-on: https://dart-review.googlesource.com/7546
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-04 21:38:10 +00:00
pq dd069fc800 Migrate test block 142 to Dart 2.0. 
Bug:
Change-Id: I358bcf6d7d3d4c78b572ed4bbcb05696c47268cc
Reviewed-on: https://dart-review.googlesource.com/10640
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-03 20:00:27 +00:00
Janice Collins 3bed0647a0 Migrate block 162 to Dart 2.0. 
Based heavily on https://codereview.chromium.org/3007803002, but built from scratch with the updated migration script.

Change-Id: I52ecd5dd97a73ec2f5fc524de532c5605c5d0a7d
Reviewed-on: https://dart-review.googlesource.com/9360
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-10-03 17:47:59 +00:00
Régis Crelier b1dd843fd4 Add test verifying that generic function types are disallowed as type argument. 
Change-Id: I76d4fd13f0370d7d42b17aa9e63a391b60a89463
Reviewed-on: https://dart-review.googlesource.com/9369
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-02 18:50:37 +00:00
Ben Konyi 876bb0c494 Migrated test block 130 to Dart 2.0. 
Slightly tricky block. Many map_literal* tests were modified as they were creating maps with
multiple instances of the same key.

Bug:
Change-Id: I5dcaa458ee8f68a4934950bb32229ff92100149b
Reviewed-on: https://dart-review.googlesource.com/9064
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-29 04:24:02 +00:00
Ben Konyi 5bb98ebc33 Migrated test block 161 to Dart 2.0. 
This block contained a lot of static type warnings and took a lot of
status file wrangling to get right.

Bug:
Change-Id: I037402a31f978af15716964c8ff5192036df4276
Reviewed-on: https://dart-review.googlesource.com/7440
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-28 17:15:51 +00:00
pq 57d452dbf7 Migrate test block 134 to Dart 2.0. 
Bug:
Change-Id: I67bba5c5049c62b8313d49efe36c81fc600b995a
Reviewed-on: https://dart-review.googlesource.com/7847
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-28 16:15:47 +00:00
Jaime Wren d18c5c3620 Migrated test block 63 to Dart 2.0 
Change-Id: I35b3ceb1ac2aa7fc4e26a28ff814bccba6bbb004
Reviewed-on: https://dart-review.googlesource.com/7200
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-28 16:06:08 +00:00
Jaime Wren 3d020fa91e Migrated test block 60 to Dart 2.0, take 2 
Original review at https://dart-review.googlesource.com/c/sdk/+/7160

Change-Id: If2aeecec04640bee3b622d97c8fcdd6cb1bdd369
Reviewed-on: https://dart-review.googlesource.com/8731
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-27 18:07:05 +00:00
pq a02ca2070f Migrate block 141 to Dart 2.0. 
Bug:
Change-Id: If806f50a6254c187fc862fc7e5c19f45ccb9a8e8
Reviewed-on: https://dart-review.googlesource.com/8361
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-26 18:42:04 +00:00
pq 650a1159ff Migrate test block 65 to Dart 2.0. 
Bug:
Change-Id: Ibf50302eb7a1cec7546f4ceb87f8c19808479568
Reviewed-on: https://dart-review.googlesource.com/8380
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-26 16:55:42 +00:00
Ben Konyi c0364e372d Migrated test block 58 to Dart 2.0. 
No major changes.

Bug:
Change-Id: I7092880088d0fd334d6d2b1f6d4f1dbc2cb03ed2
Reviewed-on: https://dart-review.googlesource.com/7487
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-25 13:51:22 +00:00
Ben Konyi 24e40a0f61 Migrated test block 139 to Dart 2.0. 
Did not migrate null_bottom / null_is_bottom type tests. Modified
null_test to not run some mirrors related checks on platforms that don't
support mirrors.

Bug:
Change-Id: I7fce784f537cc298e2945a32073700083d9275f8
Reviewed-on: https://dart-review.googlesource.com/7848
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-23 00:06:38 +00:00
Ben Konyi 038c281a47 Migrated test block 131 to Dart 2.0. 
Quite a few changes were made to method_override* tests.

Bug:
Change-Id: I554c83ae766010b55f17a86caee9418d0c34cbe7
Reviewed-on: https://dart-review.googlesource.com/7683
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 21:53:58 +00:00
William Hesse b3e7f6d299 Recommit "migrate function type tests"" 
This reverts commit ba09eb787c, which was
a revert of ca6bec3414.
New status lines have been added to tests/languge_2/language_2_dart.js.status.

Bug:
Change-Id: I9e5b344d67df1fb00d5a51078a3d2b6113223a3e
Reviewed-on: https://dart-review.googlesource.com/7800
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:52:27 +00:00
pq d9326f4ab3 Migrate test block 135 to Dart 2.0. 
Bug:
Change-Id: Icda59de9bfad2e9b2683f019fb9c6fc54c12547c
Reviewed-on: https://dart-review.googlesource.com/7587
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:04:06 +00:00
Erik Ernst 9cffb6aa0f Gardening: Removed status entry for language_2/vm/type_vm_test 
Change-Id: Ie9a6c0d22c672ebb291c98abb61b0634d0e485e4
Reviewed-on: https://dart-review.googlesource.com/7703
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-22 07:43:15 +00:00
Jaime Wren ec431ffa39 Revert "Migrated test block 60 to Dart 2.0" 
This reverts commit 9141047cd7.

Change-Id: I222dd72cabe4a69576e7f5d87e2ae61b96ac6b16
Reviewed-on: https://dart-review.googlesource.com/7636
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 21:34:32 +00:00
Jaime Wren 9141047cd7 Migrated test block 60 to Dart 2.0 
Change-Id: I3b9f5ea80001adf0017599c86db3be235fbf12e1
Reviewed-on: https://dart-review.googlesource.com/7160
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 20:43:34 +00:00
Ben Konyi a87493f8ca Migrated test block 165 to Dart 2.0. 
Minor changes to a couple of tests to make them strong-mode clean.

Bug:
Change-Id: Id0cac7a120dbdf940d101c3e5de8c206a0ad6342
Reviewed-on: https://dart-review.googlesource.com/4613
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-21 19:00:36 +00:00
Florian Loitsch 951e8dad51 Split the mock_writable test into two pieces. 
One now contains private symbols. The other doesn't.

Change-Id: I4f7586117731aad1d965060a7ff7b14050713331
Reviewed-on: https://dart-review.googlesource.com/7543
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-21 08:24:15 +00:00
Bob Nystrom 74e4ccdeb8 Migrate block 120. 
Change-Id: Ia5a433e70ab3bdf953a116a0b65de42138125d2b
Reviewed-on: https://dart-review.googlesource.com/6347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 22:23:58 +00:00
pq 86e4c97346 Re-stage migration of test block 136 to Dart 2.0. 
Bug:
Change-Id: I562ceec87bc946bb43467ca118c88991a368657f
Reviewed-on: https://dart-review.googlesource.com/6781
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 16:23:00 +00:00
pq ced11f1b0c Migrate test block 153 to Dart 2.0. 
Change-Id: Ide65fb47af440e32648d01f46ad6f858b9faeadf
Reviewed-on: https://dart-review.googlesource.com/3742
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-19 16:20:45 +00:00
Ben Konyi 55e34cb2b0 Migrated test block 55 to Dart 2.0. 
Bug:
Change-Id: I781d22614ea06b599dd9bbe6d03f820f0cfea544
Reviewed-on: https://dart-review.googlesource.com/5482
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-18 22:08:58 +00:00
Karl Klose ba09eb787c Revert "migrate function type tests" 
This reverts commit ca6bec3414.

R=whesse@google.com

Change-Id: I57195534c4c32e0fcf0cd88f5171984b126be26e
Reviewed-on: https://dart-review.googlesource.com/6466
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2017-09-18 12:05:46 +00:00
Jennifer Messerly ca6bec3414 migrate function type tests 
I'd previously fixed most of these in strong mode. This also migrates the ones in the same text range.

Change-Id: Ieb637c0635502e46362594db3ce20ec414c95ffa
Reviewed-on: https://dart-review.googlesource.com/5521
Commit-Queue: Jennifer Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-16 05:28:43 +00:00
pq b091570a09 Revert "Migrate test block 136 to Dart 2.0." 
This reverts commit f58517a87a.

Bug:
Change-Id: I1da91b30499a768aee7521c16a8ce2fc79604b15
Reviewed-on: https://dart-review.googlesource.com/6169
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-15 18:30:04 +00:00
pq f58517a87a Migrate test block 136 to Dart 2.0. 
mixin_type_parameters_super_test .. named_parameters_aggregated_test

Bug:
Change-Id: Ic2c45c6c4ff0d4f7fd239f5b5ee039fced943a49
Reviewed-on: https://dart-review.googlesource.com/6163
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-15 18:08:00 +00:00
Ben Konyi 01e5f01cfc Migrated test block 164 to Dart 2.0. 
Fairly simple block with the exception of the
causal_async_exception_stack* tests needing to be refactored to be
migrated from unittest->test.

Bug:
Change-Id: I8f4879a10730b6186bdd1b392084a2e4055262eb
Reviewed-on: https://dart-review.googlesource.com/4641
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-14 21:49:59 +00:00
Ben Konyi 795d74b35c Migrated test block 56 to Dart 2.0. 
Minor changes to make cyclic_default_values_test,
cyclic_type_variable_test, and cyclic_typedef_test strong mode clean.

Bug:
Change-Id: Icc99b07eca07f937a18fd16968619e5cd7c8ca22
Reviewed-on: https://dart-review.googlesource.com/5341
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-14 20:34:04 +00:00
Bob Nystrom 12433bd5f4 Update assertion_test to no longer allow functions in asserts. 
Dart used to allow the first argument to assert() to be a function,
which it would implicitly call, but this is being removed for Dart 2.0.

https://github.com/dart-lang/sdk/issues/30326

This gets the test testing the 2.0 behavior. Since the test is now
leading the implementation, updated the status files to mark it failing.

Bug: https://github.com/dart-lang/sdk/issues/30326
Change-Id: Ia61f540f1991ecdf42ccdb47b932890e636c1bd3
Reviewed-on: https://dart-review.googlesource.com/4181
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-14 18:10:26 +00:00
Jakob Roland Andersen d687bc6673 Migrated test batch 122 to Dart 2.0. 
Bug:
Change-Id: Icb90877af264b2f61c9e32be7420ed748cab601f
Reviewed-on: https://dart-review.googlesource.com/5741
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-14 14:42:48 +00:00
Jakob Roland Andersen eaafacb59d Revert "Revert "Reland "Migrated test batch 123 to Dart 2.0.""" 
This reverts commit 85e8613e66.

Reason for revert: Giving this one last try.

Wasn't able to reproduce the buildbot's failure on macOS or Windows, so
marking the entire test as RuntimeError, instead of just part of it.

GitHub issue: https://github.com/dart-lang/sdk/issues/30675

Original change's description:
> > This is a reland of 594e6cf010
> > Original change's description:
> > > Migrated test batch 123 to Dart 2.0.
> > > 
> > > Bug:
> > > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > > Reviewed-on: https://dart-review.googlesource.com/4800
> > > Reviewed-by: Florian Loitsch <floitsch@google.com>
TBR=jakobr@google.com,floitsch@google.com

Change-Id: I0508cf605c40125132a807a019b5cf412a393ac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5680
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-14 08:29:07 +00:00
Ben Konyi 30dde80447 Migrated test block 57 to Dart 2.0. 
Bug:
Change-Id: I4b6845b0539fc5b8bb7118d6e920685afb0b3edc
Reviewed-on: https://dart-review.googlesource.com/5342
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-13 18:08:58 +00:00
Paul Berry 5145705d51 Test a corner case of runtime checks (closure called via method interface). 
Currently, Dart 2.0 forbids overriding a method with a getter (even if
the types are compatible), so once a method has been torn off, there's
no way to ever call the tear-off through an interface target that is a
method.  However, if we ever relax that rule and allow a method to be
overridden with a getter, it will be possible to call a torn-off
method through an interface target that is a method.  If this ever
happens, we will need to make sure that the proper covariance checks
occur.

Since overriding a method with a getter is currently forbidden, the
new tests verify that the expected compile time error occurs.
However, to future proof us against the possibility that this
restriction is ever relaxed, the tests also contain enough code to
demonstrate the runtime check that would be needed.

Change-Id: Iea3a56d86f661362ff9fb970bcc80c8f80c50f4e
Reviewed-on: https://dart-review.googlesource.com/5322
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-13 17:39:40 +00:00
pq 8da668be93 Migrate Test Block 137 to Dart 2.0. 
named_parameters_default_eq_test .. namer_test

Bug:
Change-Id: I0d0d853e94e7ca78472224405f811d1ac55c1f6c
Reviewed-on: https://dart-review.googlesource.com/5283
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-13 15:44:13 +00:00
Jakob Roland Andersen 85e8613e66 Revert "Reland "Migrated test batch 123 to Dart 2.0."" 
This reverts commit e9cd03e8f8.

Reason for revert: Still fails on macOS/Windows. Sigh.

Original change's description:
> Reland "Migrated test batch 123 to Dart 2.0."
> 
> This is a reland of 594e6cf010
> Original change's description:
> > Migrated test batch 123 to Dart 2.0.
> > 
> > Bug:
> > Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> > Reviewed-on: https://dart-review.googlesource.com/4800
> > Reviewed-by: Florian Loitsch <floitsch@google.com>
> 
> Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
> Reviewed-on: https://dart-review.googlesource.com/5301
> Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
> Reviewed-by: Jakob Roland Andersen <jakobr@google.com>

TBR=jakobr@google.com,floitsch@google.com

Change-Id: Ia20ce3555e88e7c366893fb6416b77a2164db05f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5362
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-13 09:21:55 +00:00
Jakob Roland Andersen e9cd03e8f8 Reland "Migrated test batch 123 to Dart 2.0." 
This is a reland of 594e6cf010
Original change's description:
> Migrated test batch 123 to Dart 2.0.
> 
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>

Change-Id: I34710bc1a62eb1e94d6c32f20c6438f2db7bdb54
Reviewed-on: https://dart-review.googlesource.com/5301
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-13 08:59:27 +00:00
Jaime Wren 33ee69b3e4 Migrated test block 42 to Dart 2.0 
The test change of '.nooooo()' -> '.field' mitigates a bunch of status file changes that would be required.  Since this is an await, and not a strong mode/ ddc/ resolution test, this test was modified in this way.

Change-Id: I54bb9ff51c2e86dd61eb41fdfc19c93bbdf22f7a
Reviewed-on: https://dart-review.googlesource.com/4142
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-09-12 21:14:41 +00:00
pq 050cc8f815 Migrate test block 152 to Dart 2.0. 
static_field1_test.dart .. string_interpolate_test.dart

Bug:
Change-Id: I8d5602bf5f738522bc705b67d5f797013ca67ffc
Reviewed-on: https://dart-review.googlesource.com/5043
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 20:00:24 +00:00
Ben Konyi cdc7a16d8e Migrated test block 166 to Dart 2.0. 
Bug:
Change-Id: Ib21357cf328ec25c1acc58c3b37a4a7bf2910fa1
Reviewed-on: https://dart-review.googlesource.com/4612
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-12 19:22:08 +00:00
Jakob Roland Andersen ce4d332255 Revert "Migrated test batch 123 to Dart 2.0." 
This reverts commit 594e6cf010.

Reason for revert: Apparently, label_test failed on macOS/Windows, but not on Linux.

Original change's description:
> Migrated test batch 123 to Dart 2.0.
> 
> Bug:
> Change-Id: I780329831dc189add7b192faf85161659a4a8b53
> Reviewed-on: https://dart-review.googlesource.com/4800
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=jakobr@google.com,floitsch@google.com

Change-Id: I7cec6458621920229e61133f868566ee65784269
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/5181
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-09-12 14:03:11 +00:00
Jakob Roland Andersen 594e6cf010 Migrated test batch 123 to Dart 2.0. 
Bug:
Change-Id: I780329831dc189add7b192faf85161659a4a8b53
Reviewed-on: https://dart-review.googlesource.com/4800
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-12 13:28:37 +00:00
pq 2fbb267460 Revert "Migrate test block 152 to Dart 2.0." [TBR]. 
This reverts commit 9744f5d212.

Change-Id: I1299f0e9ea14c776c315dd8439bd9ab255d9060b
Reviewed-on: https://dart-review.googlesource.com/5001
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-11 18:24:16 +00:00
pq 9744f5d212 Migrate test block 152 to Dart 2.0. 
Change-Id: Iad60c7a650595703b0a0109d15d8971a4c209d84
Reviewed-on: https://dart-review.googlesource.com/3701
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-11 17:11:17 +00:00
Bob Nystrom c8aa62fe80 Fix bad_constructor_test. 
This reintroduces the previously-tested behavior (that a named
constructor can have the same name as a setter) and also cleans it up
and documents it.

Change-Id: Ia4d532a26e081ab150dfd073d1e6909f1b53a9ad
Reviewed-on: https://dart-review.googlesource.com/3386
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-07 20:31:00 +00:00