dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

676 Commits

Author SHA1 Message Date
Erik Corry 209959fe97 Fix status files to refer to correct deferred loading bug 
R=kmillikin@google.com

Bug: 30273
Change-Id: Ib6e0ecf0d68d575680cb45a9208ea93cd94551b8
Reviewed-on: https://dart-review.googlesource.com/37823
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-02-01 09:54:35 +00:00
Jenny Messerly 8489a843db fix generic_test and generics_test for Dart 2 
Change-Id: I831b5b0b6ade4cb099447e6a09058eb5c6745afa
Reviewed-on: https://dart-review.googlesource.com/36562
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-02-01 02:15:25 +00:00
Jenny Messerly 68ea5433fd implement assert initializers for DDC, fixes #27809 
also fixes #31058, DDC failed to execute all field initializers
(already fixed this in DDK when porting code_generator).

also fixes assertion_initializer_test, it was not strong mode clean, so
it was not giving any meaningful results for runtime behavior.

Change-Id: I290b266ad77ed92851cc2d0617690c6c021182a3
Reviewed-on: https://dart-review.googlesource.com/37866
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2018-02-01 01:12:17 +00:00
Jenny Messerly 5013b28bbe fix #31999, remove fuzzy arrow runtime support from DDC 
Also updates tests that relied on fuzzy arrows.

Change-Id: Ia8df1d8d421e43dfada589223d5e46182b92fa67
Reviewed-on: https://dart-review.googlesource.com/37425
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-31 22:20:38 +00:00
Erik Corry 4089f9f199 Annotate even more failing abstract class tests with issue number 
R=ahe@google.com

Bug: 32014
Change-Id: I66dd70498ac1bac854c2045cf9df9af56ee80746
TBR=ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/37801
Reviewed-by: Erik Corry <erikcorry@google.com>
 2018-01-31 13:19:29 +00:00
Erik Corry a57f95452f Annotate more failing abstract class tests with issue number 
R=ahe@google.com

Bug: 32014
Change-Id: Ib2cf0b8dcd65f7115e674676c0682efc78f8d461
TBR: ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/37820
Reviewed-by: Erik Corry <erikcorry@google.com>
 2018-01-31 13:12:00 +00:00
Erik Corry 72b36a7927 Annotate failing abstract class tests with issue number 
R=ahe@google.com

Bug: 32013
Change-Id: I1b56f8e3239ec8d5079a02031a94a4a2f93aa552
TBR=ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/37800
Reviewed-by: Erik Corry <erikcorry@google.com>
 2018-01-31 12:59:02 +00:00
Bob Nystrom 85faacc23c Fix the const assertion test. 
Dart 2 has no notion of "checked mode", so a failed assertion in a
const constructor should always be a compile error.

Change-Id: I02227c03613346918de1e3a7f7c70d209a940b90
Reviewed-on: https://dart-review.googlesource.com/37647
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-01-30 23:26:01 +00:00
Jens Johansen 5c74e0e16f Fix wrong assert in InvocationMirror_unpackTypeArguments 
There's an assert in InvocationMirror_unpackTypeArguments checking that
the length of the incomming TypeArguments is positive (len > 0).
That's not a valid assert.
When creating TypeArguments it will be TypeArguments::null() if it is
empty or contains only dynamic.
TypeArguments::null() will answer 0 as length which is thus perfectly
valid.

This CL fixes the wrong assert (technically it returns before the assert,
but still).

Fixes #31381.

Change-Id: I7a253418b69751b13e98fcf2def2b23b32f96142
Reviewed-on: https://dart-review.googlesource.com/37480
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-30 12:25:49 +00:00
Stephen Adams 6ca85ea808 Fix language_2/list_is_test 
Test was not properly migrated to Dart 2 subtyping rules.

Change-Id: If20c1fe3cc73cbfee5a6a7d55ed833793add1a5d
Reviewed-on: https://dart-review.googlesource.com/37142
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2018-01-27 21:01:50 +00:00
Jens Johansen d944e19da7 [kernel] Update status files 
Change-Id: I50e1f25a27e4e406f0e2b2b66c8607190227ae45
Reviewed-on: https://dart-review.googlesource.com/36920
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-26 08:24:58 +00:00
Lasse R.H. Nielsen d2aae0a45f Fix tests in language_2 to test strong mode semantics. 
Change-Id: I74dced985475fe48c900bfd6b6cece85f64b54cd
Reviewed-on: https://dart-review.googlesource.com/36581
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-25 10:57:42 +00:00
Jenny Messerly 0073457000 fix first_class_types_test to work for Dart 2 
Change-Id: I9f6665e1afd4d783158b170d62fcb2636ea3a081
Reviewed-on: https://dart-review.googlesource.com/36560
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2018-01-24 19:33:00 +00:00
Paul Berry 314b89e11d Update the analyzer to require noSuchMethod overrides to be concrete. 
See 38dcb10543 for details.

Change-Id: I00608f7106e1b37cde81b8145d8d748f8cd97804
Reviewed-on: https://dart-review.googlesource.com/36520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-24 13:55:18 +00:00
Jenny Messerly 5de9c20fb0 fix #31434 - recursive generic classes 
Change-Id: I5a30de9e7d48eccacddee621c94088dbd65cc77b
Reviewed-on: https://dart-review.googlesource.com/36381
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-01-23 22:11:27 +00:00
Jens Johansen 827573fc2c Status file updates after changes to Windows crash-sniffing 
Change-Id: I1fbf5ca58d1bb99811e622896ceb0d7177c87b43
Reviewed-on: https://dart-review.googlesource.com/36400
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-01-23 14:35:26 +00:00
Siva Annamalai 5f5bba2a74 Normalize status files. 
Allow void as a type.
Change-Id: Ia94c50bcc2e4023008da1dad60cdbfc3465d936b

Change-Id: Ibe7d394cf92e6bb45e06770329da857bcb2c84b0
Reviewed-on: https://dart-review.googlesource.com/36127
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2018-01-20 23:02:08 +00:00
Paul Berry 236ea5bb44 Add further test cases reflecting the consensus on #31596. 
Change-Id: Ib67f8ae239b89bf56efc059054b6430e27a0e66f
Reviewed-on: https://dart-review.googlesource.com/34922
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-01-20 17:10:57 +00:00
Sigmund Cherem bc98effc82 Fix status in simdbc64 
It appears that we have 2 ways of running the vm with dartk:

* (a) pkg/vm/dart2
* (b) compile to kernel, then separately load kernel in the vm.

The test in this CL fails with a kernel deserialization error, which show up as
compile-time errors in (a), but as runtime errors in (b) (and missing compile
time error, for the compile step)

Change-Id: Id276189e67c28e49838dc1ed91eefbd801b2438f
Reviewed-on: https://dart-review.googlesource.com/36022
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-01-19 19:06:11 +00:00
Peter von der Ahé f07534c36e Update status files for implicit new and const 
Change-Id: Ie71464c1c83ec9516d178640fdd745705588f410
Reviewed-on: https://dart-review.googlesource.com/35940
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-19 15:26:25 +00:00
Jens Johansen 76eb861729 [fasta] Add Null on the list of classes that cannot be extended 
Fixes #31817.

Bug: 31817
Change-Id: I7c2f98efee57724b65692fb0daa59ca12623dbe2
Reviewed-on: https://dart-review.googlesource.com/35601
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-19 06:53:57 +00:00
Sigmund Cherem e2ad2db805 Generate checks for library-is-loaded to fasta and dart2js. 
Change-Id: Ibf453ca7390b81da7231dcb1be43e426c00d6eeb
Reviewed-on: https://dart-review.googlesource.com/35100
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-01-18 20:17:14 +00:00
Peter von der Ahé 3fcede3c7f Short-term hack to work around issue with duplicated interfaces. 
See dartbug.com/31656

Change-Id: I017085953c5ac41d2cfd7368752918c6fcb51144
Reviewed-on: https://dart-review.googlesource.com/33884
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-01-18 14:10:15 +00:00
Jenny Messerly 3360abe2f2 fix test for #31436 to pass on Dart 2 impls 
Change-Id: I8dbd313d455f2a19a0f839de3b831c68dee1a520
Reviewed-on: https://dart-review.googlesource.com/35462
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
 2018-01-17 23:53:26 +00:00
Leaf Petersen 6b3576f673 Fix fuzzy arrow issues in tests. 
Also fixes a variety of miscellaneous accidental strong mode compile time or runtime check violations.

Change-Id: Ia8a41ac291aff3689efae0b11a9c51a2db30ef33
Reviewed-on: https://dart-review.googlesource.com/34924
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-01-16 23:08:01 +00:00
Alexander Thomas 93d8c9fe2a [gardening] Update status for passing tests on VM Kernel debug 
TBR=whesse@google.com

Bug:
Change-Id: Iba2ad6e88d9e32f2c83dc22440404bf778120076
Reviewed-on: https://dart-review.googlesource.com/34941
Reviewed-by: Alexander Thomas <athom@google.com>
 2018-01-16 18:49:53 +00:00
Alexander Thomas f152e19dbe [gardening] Correct status for vm-kernel-precomp 
Change-Id: I1f683802142ae6a041ebe9385a3f65262a9b9158
Reviewed-on: https://dart-review.googlesource.com/34901
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-16 17:27:39 +00:00
Erik Ernst d09b922203 Added noSuchMethod forwarding test and adjusted status files 
Change-Id: Ifee4f2e8810efa1fd5b08fd7544b71a3d27ff263
Reviewed-on: https://dart-review.googlesource.com/34800
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-01-16 15:52:12 +00:00
Alexander Thomas 27ebef64d4 [infra] Add VM Kernel Windows x64 builders 
Bug: https://github.com/dart-lang/sdk/issues/31707
Change-Id: Ie56f4c6f78c9b7c27fc4f587857e412db3e8f358
Reviewed-on: https://dart-review.googlesource.com/33960
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-16 15:39:03 +00:00
Martin Kustermann 09035067fe Update status files to get sim* builders green 
Change-Id: Ib3e6b8da4ee59d83da978e44a7611388f974aa23
Reviewed-on: https://dart-review.googlesource.com/34662
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-01-16 10:04:32 +00:00
Vyacheslav Egorov ff008ca37a [vm/kernel/async] Use proper type argument when createing async* controller. 
Change-Id: I40e5d2d933b83a24c9d8177437fb6df1f21b5cc1
Reviewed-on: https://dart-review.googlesource.com/34741
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-15 22:06:30 +00:00
Martin Kustermann 0bc46de838 [VM] Support spawning isolates when the main isolate was spawned from a Kernel IR file 
Issue https://github.com/dart-lang/sdk/issues/31698

Change-Id: Ifc6662a3fd56245c10f5d924f771ef85ed9b222c
Reviewed-on: https://dart-review.googlesource.com/34742
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-01-15 17:51:54 +00:00
William Hesse c989cdd6ca Update status for VM kernel precompiled mode 
This fixes two incorrect status changes in commit 473eb4be4.
There were duplicate lines for some tests and the wrong line
was removed for two of them.

TBR: sjindel@google.com
Change-Id: I518d444d0717f6e6b76130dd284746d6f100c54a
Reviewed-on: https://dart-review.googlesource.com/34700
Reviewed-by: William Hesse <whesse@google.com>
 2018-01-15 16:02:43 +00:00
William Hesse 473eb4be4b Update status for Dart kernel precompiled VM tests after commit 42a6399 
Follow-up to https://dart-review.googlesource.com/c/sdk/+/34400

Change-Id: I6d07c4a0023d4a5fc227d01fe83943f7389c9ff2
Reviewed-on: https://dart-review.googlesource.com/34587
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: William Hesse <whesse@google.com>
 2018-01-15 14:38:40 +00:00
Erik Ernst bf5b9087d2 Adjusted language_2/void_type_usage_test.dart 
Adjusted return types such that `return` test cases test the intended
situation; added new `testReturnToVoid` function to test the case which
was previously overlooked (that is, "`return e;` where `e` has type
void is OK in void function).

Change-Id: I9859b5ff33f0ac5d1e33d16f40fe57a6c1a7b4d0
Reviewed-on: https://dart-review.googlesource.com/34582
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-01-15 11:46:06 +00:00
Samir Jindel 42a639973d [kernel] Support for partial tearoff type application operator in the VM, take 3. 
The original change is available in patchset 1.
The changes since then are just status file updates.

Change-Id: I0c45c4b09a187bdd60c6a38bf23f6b7a0cf80c97
Reviewed-on: https://dart-review.googlesource.com/34400
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-15 11:24:11 +00:00
Paul Berry 45b02f8216 Use the new spec for Future flattening for type inference 
Change Fasta type inference and Kernel type checking to use the new
definition for Future flattening, which is really unwrapping (peeling
off one layer of Future or FutureOr).  Use this for inferring types of
`await` expressions and return types from `async` functions.

Ensure that we are using the same notion of flattening for inference
and checking.  (Maybe it was a red flag that we weren't.)

This fixes await_test so that it produces a runtime error rather than
a compile time error - see #31541.

A similar change will need to be made to the analyzer - see #31887.

Change-Id: I7d936e9788969a48fdc216628eaa793389fb5e30
Reviewed-on: https://dart-review.googlesource.com/34504
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-01-15 07:09:36 +00:00
Régis Crelier 0c2793b3db [VM runtime] Implement support for _extractTypeArguments in the VM (fixes #31805). 
Update status files.

This cl includes implementing these two features on all platforms:
1) Support calling generic functions via DartEntry::InvokeFunction().
2) Support native generic functions. These are currently allowed, but type
   arguments are ignored, and therefore not accessible from the C++ side.

Change-Id: Id39e8ca46c2ba1ba3d46946c16712a8572ff64ea
Reviewed-on: https://dart-review.googlesource.com/34023
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-01-12 21:32:20 +00:00
Jens Johansen 68c054d27f Revert "[kernel] Unrevert "Support for the partial tearoff type application operator in VM."" 
This reverts commit 784ee768d8.

Reason for revert: Turns many kernel bots red.

Original change's description:
> [kernel] Unrevert "Support for the partial tearoff type application operator in VM."
> 
> The original revision is available in the first patchset.
> 
> Change-Id: I579b4b85a19ac17088eed050680a46df7ffc5c0a
> Reviewed-on: https://dart-review.googlesource.com/34102
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,sjindel@google.com

Change-Id: I7262f9b578bf9991f1e79aacb88c446950c79bc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/34340
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-12 08:44:05 +00:00
Régis Crelier 0f08aababa [VM parser] Fix look-ahead parsing of void as type argument. 
This is part of implementing generalized void, see #30516.
Add regression test.
Update status files.

Change-Id: I0b4730734238b4dc463ddd7835e30ea8a2bd4300
Bug:
Reviewed-on: https://dart-review.googlesource.com/34224
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-01-11 23:42:54 +00:00
Paul Berry d57633ce71 Revert "Fix handling of forwarding semi-stubs in the front end." 
This reverts commit 379801ed11.

Reason for revert: Broke buildbots

Original change's description:
> Fix handling of forwarding semi-stubs in the front end.
> 
> See #31649 for more details about forwarding semi-stubs.
> 
> Change-Id: Iaf1153be5ac7f66503b93a362b66ac9585462f6c
> Reviewed-on: https://dart-review.googlesource.com/33820
> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Paul Berry <paulberry@google.com>

TBR=paulberry@google.com,scheglov@google.com,dmitryas@google.com,sjindel@google.com,kmillikin@google.com

Change-Id: I6b37f1143183e889a5b52cb8b0a5427991b306c0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/34280
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-11 22:05:09 +00:00
Samir Jindel 784ee768d8 [kernel] Unrevert "Support for the partial tearoff type application operator in VM." 
The original revision is available in the first patchset.

Change-Id: I579b4b85a19ac17088eed050680a46df7ffc5c0a
Reviewed-on: https://dart-review.googlesource.com/34102
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-11 21:37:38 +00:00
Samir Jindel 22c8aa0eba [kernel] Remove unnecessary RuntimeError status. 
Change-Id: I9d15ff227de3d3136ab870de320ad8166a22cfd9
Reviewed-on: https://dart-review.googlesource.com/34161
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-01-11 18:15:08 +00:00
Paul Berry 379801ed11 Fix handling of forwarding semi-stubs in the front end. 
See #31649 for more details about forwarding semi-stubs.

Change-Id: Iaf1153be5ac7f66503b93a362b66ac9585462f6c
Reviewed-on: https://dart-review.googlesource.com/33820
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-01-11 16:20:58 +00:00
Martin Kustermann 0ea33d4283 Revert "[kernel] Support for the partial type application operator in the VM." 
This reverts commit 4f265395e0.

Reason for revert: A lot of failing precompilation builders.

Original change's description:
> [kernel] Support for the partial type application operator in the VM.
> 
> Change-Id: Ieaf5d936676a6e755dab69d70105dcce0bcbfdb6
> Reviewed-on: https://dart-review.googlesource.com/32540
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=kustermann@google.com,sjindel@google.com,regis@google.com

Change-Id: Iac6a9fe7fb7467cab3818da99043d310d1981c67
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/33940
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-01-10 17:05:39 +00:00
Samir Jindel 4f265395e0 [kernel] Support for the partial type application operator in the VM. 
Change-Id: Ieaf5d936676a6e755dab69d70105dcce0bcbfdb6
Reviewed-on: https://dart-review.googlesource.com/32540
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-01-10 13:57:28 +00:00
Dmitry Stefantsov fd821941ad Update status file: some tests now pass due to recent changes 
Change-Id: Iee6dd4337b2773da1ab7f8d7adf28fdcb593deb5
Reviewed-on: https://dart-review.googlesource.com/33762
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-10 09:24:20 +00:00
Emily Fortuna bd6cbd1ec7 Fix kernel precompiled test status after assertion test change. 
Bug:
Change-Id: I9770f3eae7bc751b9a74321be051a15a56907a19
Reviewed-on: https://dart-review.googlesource.com/33146
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-01-08 22:44:12 +00:00
Aske Simon Christensen ae068aaabe Mark failures in debug mode due to missing check in Fasta. 
Change-Id: If5042674e02bd26c97103aed82922305404fa70d
Reviewed-on: https://dart-review.googlesource.com/32980
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2018-01-08 17:39:23 +00:00
Martin Kustermann 391955feb6 [Gardening] Mark language_2/duplicate_implements_impl/{03,04} as passing 
Change-Id: I5e478c24a648fde5e374898158543e65ee2360c6
Reviewed-on: https://dart-review.googlesource.com/32768
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-01-08 16:35:29 +00:00