dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

676 Commits

Author SHA1 Message Date
Martin Kustermann 2ff5f8cfcb [VM] Report an error when accessing constructor parameters inside a constructor invocation 
Closes https://github.com/dart-lang/sdk/issues/33604

Change-Id: I84034499de43ea300b278f2f922bc73c565e8bcc
Reviewed-on: https://dart-review.googlesource.com/61934
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-06-25 12:05:53 +00:00
Vyacheslav Egorov f9a11ec380 [gardening] Mark language_2/const_constructor_nonconst_param_test/01 failing in dartkp 
Bug: https://github.com/dart-lang/sdk/issues/33604
Change-Id: Ib3f5196f529ea91f6c55914cc697270a80e0b2d9
Reviewed-on: https://dart-review.googlesource.com/61928
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-25 06:39:22 +00:00
Alexander Markov eafa9ae4b6 [vm/kernel] Fix StreamingConstantEvaluator to handle non-const variables 
Fixes https://github.com/dart-lang/sdk/issues/33214

Change-Id: I7991b537204f160b2991abf9995685e4cae69f88
Reviewed-on: https://dart-review.googlesource.com/61682
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-22 17:16:45 +00:00
Dmitry Stefantsov 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds 
Fixes #33208, #31810, #32416, #32417

Bug: http://dartbug.com/33208
Bug: http://dartbug.com/31810
Bug: http://dartbug.com/32416
Bug: http://dartbug.com/32417
Change-Id: Id178daf35be459fdefe04091bf929b5743d89e81
Reviewed-on: https://dart-review.googlesource.com/41264
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-06-22 13:41:55 +00:00
Dmitry Stefantsov 10641cbf42 Update status files after 52b2a869bc 
Change-Id: Icf921a4159d296ee86bfcee61deee06259886085
Reviewed-on: https://dart-review.googlesource.com/61561
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-21 14:21:33 +00:00
Dmitry Stefantsov 52b2a869bc Update some noSuchMethod based tests to the currently desired behavior. 
Fixes #33498

Bug: http://dartbug.com/33498
Change-Id: I4a62a830cc8993748da816967753a8ce9a025d46
Reviewed-on: https://dart-review.googlesource.com/61500
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2018-06-21 12:54:42 +00:00
Dmitry Stefantsov 71ac67aed1 [kernel] Recognize noSuchMethod forwarders in class hierarchy analysis 
Fixes #33517

Bug: http://dartbug.com/33517
Change-Id: Icc357724d83197a630e9c6b4dad38b509343f0b1
Reviewed-on: https://dart-review.googlesource.com/61261
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-06-21 10:24:12 +00:00
asiva 34bbb1da30 [Gardening] Move status line to the correct section. 
Change-Id: Id17768278ac3671667440a01a13da26621aa1b37
Reviewed-on: https://dart-review.googlesource.com/61309
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-06-20 19:49:42 +00:00
asiva 075027b130 Added super_no_such_method5_test also to the issue list for 33517 
Change-Id: I9641a90ee2601422f53574014782f3263a8ede02
Reviewed-on: https://dart-review.googlesource.com/61303
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-06-20 17:17:46 +00:00
Dmitry Stefantsov a3a8d8bbd5 [VM][kernel] Don't mix in noSuchMethod forwarders 
Bug: http://dartbug.com/33380
Change-Id: I57f85e1e33105c4ffcb6a9c8a970cfbc42318936
Reviewed-on: https://dart-review.googlesource.com/60924
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-06-20 12:57:41 +00:00
Alexander Markov 437b492042 [gardening] Update status for reload-kernel bots 
Change-Id: Ic0b4e9917e43d673ce0781ec1873804011cb0252
Reviewed-on: https://dart-review.googlesource.com/61040
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-19 19:02:46 +00:00
Martin Kustermann f3960a0111 Fix language_2/vm/optimized_guarded_field_isolates_test 
This fixes some hot reload/rollback builders.

Issue https://github.com/dart-lang/sdk/issues/31402

Change-Id: I6f9f3c80f1f70b0f7084bd0c162affa125f43ba1
Reviewed-on: https://dart-review.googlesource.com/60963
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-19 15:48:47 +00:00
Martin Kustermann e496efb611 [VM] Adjust status file after 6db5f38d4e 
Change-Id: Ibdf04c5cc2b60858f108199e5cd18b6c4a6fb19f
Reviewed-on: https://dart-review.googlesource.com/60962
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-19 15:31:41 +00:00
Dmitry Stefantsov 6db5f38d4e [fasta] Don't generate noSuchMethod forwarders in abstract classes 
Bug: http://dartbug.com/33482
Change-Id: I4c9b2e9a43fdcd37238ede5814b2ad471f7b2c4d
Reviewed-on: https://dart-review.googlesource.com/60847
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2018-06-19 14:18:33 +00:00
Martin Kustermann 856c7c67ea Skip standalone_2 on !strong configurations (for JIT / AOT VM) 
This should make vm-precomp-win-simarm64-2-4-be go green.

Change-Id: I9d3f54312751ff0c00a40078c71e72e11048e3e9
Reviewed-on: https://dart-review.googlesource.com/60922
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-06-19 13:07:13 +00:00
Peter von der Ahé bd94de8e48 Use dynamic to fix string_interpolate_test 
Change-Id: I48f7b1127e5c61f9c399ac32d7118adc110a6519
Reviewed-on: https://dart-review.googlesource.com/60846
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-06-19 10:58:45 +00:00
Martin Kustermann b172a42881 [VM] Catch errors for integer operations in kernel2kernel constant evaluator 
Issue https://github.com/dart-lang/sdk/issues/33481

Closes https://github.com/dart-lang/sdk/issues/33469

Change-Id: I7ca9825a0aa5f062732a759b4dd116e716a0d1b3
Reviewed-on: https://dart-review.googlesource.com/60580
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-06-19 10:28:05 +00:00
Johnni Winther c84a9f46b2 Recompute ClassHierarchy after adding noSuchMethod forwarding stubs 
Change-Id: Idcd1ba9e43a917a526d0687be8e5b84a267042a2
Reviewed-on: https://dart-review.googlesource.com/60422
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-06-18 08:12:06 +00:00
Aske Simon Christensen f20672e00a Parse name of factory as method name instead of constructor reference. 
Report an error when a factory constructor has type parameters.

Report a better error than the old "couldn't find constructor" or
"illegal method name" when the name of a constructor does not match
the name of the enclosing class.

Fixes https://github.com/dart-lang/sdk/issues/31196

Change-Id: Ie46a5b4cbe07ba05ce2936e1f8f9ca2cad0208f7
Reviewed-on: https://dart-review.googlesource.com/57620
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-06-11 09:55:24 +00:00
Samir Jindel b45482a989 [kernel/vm/precomp] Update status file for duplicate_interface_implements_test/01. 
Change-Id: I27ddf1ee2d53033f376c8404c5aec7dac0d5275c
Reviewed-on: https://dart-review.googlesource.com/59620
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-06-10 16:53:03 +00:00
Bob Nystrom 67525aef37 Convert a batch of negative tests to multitests. 
Change-Id: I380c12ef633ec8c40de982782623d3e3659a4834
Reviewed-on: https://dart-review.googlesource.com/57162
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-06-08 19:43:34 +00:00
Martin Kustermann a4af44b470 [VM] Do not invoke any functions during AOT compilation 
In Dart 2.0 AOT compilations we give dart_bootstrap/gen_snapshot the
fully linked Kernel IR file (*.dill file) with evaluated constants.

This CL will make the 2.0 AOT compiler

   * only accept .dill files as input
   * no longer invoke various functions during startup
   * no longer start the VM service
   * hit unreachable in DartEntry::InvokeFunction()

Issue https://github.com/dart-lang/sdk/issues/33185

Change-Id: Iaba44386633856774a0c29be043780b9b262df0f
Reviewed-on: https://dart-review.googlesource.com/56520
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
 2018-06-06 10:56:10 +00:00
Vyacheslav Egorov 7b972a653b [vm/linearscan] Account for definitions with no SSA name when processing PairLocation outputs. 
ToSecondPairVreg(kNoVirtualRegister) should be kNoVirtualRegister not 0.

Revert fe28a2939a which updated statuses for
crashing tests.

Fixes https://github.com/dart-lang/sdk/issues/33329

Bug: https://github.com/dart-lang/sdk/issues/33329
Change-Id: I48e95bcb6f95555ec9ac51adc1f61619fbf40139
Reviewed-on: https://dart-review.googlesource.com/58461
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-06-05 17:41:34 +00:00
Alexander Markov fe28a2939a [Test Status] filter crashes for #33329 
Issue: https://github.com/dart-lang/sdk/issues/33329
Change-Id: I16a9241631b081cf9db97d7a6065ed805daaac95
Reviewed-on: https://dart-review.googlesource.com/58420
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-06-04 23:57:19 +00:00
Alexander Thomas a9257d05fb [vm] Prepare status files for dartk reload/rollback builders (#33126) 
Change-Id: I954debb9f258eb94de227f6772ff08b53daba322
Reviewed-on: https://dart-review.googlesource.com/57623
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-06-04 11:30:21 +00:00
Aske Simon Christensen 4fb6395058 Report error when a constructor has type parameters. 
Fixes https://github.com/dart-lang/sdk/issues/30678
Fixes https://github.com/dart-lang/sdk/issues/33110

Change-Id: I7d3fcd56d408fefce7a0b43ffd68cc5427eb0940
Reviewed-on: https://dart-review.googlesource.com/57507
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-06-01 12:48:09 +00:00
Dmitry Stefantsov 00f75adfaf Emit a compile-time error on incorrect types of initializing formals 
Fixes #32526.

Bug: http://dartbug.com/32526
Change-Id: I1e4738937ade7592f7fb1d16bf485ad4ccd077c2
Reviewed-on: https://dart-review.googlesource.com/46801
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-31 13:31:42 +00:00
Alexander Thomas 2a3d1dc9ed [vm] Prepare status for app_jitk builders (#33126) 
Change-Id: Iec5347b5f091b9fd6ff3c24047b011527f8b08ee
Reviewed-on: https://dart-review.googlesource.com/56802
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-05-29 11:43:25 +00:00
Lasse R.H. Nielsen a4494a7fb2 Make mixin and interface built-in identifiers. 
Fixes #33113

Bug: http://dartbug.com/33113
Change-Id: I4b0b7c9d82ae9df6a7e9f71168ca981c62c7a2f1
Reviewed-on: https://dart-review.googlesource.com/55222
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-18 09:57:17 +00:00
Martin Kustermann 510669a0b4 [VM] Address uncovered issues, mark test as passing 
Change-Id: Ie2c5eb055ce6138952af145ce6fdb972c057bd16
Reviewed-on: https://dart-review.googlesource.com/55780
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-05-17 19:21:35 +00:00
Martin Kustermann 775eeece8a [VM] Enable kernel2kernel constants evaluation in AOT for the VM. 
Change-Id: Iff40aaf464f870235c9a15c4ee33385256e58023
Reviewed-on: https://dart-review.googlesource.com/55461
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-05-16 16:11:22 +00:00
Ryan Macnak a5c11d7d03 [vm] Remove Dart_ReadKernelBinary, take 2. 
Update status for simulators, which the test harness invokes with DIL files instead of source files.

Change-Id: I8444ad7e17a0a71a1ce3c0021487397baa1c3e65
Reviewed-on: https://dart-review.googlesource.com/54622
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-05-14 20:58:08 +00:00
Aske Simon Christensen f5130108ea Some triage of missing compile-time errors in Fasta 
Change-Id: Ia7601f7296e2da66ca234a94c57105c366d94a06
Reviewed-on: https://dart-review.googlesource.com/52800
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Karl Klose <karlklose@google.com>
 2018-05-14 10:18:17 +00:00
Jens Johansen 22c80a4e14 Test for constructor having type parameter 
Change-Id: I766ac78f087b3396c5bf09d92fce55b381cda1ef
Reviewed-on: https://dart-review.googlesource.com/54391
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-05-14 09:16:17 +00:00
Zach Anderson 46ab040e58 Revert "[vm/kernel] Enable kernel2kernel "constants" transformation in AOT mode (after running TFA)" 
This reverts commit 039e8a1755.

Reason for revert:
Blocks the roll into Flutter.
See https://github.com/dart-lang/sdk/issues/33095

Original change's description:
> [vm/kernel] Enable kernel2kernel "constants" transformation in AOT mode (after running TFA)
> 
> This CL also uses the newer `onProblem` error reporting mechanism, which supports contexts.
> 
> The errors by the constant evaluator are formatted e.g. like this:
> 
>     .../language_2/compile_time_constant_o_test_01.dart:14:8: Error: Duplicate keys are not allowed in constant maps (found duplicate key "StringConstant(foo)").
>       "foo": 499
>        ^
>     .../language_2/compile_time_constant_o_test_01.dart:32:24: Context: While analyzing:
>       Expect.identical(m1, m3);
> 
> Change-Id: I463416e14686e218b0f08903bd6aa0bca7392260
> Reviewed-on: https://dart-review.googlesource.com/53021
> Commit-Queue: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Alexander Markov <alexmarkov@google.com>

TBR=vegorov@google.com,kustermann@google.com,alexmarkov@google.com,askesc@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1af0200dcb0aef03c7bd9ba3b5aead1565f05708
Reviewed-on: https://dart-review.googlesource.com/54720
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Todd Volkert <tvolkert@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2018-05-11 17:50:46 +00:00
Ryan Macnak 407872b9e5 Revert "[vm] Remove Dart_ReadKernelBinary." 
This reverts commit 2998c32951.

Reason for revert: Failures with kernel + simulators

Original change's description:
> [vm] Remove Dart_ReadKernelBinary.
> 
>  - Fix const-ness of Dart_FileReadCallback and callers.
>  - Fix leak on read error in DartUtils::FileRead.
> 
> This is progress towards sharing kernel memory on Fuchsia.
> 
> Bug: https://github.com/dart-lang/sdk/issues/32618
> Change-Id: I47f8b224905d6a105a5ca0ab2ee4ab6a42b5e342
> Reviewed-on: https://dart-review.googlesource.com/47102
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=aam@google.com,rmacnak@google.com,asiva@google.com

Change-Id: Ibb636b817de1629a062fe0a6ef9462a2fef669ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/32618
Reviewed-on: https://dart-review.googlesource.com/54560
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-05-10 01:36:39 +00:00
Ryan Macnak 2998c32951 [vm] Remove Dart_ReadKernelBinary. 
- Fix const-ness of Dart_FileReadCallback and callers.
 - Fix leak on read error in DartUtils::FileRead.

This is progress towards sharing kernel memory on Fuchsia.

Bug: https://github.com/dart-lang/sdk/issues/32618
Change-Id: I47f8b224905d6a105a5ca0ab2ee4ab6a42b5e342
Reviewed-on: https://dart-review.googlesource.com/47102
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-05-10 00:35:37 +00:00
Karl Klose 2daa5610ac Add more issue numbers to fasta status file 
R=dmitryas@google.com

Change-Id: Ib04869c94b2a695ed1ac65b3f50adff84f84ab99
Reviewed-on: https://dart-review.googlesource.com/54231
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-09 11:18:53 +00:00
Karl Klose 41eb5ddfdc Add some issue numbers to fasta status file 
R=dmitryas@google.com

Change-Id: I8091190fbd2ea3eff399b4b568cfb62698cbf954
Reviewed-on: https://dart-review.googlesource.com/54220
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2018-05-09 10:16:22 +00:00
Martin Kustermann 039e8a1755 [vm/kernel] Enable kernel2kernel "constants" transformation in AOT mode (after running TFA) 
This CL also uses the newer `onProblem` error reporting mechanism, which supports contexts.

The errors by the constant evaluator are formatted e.g. like this:

    .../language_2/compile_time_constant_o_test_01.dart:14:8: Error: Duplicate keys are not allowed in constant maps (found duplicate key "StringConstant(foo)").
      "foo": 499
       ^
    .../language_2/compile_time_constant_o_test_01.dart:32:24: Context: While analyzing:
      Expect.identical(m1, m3);

Change-Id: I463416e14686e218b0f08903bd6aa0bca7392260
Reviewed-on: https://dart-review.googlesource.com/53021
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-05-09 09:00:02 +00:00
Kevin Millikin 8f6c6c2a8e Implement some missing override checking 
Detect the following conflicts:

  - declaring a method and inheriting a setter or getter with the same
    name

  - declaring a getter or setter and inheriting a method with the same
    name

  - inheriting both a method and a getter or setter (or both) with the
    same name

Declaring a method and a getter with the same name is already
detected.  Declaring a method and a setter with the same name is not
yet detected, because it should be done in the same way as
method/getter declaration conflicts.

Bug: https://github.com/dart-lang/sdk/issues/32613
Change-Id: I2d168894453d7032372388faa0872d3fc7aa9ef7
Reviewed-on: https://dart-review.googlesource.com/53803
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-05-08 13:40:51 +00:00
Jenny Messerly 3002e47e36 cleanup language_2 and corelib_2 tests that import dart:mirrors 
Preserves tests that didn't really need mirrors, and moves tests for
mirror functionality into lib_2/mirrors tests.

Change-Id: Ie16dee1a4b508e3f14da53499f57c5dae2d1e513
Reviewed-on: https://dart-review.googlesource.com/49624
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-07 23:50:56 +00:00
Samir Jindel 772c9bb5f3 [vm/kernel] Re-land partial instantiation of local functions. 
This change has been adjusted to account for the recent fix to Internal_prependTypeArguments.

Reviewed-on: https://dart-review.googlesource.com/50980
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Change-Id: I434a42578b91f0930b088c4d264d882c3ef5b4a3
Reviewed-on: https://dart-review.googlesource.com/53801
 2018-05-05 21:26:37 +00:00
William Hesse c8c994b26d Revert "Add some status entries for crashing tests related to issue" 
This reverts commit 05a7b6e05f.

Reason for revert: This should have been reverted when the CL causing the crashes was reverted, in 2765fcf2ae
 (https://dart-review.googlesource.com/c/sdk/+/53540)

It should be relanded when the related CL is landed, unless these test crashes are fixed.

Original change's description:
> Add some status entries for crashing tests related to issue
> https://github.com/dart-lang/sdk/issues/33029
> 
> Change-Id: I3349040098bd33906b42b007b1a331d413c673db
> Reviewed-on: https://dart-review.googlesource.com/53526
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=alexmarkov@google.com,asiva@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Iab3265f816f2244920e8debbb872a152911c0ec4
Reviewed-on: https://dart-review.googlesource.com/53780
Reviewed-by: William Hesse <whesse@google.com>
 2018-05-04 11:29:46 +00:00
Paul Berry 8f52be2282 Don't infer types when there's an irreconcilable type mismatch. 
Also fix the type inference algorithm so that when it explores
multiple alternatives (as a result of the use of FutureOr<>), if one
alternative generated some constraints but failed to produce a match,
it rewinds those constraints and tries the other alternative.
(Previously, it erroneously assumed that if any constraints were
generated, the alternative matched successfully).

Also add unit tests to verify the proper operation of the subtype
match algorithm.

Fixes #32305.

Change-Id: I060b5d6d5247a68d2b27bba78819bae172e43d97
Reviewed-on: https://dart-review.googlesource.com/53685
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-05-03 23:27:14 +00:00
Alexander Aprelev e6d7d67f4b Revert 4f18af12c7 as it causes test breakages. 
Bug: https://github.com/dart-lang/sdk/issues/33040
Change-Id: I09aac75e440876111a2c91aaf728ba514d7d5c6b
Reviewed-on: https://dart-review.googlesource.com/53688
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2018-05-03 21:11:44 +00:00
asiva 05a7b6e05f Add some status entries for crashing tests related to issue 
https://github.com/dart-lang/sdk/issues/33029

Change-Id: I3349040098bd33906b42b007b1a331d413c673db
Reviewed-on: https://dart-review.googlesource.com/53526
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-05-03 00:58:44 +00:00
Bob Nystrom bed71b7776 Migrate and clean up the prefix negative tests. 
Since there were already non-negative tests with the same numbers, I
gave them meaningful names.

Merged a couple of tests into the same file when it made sense since
multitests let us do that.

Deleted prefix1_negative_test, because it essentially tested only that
a random identifier does not resolve, which is not particularly related
to prefixes.

Change-Id: I91718f6df5126f123d9a8ea3abbc6898797db2db
Reviewed-on: https://dart-review.googlesource.com/52985
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2018-05-02 16:05:25 +00:00
Aske Simon Christensen 011676641a Ignore forwarding stubs when checking for missing implementations. 
Fixes https://github.com/dart-lang/sdk/issues/33009

Change-Id: If131193014d99430a0b1934d2f8890cd4f123934
Reviewed-on: https://dart-review.googlesource.com/53203
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-05-01 15:44:24 +00:00
Dmitry Stefantsov 5af05d407d [fasta] Report type argument number mismatch during outline building 
Change-Id: I1c1f22f3117ccbfc8620b3b0459bc96ed1ad1bdf
Reviewed-on: https://dart-review.googlesource.com/51128
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-04-30 13:01:15 +00:00