dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

676 Commits

Author SHA1 Message Date
Florian Loitsch e92c759e0b Migrate test block 129. 
Change-Id: I36f6a3f007862a7c5d2e8f304cb6730cdc9b4610
Reviewed-on: https://dart-review.googlesource.com/12289
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-11 08:59:49 +00:00
pq 0e347e2c18 Migrate test block 151 to Dart 2.0. 
Bug:
Change-Id: I08178cf2d81a76827e6a1433f3b542c5615f1c89
Reviewed-on: https://dart-review.googlesource.com/12500
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-10 21:17:31 +00:00
Jaime Wren 5b01202e3a Migrate test block 64 
Change-Id: I4c72d401ea22c4c46054924a971cf8cd6ed92575
Reviewed-on: https://dart-review.googlesource.com/12420
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-10-10 18:36:56 +00:00
Janice Collins e166ab3e2b Migrate test block 160 to Dart 2.0. 
Successfully migrated 7 tests. Need manual work on 6 tests:
- language_2/try_catch_test.dart:
  (TODO) Merge from language/try_catch_test.dart into this file.
- language_2/type_argument_in_super_type_test.dart:
  (TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_check_const_function_typedef2_test.dart:
  (TODO) Fix code that mentions "checked" mode.
- language_2/type_checks_in_factory_method_test.dart:
  (TODO) Ensure code that checks for a TypeError uses 2.0 semantics.
- language_2/type_conversion_ssa_test.dart:
  (TODO) Fix code that mentions "checked" mode.
- language_2/type_error_test.dart:
  (TODO) Merge from language/type_error_test.dart into this file.
  (TODO) Ensure code that checks for a TypeError uses 2.0 semantics.


Bug:
Change-Id: I43901890540efcf55da13d013571ce91979cbb64
Reviewed-on: https://dart-review.googlesource.com/11142
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-10 15:55:32 +00:00
Florian Loitsch 5b01aaa4e5 Migrate test block 147. 
Change-Id: I811e8dd4c44d42e6d0ffc94635c6922a21627c46
Reviewed-on: https://dart-review.googlesource.com/12297
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-10 11:25:03 +00:00
Jaime Wren 31e5cab243 Migrate test block 62 
- negative tests merged into non-negative tests
- lots of factory tests

Change-Id: I825e3ab6153f0dce243c3b8f1c4d223ab8ec5f9b
Reviewed-on: https://dart-review.googlesource.com/12126
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-10-09 20:00:01 +00:00
Ben Konyi afdf5281c9 Migrated test block 40 + 41 to Dart 2.0. 
Bug:
Change-Id: I412da79f3765c4ddf8c621ef290b2665d4d54a67
Reviewed-on: https://dart-review.googlesource.com/11647
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-07 00:11:46 +00:00
Régis Crelier 98a253186c [VM parser] Disallow implicit reference to 'this' in assertion initializer (fixes #29784). 
Add regression test.
Adjust various status files.

Change-Id: I97bdf960260f0a13c2cfc6d95299d67a44c2238d
Reviewed-on: https://dart-review.googlesource.com/11247
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-10-06 18:40:14 +00:00
pq 6f58da2ef8 Migrate test block 138 to Dart 2.0. 
Bug:
Change-Id: I9050869dc3365d122cf3c8754b39859d20e20902
Reviewed-on: https://dart-review.googlesource.com/10161
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-06 17:33:58 +00:00
Ben Konyi 1d53f0a1cc Migrated test block 38 to Dart 2.0. 
Single test with no changes, although it still uses unittest.

Bug:
Change-Id: I0111814db289f512950d5e83471dab546867553f
Reviewed-on: https://dart-review.googlesource.com/11648
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-05 23:53:13 +00:00
Jens Johansen 5fff3689d6 [kernel] Report error instead of crashing in constant evaluator. 
Change-Id: I2c116cdc6add54194d0641631b3603313603c89e
Reviewed-on: https://dart-review.googlesource.com/11442
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 12:13:03 +00:00
Florian Loitsch 354a4ec420 Migrate test block 149. 
Change-Id: I6529a9ac0ad6557dc751be5c6f7bf14c9d45f909
Reviewed-on: https://dart-review.googlesource.com/11400
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 10:36:11 +00:00
Jakob Roland Andersen d7c5584976 Migrate test block 143. 
Change-Id: I843937de387436e07b289ccc35efa6776d59c142
Reviewed-on: https://dart-review.googlesource.com/11280
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 07:27:28 +00:00
Florian Loitsch 3b64211ab2 Migrate test block 127. 
Change-Id: I05a4baa3c641d71ccee1fce1e7f680f3fd9f42fc
Reviewed-on: https://dart-review.googlesource.com/9041
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-05 06:43:21 +00:00
Florian Loitsch ec69c47c12 Migration of test block 126. 
Change-Id: I8bbccbfae0194f246b8305ea4ca7bb02b5b6a9ec
Reviewed-on: https://dart-review.googlesource.com/7546
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
 2017-10-04 21:38:10 +00:00
Janice Collins 3bed0647a0 Migrate block 162 to Dart 2.0. 
Based heavily on https://codereview.chromium.org/3007803002, but built from scratch with the updated migration script.

Change-Id: I52ecd5dd97a73ec2f5fc524de532c5605c5d0a7d
Reviewed-on: https://dart-review.googlesource.com/9360
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-10-03 17:47:59 +00:00
Samir Jindel 195c62ff0c [kernel] Begin reducing type erasure. 
1. We no longer remove type parameters on functions.
2. We no longer remove type arguments at call sites.
3. We allow non-captured function type parameters to be used outside closures. 

Bug:
Change-Id: I116ec54c90b04be90e1157042c22797e57a7c51c
Reviewed-on: https://dart-review.googlesource.com/9342
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-03 14:33:30 +00:00
Jens Johansen 2e75b6cce9 [kernel] Fix closure in for loop 
In kernel the loop level wasn't set correctly for for loops, resulting
in the loop variable not always being fresh.

Examples:

```
  // Capture the loop variable, ensure we capture the right value.
  for (int i = 0; i < 10; i++) { if (i == 7) f = () => "i = $i"; }

  print(f());
  // There is only one instance of k. The captured variable continues to change.
  int k;
  for (k = 0; k < 10; k++) { if (k == 7) f = () => "k = $k"; }
  print(f());
```

resulted in
i = 10
k = 10

(i.e. it's wrong)

whereas

```
  // Capture the loop variable, ensure we capture the right value.
  for (int i = 0; i < 10; i++) { if (i == 7) { f = () => "i = $i"; } }
  print(f());
  {
    // There is only one instance of k. The captured variable continues to change.
    int k;
    for (k = 0; k < 10; k++) { if (k == 7) { f = () => "k = $k"; } }
    print(f());
  }
```

resultet in

i = 7
k = 10

(i.e. it's correct).

Now both examples produce the correct result.

Change-Id: I1fb4c888c6a0eaa690f62226e093508992b33ed4
Reviewed-on: https://dart-review.googlesource.com/9961
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-03 07:56:13 +00:00
Jens Johansen 471d92dfe4 [kernel] Get class type arguments correctly 
Previously we got the length of the class' type_parameters().
Now instead we use the class' NumTypeArguments().

Bug:
Change-Id: I3807443765e4926efc17eba54d3bf4f50e8e30c6
Reviewed-on: https://dart-review.googlesource.com/9482
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-10-03 07:26:28 +00:00
Régis Crelier b1dd843fd4 Add test verifying that generic function types are disallowed as type argument. 
Change-Id: I76d4fd13f0370d7d42b17aa9e63a391b60a89463
Reviewed-on: https://dart-review.googlesource.com/9369
Commit-Queue: Régis Crelier <regis@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-02 18:50:37 +00:00
Ben Konyi 876bb0c494 Migrated test block 130 to Dart 2.0. 
Slightly tricky block. Many map_literal* tests were modified as they were creating maps with
multiple instances of the same key.

Bug:
Change-Id: I5dcaa458ee8f68a4934950bb32229ff92100149b
Reviewed-on: https://dart-review.googlesource.com/9064
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-29 04:24:02 +00:00
Ben Konyi 5bb98ebc33 Migrated test block 161 to Dart 2.0. 
This block contained a lot of static type warnings and took a lot of
status file wrangling to get right.

Bug:
Change-Id: I037402a31f978af15716964c8ff5192036df4276
Reviewed-on: https://dart-review.googlesource.com/7440
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-28 17:15:51 +00:00
Jaime Wren d18c5c3620 Migrated test block 63 to Dart 2.0 
Change-Id: I35b3ceb1ac2aa7fc4e26a28ff814bccba6bbb004
Reviewed-on: https://dart-review.googlesource.com/7200
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-28 16:06:08 +00:00
Jaime Wren 3d020fa91e Migrated test block 60 to Dart 2.0, take 2 
Original review at https://dart-review.googlesource.com/c/sdk/+/7160

Change-Id: If2aeecec04640bee3b622d97c8fcdd6cb1bdd369
Reviewed-on: https://dart-review.googlesource.com/8731
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-27 18:07:05 +00:00
Ben Konyi ef4d11e894 Migrated test block 59 to Dart 2.0. 
No major changes.

Bug:
Change-Id: If12047444ce4869353ee058d16b745eaef0101e9
Reviewed-on: https://dart-review.googlesource.com/8081
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-27 14:14:04 +00:00
Dan Rubel f0caee1b24 Improve import directive recovery and report analyzer errors 
- New handleRecoverImport event
    for clauses in import directive that are out of order
- New error codes for
    Duplicate prefix
    Prefix after combinator

Change-Id: I0fea7ad4b4014a0b8578d3982e0515fe85044854
Reviewed-on: https://dart-review.googlesource.com/7980
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-27 12:56:46 +00:00
Régis Crelier 708952b3b0 Do not conflate 2 issues into 1 test. 
Passing the type argument vector <int> in the 'none' configuration is not
correct, but this is not what this test is supposed to check.

Change-Id: I2afd2987e572a6b4340a7d70ee92878abc67055e
Reviewed-on: https://dart-review.googlesource.com/8729
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-26 23:19:15 +00:00
pq 650a1159ff Migrate test block 65 to Dart 2.0. 
Bug:
Change-Id: Ibf50302eb7a1cec7546f4ceb87f8c19808479568
Reviewed-on: https://dart-review.googlesource.com/8380
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-26 16:55:42 +00:00
Ben Konyi c0364e372d Migrated test block 58 to Dart 2.0. 
No major changes.

Bug:
Change-Id: I7092880088d0fd334d6d2b1f6d4f1dbc2cb03ed2
Reviewed-on: https://dart-review.googlesource.com/7487
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-25 13:51:22 +00:00
Ben Konyi 24e40a0f61 Migrated test block 139 to Dart 2.0. 
Did not migrate null_bottom / null_is_bottom type tests. Modified
null_test to not run some mirrors related checks on platforms that don't
support mirrors.

Bug:
Change-Id: I7fce784f537cc298e2945a32073700083d9275f8
Reviewed-on: https://dart-review.googlesource.com/7848
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-09-23 00:06:38 +00:00
Ben Konyi 038c281a47 Migrated test block 131 to Dart 2.0. 
Quite a few changes were made to method_override* tests.

Bug:
Change-Id: I554c83ae766010b55f17a86caee9418d0c34cbe7
Reviewed-on: https://dart-review.googlesource.com/7683
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 21:53:58 +00:00
William Hesse b3e7f6d299 Recommit "migrate function type tests"" 
This reverts commit ba09eb787c, which was
a revert of ca6bec3414.
New status lines have been added to tests/languge_2/language_2_dart.js.status.

Bug:
Change-Id: I9e5b344d67df1fb00d5a51078a3d2b6113223a3e
Reviewed-on: https://dart-review.googlesource.com/7800
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:52:27 +00:00
pq d9326f4ab3 Migrate test block 135 to Dart 2.0. 
Bug:
Change-Id: Icda59de9bfad2e9b2683f019fb9c6fc54c12547c
Reviewed-on: https://dart-review.googlesource.com/7587
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-22 17:04:06 +00:00
Jaime Wren ec431ffa39 Revert "Migrated test block 60 to Dart 2.0" 
This reverts commit 9141047cd7.

Change-Id: I222dd72cabe4a69576e7f5d87e2ae61b96ac6b16
Reviewed-on: https://dart-review.googlesource.com/7636
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 21:34:32 +00:00
Jaime Wren 9141047cd7 Migrated test block 60 to Dart 2.0 
Change-Id: I3b9f5ea80001adf0017599c86db3be235fbf12e1
Reviewed-on: https://dart-review.googlesource.com/7160
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2017-09-21 20:43:34 +00:00
Ben Konyi a87493f8ca Migrated test block 165 to Dart 2.0. 
Minor changes to a couple of tests to make them strong-mode clean.

Bug:
Change-Id: Id0cac7a120dbdf940d101c3e5de8c206a0ad6342
Reviewed-on: https://dart-review.googlesource.com/4613
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-09-21 19:00:36 +00:00
Alexander Aprelev 02032850e5 Fix dartk checked tests 
Fix red https://build.chromium.org/p/client.dart.fyi/builders/vm-kernel-linux-release-x64-checked-be buildbot.

Change-Id: I7e5d6769d93802d397685d258f79c638aa4e2d45
Reviewed-on: https://dart-review.googlesource.com/4981
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-09-21 16:37:54 +00:00
pq 86e4c97346 Re-stage migration of test block 136 to Dart 2.0. 
Bug:
Change-Id: I562ceec87bc946bb43467ca118c88991a368657f
Reviewed-on: https://dart-review.googlesource.com/6781
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-20 16:23:00 +00:00
Ben Konyi 55e34cb2b0 Migrated test block 55 to Dart 2.0. 
Bug:
Change-Id: I781d22614ea06b599dd9bbe6d03f820f0cfea544
Reviewed-on: https://dart-review.googlesource.com/5482
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-18 22:08:58 +00:00
Jaime Wren 89b700eddd Migrated test block 54 to Dart 2.0 
Some status files touched, and some constructor initializations re-ordedered to get DDC to pass.

Some context: https://www.dartlang.org/guides/language/effective-dart/usage#do-place-the-super-call-last-in-a-constructor-initialization-list

Change-Id: Ifd371214c5620a7745d5cfbf250922ca6d67bc95
Reviewed-on: https://dart-review.googlesource.com/4083
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
 2017-09-18 18:39:12 +00:00
Karl Klose ba09eb787c Revert "migrate function type tests" 
This reverts commit ca6bec3414.

R=whesse@google.com

Change-Id: I57195534c4c32e0fcf0cd88f5171984b126be26e
Reviewed-on: https://dart-review.googlesource.com/6466
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Karl Klose <karlklose@google.com>
 2017-09-18 12:05:46 +00:00
Jennifer Messerly ca6bec3414 migrate function type tests 
I'd previously fixed most of these in strong mode. This also migrates the ones in the same text range.

Change-Id: Ieb637c0635502e46362594db3ce20ec414c95ffa
Reviewed-on: https://dart-review.googlesource.com/5521
Commit-Queue: Jennifer Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-16 05:28:43 +00:00
pq b091570a09 Revert "Migrate test block 136 to Dart 2.0." 
This reverts commit f58517a87a.

Bug:
Change-Id: I1da91b30499a768aee7521c16a8ce2fc79604b15
Reviewed-on: https://dart-review.googlesource.com/6169
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-15 18:30:04 +00:00
pq f58517a87a Migrate test block 136 to Dart 2.0. 
mixin_type_parameters_super_test .. named_parameters_aggregated_test

Bug:
Change-Id: Ic2c45c6c4ff0d4f7fd239f5b5ee039fced943a49
Reviewed-on: https://dart-review.googlesource.com/6163
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-15 18:08:00 +00:00
Alexander Markov 38f10b8bbb [Tests] Update status files for compiler = dartkp configuration 
Change-Id: I9b57d569b0a2dfdf6ad456659011783095e34fd7
Reviewed-on: https://dart-review.googlesource.com/6060
Reviewed-by: Alexander Aprelev <aam@google.com>
 2017-09-15 16:57:45 +00:00
Terry Lucas ccd7c7dfc8 Cleaned up status files. 
TBR=rnystrom@google.com

Change-Id: Ia8c3e1038c33948be12837ed775947e3e096348d
Reviewed-on: https://dart-review.googlesource.com/6082
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-15 13:52:07 +00:00
Terry Lucas 6dbb57769c Update status file results 
TBR=rnystrom@google.com

Change-Id: I8730b5a99c0c1f0f7b8ddb3fe9617eb0b9ba35f5
Reviewed-on: https://dart-review.googlesource.com/6121
Reviewed-by: Terry Lucas <terry@google.com>
 2017-09-15 06:13:09 +00:00
Terry Lucas 83146c0689 Migrated test block 53 to Dart 2.0 
Change-Id: I14461accc36505b3c8dfcf88705ccf8c9fd817f4
Reviewed-on: https://dart-review.googlesource.com/4522
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-15 03:51:03 +00:00
Ben Konyi 01e5f01cfc Migrated test block 164 to Dart 2.0. 
Fairly simple block with the exception of the
causal_async_exception_stack* tests needing to be refactored to be
migrated from unittest->test.

Bug:
Change-Id: I8f4879a10730b6186bdd1b392084a2e4055262eb
Reviewed-on: https://dart-review.googlesource.com/4641
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-14 21:49:59 +00:00
Ben Konyi 795d74b35c Migrated test block 56 to Dart 2.0. 
Minor changes to make cyclic_default_values_test,
cyclic_type_variable_test, and cyclic_typedef_test strong mode clean.

Bug:
Change-Id: Icc99b07eca07f937a18fd16968619e5cd7c8ca22
Reviewed-on: https://dart-review.googlesource.com/5341
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-14 20:34:04 +00:00