Commit Graph

10 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen 9edecbc803 Add test checking that const contexts are not applied where they shouldn't.
Change-Id: I39782577b7555dc63311531ca17f61f8deec5b4a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98854
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2019-06-27 12:47:31 +00:00
Lasse R.H. Nielsen 5ea271bb01 Clean up documentation of implicit new/const insertions tests.
Add Expect.allIdentical to complement Expect.allDistinct.

Change-Id: I65e4e0005f141434bd8fb47d9c60153f32b293aa
Reviewed-on: https://dart-review.googlesource.com/50421
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-04-10 14:49:41 +00:00
Dmitry Stefantsov 0fedb9b9d8 [fasta] Disable upwards new/const completion
Change-Id: If2c14bf402bbcbacbf4cf2da351eb7234e1e0944
Reviewed-on: https://dart-review.googlesource.com/49900
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-04-06 19:31:22 +00:00
Lasse R.H. Nielsen 619434d38d Remember that C() is a compile-time constant expression.
Actually make default value expression not constant.

Change-Id: Id9082716a6606618b91545f427726925849fb61c
Reviewed-on: https://dart-review.googlesource.com/45323
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-03-06 16:07:23 +00:00
Lasse R.H. Nielsen 9986b6de25 Fix bugs in implicit-creation tests. Add one more test.
Change-Id: Id5328ba0568d7eba78c2b9145ee2db3476dc5bd5
Reviewed-on: https://dart-review.googlesource.com/44961
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-03-06 13:47:51 +00:00
Peter von der Ahé 982fc59531 Annotate local variable instead of local function
Change-Id: Ieac8446f24c5244cf5614242567ebcd3f033c23b
Reviewed-on: https://dart-review.googlesource.com/41260
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-26 13:09:03 +00:00
Lasse R.H. Nielsen 06439147c4 Update some tests to work better.
Add test for strong-mode only allowing super-chaining at the end of the initializer list.

Change-Id: Ic1c99f4f24738094eec14cb9c59354716f776b1e
Reviewed-on: https://dart-review.googlesource.com/40301
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-02-15 08:43:34 +00:00
Brian Wilkerson b7f61f5801 Fix some of the optional new and const tests
Change-Id: Idcdadb0b26c2fc187a90dd60f11b634a84c12b9f
Reviewed-on: https://dart-review.googlesource.com/38920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-02-06 18:04:33 +00:00
Peter von der Ahé aade3541f7 Add some tests for implicit new/const instance creation.
Marked as failing everywhere.

Change-Id: I09d3502ab114c3c6b4f7f69913e34fd35377f7b5
Reviewed-on: https://dart-review.googlesource.com/33440
Reviewed-by: Erik Ernst <eernst@google.com>
2018-01-19 15:26:25 +00:00
Erik Ernst 3698b91be8 Added test directories for Dart 2 features.
At and after the meeting that Anders called in AAR today we discussed
the list of directories that we would need. These came up:

  generalized void
  instantiate to bound
  noSuchMethod forwarding
  super-bounded types

I combined super-bounded types and instantiate to bound into one
topic, since they are so interwoven.

I also noted that we have more features coming up, even though we have
not discussed them much recently, and one of them will need a number
of tests: optional const/new. So I created new test directories for
these five topics, and added a short README.md to indicate their
purpose.

Change-Id: I17a407073d2dbcbccce0bfbd321cb01365d4b9ee
Reviewed-on: https://dart-review.googlesource.com/31200
Reviewed-by: Anders Sandholm <sandholm@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
2017-12-22 15:39:13 +00:00