f3ca3abd63
Regression test for issue 11023
...
The VM resolves types too eagerly at least during top-level
parsing. This may result in referencing the wrong type, as in
this new test.
R=iposva@google.com
Review URL: https://codereview.chromium.org//15647019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23651 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 19:15:48 +00:00
59da9de8c7
Ensure that all phis inserted by load optimizer have consistent representation.
...
Revert r23619.
R=srdjan@google.com
BUG=dart:11048
Review URL: https://codereview.chromium.org//16430002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23634 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 15:37:23 +00:00
98e2f04473
IfConverted should unuse inputs of the join it removes.
...
R=srdjan@google.com
BUG=dart:11087
Review URL: https://codereview.chromium.org//16423005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23631 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-05 14:26:25 +00:00
d883e45e43
Update status files for simarm tests on Mac OS X.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//16286022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23609 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 19:46:16 +00:00
004a1f81c9
Enable optimization of try-finally in the VM's optimizing compiler.
...
I changed the status of two co19 tests that crash with a stack overflow
because of recursion in dart2js. Optimized functions may take more stack
space, and this CL enables optimizations for more functions in dart2js.
I added smaller versions of those two tests to our own test suite.
BUG=dart:8857
R=ahe@google.com
Review URL: https://codereview.chromium.org//15934013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23597 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 14:35:43 +00:00
662c2a8262
Rename RuntimeError to CyclicIntializationError, as per spec.
...
The RuntimeError has been used to report cyclic initialization errors in
dart2js.
It has also been used for other, unrelated, uses, where it makes
little to no sense.
The RuntimeError type has been removed, but added in js_helper.dart,
where dart2js uses it.
Uses of new RuntimeError("some message") have been converted to
other errors (Argument/State/Unsupported). In some cases, just
throwing a String might have been just as good.
BUG=http://dartbug.com/11040
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//16154017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23584 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 10:33:11 +00:00
eb5864d73c
Update test status file for dart2dart.
...
This test fails in minified mode.
BUG=dart:11065
TEST=tests/language/super_getter_setter_test.dart
Review URL: https://codereview.chromium.org//16357006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23581 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 08:15:18 +00:00
8566fdc2bc
Re-apply: Fix type propagation bug by always narrowing types, and fix unit tests where the type inferrer does not run.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//15985005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23579 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 07:48:22 +00:00
fb8008785e
Revert r23577, some unit tests fail.
...
Review URL: https://codereview.chromium.org//16196012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23578 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 07:04:10 +00:00
f9249e6459
Fix type propagation bug by always narrowing types.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//16295008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23577 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 06:52:01 +00:00
cec8d9040a
Update status files to mark passing tests as passing for the dart-analyzer.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//16337009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23555 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 18:27:15 +00:00
07966b62da
Fix two bugs in the Dart VM's super-noSuchMethod invocation.
...
1. The result value of an expression
"super.someMissingSetter = val" was incorrect in case of a noSuchMethod call.
To fix this I refactored the BuildStaticNoSuchMethod function. It now no longer
creates AST nodes and visits them, because the last argument may be needed saved
as a result value.
2. The evaluation order of "super[e1] = e2" was wrong in case of a noSuchMethod call.
BUG=dart:8917, dart:10965
TEST=tests/language/super_operator_index7_test.dart, tests/language/super_operator_index8_test.dart
R=srdjan@google.com
Review URL: https://codereview.chromium.org//15979010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23553 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 17:09:09 +00:00
1eaa74c013
Updates status files so that arm and simarm are the same.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//15927015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23550 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 16:44:20 +00:00
3264ecdd1b
Cleanup suppressions.
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org//15969012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23548 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 15:44:39 +00:00
c73ff61873
Fix dartbug.com/11010.
...
R=ngeoffray@google.com
BUG=11010
Review URL: https://codereview.chromium.org//16324005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23538 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 10:51:46 +00:00
3de94b2151
Make fields of BoundClosure private to not expose implementation details.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//16320003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23524 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-03 07:30:41 +00:00
d5da0f0c0d
Adjusted expectations from last Blink roll
...
TBR=antonm, blois
Review URL: https://codereview.chromium.org//15795004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23513 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-02 20:30:14 +00:00
479c0427d9
Fix leaf floating point runtime calls on ARM (work still needed in simulator).
...
Various cleanups.
R=zra@google.com
Review URL: https://codereview.chromium.org//15945006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23506 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 23:51:38 +00:00
df47dc0740
Cover the 'extends' and typedef cases of the CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//16231012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23473 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 16:19:56 +00:00
9eced04799
Removed suppression of type_checks_in_factory_method_test on ie9, seems passing now
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//15736019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23465 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 12:58:29 +00:00
87d2467ded
Fix issue with dart2dart translation of parameters (collision risk).
...
R=antonm@google.com
BUG=http://dartbug.com/10996
Review URL: https://codereview.chromium.org//15959017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23458 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 08:54:43 +00:00
97a881be10
Enable language tests on SIMARM and mark 14 of them as failing.
...
Implement more features on ARM.
R=zra@google.com
Review URL: https://codereview.chromium.org//16244007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23448 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-31 00:38:21 +00:00
4170ce84c2
Report CTEC.REDIRECT_TO_NON_CONST_CONSTRUCTOR
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16181004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23444 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 21:21:17 +00:00
30c9e6eb7a
Implementation of CompileTimeErrorCode.RECURSIVE_INTERFACE_INHERITANCE error code.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//15855005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23440 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 20:06:28 +00:00
ad595d9f98
Adjust dart2dart test expectations.
...
R=ahe@google.com
Review URL: https://codereview.chromium.org//15792006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23417 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 14:07:25 +00:00
47cd31c7af
Support type variables on redirecting factory constructors.
...
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//12093019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23407 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 13:14:42 +00:00
9a6657cd4d
Eliminate temporary locals for some expressions
...
This CL affects a subset of expressions that use temporary locals: constructor
calls, array literals and and instance getter postfix-ops.
For expressions that are de-sugared in the parser I added LetNode.
It creates a scoped temporary local bound to an initializing expression.
For expressions where we need a temporary local at graph-building time,
I added a helper class TempLocalScope to easily create a single temporary
local in the graph builder since this is a frequently recurring pattern.
This simplifies code in the parser and the graph builder and also fixes a
bug with indexed-super invocation and NoSuchMethod.
BUG=dart:8918
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//14942010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23401 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 12:19:21 +00:00
6f15041c76
Fix type tests for null.
...
BUG=dartbug.com/10901
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//16042017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23388 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 08:46:25 +00:00
91297abbfa
Re-apply "Implement operator== and hashCode for bound closures.". The emitter should not try to share a bound closure class between an intercepted method and a non-intercepted method because the call has different calling conventions: the intercepted version pass an extra argument, which is the actual receiver.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//15888010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23387 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 08:27:28 +00:00
16530e2e6b
Fix http://dartbug.com/8669 by making sure we do not crash when trying to use Object as a mixin.
...
R=johnniwinther@google.com , ngeoffray@google.com
BUG=
Review URL: https://codereview.chromium.org//15888009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23384 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 07:21:49 +00:00
76f4ae07ba
Revert r23380, some browser tests fail.
...
Review URL: https://codereview.chromium.org//15987007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23383 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 07:05:38 +00:00
6ed50f8a6b
Implement operator== and hashCode for bound closures.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//16042014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23380 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 06:48:38 +00:00
c082d9f570
Report CompileTimeErrorCode for 'const' argument mismatch.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//15797007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23374 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-30 01:22:56 +00:00
7fed1dd2c7
Fix generation of a bailout method when a BailoutTarget was in the middle of a loop/labeled block. It confused the SSA codegen.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//16004005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23337 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 10:14:36 +00:00
21b88c4e2e
Fix bug in SsaConstructionFieldTypes where the phase got confused seeing multiple HForeignNew due to inlining.
...
R=kasperl@google.com
Review URL: https://codereview.chromium.org//16191004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23327 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 08:29:10 +00:00
41663b899b
Remove previous duplicated entry in status file (the first entry was removed in https://codereview.chromium.org/15824005/ ).
...
Review URL: https://codereview.chromium.org//16189004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23326 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 08:28:00 +00:00
14e320d109
More status file changes.
...
Review URL: https://codereview.chromium.org//15824005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23323 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 07:39:49 +00:00
107ab2ab55
CL https://codereview.chromium.org/16001006/ also fixed dart2dart for redirecting factories.
...
Review URL: https://codereview.chromium.org//16105006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23321 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 07:14:55 +00:00
67220724ec
- Reenable gc_test.
...
Review URL: https://codereview.chromium.org//16063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23317 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-29 03:56:33 +00:00
f27a535577
Report SWC. and CTEC.CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23285 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 15:33:52 +00:00
082df12ce3
Issue 10899. Triage 'language/class_literal' failing tests
...
https://code.google.com/p/dart/issues/detail?id=10899
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//15872003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23281 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 15:03:03 +00:00
a4d526ff0c
Fix bug in ClassElement.lookupSelector: by returning an abstract method, we were not returning the actual element that would be hit at runtime.
...
R=karlklose@google.com
Review URL: https://codereview.chromium.org//15712007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23259 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 12:45:38 +00:00
04aca6a019
- Inline iterator calls made for a "for in".
...
- Remove inlining restriction for recursive calls.
R=kasperl@google.com
Review URL: https://codereview.chromium.org//15818003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23253 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 11:50:41 +00:00
911b12ed96
Fix a bug where we would emit:
...
for (var t = 42, $.global = 54; ;)
which is invalid JavaScript.
R=kasperl@google.com
Review URL: https://codereview.chromium.org//16059005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23246 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 10:00:18 +00:00
a8857ed49c
Status file updates for arm -> remove Skip markers
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//15956005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23242 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 09:09:38 +00:00
f0d5807146
Triage on-catch related failing language tests
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//15963005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23232 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 19:24:11 +00:00
33327969d3
Ensure that 'throw' has expression.
...
Both VM and dart2js support "rethrow" now, so it is time to start to report error for "throw" without exception.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//15758006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23231 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 19:01:38 +00:00
e5b94c9a7d
Fix dart2dart status.
...
Review URL: https://codereview.chromium.org//16101006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23222 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 13:13:07 +00:00
a8da79c004
Create a new scope when analyzing then and else of an if.
...
R=karlklose@google.com
Review URL: https://codereview.chromium.org//16043007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23215 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-27 12:15:57 +00:00
79030deff3
Skip language tests which should pass/fail depending on --checked flag
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//16058004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23197 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-26 05:49:40 +00:00
hausner@google.com