dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Asger Feldthaus 19cb08fa05 dart2js cps: Remove code after calls that cannot return. 
This should resolve an outstanding issue with unreachable code being
transformed. A subterm in the unreachable code would get specialized
and then reanalyzed while some of the definitions in scope have no type.

This changes a lot of test case results. Some test results
have changed in very surprising ways, but I would argue
these are separate bugs that we should hunt down.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1335273003 .
 2015-09-15 17:46:48 +02:00
Kevin Millikin 0253d7edd0 Dart2js CPS: mark a pair of failures in the test status files. 
R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1341323002 .
 2015-09-15 15:50:36 +02:00
regis de456dac24 Update language status file for dart2js. 
Review URL: https://codereview.chromium.org//1337923005 .
 2015-09-14 18:48:04 +08:00
regis e8139d4d92 Fix right shifting of a Mint value by an amount larger than 63. 
Add regression test.
Enhance existing bit shift test.

Fixes #24283

R=ager@google.com

Review URL: https://codereview.chromium.org//1338233002 .
 2015-09-14 18:20:48 +08:00
Rico Wind 2e22f41612 This is a fixed up version of: 
https://codereview.chromium.org/1305183010/

- Reorder the priority of flags in the test harness when passed to the VM:
  default flags, file flags, command line flags
- Ensure to not enable assertions when not being requested.

Peter, any reason to not move the flags in to the
configuration file?  Why don't we actually have all of them in there? (not
that I want to move them, I am just currious why we don't add them in
there, it seems more logical to me)

BUG=
R=iposva@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/dd7767d95eda87054844e0b24ebd2ce9b04354bb

Review URL: https://codereview.chromium.org//1330643003 .
 2015-09-14 07:58:18 +02:00
Sigurd 18bb772cdd Fix crash when deferred loading would encounter an unresolved super setter. 
BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1327123003 .
 2015-09-09 14:56:11 +02:00
Karl Klose d9caf4a725 Move cps-ir section to the end of the file and update test expectations. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1312583008 .
 2015-09-07 15:37:39 +02:00
Rico Wind 02320ff26e Revert "This is a fixed up version of:" 
This reverts commit dd7767d95e.

This made the analyzer fail:
http://build.chromium.org/p/client.dart/builders/analyzer_experimental-linux-release-be/builds/3418/

Please note that this is just not the new test (which I would just have
suppressed)
It seems that in --checked --host-checked mode we see a range of new
failures, because of the change to flags.

It also made dart2js fail on the new tests

Ivan: Will you look into this with the analyzer people?

R=iposva@google.com
BUG=

Review URL: https://codereview.chromium.org//1308743006 .
 2015-09-07 08:41:46 +02:00
Rico Wind dd7767d95e This is a fixed up version of: 
https://codereview.chromium.org/1305183010/

- Reorder the priority of flags in the test harness when passed to the VM:
  default flags, file flags, command line flags
- Ensure to not enable assertions when not being requested.

Peter, any reason to not move the flags in to the
configuration file?  Why don't we actually have all of them in there? (not
that I want to move them, I am just currious why we don't add them in
there, it seems more logical to me)

BUG=
R=iposva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//1330643003 .
 2015-09-07 07:44:41 +02:00
Johnni Winther ae721be5ae Prepare for computation of NewStructure in Resolution. 
BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/1a8f32efc441c4f8603b0d8c83b82d326dbc5d4c

Reverted: https://github.com/dart-lang/sdk/commit/db89bc6574859b93434e98e68bcbe15f0330ab9e

Review URL: https://codereview.chromium.org//1323573002.
 2015-09-01 12:39:47 +02:00
Johnni Winther db89bc6574 Revert "Prepare for computation of NewStructure in Resolution." 
This reverts commit 1a8f32efc4.

BUG=

Review URL: https://codereview.chromium.org//1308153007.
 2015-09-01 10:15:22 +02:00
Johnni Winther 1a8f32efc4 Prepare for computation of NewStructure in Resolution. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1323573002.
 2015-09-01 10:11:19 +02:00
Konstantin Shcheglov 3e9645af53 Resolve enum documentation comments. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325513004 .
 2015-08-28 14:07:13 -07:00
Johnni Winther 9ce4da5e1a Refactor qualified send sets. 
Closes #23795

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1293953006.
 2015-08-21 09:34:45 +02:00
Stephen Adams b569deac48 update language_dart2js.status for --cps-ir ??= tests 
TBR=sigmund@google.com

Review URL: https://codereview.chromium.org//1294773003 .
 2015-08-20 12:14:56 -07:00
Paul Berry 79d85a9d34 Pull in new analyzer_cli to enable support for the "--supermixin" flag. 
Partially addresses #23772.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1301023004 .
 2015-08-20 09:33:38 -07:00
Sigmund Cherem 6e0b2418c7 [dart2js] fix inference of ??= and []??= 
Fixes #24134
Fixes #24135

R=floitsch@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//1305663002 .
 2015-08-20 07:32:34 -07:00
Johnni Winther fb7ea815c8 Handle C?.m as C.m for Sends 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1294103004.
 2015-08-18 11:38:48 +02:00
Asger Feldthaus 0210c5c035 dart2js cps: Fix treatment of captured type variables. 
CLOSES=24064
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1286113003.
 2015-08-13 13:35:50 +02:00
Florian Loitsch ad38b75bb2 Forward cancel subscription in stream pipes. 
R=lrn@google.com

Review URL: https://codereview.chromium.org//1284223005 .
 2015-08-13 12:57:35 +02:00
Srdjan Mitrovic 30d68644a1 Enable analyzer tests after fixing them for analysis 
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1289713002 .
 2015-08-11 17:43:13 -07:00
Srdjan Mitrovic 532474ab35 Fix analyzer tests 
BUG=

Review URL: https://codereview.chromium.org//1291583002 .
 2015-08-11 16:43:51 -07:00
Srdjan Mitrovic c06e66c9b9 Fix test breakage in checked mode 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1291563002 .
 2015-08-11 16:16:11 -07:00
Srdjan Mitrovic 56c91201c3 Fix issue 24043: do not trust the pattern. Enable a 'hidden' test. 
If there is a performance issues, I can add specialized code for String patterns.

BUG=24043
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1286823003 .
 2015-08-11 14:46:17 -07:00
Matthias Hausner fc55f38aaf Fix ??= AST modification. 
BUG=23988
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1273033007 .
 2015-08-11 13:13:56 -07:00
Asger Feldthaus 684b83ab05 dart2js cps: Change rewriting of equality operators. 
Dart == calls now are rewritten to an Identical node (if applicable),
which can then be specialized further into JS == and === nodes.

Previously, == calls would specialize directly to JS == and === nodes,
but some of these optimizations were then missed for the cases where
Identical nodes are introduced directly (e.g. for switch cases).

The rules have also changed a bit to be more effective, and there
are some small improvements to the utility functions.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1276843008.
 2015-08-11 15:47:49 +02:00
Harry Terkelsen 4eb2f6694b dart2js now passes compile_time_constant_checked5_test 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1275783004.
 2015-08-10 18:03:59 -07:00
Karl Klose bafb8fb191 dart2js cps: Support async/await by rewriting the JavaScript AST. 
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1253333002 .
 2015-08-07 11:27:40 +02:00
Karl Klose 7eb3bb82b7 dart2js cps: update test expectations for new tests. 
TBR=kmillikin@google.com

Review URL: https://codereview.chromium.org//1280603003 .
 2015-08-07 08:36:47 +02:00
William Hesse 60c7a3d0ab Factor failing tests out of language/async_star_test.dart 
Make async_star_test no longer a multitest, and stop using package:test in
the factored tests.

BUG=dartbug.com/2238, dartbug.com/22853
R=lrn@google.com

Review URL: https://codereview.chromium.org//1270413002 .
 2015-08-06 14:56:30 +02:00
Johnni Winther 29cdb17f39 Refactor visitSendSet for super compounds and assignment. 
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1274073003.
 2015-08-06 14:38:05 +02:00
Matthias Hausner 223e5a6bb5 Adapt C?.m to latest spec version 
BUG=23794
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1269413005 .
 2015-08-05 15:41:31 -07:00
Florian Loitsch c33930b5d9 dart2js: Fix lazy statics in the startup-emitter. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1264283003 .
 2015-08-04 14:21:16 +02:00
Florian Loitsch ecb10239c8 Add cyclic default-value test. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1255083008 .
 2015-08-04 13:55:55 +02:00
Matthias Hausner a4b7b5ad91 Skip tearoff_constructor test until I know why it crashes in checked mode. 
BUG=

Review URL: https://codereview.chromium.org//1260223003 .
 2015-08-03 16:37:23 -07:00
Matthias Hausner 4ebab25d8f Implement constructor closures 
One detail that isn't implemented yet is canonicalization of constructor tear-offs. At the moment, two tear-offs of the same constructor result in closures that are not equal.

BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org//1255063005 .
 2015-08-03 15:50:46 -07:00
Siva Annamalai 884a91fb27 Fix analyzer warning from test for issue21079. 
BUG=

Review URL: https://codereview.chromium.org//1252913012 .
 2015-07-30 10:51:08 -07:00
Siva Annamalai 325f40d9db Fix for bug 21079 
Implement patch records to patch canonical objects.

BUG=21079
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1255003004 .
 2015-07-30 10:24:13 -07:00
Johnni Winther e8a19f42af Refactor resolution index SendSet operations. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1258073010.
 2015-07-30 13:00:36 +02:00
Siva Annamalai af80eeef79 Fix the dartium status file to account for the mixin test failures. 
BUG=

Review URL: https://codereview.chromium.org//1264773002 .
 2015-07-29 15:47:54 -07:00
Siva Annamalai 112bfdf3c1 Fix dartium status file. 
BUG=

Review URL: https://codereview.chromium.org//1258333003 .
 2015-07-29 09:33:42 -07:00
Paul Berry a8b9e9959c Modify DEP 34 language tests in preparation for adding analyzer support. 
Both of these tests used "VMOptions" to enable the new behavior.  They
need to use "SharedOptions" so that the new behavior is also enabled
in dart2js and analyzer.

Also, since mixin_super_bound2_test verifies that the appropriate
errors are thrown at runtime when type bounds are incorrect, it's
going to have a static warning when run through the analyzer (once the
analyzer supports DEP 34).  In order to prevent this from leading to a
buildbot failure, we need to change the test into a multitest:

- mixin_super_bound2_test/01 reproduces the previous behavior of the
  test, throwing the appropriate errors at runtime and generating a
  static warning when analyzed.

- mixin_super_bound2_test/none lacks the incorrect type bounds, so it
  doesn't produce and runtime errors or static warnings.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1254933003 .
 2015-07-29 08:59:01 -07:00
Siva Annamalai 3ba3667926 One more attempt at fixing the dart2js status file. 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1255393004 .
 2015-07-28 17:59:29 -07:00
Siva Annamalai bb1b99744c Fix status file for issue 23244. 
BUG=

Review URL: https://codereview.chromium.org//1266433003 .
 2015-07-28 15:44:50 -07:00
Siva Annamalai d1ca481306 Fix status file for tests added to address issue 23244. 
BUG=

Review URL: https://codereview.chromium.org//1260323002 .
 2015-07-28 13:31:31 -07:00
Srdjan Mitrovic cb1dd1257e Fix test so that dartanalyzer can hadle it correctly. 
BUG=
R=hausner@google.com

Review URL: https://codereview.chromium.org//1255973006 .
 2015-07-28 13:18:00 -07:00
Srdjan Mitrovic fafbe30eb0 Fix #23871: identical on consts should be always const 
BUG=23871
R=hausner@google.com

Review URL: https://codereview.chromium.org//1259813003 .
 2015-07-28 11:37:22 -07:00
Siva Annamalai b0c9f2ef9b Fix for issue 23244 
Refactoring of WriteObjectImpl and ReadObjectImpl to enable inlining of canonical objects in the snapshot stream.

BUG=23244
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1260033004 .
 2015-07-28 10:52:05 -07:00
Paul Berry 0e98c58190 Fix analyzer interpretation of 'ClassName?.staticMember'. 
Previously, trying to access a static member of a class using '?.' was
not allowed.  But the spec was changed in
b11670f899 so that
'ClassName?.staticMember' is now equivalent to
'ClassName.staticMember'.

This CL updates analyzer to follow the spec, and updates the tests in
"tests/language" accordingly.  VM and dart2js still need fixing
(see #23794 and #23795).

Fixes #23464.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1255293005 .
 2015-07-28 09:49:35 -07:00
Srdjan Mitrovic 9dbb6d488f Fix issue #23914: do not attempt to make an already immutable array immutable 
BUG=23914
R=asiva@google.com, iposva@google.com

Review URL: https://codereview.chromium.org//1256763004 .
 2015-07-27 16:43:13 -07:00