dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Regis Crelier 69a66ef6ca Update dart2js status file for recently added test. 
Review URL: https://codereview.chromium.org/2336333002 .
 2016-09-13 10:54:33 -07:00
Regis Crelier 4634faa574 Add new language test for generic function parameter (filed issue #27299). 
R=hausner@google.com

Review URL: https://codereview.chromium.org/2333973002 .
 2016-09-13 09:24:57 -07:00
Lasse R.H. Nielsen 64e863a5cf Mark new tests using deferred imports as crashing with hot reload. 
Review URL: https://codereview.chromium.org/2335933004 .
 2016-09-13 11:41:43 +02:00
Lasse R.H. Nielsen bcdf0a1f12 Make dart2js not consider dart:io there if the library is unsupported. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2321973002 .
 2016-09-13 09:21:54 +02:00
Brian Wilkerson a5ee525e14 Add support for accessing field formal parameters in the initializer list of constructors 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2335693002 .
 2016-09-12 09:48:34 -07:00
Stephen Adams 1201bd5528 Dynamicize some mixin type tests 
Add dynamic cases to some recent problem tests where dart2js now
optimizes away the type tests.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2302173003 .
 2016-09-02 11:08:06 -07:00
Matthias Hausner c15bac4812 Ensure that constant field initializers are canonicalized 
In const constructors, field initializer values that are known
to be compile-time constants should be evaluated and canonicalized
at compile time.

BUG=#27164
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2300113002 .
 2016-09-01 13:23:20 -07:00
Stephen Adams a7087aa7c4 dart2js: Fix some problems with mixins and generics 
Force the generation of substitutions for mixins at mixin applications. This compensates for the partial lack of rules for mixins in the code that anticipates which substitutions are required.

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2299783002 .
 2016-09-01 11:08:23 -07:00
Lasse R.H. Nielsen 3c798ed008 Don't make main async in the asyncstar_main_test file. 
The framework thinks the test is done before it gets started.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2300993002 .
 2016-09-01 14:29:37 +02:00
Lasse R.H. Nielsen 8a70e46d76 Fix problem occurring when an async* stream is paused at the end of a yield*. 
In this case, the stream is unscheduled and it is not expecting to be resumed,
so nothing further happens.

Closes https://github.com/dart-lang/sdk/issues/27205

R=floitsch@google.com, hausner@google.com

Review URL: https://codereview.chromium.org/2297013003 .
 2016-09-01 11:03:35 +02:00
Stephen Adams 82fc834632 Add language test with nested function typedef with two references to argument 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2297783002 .
 2016-08-30 13:27:20 -07:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
 2016-08-29 08:14:33 -07:00
Sigmund Cherem 2efdf57c92 more status updates: many tests that import mirrors also "pass" because they expect compile-time failures 
BUG=

Review URL: https://codereview.chromium.org/2284743003 .
 2016-08-26 12:56:11 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup 
Review URL: https://codereview.chromium.org/2285823002 .
 2016-08-26 10:04:41 -07:00
Lasse R.H. Nielsen 99439a336a See: https://docs.google.com/document/d/1iEuLbDMgbB657R5aFj9EfnT6B0obzQk93Of7CfWKc00/edit#heading=h.9ixvz54wwawi 
Implement assert in initializer list in VM.

R=hausner@google.com

Review URL: https://codereview.chromium.org/2002923002 .
 2016-08-24 12:43:26 +02:00
Stephen Adams 3cec399d2c Add test case for type with partial parameterization by method type parameter 
BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2257813003 .
 2016-08-23 10:45:22 -07:00
Johnni Winther f49b7c2720 Support raw types in metadata. 
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2254363003 .
 2016-08-23 09:49:33 +02:00
Matthias Hausner 4d4ebafad3 Implement parsing support for generic functions 
Take two. (This version adds status file entries for checked
tests.)

Type parameters and arguments are parsed but ignored. Proper
handling of the parameters will be added subsequently.

The feature must be enabled with --generic-method-syntax.

Compiling all of dart2js consumes about 2.2% more tokens with
this change, due to the necessary lookahead to distinguish
generic functions from generic types.

===== with this change =========

Number of tokens:        1056691
Source length:           5850143 characters
Number of source tokens: 936226

Total tokens consumed:   3628934  <<<<<
Classes parsed:          2457
  Tokens consumed:       977999
Functions parsed:        49607
  Tokens consumed:       2430638

===== without this change ======

Number of tokens:        1056691
Source length:           5850143 characters
Number of source tokens: 936226

Total tokens consumed:   3547765 <<<<<
Classes parsed:          2457
  Tokens consumed:       942536
Functions parsed:        49607
  Tokens consumed:       2371357

(This reverts commit a1edb1766fd16b1268f3506feb7c9856b32bedfc.)

BUG= 25869

Review URL: https://codereview.chromium.org/2269693002 .
 2016-08-22 10:58:55 -07:00
Matthias Hausner a1edb1766f Revert "Implement parsing support for generic functions" 
This reverts commit 19af852471.

Checked tests failed. Will work on this on Monday.

TBR=asiva

Review URL: https://codereview.chromium.org/2267473002 .
 2016-08-19 16:40:03 -07:00
Matthias Hausner 19af852471 Implement parsing support for generic functions 
Type parameters and arguments are parsed but ignored. Proper
handling of the parameters will be added subsequently.

The feature must be enabled with --generic-method-syntax.

Compiling all of dart2js consumes about 2.2% more tokens with
this change, due to the necessary lookahead to distinguish
generic functions from generic types.

===== with this change =========

Number of tokens:        1056691
Source length:           5850143 characters
Number of source tokens: 936226

Total tokens consumed:   3628934  <<<<<
Classes parsed:          2457
  Tokens consumed:       977999
Functions parsed:        49607
  Tokens consumed:       2430638

===== without this change ======

Number of tokens:        1056691
Source length:           5850143 characters
Number of source tokens: 936226

Total tokens consumed:   3547765 <<<<<
Classes parsed:          2457
  Tokens consumed:       942536
Functions parsed:        49607
  Tokens consumed:       2371357

BUG=25869
R=asiva@google.com

Review URL: https://codereview.chromium.org/2260693002 .
 2016-08-19 16:21:00 -07:00
Johnni Winther d4d5a48c10 Type check field initializers in the correct context. 
Closes #27104

R=sigmund@google.com

Review URL: https://codereview.chromium.org/2250433007 .
 2016-08-19 09:58:51 +02:00
Florian Schneider 021ebb2033 Correct and GC unrecognized flags from our tests. 
Fix some misspelled flags.

Remove some non-existent flags.

Fix --short_socket_read and --short_socket_write flags used in IO tests.

Running with --ignore-unrecognized-flags is still on because some flags are only visible
in DEBUG mode.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2247733005 .
 2016-08-15 18:28:11 -07:00
Matthias Hausner 3f93791991 Class fields cannot be declared to be of type void 
Add a test case and detect void fields.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2248943002 .
 2016-08-15 17:14:58 -07:00
Johnni Winther b6a6b19a1e Ensure correct current element for field initializers. 
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/2230853002 .
 2016-08-11 13:19:36 +02:00
Johnni Winther 32bcf1e3b2 Fix string_interpolation tests. 
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org/2230823002 .
 2016-08-10 11:39:25 +02:00
Terry Lucas fa5741f325 Updated to reverted WebKit CL and updated status files to only skip the failing tests. 
TBR=hausner@google.com

Review URL: https://codereview.chromium.org/2217343002 .
 2016-08-05 13:17:00 -07:00
Sigmund Cherem 0eee4027a6 Delete dart_backend from compiler. 
R=sra@google.com

Review URL: https://codereview.chromium.org/2213673002 .
 2016-08-04 15:57:04 -07:00
Matthias Hausner 6075a53547 Skip initializing_formal_* tests on Dartium 
Apparently the VM does not get the --initializing-formal-access flag
set, which these tests need in order to pass.

TBR=terry

BUG=

Review URL: https://codereview.chromium.org/2219473002 .
 2016-08-04 13:47:21 -07:00
Matthias Hausner 643fdb9dc8 Implement the language change that makes initializing formal parameters visible in the initializer list, but not in the constructor's body. 
The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
R=regis@google.com

Review URL: https://codereview.chromium.org/2051213005 .
 2016-08-04 11:24:25 -07:00
John McCutchan 268082769b Initial status file updates for $hot_reload_rollback 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2207653002 .
 2016-08-02 11:03:44 -07:00
John McCutchan 8b3a8bbe0f Update status files now that tear off closure equality works across reloads 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2185133004 .
 2016-07-28 12:42:12 -07:00
Regis Crelier 48060a653f Reverting bad fix of issue #26941. 
Review URL: https://codereview.chromium.org/2179903009 .
 2016-07-28 12:39:49 -07:00
Regis Crelier 093bca5909 Temporarily skip test that became flaky after fixing #26941. 
Review URL: https://codereview.chromium.org/2192723002 .
 2016-07-27 22:38:42 -07:00
Regis Crelier f10ce1eb69 Skip new regression test crashing when precompiled. 
Review URL: https://codereview.chromium.org/2186493005 .
 2016-07-27 18:31:50 -07:00
Regis Crelier 11d340c51d Force local context allocation in finally clauses (fixes #26948). 
Add regression test.

R=fschneider@google.com, hausner@google.com

Review URL: https://codereview.chromium.org/2188863002 .
 2016-07-27 14:03:25 -07:00
Ryan Macnak 634a62c9df DBC: Add missing deopt info after stack overflow checks. 
Fixes collecting a debugger stack trace at an interrupt.

Enable most vm-service tests.

R=zra@google.com

Review URL: https://codereview.chromium.org/2183993004 .
 2016-07-27 12:25:54 -07:00
Konstantin Shcheglov f8c32c5ea1 Issue 26860. Report CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR for parameters of function typed constructor parameters. 
R=pquitslund@google.com, brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/26860

Review URL: https://codereview.chromium.org/2178123003 .
 2016-07-25 14:56:47 -07:00
John McCutchan f79756b88d Hot reload status file updates 
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2164063002 .
 2016-07-20 11:02:23 -07:00
John McCutchan c692a64e5a Rework how enums are implemented and reloaded 
- Enum instances now hold their index and their label. Before the labels were held in a static array to the side and the index was used to look up the label.

- Before and after reload enum instances are now paired (by label) and put into the 'become' table.

Fixes https://github.com/dart-lang/sdk/issues/26877

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2153143002 .
 2016-07-15 10:52:20 -07:00
Johnni Winther 72fed51ac0 Enable deferred tests on d8/Windows. 
The preamble now sets up the currentScript property.

R=het@google.com

Review URL: https://codereview.chromium.org/2141423002 .
 2016-07-15 10:02:04 +02:00
John McCutchan 6c27b6e381 Tweak for hot reload status file 
Enum identity tests can sometimes pass.

BUG=

Review URL: https://codereview.chromium.org/2147183003 .
 2016-07-14 07:56:56 -07:00
Todd Turnidge 77b99396e8 Disallow deferred loading when using isolate reloading. 
Update status files.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2144113002 .
 2016-07-13 15:25:06 -07:00
John McCutchan 80cca0ec0e More status file updates for reload bots 
BUG=

Review URL: https://codereview.chromium.org/2146043002 .
 2016-07-13 09:19:20 -07:00
Ryan Macnak cdacb9b8a2 Update status files for caching-JIT snapshots. 
Review URL: https://codereview.chromium.org/2144813004 .
 2016-07-12 18:31:40 -07:00
John McCutchan 09944945ab Update service.status for hot_reload 
BUG=

Review URL: https://codereview.chromium.org/2142143003 .
 2016-07-12 12:41:20 -07:00
Brian Wilkerson afd21330f7 Generalize the first argument in an assert to be an expression (issue 26865) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2140673004 .
 2016-07-12 11:02:51 -07:00
Regis Crelier 9ebf264b70 Update dart2js language status file with crashing tests (issue was filed). 
R=asiva@google.com

Review URL: https://codereview.chromium.org/2146533002 .
 2016-07-12 10:50:13 -07:00
Regis Crelier 455110c6ee Tighten check disallowing use of initializing formals (fixes #26855). 
Add regression test.
Add exception for analyzer (filed an issue).

R=asiva@google.com

Review URL: https://codereview.chromium.org/2139003002 .
 2016-07-11 15:30:24 -07:00
John McCutchan 257bd302bb Update language.status for hot reload tests 
BUG=

Review URL: https://codereview.chromium.org/2134393002 .
 2016-07-11 14:40:15 -07:00
Harry Terkelsen 44cd029db8 update status files now that trailing commas are implemented 
BUG=

Review URL: https://codereview.chromium.org/2133243002 .
 2016-07-08 10:42:41 -07:00