dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Martin Kustermann be01bf89b3 VM: [Kernel] Skip large_class_declaration_test with --compiler=dartk/dartkp 
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2623833003 .
 2017-01-10 10:44:05 +01:00
Regis Crelier 7b68f5a2ee Status update: 3 previously failing kernel tests are now passing, most probably 
fixed by https://codereview.chromium.org/2624543002/

R=hausner@google.com

Review-Url: https://codereview.chromium.org/2621733003 .
 2017-01-09 16:21:41 -08:00
Martin Kustermann 663febe910 VM: [Kernel] Status file triaging of language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2624563002 .
 2017-01-09 22:04:49 +01:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1 
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
 2017-01-09 12:46:20 -08:00
Martin Kustermann 98e3037f41 Share common failures between kernel and non-kernel in language_kernel.status -> language.status 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2621623002 .
 2017-01-09 13:53:23 +01:00
Florian Loitsch e0abc45287 Add test that crashes dart2js. 
When a typedef compilation fails, it seems to replace itself with a dynamic type. However, that type leads to a crash later in the pipeline.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2607133002 .
 2017-01-06 13:27:35 +01:00
Johnni Winther e43c9e732b Disable test for fast-startup. 
Review-Url: https://codereview.chromium.org/2618753005 .
 2017-01-06 09:41:51 +01:00
Florian Schneider 97acc859cc Make test work with Dartium. 
Dartium requires main() to have zero arguments. Standalone VM accepts both.

TBR=asiva@google.com,

Review-Url: https://codereview.chromium.org/2613203002 .
 2017-01-05 21:37:10 -08:00
Florian Schneider 86e902ce5a Fix test status of new test for dartk. 
TBR=vegorov@google.com

BUG=

Review-Url: https://codereview.chromium.org/2617903003 .
 2017-01-05 19:08:09 -08:00
Florian Schneider 4347f9f0a2 Fix test status for hot-reload for a new test 
The test uses deferred libraries which are not supported with hot reload.

TBR=johnmccutchan@google.com,

Review-Url: https://codereview.chromium.org/2616053002 .
 2017-01-05 18:41:02 -08:00
Florian Schneider 9c82d88d67 VM: Fix bug in deferred loading. 
In some cases when loading a deferred library twice, the VM would crash/throw.

Make sure we generate the correct static NoSuchMethod error when referring to
a deferred library that is not loaded yet.

Fixes #28278.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2618823002 .
 2017-01-05 18:20:51 -08:00
Zach Anderson cf1a432ac7 Gardening: Update status file for kernel crash 
I believe this is by design as there are no mirrors in precompiled
mode.

Review-Url: https://codereview.chromium.org/2616793003 .
 2017-01-05 11:19:49 -08:00
Regis Crelier 4e7ab97a20 Update dartk status file. 
Review-Url: https://codereview.chromium.org/2614743005 .
 2017-01-05 10:34:33 -08:00
Zach Anderson 8d709c279d Gardening: Tighten status update, adjust flaky test 
related #28276

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2613713006 .
 2017-01-05 10:30:43 -08:00
Regis Crelier dc0605012f Move Null type to the Bottom in the VM (fixes #28025). 
Fix wrong comments.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2608373002 .
 2017-01-05 10:05:31 -08:00
Zach Anderson 056fbcb92e Gardening: Update status for flaky optimized_stacktrace_test 
related #28276

Review-Url: https://codereview.chromium.org/2615533006 .
 2017-01-05 10:00:58 -08:00
Vyacheslav Egorov 8360a89fce Gardening: mark language/regress_28255_test SkipByDesign in configurations without mirrors. 
R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2610163005 .
 2017-01-05 17:12:05 +01:00
Johnni Winther 12491d4ab8 Fix needsNoSuchMethod computation for abstractly instantiated classes 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2612253002 .
 2017-01-05 16:42:38 +01:00
Bob Nystrom 45b771f946 Remove tests for generalized tear-offs. 
R=mit@google.com

Review-Url: https://codereview.chromium.org/2608363002 .
 2017-01-04 10:14:41 -08:00
Lasse Reichstein Holst Nielsen 775eb3bd23 Also expect errors in dartium for null-as-bottom tests 
Review-Url: https://codereview.chromium.org/2614713002 .
 2017-01-04 15:45:09 +01:00
Asger Feldthaus 0546f6b4b7 Support generic method syntax in kernel pipeline. 
Closes https://github.com/dart-lang/sdk/issues/28231
Closes https://github.com/dart-lang/sdk/issues/28238

R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2613683003 .
 2017-01-04 14:25:36 +01:00
Lasse R.H. Nielsen cbf69e80b4 Add test for Nullable-By-Default (Null is subtype of all types). 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2577083002 .
 2017-01-04 14:20:30 +01:00
Siva Annamalai 4ef532a979 Update status file for enum_syntax_test/05 which is not crashing under dartkp/dart_precompiled/debug mode anymore. 
Review-Url: https://codereview.chromium.org/2609953003 .
 2017-01-03 18:47:03 -08:00
Lasse R.H. Nielsen 821eeb1aac Update expectations for dartk-vm crashes. 
Review-Url: https://codereview.chromium.org/2606343002 .
 2017-01-03 13:38:30 +01:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
 2017-01-03 12:05:40 +01:00
Siva Annamalai c78cb290df Adjust co19 status files for dartium. 
Review-Url: https://codereview.chromium.org/2607223002 .
 2016-12-29 15:12:22 -08:00
Siva Annamalai c69cbb586f - report tear offs using the x#y syntax as a compilation error 
(fixes issue 27520)
- adjust status files to reflect all tests which have the x#y syntax as
  compile time errors.

BUG=27520
R=regis@google.com

Review-Url: https://codereview.chromium.org/2607173002 .
 2016-12-29 13:01:12 -08:00
Sigmund Cherem 7c3c297a8a dart2js rti fix: functions are subtypes of Object 
closes https://github.com/dart-lang/sdk/issues/28045

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2599073002 .
 2016-12-22 11:16:13 -08:00
Florian Loitsch 5464ae2c93 Update status file. 
Review-Url: https://codereview.chromium.org/2598993003 .
 2016-12-22 18:47:24 +01:00
Florian Loitsch 411e0d60ac Update status file. 
Review-Url: https://codereview.chromium.org/2600543002 .
 2016-12-22 18:07:28 +01:00
Johnni Winther f6b5361adb Support for Null as bottom in dart2js 
Closes #28026

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2595363002 .
 2016-12-22 15:01:33 +01:00
Kasper Lund 64a0188ac3 Revert "Runtime support for Null as any in dart2js". 
This caused failures on vm-kernel* and vm-precomp* bots.

This reverts commit 0a1ed5fab4.

TBR'ed.

R=johnniwinther@google.com
BUG=

Review-Url: https://codereview.chromium.org/2597943002 .
 2016-12-22 09:29:17 +01:00
Vyacheslav Egorov ff5292e5fb VM: Fix lazy_deopt_vm_test timeouts by limiting (re)optimizations to a single function. 
BUG=
TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2594013003 .
 2016-12-21 17:03:50 +01:00
Johnni Winther 0a1ed5fab4 Runtime support for Null as any in dart2js 
R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2587343006 .
 2016-12-21 14:59:09 +01:00
Vyacheslav Egorov e763fac3b7 VM: [DBC] Fix more problems with lazy deopt. 
Catch entries must record a lazy deoptimization descriptor because we patch catch entries if exception reaches a frame that has a pending lazy deoptimization.

StringInterpolate instruction was recording an incorrect lazy deoptimization environment - on DBC we drop arguments from it because it is a part of the return sequence and not a part of the calling sequence like on other architectures. This means one needs to pass correct argument count down to RecordAfterCall(Helper). StringInterpolate however has argument count of 0 but internally emits a call with a single argument leading to a mismatch if RecordAfterCall is used. Use
RecordAfterCallHelper instead.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2595553002 .
 2016-12-20 17:30:06 +01:00
Matthias Hausner b7cb4095f1 Fix dartium status 
assert_message test no longer fails, so fix the status file.

BUG=#28150

Review-Url: https://codereview.chromium.org/2587263002 .
 2016-12-19 16:06:37 -08:00
Vyacheslav Egorov 1fcc7384aa VM: [DBC] Fix lazy deoptimization after calls that return no values. 
On DBC calls return value on the stack instead of a dedicate register but not all calls have a return value (e.g. CheckStack does not) and such calls don't push anything. Implementation of a lazy deopt however assumed that value is always present and tried to manually preserve it by popping and pushing it back after the frame was rewritten. This of course damaged the frame if we performed a lazy deoptimization after the call that did not push anything.

Instead of manually preserving result value value use frame translation to handle it. This allows to handle calls that return value and those that do not uniformly in the Deopt bytecode. Compiler takes care of creating the right deoptimization environment instead.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2587133002 .
 2016-12-19 23:08:26 +01:00
William Hesse 1d7fb1c6ba Update status for language/assert_message_test on Dartium 
BUG=https://github.com/dart-lang/sdk/issues/28150
R=sortie@google.com

Review-Url: https://codereview.chromium.org/2586953002 .
 2016-12-19 11:16:34 +01:00
Asger Feldthaus 92f74d21e3 Update kernel status file after configurable import test was added. 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2577893006 .
 2016-12-16 15:59:29 +01:00
Lasse R.H. Nielsen 04c33c8413 Add one more test for configurable imports. 
R=eernst@google.com, mit@google.com

Review URL: https://codereview.chromium.org/2579253003 .
 2016-12-16 14:44:21 +01:00
Martin Kustermann 44b45f8f59 Mark language/generic_sends_test as passing 
Review-Url: https://codereview.chromium.org/2578423002 .
 2016-12-16 10:33:11 +01:00
Vyacheslav Egorov b0a0a42962 VM: [Kernel] Do not crash when encountering generic methods in Kernel. 
Instead do what source based front-end does for now: replace type parameters with dynamic.

BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2571393002 .
 2016-12-15 16:23:42 +01:00
Harry Terkelsen 4b840f2d13 fix assert with message 
Fixes https://github.com/dart-lang/sdk/issues/28106

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2576113002 .
 2016-12-14 15:51:49 -08:00
Matthias Hausner 2c0b605a96 Add optional message argument to assert statements in the VM. 
Add flag --assert-message to control the feature.

BUG=#24215
R=regis@google.com

Review-Url: https://codereview.chromium.org/2574003003 .
 2016-12-14 11:05:19 -08:00
Vyacheslav Egorov ddd6534540 VM: [Kernel] Update status files to mark failing language test. 
BUG=
TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2566283006 .
 2016-12-14 00:18:01 +01:00
Florian Loitsch 7374ec71bd Remove support for mixin typedefs in dart2js. 
Fixes #14410.
BUG= http://dartbug.com/14410
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2567943003 .
 2016-12-13 14:04:06 +01:00
Johnni Winther 0937e2a2e4 Update status 
Review-Url: https://codereview.chromium.org/2574723002 .
 2016-12-13 12:21:32 +01:00
Johnni Winther d4c9dc92e1 Fix rti encoding of generic methods 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2565413002 .
 2016-12-13 10:27:59 +01:00
Matthias Hausner 156fdef01d Revert "Add optional message argument to assert statements in the VM." 
This reverts commit 67e83dd79d.

BUG=

Review-Url: https://codereview.chromium.org/2558993005 .
 2016-12-09 09:50:27 -08:00
Matthias Hausner 67e83dd79d Add optional message argument to assert statements in the VM. 
Add flag --assert-message to control the feature.

Fixes issue #24215
BUG= http://dartbug.com/24215

This replaces Lasse’s CL  1307363005

patch from issue 1307363005 at patchset 140001 (http://crrev.com/1307363005#ps140001)

R=lrn@google.com

Review-Url: https://codereview.chromium.org/2564623003 .
 2016-12-09 09:25:58 -08:00