dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

5559 Commits

Author SHA1 Message Date
Emily Fortuna 942963fa2e Add TypeVariable analysis in closure conversion. 
Bug:
Change-Id: I4155ceb042295934cc3c9125d275dc5f034675dd
Reviewed-on: https://dart-review.googlesource.com/6025
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-18 20:26:33 +00:00
Harry Terkelsen b49dd9fe98 register SUPER_NO_SUCH_METHOD feature when appropriate 
Change-Id: If620aa0bb051d8bd014070e0a2c3e4c525dc6729
Reviewed-on: https://dart-review.googlesource.com/6643
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-18 19:54:12 +00:00
Stephen Adams 69b50ed990 dart2js-kernel: Fix bug with finding optional parameter default values 
Change-Id: Iefa443318124838aeafa9998e08d1143c1976dc4
Reviewed-on: https://dart-review.googlesource.com/6346
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-15 23:54:22 +00:00
Sigmund Cherem 1ca12788c6 Revert "Check whether type-arguments and type-parameters length match from the body builder." 
This reverts commit 321a4ec048.

Some VM tests expect to see the behavior with a raw type instead of
an invalid type. I'll revert first, then resend this CL with the default
result changed.

R=ahe@google.com

Change-Id: I2cdd855dbaec93d0a0c257f7e202518fd9b59c81
Reviewed-on: https://dart-review.googlesource.com/6342
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-15 22:15:09 +00:00
Stephen Adams dccce129e4 dart2js-kernel: Don't crash on non-constant constants 
Change-Id: I7919ccdcd72f6653d2baa3c25c5d18df982ccda4
Reviewed-on: https://dart-review.googlesource.com/5941
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-15 21:44:24 +00:00
Stephen Adams 79d918aaf3 update dart2js kernel status 
TBR=sigmund@google.com

Change-Id: Ie897e2af7153eafa10e0ddb13484e02221370ed7
Reviewed-on: https://dart-review.googlesource.com/6170
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-15 21:12:18 +00:00
Sigmund Cherem 321a4ec048 Check whether type-arguments and type-parameters length match from the body builder. 
Bug:
Change-Id: I395365393c9032ff179d675f42ca56b7981531e0
Reviewed-on: https://dart-review.googlesource.com/5620
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-15 20:37:41 +00:00
Harry Terkelsen 3a25ead178 Generate super.noSuchMethod if super call is malformed 
This doesn't fix all of the errors with 
'Error: ".function" called on null' stacktraces. 

Change-Id: I7ddc0405db7e2f028eb27028c854dab29a0adf16
Reviewed-on: https://dart-review.googlesource.com/5522
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-15 20:03:51 +00:00
Stephen Adams ee3d649a6e dart2js-kernel: Implement _DuplicatedFieldInitializerError 
Bug:
Change-Id: I14925233d4275afbb0ec8bc17752acd43e04c9ac
Reviewed-on: https://dart-review.googlesource.com/5602
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-14 18:21:38 +00:00
Emily Fortuna 83f5b64ea1 When accessing "super" properties, capture "this". 
Bug:
Change-Id: I770aed67e2e4d078feba7d04662029e9a0a454fc
Reviewed-on: https://dart-review.googlesource.com/5601
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-14 17:37:07 +00:00
Johnni Winther 5aa3259698 Handle break to labeled statement 
No tests yet. Kernel doesn't support file-offsets on labeled statement.

Change-Id: I5dcfcc21433aec5ad0be26bfef5bbca0b609ba35
Reviewed-on: https://dart-review.googlesource.com/5161
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-14 08:59:11 +00:00
Stephen Adams 26d220445c dart2js-kernel: Handle type variables with names like '#U0' 
R=sigmund@google.com

Bug:
Change-Id: I91972d7b0324e0ba7f4969529e203da40923ad55
Reviewed-on: https://dart-review.googlesource.com/5580
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-13 23:18:21 +00:00
Harry Terkelsen c0edd4ee0e ensure type arguments for instantiations are in the class hierarchy 
Change-Id: Ife2da89018278fa5e5a9b940f7052006f2f7f841
Reviewed-on: https://dart-review.googlesource.com/5485
Commit-Queue: Harry Terkelsen <het@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 18:55:48 +00:00
Stephen Adams 0bfad6483e de-dup dart2js kernel status files 
TBR=sigmund@google.com

Bug:
Change-Id: I41d0bfdad38f0ab65649cd9d69e82097e9877fe2
Reviewed-on: https://dart-review.googlesource.com/5483
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-13 17:13:03 +00:00
Stephen Adams 5ab592a3b5 Compute field initializers in correct order with respect to type parameters and other initializers 
Change-Id: I253515188d4428de88bcca4799dac6204d3e7329
Reviewed-on: https://dart-review.googlesource.com/5299
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-13 02:16:32 +00:00
Alexander Markov 6fbab08b21 [Tests] Update status files for dartkp configuration 
This CL silences several tests for '$compiler = dartkp' configuration
in order to make vm-kernel-precomp-* buildbots greener.
These tests are already silenced for '$compiler = precompiler' or
'$compiler = dartk' configurations.

Change-Id: Ia3208853655868ae4cf39775d40db15218c1a1df
Reviewed-on: https://dart-review.googlesource.com/5286
Reviewed-by: Alexander Aprelev <aam@google.com>
 2017-09-12 20:08:51 +00:00
Emily Fortuna c73cbf5615 Dart gardening: Update status files for dart2js 
Bug:
Change-Id: I6b95fcd23dcf5de36ded6ad819bacfc1e99aae76
Reviewed-on: https://dart-review.googlesource.com/5292
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-12 20:05:31 +00:00
Beeravolu Siva Chandra Reddy 004a515217 Populate library imports and exports when loading library from kernel. 
Change-Id: If6cc94aa186948caa8798212d6161da650ff2d8e
Reviewed-on: https://dart-review.googlesource.com/4381
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-09-12 10:44:49 +00:00
Johnni Winther 80a3fe0532 Update --dart2js-with-kernel status 
Change-Id: If5a8247f5c76385934b4a8794c07863a31d51f2a
Reviewed-on: https://dart-review.googlesource.com/5160
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-12 08:47:00 +00:00
Emily Fortuna 553e4a0967 Don't make field entities for variables in boxes. 
Bug:
Change-Id: Ie31e88438da93a1d54c8c688a5ccd212bb81bb28
Reviewed-on: https://dart-review.googlesource.com/4241
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-09-11 23:32:51 +00:00
pq 2fbb267460 Revert "Migrate test block 152 to Dart 2.0." [TBR]. 
This reverts commit 9744f5d212.

Change-Id: I1299f0e9ea14c776c315dd8439bd9ab255d9060b
Reviewed-on: https://dart-review.googlesource.com/5001
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-09-11 18:24:16 +00:00
pq 9744f5d212 Migrate test block 152 to Dart 2.0. 
Change-Id: Iad60c7a650595703b0a0109d15d8971a4c209d84
Reviewed-on: https://dart-review.googlesource.com/3701
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-09-11 17:11:17 +00:00
Harry Terkelsen 607e3ecd69 Fixed the test by checking if typedefs are malformed. 
This prevents the getFunctionTypeOfTypedef call from failing in
checked mode by returning a MalformedType.

Revert "Revert "Add types referenced in is-checks to the class hierarchy""

This reverts commit e0a4839c3e.

Change-Id: I1e94ba5ba345c36e04e54da6e8c0580a21836838
Reviewed-on: https://dart-review.googlesource.com/3422
Reviewed-by: Harry Terkelsen <het@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-07 19:56:26 +00:00
Emily Fortuna d7e28e386d Make constructor entities and constructor body entities share the same locals map lookup. 
Bug:
Change-Id: Icdd1bfe64aaa0e2362d71f005a1037d1ab947402
Reviewed-on: https://dart-review.googlesource.com/3425
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-07 18:10:35 +00:00
Bob Nystrom e9255446b3 Migrate block 117. 
Change-Id: Ie2f7d2b93120dc2f2fbef6d1c01604d240ecc7da
Reviewed-on: https://dart-review.googlesource.com/3420
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-06 23:32:58 +00:00
Stephen Adams eacbac7f90 Update dart2js kernel status 
TBR=efortuna@google.com

Change-Id: Ie25df9f9efe6093bc3c55d254a868ca093b95ee6
Reviewed-on: https://dart-review.googlesource.com/3789
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-06 23:21:41 +00:00
Emily Fortuna 0a36b589be Update test statuses from c019 tests. 
TBR

Bug:
Change-Id: I7e3c9ae36aae8bfd1bf9a2355ba8a65904d90106
Reviewed-on: https://dart-review.googlesource.com/3780
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 22:23:58 +00:00
Florian Loitsch 051f0f1267 Added new entries to the .gitattributes file. 
Also updated the tests so that we don't forget in the future.

Change-Id: I0a998af306a0b6fa54b3c86cf164fdfe1f76340d
Reviewed-on: https://dart-review.googlesource.com/3624
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-06 18:05:57 +00:00
Jennifer Messerly 719e854ce4 fix regress_29481_test status for analyzer 
(it's passing now)

Change-Id: I7c0b242c3569dd21b1c8c3c66257fe5874c135c0
Reviewed-on: https://dart-review.googlesource.com/3344
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2017-09-05 23:21:32 +00:00
Harry Terkelsen e0a4839c3e Revert "Add types referenced in is-checks to the class hierarchy" 
This reverts commit a577b303f0.

Bug:
Change-Id: I8a02bf3ef559de8af62aef9d4b7e840975bb5b47
Reviewed-on: https://dart-review.googlesource.com/3343
Reviewed-by: Harry Terkelsen <het@google.com>
 2017-09-05 23:13:29 +00:00
Harry Terkelsen a577b303f0 Add types referenced in is-checks to the class hierarchy 
Change-Id: Ia250501052efc051779f75f9d582c1ceaa2c78f4
Reviewed-on: https://dart-review.googlesource.com/3384
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-05 21:53:35 +00:00
Stephen Adams 080169c51a dart2js kernel: sort constants 
reviewed: https://codereview.chromium.org/3011803002

TBR=sigmund@google.com

Change-Id: Ic444964c3d5995d12e4e00f0af44c175533b7291
Reviewed-on: https://dart-review.googlesource.com/3340
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-05 20:30:43 +00:00
Emily Fortuna 3aa574d95d Add ability to look up type parameters that are associated with ClassEntities with the element environment. 
This is the reapplication of this already approved CL: https://codereview.chromium.org/3010943002/ but now with Gerrit.

Bug:
Change-Id: I4c2204d1f76bdec4bcad993c8a11b5f003d38d77
Reviewed-on: https://dart-review.googlesource.com/3341
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-05 19:36:55 +00:00
Stephen Adams 87f127e639 dart2js kernel status updates 
- remove duplicates and dead language tests and update crash reasons

Bug:
Change-Id: I5027548fa0f8bd692d7013fab37bfc89fc66f315
Reviewed-on: https://dart-review.googlesource.com/3307
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-05 18:27:06 +00:00
Florian Loitsch 491d67cae6 Tests only fail in non-startup mode. 
Change-Id: If95ea4a3572d3067004e92d94e934c30e327c81d
Reviewed-on: https://dart-review.googlesource.com/2900
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-04 13:37:07 +00:00
Florian Loitsch 198d816747 Mark conditional_import tests as failing for dart2js. 
Review-Url: https://codereview.chromium.org/3007093003 .
 2017-09-04 12:20:17 +02:00
Harry Terkelsen bb312921ac Revert "Add types referenced in is-checks to the class hierarchy" 
This reverts commit c8d2478747.

BUG=

Review-Url: https://codereview.chromium.org/3012733002 .
 2017-09-01 15:27:28 -07:00
Harry Terkelsen c8d2478747 Add types referenced in is-checks to the class hierarchy 
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/3011793002 .
 2017-09-01 15:02:59 -07:00
Emily Fortuna b1dd578da7 Don't try to add abstract methods to the codegen work queue to generate bodies 
BUG=
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/3012683002 .
 2017-09-01 10:21:03 -07:00
Johnni Winther 374df045e7 Handle forwarding constructors to unnamed mixin applications 
+ handle instance fields from mixins
+ change class sorting to put unnamed mixin applications last

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3005823002 .
 2017-09-01 19:07:02 +02:00
Sigmund Cherem 650a2d72a2 Undo status change. 
It appears this no longer reproduces (it might have been from a stale drt).

Review-Url: https://codereview.chromium.org/3011853002 .
 2017-09-01 10:03:17 -07:00
Emily Fortuna ea038bd8e0 Pass in this as a free variable to the closure class 
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3009903002 .
 2017-08-31 10:41:19 -07:00
Johnni Winther eabc6fdff3 Update --dart2js-with-kernel status 
Review-Url: https://codereview.chromium.org/3012633002 .
 2017-08-31 14:29:20 +02:00
Karl Klose b2dca8b51d [gardening] Mark language/conditional_import tests as failing on dart2js-drt 
TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3005953002 .
 2017-08-31 13:51:49 +02:00
Karl Klose d8218d1fc3 [gardening] Mark language/reexport_core_test as no longer crashing 
TBR=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3008963002 .
 2017-08-31 08:05:27 +02:00
Stephen Adams 9bc8e5932a Update dart2js kernel status in language and language_2 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/3005933002 .
 2017-08-30 15:51:29 -07:00
Janice Collins e31e611101 Fix many bots. 
This covers the following cases:

python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/bad_constructor_test/05
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/closures_with_complex_params_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_async_star_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_async_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_field_mixin6_test/01
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_field_mixin6_test/none
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_function_typedef_test/01
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_method_types_test/01
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/generic_method_types_test/02
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/typecheck_multifield_declaration_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/unused_overridden_async_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language_2/vm/allocation_sinking_vm_test
python tools/test.py -m release -c dart2js -r d8 --minified --dart2js-with-kernel --use-sdk --dart2js-batch --reset-browser-configuration language/reexport_core_test
python tools/test.py -m release -c dartk language_2/bad_constructor_test/05
python tools/test.py -m release -c dartk language/reexport_core_test

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/3005863003 .
 2017-08-30 14:55:29 -07:00
Janice Collins 3a8a1ca54c Migrate test block 113 to Dart 2.0. 
Request particular attention to generic_creation_test and generic_field_mixin6_test, but all of the following required tweaks
to the status files to pass tests:

generic_closure_test
generic_function_bounds_test
generic_function_dcall_test
generic_function_typedef_test
generic_field_mixin6_test
generalized_void_syntax_test
generic_functions_test

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3008573002 .
 2017-08-30 08:50:16 -07:00
Janice Collins fe7c2acd4e Migrate block 163 to Dart 2.0. 
Interesting tests requiring status file or other changes:

type_variable_promotion_test
type_variable_scope_test
type_variable_static_context_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
unary_plus_negative_test
unhandled_exception_negative_test
unbound_getter_test
unresolved_in_factory_negative_test -
unresolved_top_level_var_negative_test - changed from negative to compile-time error
unresolved_top_level_method_negative_test - changed from negative to compile-time error
vm/async_await_catch_stacktrace_test

BUG=
R=lrn@google.com

Review-Url: https://codereview.chromium.org/3008723002 .
 2017-08-30 08:05:12 -07:00
Johnni Winther 3f0c2d4bb3 Handle missing break in last switch case 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/3003283003 .
 2017-08-30 11:32:20 +02:00