Commit Graph

5559 Commits

Author SHA1 Message Date
Sigmund Cherem 5428a12b84 Ensure that env includes the actual mixin application fields and procedures.
From the docs of mixedInClass and mixin: the former is the direct thing that is
mixed in, but if it is a named mixin application it may not contain the actual
fields and procedures, instead the `.mixin` class does.

Change-Id: I049ced771925431d613b0b661154c1761fbe0a51
Reviewed-on: https://dart-review.googlesource.com/38161
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
2018-02-02 07:10:30 +00:00
Brian Wilkerson 4cad8c202d Attempt to fix bot status
Change-Id: Ib934765771306d57b218d3691c3bba249f1d90ef
Reviewed-on: https://dart-review.googlesource.com/37863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-31 19:51:55 +00:00
Régis Crelier ed1d8bd475 [VM parser] Complete support for generalized void (fixes #30516).
'void' is now allowed as type annotation for locals, fields, and formal
parameters, in addition to being previously allowed as type argument.
Update status files.

Change-Id: I6459f56824dc0a695615d8dc87c9a8a1f9be29ef
Reviewed-on: https://dart-review.googlesource.com/37651
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2018-01-31 00:56:41 +00:00
Brian Wilkerson 1d6b2de09c Another status file update to fix the bots
Change-Id: I4cd60ab7c74573f136db44c2c4075d20abcd6688
Reviewed-on: https://dart-review.googlesource.com/37643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-01-30 19:47:59 +00:00
Brian Wilkerson f8596607bb Update status files to fix bots
Change-Id: I1659bc7e8ef8452daf44ae6ca30064f01f338272
Reviewed-on: https://dart-review.googlesource.com/37580
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-01-30 17:33:09 +00:00
Johnni Winther 09bb73427e Compute implicit is-tests more precisely.
Closes #21969

Change-Id: If446df1e1ae4cdfb4d32580abb7f12fb213d678c
Reviewed-on: https://dart-review.googlesource.com/35865
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-26 22:26:17 +00:00
Siva Annamalai 8d9d68751a More status file updates
Change-Id: I2a767ba0ce7ab0a8e65add40933a19f969f401cc
Reviewed-on: https://dart-review.googlesource.com/36161
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-01-21 06:36:02 +00:00
Sigmund Cherem 7e78f0a952 Update more dart2js .status files
This covers legacy mode,  but using fasta.

Change-Id: I7af9518d8a69512012400f6215d0195fb6069e51
Reviewed-on: https://dart-review.googlesource.com/36060
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-19 20:41:47 +00:00
Erik Corry 25f08d3c5c Disable cyclic_type_test/03 which is failing
R=ahe@google.com

Bug: 31944
Change-Id: I7474f4356c3569a95a28110b69f274c785356203
Reviewed-on: https://dart-review.googlesource.com/35961
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-19 15:33:25 +00:00
Vyacheslav Egorov 01658c8491 [gardening] Fix error in language.status file.
TBR=ahe@google.com

Change-Id: Ia9033eefd271d36d9945e7d0d812f925eec653be
Reviewed-on: https://dart-review.googlesource.com/35980
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-01-19 14:32:53 +00:00
Lasse R.H. Nielsen 08edf99bde Mark language/cyclic_type_test/03 as crashing on one platform.
Change-Id: Ifc612e692cedeb105e9bebdbddacaeb48f66a2cc
Reviewed-on: https://dart-review.googlesource.com/35963
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-01-19 14:06:32 +00:00
William Hesse 17bc2b78c4 Update status for a language test with a fasta compile-time error
Bug: https://github.com/dart-lang/sdk/issues/31935
Change-Id: Ifc25e8d4684879184418cb9e3d2f71cc71a88c30
R: ahe@google.com
Reviewed-on: https://dart-review.googlesource.com/35880
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-19 09:03:29 +00:00
Jens Johansen 55f4a6e56c [kernel] Update status after fix of #31817 (take 2)
Change-Id: I2e9576042d8476fc2b7f7c1857f0c6210038a81b
Reviewed-on: https://dart-review.googlesource.com/35861
Reviewed-by: Jens Johansen <jensj@google.com>
2018-01-19 07:53:22 +00:00
Sigmund Cherem a4df86676f Adjust .status files
CL https://dart.googlesource.com/sdk/+/3fcede3c7f57a9b3457cae83d928694b864f01bd
changed the behavior. A similar change was included for language_2, this is the
same kind of changes for the old language/ suite.

TBR=ahe@google.com

Change-Id: I4ea256442481d92bbb7eaa4d4d47294f5222e8d0
Reviewed-on: https://dart-review.googlesource.com/35808
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-18 22:11:14 +00:00
Sigmund Cherem e2ad2db805 Generate checks for library-is-loaded to fasta and dart2js.
Change-Id: Ibf453ca7390b81da7231dcb1be43e426c00d6eeb
Reviewed-on: https://dart-review.googlesource.com/35100
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-01-18 20:17:14 +00:00
Erik Corry 5ed2f25f40 There is no longer a safarimobilesim test runtime.
And so there is no need to maintain status files for this platform.

R=whesse@google.com

Change-Id: Ie70e4b7308cfd9b1b179b2d1eeeb8f36dd1a62dc
Reviewed-on: https://dart-review.googlesource.com/34824
Commit-Queue: Erik Corry <erikcorry@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-01-17 13:13:17 +00:00
Johnni Winther 897114ff79 Update dart2js_with_kernel status
Change-Id: Icf935c78ba915b487c1213d59b328ab884324e5d
Reviewed-on: https://dart-review.googlesource.com/35140
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-01-17 08:00:40 +00:00
Sigmund Cherem 9cdf04e8ee Mark conditional_import_tests as passing in dart2js
TBR=sjindel@google.com

Change-Id: I6310ce0f1dae916d4075453ed6fcdad2fcb1f38e
Reviewed-on: https://dart-review.googlesource.com/35061
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-17 00:58:26 +00:00
Sigmund Cherem 0e1a407823 Produce a static error when using kernel and mirrors
Just noticed that the 'supportsRelection' flag was not checked when running with
'--use-kernel'.

Change-Id: I9f4bd540ad963c33c8b9013860ac63b1c6707299
Reviewed-on: https://dart-review.googlesource.com/35006
Reviewed-by: Harry Terkelsen <het@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-01-17 00:56:12 +00:00
Sigmund Cherem 96f915faa1 Update status for dart2js-with-kernel after disabling int64 in dart2js
TBR=sra@google.com

Change-Id: I3e13493ba619fb16ed9731fc85fc14938022ef59
Reviewed-on: https://dart-review.googlesource.com/35000
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-01-16 22:30:04 +00:00
Sigmund Cherem 0c04eb53c7 Disable int64 when running dart2js
The goal is to renable it as soon as we migrate our constant-evaluator and
constant folding to use Bigint.

Change-Id: I3bba1bbe07517e9cb496896b3417f58173878d62
Reviewed-on: https://dart-review.googlesource.com/34302
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-01-16 19:52:22 +00:00
Sigmund Cherem f1390f7660 Add missing return in loadLibrary tearoff
The code to represent a tearoff of loadLibrary looked like this:

  Future __loadLibrary__lib1 () {
    lib1.loadLibrary();
  }

but should have been like:

  Future __loadLibrary__lib1 () {
    return lib1.loadLibrary();
  }

Change-Id: I31efb5bee9f7e376660602c1b842a90a0a2659a4
Reviewed-on: https://dart-review.googlesource.com/34510
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-01-16 19:35:32 +00:00
William Hesse 63511838dd Update status for failing local function test on dart2js
Bug: https://github.com/dart-lang/sdk/issues/31879
Change-Id: I141e2ef9c4cc40796d3b3198e4183a1c05f0b063
TBR=johnniwinther@google.com
Reviewed-on: https://dart-review.googlesource.com/34382
Reviewed-by: William Hesse <whesse@google.com>
2018-01-12 14:01:01 +00:00
Johnni Winther 8e8915f538 Support generic closures in rti analysis
Change-Id: I1d393cff5b83f8db69e7bddb8ecfcd4a5205854f
Reviewed-on: https://dart-review.googlesource.com/32700
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-08 11:36:40 +00:00
Martin Kustermann 3c5211fd93 [Gardening] Remove passing test from status file
Change-Id: Ie465eb85631e875a295e14f10231bda94f86a6ea
Reviewed-on: https://dart-review.googlesource.com/32764
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2018-01-08 11:18:22 +00:00
Harry Terkelsen 11d1b6f0db update status files after switch case fixes
Change-Id: If0127431e9237478ce12ff495d32eff144781bcd
Reviewed-on: https://dart-review.googlesource.com/32670
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
2018-01-05 23:29:29 +00:00
Alexander Markov c051a0b905 [VM, Tests] Turn Dart 2.0 fixed-size integers ON by default, v2
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.

This CL includes ff9fc413a7 with fixes.

Change-Id: I632d8177e9d07cd82ecea75ab6c325681b3a25c9
Reviewed-on: https://dart-review.googlesource.com/32443
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-01-05 01:44:56 +00:00
Alexander Markov 90551f6aa5 Revert "[VM, Tests] Turn Dart 2.0 fixed-size integers ON by default"
This reverts commit ff9fc413a7.

Reason: buildbot failures.
Change-Id: I68ffde271c8ba3b212e3bf015e2e550c8c891441
Reviewed-on: https://dart-review.googlesource.com/32442
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-01-04 19:04:44 +00:00
Alexander Markov ff9fc413a7 [VM, Tests] Turn Dart 2.0 fixed-size integers ON by default
Dart 2.0 fixed-size integers are enabled in Dart VM in all modes.
Status of legacy tests is updated.

Change-Id: I967a413c0b81eb92cf6be78ad3ee324798288bd2
Reviewed-on: https://dart-review.googlesource.com/31406
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-01-04 18:02:57 +00:00
Sigmund Cherem d85651846f Update .status files
One language test "passes" when we no longer complain about the mixin issue.

Bug:
Change-Id: I5aeb4ead7d3faf6ec756eeb11fecc20bcfb4c16e
Reviewed-on: https://dart-review.googlesource.com/31260
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-12-21 22:49:02 +00:00
Brian Wilkerson 439dfe0c29 Revert "Produce an error if there would be an exception thrown by an assert in an initializer list"
Change-Id: I21553a5a3bf12b7636d9ef507092d0e19f9c0d57
Reviewed-on: https://dart-review.googlesource.com/30041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-12-16 01:44:13 +00:00
Brian Wilkerson 71dd8acda1 Produce an error if there would be an exception thrown by an assert in an initializer list
Change-Id: Ia95b2e09c64846d319d940e29c422355ab972da6
Reviewed-on: https://dart-review.googlesource.com/29700
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-12-15 23:03:15 +00:00
Emily Fortuna 4cd0593574 Tiny fix to fix type errors in our compiler while running host-checked
and deferred loaded code.

Bug:
Change-Id: I57b51a287fd7ffad59a1a59eae34e739b5e5603b
Reviewed-on: https://dart-review.googlesource.com/29745
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
2017-12-15 18:42:33 +00:00
Leaf Petersen 53908b0790 Remove warning for "is" checks with generic type parameters.
The analyzer used to emit a warning when a type parameter to a generic
method was used in an "is" check.  This warning was there to help
users write code that worked correctly on both Dart 1.0 and 2.0.  Now
that 2.0 generic methods are being more broadly supported and used,
this warning is blocking further library work, and is being removed.

Fixes https://github.com/dart-lang/sdk/issues/30530

Bug:
Change-Id: I70395305ad082aee3072b5beeb0b1b7f7883391b
Reviewed-on: https://dart-review.googlesource.com/29821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-12-15 18:12:03 +00:00
Brian Wilkerson df479ca916 Accept a trailing comma in asserts in initializer lists (issue 31320)
Change-Id: I6166aac91abc65c0817d14e1d98f5944236016bf
Reviewed-on: https://dart-review.googlesource.com/29520
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-12-14 15:49:45 +00:00
Johnni Winther 5f06d51d1a Enable inlining by default
Change-Id: I4810959da23193d8a1b572b4feea329a2f4b2f31
Reviewed-on: https://dart-review.googlesource.com/29320
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-12-14 10:02:54 +00:00
Johnni Winther 0edef589d4 Ensure type variables for inlined constructors and mixin fields
Change-Id: I348acffb7842ff1c9f28ebf73c507e282c6a045e
Reviewed-on: https://dart-review.googlesource.com/29080
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2017-12-14 08:53:21 +00:00
Siva Annamalai bb240a6cbf Skip all Dart 1.0 tests in language/corelib and standalone tests when kernel mode
is specified as we will only support Dart 2.0 in kernel mode.

Change-Id: I712fa6e0f733738e4b722aeb10b5eba6a64316c5
Reviewed-on: https://dart-review.googlesource.com/28520
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2017-12-12 16:16:21 +00:00
Erik Ernst 10411158db Reclassified a couple of test outcomes as "syntax error".
Change-Id: I140e12f0fb296a157cd7d89b58d83c5dbaced643
Reviewed-on: https://dart-review.googlesource.com/27221
Reviewed-by: Erik Ernst <eernst@google.com>
2017-12-07 14:24:48 +00:00
Morten Krogh-Jespersen 3db4b1070b Normalize all status files and enable presubmit hook.
This CL normalizes all status files by the status file normalizer found at
pkg/status_file/bin/normalize.dart.

To make sure all status files are kept in pristine condition, a linter is placed
on the presubmit hook. The linter can be found at pkg/status_file/bin/lint.dart.

Bug:
Change-Id: I20bdb74824be65f079b8c9ab08b7ae38394d637f
Reviewed-on: https://dart-review.googlesource.com/24112
Commit-Queue: Morten Krogh-jespersen <mkroghj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2017-12-07 08:38:30 +00:00
Sigmund Cherem 30f154c8ea Bring status on a few suites up to date for --checked and --fast-startup
TBR=efortuna@google.com

Change-Id: If7196983eecf4cd7932e20332dca5471f24319f0
Reviewed-on: https://dart-review.googlesource.com/27087
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2017-12-07 05:08:30 +00:00
Emily Fortuna cd23222050 Triaging remaining kernel checked mode test failures.
Bug:
Change-Id: Id17cb593259259d9535f47b3fd9ecdceaaa27645
Reviewed-on: https://dart-review.googlesource.com/26980
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
2017-12-06 23:56:02 +00:00
Emily Fortuna fe178582ef Add constraint checks for constructors (factory and generative).
Bug:
Change-Id: I68a3420276cd49c33ca4697262117aa8d4a3ff0f
Reviewed-on: https://dart-review.googlesource.com/26740
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2017-12-06 21:51:30 +00:00
Harry Terkelsen 9f973c6599 Disable importing dart:mirrors in kernel mode
Change-Id: I9a4b7d32a67cc109b9a9d3a33b5996176988a97c
Reviewed-on: https://dart-review.googlesource.com/26404
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
2017-12-06 18:44:15 +00:00
Emily Fortuna dc1b5525bf Create temporary Method type in kernel world for compatibility with Dart 1
Bug:
Change-Id: I9efa163ce1a9a76df405f32d35850743e7f090cc
Reviewed-on: https://dart-review.googlesource.com/25723
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2017-12-04 19:37:54 +00:00
Johnni Winther cc21375ab0 Update dart2js_with_kernel status after revert
Change-Id: I4ab972028e1d080b7a82f2b7dc342c72413d750b
Reviewed-on: https://dart-review.googlesource.com/25620
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-12-01 18:55:01 +00:00
Johnni Winther ede2367ef6 Update dart2js_with_kernel status
Change-Id: Iac1643bfe2110eb5c3448dd865e016410b59d494
Reviewed-on: https://dart-review.googlesource.com/25540
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2017-12-01 17:35:09 +00:00
Emily Fortuna b7ef9072f1 Set "type" for FutureOr to dynamic (temporarily).
Bug:
Change-Id: Ie4a376316c0fa444642c2535c0a97f3245c92fda
Reviewed-on: https://dart-review.googlesource.com/24621
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
2017-11-30 18:18:04 +00:00
Lasse R.H. Nielsen f205ec5d6c Make bots green. See issue #31496
Change-Id: I6870407fad0ca5a5ea94504b7c5b3d1c3b17c593
Reviewed-on: https://dart-review.googlesource.com/24920
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Anders Sandholm <sandholm@google.com>
2017-11-30 11:57:53 +00:00
Ryan Macnak 9b7b91ee66 Reapply "[vm] Tighten stack overflow check in the parser."
Use a smaller recursion limit that handles IA32 ASAN.

Bug: https://github.com/dart-lang/sdk/issues/31158
Change-Id: If2a5694722619d100be2e91f952210d92af4ec7c
Reviewed-on: https://dart-review.googlesource.com/24623
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2017-11-30 02:11:22 +00:00