jimhug@google.com
71513ed70f
better property overriding field
...
+1 passing test for +10 lines in frogsh? I think this fixes a lot of property overriding field cases - but only one of those appears to be covered in the current tests.
Review URL: http://codereview.chromium.org//8483005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1238 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-06 18:56:12 +00:00
jimhug@google.com
1a5fa2832e
unary operators
...
+4 tests passing, -5 lines in frogsh
Review URL: http://codereview.chromium.org//8487003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1237 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-06 18:31:14 +00:00
jimhug@google.com
e50dda8026
more negative test fixes
...
TODO around fixing function types hack for concrete methods is getting bigger - but I'm going to punt that until the official workweek as it doesn't seem like much fun <smile>.
Review URL: http://codereview.chromium.org//8485002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1236 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-06 16:19:20 +00:00
jimhug@google.com
d5e00e9ae0
no-change, testing flakiness of dart_client tests
...
Review URL: http://codereview.chromium.org//8481024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1235 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-05 19:40:45 +00:00
jimhug@google.com
af117a0842
minor fixes
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//8481023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1234 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-05 18:19:19 +00:00
jimhug@google.com
e6f1d5c142
All skipped tests should now be "correctly skipped" which means they should not count towards the total tests when computing percentages.
...
Fixed bugs in validating libraries and in static checking for named parameters as the easiest way to clean up the status of these tests.
Review URL: http://codereview.chromium.org//8481022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1233 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-05 16:04:19 +00:00
jmesserly@google.com
a73af9f52c
Better runtime type checks. The generated code is nicer+faster and they're generated in more places. Since it's reasonably fast now, I enabled it in presubmit.py.
...
TBR=jimhug
Review URL: http://codereview.chromium.org//8457007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1232 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-05 00:44:53 +00:00
sigmund@google.com
b7c4e9b778
fix test
...
Review URL: http://codereview.chromium.org//8477011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1218 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 19:59:15 +00:00
ahe@google.com
b22f088173
Update status file to unbreak dart/frog/presubmit.py.
...
Review URL: http://codereview.chromium.org//8457008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1193 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 12:18:36 +00:00
ngeoffray@google.com
c93b5a40ea
Integrate leg as a component in test.py. Also update presubmit script to run tests with leg.
...
Review URL: http://codereview.chromium.org//8462004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1187 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 10:29:48 +00:00
jmesserly@google.com
b4cd0751a1
Reduces code generated by dynamic calls.
...
Also cleans type asserts
TBR=jimhug
Review URL: http://codereview.chromium.org//8334035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1163 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 21:16:50 +00:00
hausner@google.com
a6b3f4f19c
No returns allowed in constructors
...
Add compiler error message when a constructor explicitly returns a
value. Fixes bug/issue 224.
Review URL: http://codereview.chromium.org//8450009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1161 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 20:07:35 +00:00
zundel@google.com
2e6e49f78a
Integrate frog tests into presubmit.sh
...
Review URL: http://codereview.chromium.org//8437064
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1145 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 13:20:21 +00:00
ngeoffray@google.com
5d6af6602a
Bleeding edge change to get frog integrated into the testing infrastructure.
...
Review URL: http://codereview.chromium.org//8372095
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1140 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 12:15:55 +00:00
codefu@google.com
9f68a5c004
Naming scheme for negative tests
...
R=iposva
BUG=
TEST=
Review URL: http://codereview.chromium.org//8444001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1104 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 17:36:28 +00:00
hausner@google.com
7651034e9e
Two-phase constructors
...
This CL fixes the initializer evaluation order and brings the VM fully up to spec.
Constructors are executed in two phases: the initializer phase and the constructor body phase. An additional implicit parameter tells the constructor code whether to execute the initializer list or the body (or both).
If the super initializer call is not at the end of the initializer list, the super constructor has to be called twice. The arguments to the super initializer have to be evaluated and stored in temporary local variables. At the beginning of the constructor block, a second implicit super call is inserted.
If the super initializer call happens to be at the end of the list, none of this madness has to happen, except for the extra implicit parameter to the constructor.
Review URL: http://codereview.chromium.org//8440014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1102 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 17:19:15 +00:00
codefu@google.com
01d80fb5c4
Add negative test for invalid prefixes.
...
Update dartc's parser to validate identifier in string literal.
Add new error code.
http://code.google.com/p/dart/issues/detail?id=266
R=mmendez
BUG=
TEST=
Review URL: http://codereview.chromium.org//8441001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1099 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 16:54:27 +00:00
scheglov@google.com
a30bf8af1f
Mark WrongNumberTypeArgumentsTest as failing on VM
...
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8439042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1093 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 15:20:11 +00:00
scheglov@google.com
a2dfac76d7
Make some ErrorCode-s compile-time errors and some just type warnings
...
R=zundel@google.com
BUG=
TEST=
Review URL: http://codereview.chromium.org//8384012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1089 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 13:55:53 +00:00
sra@google.com
22b0df3723
Test for constructor order and bindings.
...
BUG=
TEST=
Review URL: http://codereview.chromium.org//8440015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1067 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 03:25:37 +00:00
jimhug@google.com
8b964a96ab
Most of these tests appear to be relying on checking code that will never be run. My model of dart is that these tests may not happen - unless compiled with a special --compile_all flag - and that we should fix the tests by adding some small amount of code to ensure that the broken code is reached.
...
I have some more detailed notes on a few of the tests which have different issues.
With these changes, the vm and dartc both still pass all tests (except for some confusing behavior in dartc on ThirdTest). However, these tests should match the expected semantics of dart more closely and allow for greater flexibility in deciding exactly when correctness must be verified.
Note: We still need to add a separate test for the --compile_all flag that will test the mode where we insist on compiling/checking all input code.
Review URL: http://codereview.chromium.org//8431016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1055 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-02 00:23:03 +00:00
regis@google.com
3125475ef8
Canonicalize types.
...
Review URL: http://codereview.chromium.org//8372041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1045 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 22:00:06 +00:00
fabiomfv@google.com
ec78d3fce6
https://code.google.com/p/dart/issues/detail?id=223
...
Review URL: http://codereview.chromium.org//8384018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1036 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 18:42:54 +00:00
ngeoffray@google.com
33ec29bf11
Add a new variable environment for testing, to replace the misusage of 'arch'.
...
Review URL: http://codereview.chromium.org//8408002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@993 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 09:12:55 +00:00
sra@google.com
60bbb9b0bc
Add test with implicit super() initializer.
...
TBR=hausner
BUG=286
TEST=
Review URL: http://codereview.chromium.org//8427025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@991 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 05:11:02 +00:00
srdjan@google.com
24b14c7e53
Fix for bug 5270133 by preventing wrong canonicalization. Fixes problem of sporadic Dart failures when running in checked mode. Fixed wrong tests.
...
Review URL: http://codereview.chromium.org//8432016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@983 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 00:12:12 +00:00
regis@google.com
78353be760
Verify that user classes/interfaces do not extend/implement any of bool, num,
...
int, double, String, Function, or Dynamic.
Review URL: http://codereview.chromium.org//8416052
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@922 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 22:24:18 +00:00
hausner@google.com
b4c4b6f13e
Add two constructor tests
...
Check evaluation order of initializers.
Review URL: http://codereview.chromium.org//8341118
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@919 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 21:28:29 +00:00
asiva@google.com
69a41e4c4c
- Add new test for regex
...
- Update test status
Review URL: http://codereview.chromium.org//8399016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@902 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 17:32:29 +00:00
regis@google.com
d104e34a9f
Add support for 'Dynamic' type in the VM.
...
Add a test and disable if for dartc.
Review URL: http://codereview.chromium.org//8403005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@862 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-28 00:00:31 +00:00
mmendez@google.com
959e3573d7
Fixes issue http://code.google.com/p/dart/issues/detail?id=235 .
...
Mismatched type arguments result in an error not a type warning.
BUG=
TEST=
Review URL: http://codereview.chromium.org//8392047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@821 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-27 13:33:45 +00:00
fabiomfv@google.com
7816675ba0
https://code.google.com/p/dart/issues/detail?id=225
...
moved CL. LGTM from http://codereview.chromium.org/8390059/
Review URL: http://codereview.chromium.org//8401008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@815 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-27 12:29:33 +00:00
vsm@google.com
fa05dc1712
Mark these tests as now passing
...
TBR=ngeoffray
BUG=5476054
Review URL: http://codereview.chromium.org//8403014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@792 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 23:43:51 +00:00
regis@google.com
ee7aca7f5b
Fix type tests involving an implicit closure of a non-parameterized class
...
extending a parameterized class.
Add corresponding test.
Disable new test for dartc (filed new issue 5516001).
Review URL: http://codereview.chromium.org//8393033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@771 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 19:03:29 +00:00
regis@google.com
57cf4c0e46
Fix issue 235.
...
Add test.
Disable new test for dartc.
Review URL: http://codereview.chromium.org//8394057
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@766 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 17:59:55 +00:00
mmendez@google.com
2fdc3101c2
Report an error if a constructor initializer calls a setter method.
...
BUG=http://code.google.com/p/dart/issues/detail?id=92
Review URL: http://codereview.chromium.org//8394018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@760 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 17:18:56 +00:00
ager@google.com
1fa8860919
Implement path canonicalization on Windows to fix infinite loop on cyclic includes.
...
R=sgjesse@google.com
BUG=179
TEST=language/CyclicImportTest
Review URL: http://codereview.chromium.org//8394041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@744 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 12:44:16 +00:00
ngeoffray@google.com
270004a10a
dartium runs the VM in release mode -> the test does not fail.
...
Review URL: http://codereview.chromium.org//8393046
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@735 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 10:04:45 +00:00
regis@google.com
0b98430a58
Cleanups.
...
Review URL: http://codereview.chromium.org//8390021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@726 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 23:16:16 +00:00
asiva@google.com
2d44c017dd
Update language tests status.
...
Review URL: http://codereview.chromium.org//8390014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@719 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 21:56:34 +00:00
ngeoffray@google.com
c0d7de3d3a
Test fails on dartium, not crash.
...
Review URL: http://codereview.chromium.org//8395001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@700 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 14:37:07 +00:00
ngeoffray@google.com
6e625e250c
Add a test for non-parameterized factory.
...
Review URL: http://codereview.chromium.org//8381036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@697 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 13:53:50 +00:00
ngeoffray@google.com
780e1e9b1a
Test cases for Issue 224 and 225: A 'return' in a generative constructor does not trigger a compile-time error.
...
Review URL: http://codereview.chromium.org//8389001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@680 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 09:20:04 +00:00
ngeoffray@google.com
8ca1529274
Add a test for http://code.google.com/p/dart/issues/detail?id=223 .
...
Review URL: http://codereview.chromium.org//8332024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@679 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-25 08:33:13 +00:00
regis@google.com
2e745d1660
Add a #library in new tests with an #import, as required by Chromium.
...
Review URL: http://codereview.chromium.org//8380029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@665 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-24 23:21:12 +00:00
asiva@google.com
3ba848d0cc
Add cyclic dependency test which causes a crash in the VM.
...
Review URL: http://codereview.chromium.org//8375017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@664 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-24 23:16:22 +00:00
hausner@google.com
48304ec6d7
Implicitly move super constructor call
...
Implicitly move super constructor call to the end of the initializer
list. Some code failed after r412.
Review URL: http://codereview.chromium.org//8380023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@663 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-24 23:06:01 +00:00
regis@google.com
023b41275d
Skip a new test failing on Chromium.
...
Review URL: http://codereview.chromium.org//8380024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@661 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-24 22:53:27 +00:00
regis@google.com
a019951eb9
Fix member overriding rules in VM according to latest spec.
...
Fix tests accordingly.
Review URL: http://codereview.chromium.org//8360022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@607 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-21 17:44:04 +00:00
asiva@google.com
b8d33a1372
Update test status and add new tests.
...
Review URL: http://codereview.chromium.org//8352011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@592 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-20 23:29:03 +00:00