Commit Graph

1846 Commits

Author SHA1 Message Date
karlklose@google.com d90d5b1698 Reapply 'Add runtimeType() to Object which returns canonicalized instances of Type'.
This CL fixes a bug in https://chromiumcodereview.appspot.com/10908142/ which generated unneeded type information leading to runtime regression.

Original committed in 12491 and reverted in

R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//10941031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12540 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 08:56:06 +00:00
efortuna@google.com 25d3eae1d6 Revert CLs by gram 12515-12526.
Review URL: https://codereview.chromium.org//10950020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12529 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 01:18:37 +00:00
scheglov@google.com a17964f959 Issue 5153. Setter should not conflict with method
http://code.google.com/p/dart/issues/detail?id=5153

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10943012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12528 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 01:17:29 +00:00
gram@google.com e8bffa09c0 Temporarily skip failing tests; I will investigate the cause tomorrow.
Review URL: https://codereview.chromium.org//10946018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12526 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 00:44:06 +00:00
ricow@google.com 5bcc7e0092 Revert r12491
This is causing checked mode failures on the buildbot.
Review URL: https://codereview.chromium.org//10949003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12500 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 14:40:15 +00:00
karlklose@google.com 59e0304206 Add runtimeType() to Object which returns canonicalized instances of Type.
BUG=3903

Review URL: https://chromiumcodereview.appspot.com//10908142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12491 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 12:12:07 +00:00
lrn@google.com c477dea8e9 Fix expectations after introducing "identical". Again.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//10945005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12468 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 07:07:05 +00:00
lrn@google.com 24ec1f24f5 Update test expectations some more.
TBR=ngeoffray@google.com

Review URL: https://codereview.chromium.org//10949002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12466 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 06:13:29 +00:00
lrn@google.com 94362c5d72 Make identical(a,b) a compile-time constant in dart2js.
Introduces the 'identical' top-level function in dart:core.

Review URL: https://codereview.chromium.org//10908287

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12465 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-18 05:54:20 +00:00
scheglov@google.com d6802247b5 Issue 5082. It is an error if argument to '?' is not a formal parameter
http://code.google.com/p/dart/issues/detail?id=5082

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10928230

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12438 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 15:09:52 +00:00
antonm@google.com dad3c0e742 Properly process constructs like Class.getter++ where there is no setter.
R=smok@google.com
BUG=5178

Review URL: https://codereview.chromium.org//10911312

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12436 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 14:13:14 +00:00
hausner@google.com 1d93b4206e Fix the fix.
Review URL: https://codereview.chromium.org//10933111

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12411 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 23:49:41 +00:00
hausner@google.com f9e6afbe0c Update dartc, dart2dart status
Review URL: https://codereview.chromium.org//10928212

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12410 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 23:41:36 +00:00
hausner@google.com 19c8f19f5e Stop making classes implicitly abstract
Allocating an implicitly abstract class is no longer a runtime error.
Review URL: https://codereview.chromium.org//10910284

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12408 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 22:46:54 +00:00
scheglov@google.com a2395ed946 Issue 5084. Report error if a type name appears multiple times in an implements clause
http://code.google.com/p/dart/issues/detail?id=5084

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10918247

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12391 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 15:55:31 +00:00
scheglov@google.com b388161d1f Issue 3476. Final variables don't have to have constant initializers
http://code.google.com/p/dart/issues/detail?id=3476

R=jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//10919290

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12382 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 13:04:19 +00:00
antonm@google.com ecdce6164b Properly collect placeholders for function expressions.
Now function expressions can be found in lhs of variable declarations as well:

final inc = (x) => x + 1;

Process them like other functions.

R=smok@google.com
BUG=5141

Review URL: https://codereview.chromium.org//10913250

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12374 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 10:35:02 +00:00
ngeoffray@google.com 408eb9f0e8 And fix dart2dart as well.
Review URL: https://codereview.chromium.org//10918243

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12373 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 10:09:55 +00:00
ngeoffray@google.com 8bc6cbf8de Update test for dart analyzer.
Review URL: https://codereview.chromium.org//10917256

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12372 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 10:06:24 +00:00
ngeoffray@google.com 04293eb214 Implement checked mode for const constructors.
Review URL: https://chromiumcodereview.appspot.com//10916232

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12370 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 09:47:18 +00:00
karlklose@google.com e8134639ab Adjust status file to fix dart2dart buildbot.
R=ahe@google.com

Review URL: https://codereview.chromium.org//10919283

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12362 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 06:21:01 +00:00
karlklose@google.com b8e93b6c5a Convert static error to warning for calls to nonexisting toplevel methods, getters and setters.
This also fixes an issue with calling nonexisting static getters/setters when an abstract field was defined.

R=ngeoffray@google.com

Review URL: https://chromiumcodereview.appspot.com//10908236

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12361 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 05:29:22 +00:00
scheglov@google.com ea65bbb961 Issue 3553. Stop treating static final variables as constants
http://code.google.com/p/dart/issues/detail?id=3553
http://code.google.com/p/dart/issues/detail?id=3476

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//10907215

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12336 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:49:07 +00:00
brianwilkerson@google.com cd57835f8f Add built-in identifiers 'library', 'import', 'export' and 'part' (issue 5120)
Review URL: https://codereview.chromium.org//10919266

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12335 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:27:51 +00:00
iposva@google.com 8ff541e0b9 - Fix status file.
Review URL: https://codereview.chromium.org//10918217

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12334 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 15:17:01 +00:00
kasperl@google.com 55733ca3bf Add missing :.
R=antonm@google.com
BUG=

Review URL: https://codereview.chromium.org//10905261

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12327 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 13:36:17 +00:00
kasperl@google.com cf10562f07 Fix status file for dart2dart.
R=antonm@google.com
BUG=http://dartbug.com/5141

Review URL: https://codereview.chromium.org//10918214

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12326 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 13:30:25 +00:00
kasperl@google.com f015adb586 Update test expectations for dart2dart.
TBR'ed.

R=hausner@google.com
BUG=

Review URL: https://codereview.chromium.org//10914260

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12323 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 12:56:21 +00:00
kasperl@google.com d1da3ed908 Re-land r12289.
Looks like Johnni has fixed the dartdoc issues.

R=iposva@google.com,hausner@google.com
BUG=

Review URL: https://codereview.chromium.org//10919263

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12321 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 12:37:00 +00:00
aprelev@gmail.com 9ecad0703b issue 4817 fixed. Implemented raw strings with 'r' instead of '@' for dart2js
BUG=dart:4817

Review URL: https://chromiumcodereview.appspot.com//10920066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12292 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 01:43:23 +00:00
hausner@google.com 08893af550 Revert change 12289
Will resubmit tomorrow. Dartc and Editor need to cleanup static finals.
Review URL: https://codereview.chromium.org//10928169

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12291 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 00:22:12 +00:00
hausner@google.com b740a3266f Stop treating finals as const
Toplevel final variables and static final fields are no longer
considered compile-time constants.
Review URL: https://codereview.chromium.org//10918203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12289 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 00:03:16 +00:00
brianwilkerson@google.com 578208a363 Clean up many tests marked as skipped or flaky (issue 5064)
Review URL: https://chromiumcodereview.appspot.com//10928150

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12272 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 17:30:09 +00:00
kasperl@google.com e89a2ddea4 Update test expectations for dartc and dart2dart.
R=ngeoffray@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10933036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12237 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 07:16:02 +00:00
kasperl@google.com 6acb4e8c72 Stop treating final as const in dart2js.
R=iposva@google.com,ngeoffray@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10918188

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12235 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 07:02:14 +00:00
hausner@google.com ab30a5c4bb One day I'll understand status files.
Review URL: https://chromiumcodereview.appspot.com//10917201

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12230 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-12 00:29:54 +00:00
hausner@google.com 7c6d3cde75 Update status for raw string test in dartium
Review URL: https://chromiumcodereview.appspot.com//10911232

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12228 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 23:25:38 +00:00
hausner@google.com 3c3c9f1d25 Fix dartium/drt status
Review URL: https://chromiumcodereview.appspot.com//10907184

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12221 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 20:44:47 +00:00
hausner@google.com 4b382c2b5c Fix dartc status
Review URL: https://chromiumcodereview.appspot.com//10916242

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12218 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 20:20:49 +00:00
hausner@google.com a32a698c6f Support new library/import syntax
This change simply adds new syntax support for the functionality we
currently have in the VM.

- Support for library and import, import-as.
- Still to do: show/hide combinators, export, library parts.
Review URL: https://chromiumcodereview.appspot.com//10928121

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12216 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 20:10:56 +00:00
ngeoffray@google.com 0982c13abe Fix status for dart2dart
Review URL: https://chromiumcodereview.appspot.com//10933020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12188 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 12:24:11 +00:00
ngeoffray@google.com d50ea302af Support check mode for statics.
Review URL: https://chromiumcodereview.appspot.com//10908143

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12187 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 12:02:48 +00:00
ahe@google.com 7567a89a6f Update status file for dart2dart.
Review URL: https://chromiumcodereview.appspot.com//10914182

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12146 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 19:14:14 +00:00
ahe@google.com 644cc196a9 Update dart2dart status file after supporting named parameter syntax.
Review URL: https://chromiumcodereview.appspot.com//10919192

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12115 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-10 14:25:17 +00:00
hausner@google.com 22fdbae05b VM can parse and ignore metadata
Support parsing of metadata in all legal locations except library
and import directives. The metadata is simply ignored. It is not
evaluated or validated for correctness.
 
Review URL: https://chromiumcodereview.appspot.com//10913138

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12078 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 23:06:48 +00:00
scheglov@google.com 03ccc4df50 Issue 4988. Fixe for 'assert' statement vs function resolving
http://code.google.com/p/dart/issues/detail?id=4988

R=brianwilkerson@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com//10910142

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12071 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 22:09:49 +00:00
antonm@google.com 123a2620f7 Do not rename assert syntax.
TBR=lrn@google.com,smok@google.com

Review URL: https://chromiumcodereview.appspot.com//10914150

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12048 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 17:11:14 +00:00
ahe@google.com c8ca545f23 Update status file for dart2dart.
Review URL: https://chromiumcodereview.appspot.com//10908147

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12047 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 17:01:24 +00:00
ahe@google.com 6aa2dcff6f Update status files on your behalf.
Review URL: https://chromiumcodereview.appspot.com//10907114

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12041 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 15:15:24 +00:00
lrn@google.com be2453bae1 Removed/moved "assert" function to core_patch.dart as "_assert".
Changed resolution of assert to only accepting assert in a statement position.
Added more assert tests.

Review URL: https://chromiumcodereview.appspot.com//10915083

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12026 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 12:45:02 +00:00