2 Commits

Author	SHA1	Message	Date
Daco Harkes	312a572ade	[vm/ffi] Fix prepare_flutter_bundle.dart ... It now includes /ffi_test_functions_generated.cc and prints instructions on how to use the generated bundle. This CL adds some TODOs and deletes the non-migrated copy that was in the NNBD folder. Finally, this CL disable a check that fails because of static linking on iOS. Issue https://github.com/dart-lang/sdk/issues/39570. Change-Id: Ie85d92568bb95eaafd2991725a1a31cdecd246be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169402 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>	2020-10-28 21:33:35 +00:00
Daco Harkes	9920801424	[vm/ffi] Split FFI tests in NNBD and legacy ... Closes: https://github.com/dart-lang/sdk/issues/40233 This CL creates nnbd versions of the tests and runs them on the nnbd sdk. This CL does not (1) migrate sdk_nnbd/lib/ffi fully yet, and does not (2) fix all the tests/ffi (which is NNBD tests) yet. Uncovered new issues: Issue: https://github.com/dart-lang/sdk/issues/40234 nullptr should have type Pointer<Never>. Issue: https://github.com/dart-lang/sdk/issues/40247 Structs need external fields. Issue: https://github.com/dart-lang/sdk/issues/40271 Callbacks hit assert in debug. Change-Id: Icb1b83577e03ed283165eb17703fc8dfc7fa5960 Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64-try,app-kernel-linux-debug-x64-try,vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-x64-try,vm-kernel-win-debug-ia32-try,vm-kernel-precomp-linux-debug-x64-try,vm-dartkb-linux-release-x64-abi-try,vm-kernel-precomp-android-release-arm64-try,vm-kernel-asan-linux-release-x64-try,vm-kernel-linux-release-simarm-try,vm-kernel-linux-release-simarm64-try,vm-kernel-precomp-android-release-arm_x64-try,vm-kernel-precomp-obfuscate-linux-release-x64-try,dart-sdk-linux-try,analyzer-analysis-server-linux-try,analyzer-linux-release-try,front-end-linux-release-x64-try,vm-kernel-precomp-win-release-x64-try,analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132604 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>	2020-01-29 14:04:41 +00:00