4e25e499c8
[ddc] Add library URIs to cast failure messages
...
When the two types have the same name but are from different libraries
showing the library URI will help users understand the failure better.
Change-Id: I5ab4412e676272111d41f688ef2d1cc83afbe627
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194116
Reviewed-by: Mark Zhou <markzipan@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2021-04-09 22:24:43 +00:00
1eda15854d
[cfe] Allow experiments only in current sdk version
...
Experiments that have not be enabled by default should only be allowed
in the current version of the sdk.
Closes #45460
Change-Id: I159f390ac85fe37943920717ce11a4c817d5b4a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193480
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2021-03-31 15:20:08 +00:00
e352744fa4
[ddc] Fix failing debugger tests
...
- Accept the existing output in the golden file as a new baseline.
- Copy the golden file for the null safe version of the test and
enable running the full golden diff.
Fixes: https://github.com/dart-lang/sdk/issues/44025
Change-Id: Ie5b3e7c7689d17fca8a01e970b28fc815a6b9851
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172688
Reviewed-by: Mark Zhou <markzipan@google.com >
Commit-Queue: Nicholas Shahan <nshahan@google.com >
2020-11-20 23:14:33 +00:00
f346cb7f77
Fix ddc debugger_test
...
This CL:
- Fixes https://github.com/dart-lang/sdk/issues/43987 (an exception in custom formatting code)
- Restores (most of) debugger_test.dart to passing (which tests above)
- Fixes a type caching error also exposed by the above test
Note, this skips the golden file comparison. That appears to be very broken
(see comment).
Change-Id: I283b66a710f17765faed47aa099b0b8570e6cac1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170022
Reviewed-by: Gary Roumanis <grouma@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Commit-Queue: Vijay Menon <vsm@google.com >
2020-11-02 23:31:30 +00:00
1332cf8c41
[ddc] Migrate tests in dartdevc suite
...
Change-Id: I2a35de7f79b8d768cdd0144b3bf5de87fa929942
Issue: https://github.com/dart-lang/sdk/issues/42107
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154301
Commit-Queue: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Joshua Litt <joshualitt@google.com >
2020-07-15 00:16:03 +00:00
d14ab0779a
[dartdevc] Migrate tests/compiler/dartdevc_native to tests/dartdevc_2.
...
Change-Id: I9c486f29f3bcf8a6ecf481eb25ea61d0468049b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150667
Commit-Queue: Joshua Litt <joshualitt@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
2020-06-17 18:14:00 +00:00
Nicholas Shahan