dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

533 Commits

Author SHA1 Message Date
Ben Konyi 56ee9f86d6 Updated status file to fix failures on the vm-kernel bots caused by migration of test block 13. 
TBR=jcollins@google.com,rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2993753002 .
 2017-08-04 17:31:12 -07:00
Jennifer Messerly e1f4de9a6e fix corelib_2/iterable_to_set_test to reflect strong mode runtime checks 
`Set<dynamic>` should not be a subtype of `Set<int>` in strong mode.

R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2993743002 .
 2017-08-04 17:06:14 -07:00
Sigmund Cherem 352dc54191 Update status files to make bots green, minor changes to the script 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2990303002 .
 2017-08-04 14:04:37 -07:00
Ben Konyi df3238ef2d Migrated test block 12 to Dart 2.0. 
Modified json_map_test to not expect the maps to be of type Map<int,
dynamic>, and marked iterable_to_list_test and iterable_to_set_test as
failing on DDC in the status files.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2996513002 .
 2017-08-04 13:34:48 -07:00
Ben Konyi b1bca14dab Migrated test block 13 to Dart 2.0. 
Removed list_index_of2_test as it shouldn't be valid in Dart 2.0.

BUG=
R=jcollins@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2994543002 .
 2017-08-04 11:21:22 -07:00
Sigmund Cherem edc1054ae1 Normalize status files for dart2js_with_kernel 
This is only moving status lines around to ensure we only have 2 sections for
$dart2js_with_kernel per file: minified and host-checked.  Some entries are now
duplicated because we no longer have the $dart2js_with_kernel (non-checked)
section.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2993083002 .
 2017-08-04 09:41:08 -07:00
Florian Loitsch 33f1fc8059 Update status files for double_round tests. 
Review-Url: https://codereview.chromium.org/2999443002 .
 2017-08-04 12:08:31 +02:00
Jennifer Messerly d28725fe99 fix ddc bot status 
Review-Url: https://codereview.chromium.org/2991403003 .
 2017-08-03 16:52:57 -07:00
Ben Konyi 64465ad4c7 Fixing failures caused by migration of test block 14. Context: https://build.chromium.org/p/client.dart/builders/vm-kernel-linux-release-x64-be/builds/3619/steps/vm%20tests/logs/stdio 
TBR=jcollins@google.com,rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2993663002 .
 2017-08-03 14:48:35 -07:00
Jennifer Messerly 62303b6711 enable batch mode for dartdevc tests, also fix status so ddc bots pass 
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2987393002 .
 2017-08-03 14:39:45 -07:00
Ben Konyi d7891cf587 Migrated test block 14 to Dart 2.0. 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2991363002 .
 2017-08-03 13:46:54 -07:00
Janice Collins 556fa63c2b double_round_to_double2 doesn't work on dart2js-safari. 
Fixes more bot breakage for block 7.

BUG=
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2991373002 .
 2017-08-03 13:02:14 -07:00
Alexander Markov 49819ea5cd Filter tests for limited ints in DDC mode 
These tests requires custom DartVM option --limit-ints-to-64-bits
and they can't be run through dart2js or dartdevc, so they are
filtered in .status file.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2994523002 .
 2017-08-03 11:22:35 -07:00
Janice Collins c2c93a0053 dynamic_nosuchmethod_test uses mirrors, disable when using fast_startup 
or precompiler.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2991313003 .
 2017-08-03 11:14:55 -07:00
Ben Konyi ce197702e4 Migrated test block 15 to Dart 2.0. 
list_unmodifiable_test required some modifications so callbacks matched
the correct types. list_unmodifiable_test and list_test also needed to
be disabled on dartdevc due to some issue with List<int> not mapping to
JSArray.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2992833002 .
 2017-08-03 11:12:26 -07:00
Janice Collins 8210a8cd3d Fix bots from block 8 changes 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2995453002 .
 2017-08-03 10:10:03 -07:00
Janice Collins 28a856828b Migrate test block 7 to Dart 2.0. 
duration2_test.dart converted to a static-only test and skipped where appropriate for non-strong.  error_stack_trace_test converted to a multitest and error_stack_trace1_test modified to use more modern catch convention for stack traces.

R=bkonyi@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2987793002 .
 2017-08-03 08:55:30 -07:00
Janice Collins 328c30324c Migrate test block 8 to Dart 2.0. 
This was a hairy test block, please review carefully.  Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved outside the SDK
from_environment_const_type_undefined_test.dart, from_environment_const_type_test: change to expect compile-time errors for all error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments.  Stripped runtime checking of checked mode.  Also, this doesn't work, but should, with dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option comments

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2989643002 .
 2017-08-03 08:37:46 -07:00
Ben Konyi 350fa1cdb6 Removed package_resource_test and its status file entries. 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2989203002 .
 2017-08-01 14:10:56 -07:00
Ben Konyi 4d6f6a8bbd Migrated test block 19 to Dart 2.0. 
Added 'toString()' to lines 63 and 99 of regexp/global_test.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2989863002 .
 2017-08-01 12:24:23 -07:00
Johnni Winther a376c27a58 [gardening] Updated status for corelib_2/map_keys2_test 
Review-Url: https://codereview.chromium.org/2986203002 .
 2017-08-01 09:43:02 +02:00
Ben Konyi 675ffe3564 Skip package_resource_test temporarily. 
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2990073003 .
 2017-07-31 16:24:32 -07:00
Ben Konyi 232a6330d8 Moving test that was not moved automatically by migration script. 
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2988213002 .
 2017-07-31 16:03:15 -07:00
Ben Konyi f50a306875 Migrated test block 16 to Dart 2.0. 
Lots of issues in map_test caused by the use of conflicting key types.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2990903002 .
 2017-07-31 15:08:23 -07:00
Ben Konyi 8b36c83a10 Migrated test block 17 to Dart 2.0. 
Fairly minor changes to print_test, and num_clamp_test was split into
two tests to isolate compile time errors.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2987203002 .
 2017-07-31 15:04:00 -07:00
Jennifer Messerly bba4b68d51 fix unsound cast failures in tests 
the "whitelist" option to ignore cast failures is no longer used by most tests (I'm investigating what to do about package:unittest)

R=rnystrom@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2989993002 .
 2017-07-31 14:30:40 -07:00
Alexander Markov 41fb3c6d16 [vm] Change TypedData_getUint64 native method to silently cast values 
The TypedData_getUint64 native method is used to implement Uint64List
and ByteData.getUint64().

When running in --limit-ints-to-64-bits mode (with Dart integers
limited to 64 bits), this native method and its clients should
silently cast values (with wrap-around) to signed 64-bit integer.
This is the intended behavior, chosen to make it possible to work
with arbitrary data.

This CL changes underlying Integer::NewFromUint64() to do the silent
conversion instead of returning Integer::null().

Another client of Integer::NewFromUint64, Dart_NewIntegerFromUint64 is
changed to handle error without relying on Integer::NewFromUint64().

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Review-Url: https://codereview.chromium.org/2992013002 .
 2017-07-31 14:06:33 -07:00
Ben Konyi 22aa6bc24a Fixed failures caused by corelib_2/regexp/UC16_test on ff 
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2989153002 .
 2017-07-31 12:22:16 -07:00
Ben Konyi 4e98aa3569 Fixed failing test in corelib_2/regexp/UC16_test on dart2js-jsshell. 
TBR=rnystrom@google.com
BUG=

Review-Url: https://codereview.chromium.org/2990053002 .
 2017-07-31 10:52:33 -07:00
Ben Konyi 011c9b0f75 Migrated test block 19 to Dart 2.0. 
BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2985233002 .
 2017-07-31 09:49:08 -07:00
Alexander Markov 401c812356 Fix test int_parse_with_limited_ints_test in checked and strong modes 
Closes https://github.com/dart-lang/sdk/issues/30302

R=zra@google.com

Review-Url: https://codereview.chromium.org/2986193002 .
 2017-07-31 09:37:08 -07:00
Alexander Markov dc8f730e8f Silence newly added test int_parse_with_limited_ints_test (#30302) 
TBR

Review-Url: https://codereview.chromium.org/2992733002 .
 2017-07-31 09:16:44 -07:00
Alexander Markov b64014c624 [corelib] Add explicit overflow checks to int.parse 
In the --limit-ints-to-64-bits mode, when Dart integers are limited
to 64 bits, int.parse() should detect and reject large integers.
This CL adds explicit overflow checks into int.parse() implementation.

R=lrn@google.com, zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Review-Url: https://codereview.chromium.org/2987003002 .
 2017-07-31 08:31:46 -07:00
Vyacheslav Egorov 33ab401cc7 Gardening: fix issues with expectations for precomp-linux-product-x64. 
Fixes https://github.com/dart-lang/sdk/issues/30289

R=kustermann@google.com
BUG=

Review-Url: https://codereview.chromium.org/2987113002 .
 2017-07-31 13:44:40 +02:00
Bob Nystrom f23c9cba92 One more Safari change. 
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2991043002 .
 2017-07-28 15:33:24 -07:00
Bob Nystrom fe2f6fd58c Fix test status. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2992023002 .
 2017-07-28 14:10:54 -07:00
Florian Loitsch a7de4384d6 Reduce number of iterations for the regexp-cache test. 
Review-Url: https://codereview.chromium.org/2988103002 .
 2017-07-28 22:21:59 +02:00
Ben Konyi 4f33acda8a Migrated test block 21 to Dart 2.0. 
No changes made to tests.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2989843002 .
 2017-07-28 13:10:40 -07:00
Ben Konyi 814edbe896 Migrated test block 20 to Dart 2.0. 
No changes to tests, just the following status file updates:

Entries for status file /usr/local/google/home/bkonyi/sdk/tests/corelib/corelib.status:
[ (($compiler == dart2js) && (bool $dart2js_with_kernel)) ]
regexp/invalid-range-in-class_test: Crash
regexp/issue_19193_test: Crash
regexp/lastindex_test: Crash
regexp/lookahead_test: Crash
regexp/multiline_test: Crash
regexp/negative-special-characters_test: Crash
regexp/no-extensions_test: Crash
regexp/non-capturing-groups_test: Crash

[ ((($compiler == dart2js) && (bool $dart2js_with_kernel)) && (bool $minified)) ]
regexp/bol-with-multiline_test: Crash
regexp/look-ahead_test: Crash
regexp/loop-capture_test: Crash
regexp/malformed-escapes_test: Crash
regexp/many-brackets_test: Crash
regexp/non-bmp_test: Crash
regexp/non-capturing-backtracking_test: Crash
regexp/non-character_test: Crash
regexp/non-greedy-parentheses_test: Crash

Entries for status file /usr/local/google/home/bkonyi/sdk/tests/corelib_strong/corelib_strong.status:
[ ($compiler == dartdevc) ]
regexp/bol-with-multiline_test: RuntimeError # Issue 29921
regexp/invalid-range-in-class_test: RuntimeError # Issue 29921
regexp/look-ahead_test: RuntimeError # Issue 29921
regexp/loop-capture_test: RuntimeError # Issue 29921
regexp/malformed-escapes_test: RuntimeError # Issue 29921
regexp/many-brackets_test: RuntimeError # Issue 29921
regexp/negative-special-characters_test: RuntimeError # Issue 29921
regexp/no-extensions_test: RuntimeError # Issue 29921
regexp/non-bmp_test: RuntimeError # Issue 29921
regexp/non-capturing-backtracking_test: RuntimeError # Issue 29921
regexp/non-capturing-groups_test: RuntimeError # Issue 29921
regexp/non-character_test: RuntimeError # Issue 29921
regexp/non-greedy-parentheses_test: RuntimeError # Issue 29921

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2989003002 .
 2017-07-28 12:52:08 -07:00
Florian Loitsch ee46026671 Don't use LinkedList in the core libraries anymore. 
R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/fe17b5b2bc24454dd2f596d8ce6e2e7661e87f10
Reverted: https://github.com/dart-lang/sdk/commit/5d4a786f4466ebcb06c36ed44f262c9e120a7273
Review-Url: https://codereview.chromium.org/2975443002 .
 2017-07-28 21:14:11 +02:00
Sigmund Cherem c67dd31dbd Fix status lines in minified mode 
TBR=johnniwinther@google.com,efortuna@google.com

Review-Url: https://codereview.chromium.org/2989953002 .
 2017-07-28 12:09:28 -07:00
Ben Konyi 26c8479729 Migrated test block 22 to Dart 2.0 
No updates made to tests.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2989723002 .
 2017-07-28 11:28:08 -07:00
Sigmund Cherem b1065335cd Use dart2js_plaform.dill from the sdk. 
This will enable --use-kernel tests in the dart2js bots.

After this change, running our tests will change a little bit, either of these
would work:

Option A: --use-sdk (host-checked not allowed)

python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --use-sdk \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
   -c dart2js -r d8 --dart2js-batch --report \
   --dart2js-with-kernel --host-checked \
   --dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
   language corelib library_2 corelib_2 \
   dart2js_native dart2js_extra

In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.

BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2988063002 .
 2017-07-28 10:07:08 -07:00
Erik Ernst 472bf54d96 Adjusted status for corelib_2/symbol_test for !$strong. 
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2991793002 .
 2017-07-28 16:10:19 +02:00
Ben Konyi f86b80016a Fixed bad find/replaces. 2017-07-27 12:17:39 -07:00
Ben Konyi 4479a89467 Migrated test block 23 to Dart 2.0. 
No major changes. Updated regexp_test.dart to not use the same variable
for Strings and Regexps.

BUG=
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2990603003 .
 2017-07-27 12:10:01 -07:00
Erik Ernst 94669b4811 Added status for d8 failures, cf. issue 30279. 
Review-Url: https://codereview.chromium.org/2988023002 .
 2017-07-27 16:08:51 +02:00
Siva Annamalai 8751f704d5 Remove references to 'dartium' and 'drt' in status files. 
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2986693002 .
 2017-07-26 15:59:38 -07:00
Karl Klose aafe64d4a8 Mark corelib_2/splay_tree_from_iterable test as failing with dartk 
TBR=dmitryas@google.com

Review-Url: https://codereview.chromium.org/2987923002 .
 2017-07-26 13:43:28 +02:00
Kevin Moore 4afc45c2d9 Fix status for int_modulo_arith_test/none 
Follow up from
https://codereview.chromium.org/2990623002 @ c347b0ed16
Review-Url: https://codereview.chromium.org/2986873002 .
 2017-07-25 22:43:56 -07:00