Commit Graph

4 Commits

Author SHA1 Message Date
Alexander Markov 4334c97dcb [Tests] Fix corelib_2/iterable_fold_test and iterable_reduce_test
* Change 'var iterable' to dynamic as type inference can only
  infer Object type.

* Explicitly set result type of closures passed to reduce() to
  make closure type compatible with parameter type expected by reduce().

* To modify List of Lists of int, add '[4]' instead of '4' to trigger
  expected ConcurrentModificationError instead of type error.

* Remove splitting to multi-test.

* Format with dartfmt.

Change-Id: Ie1a35eececbf1133cb2384afad10e9d355016abe
Reviewed-on: https://dart-review.googlesource.com/36300
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-01-26 17:43:33 +00:00
Paul Berry 1712abdeec Strong mode fix for iterable_reduce_test.dart
List.expand() requires a callback that returns an Iterable.

Change-Id: I5a665cf9ea4ee78be876912b31300342ac141bd4
Reviewed-on: https://dart-review.googlesource.com/19451
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2017-11-09 06:37:26 +00:00
Bob Nystrom 07b9df22ac Use the Expect.throws___() helper methods throughout tests.
No behavioral changes, just getting rid of a lot of redundant closures
and helper functions.

Change-Id: I55c52c2cc9e5505bb64203c31aad8d76847f8eeb
Reviewed-on: https://dart-review.googlesource.com/14320
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2017-10-17 23:37:15 +00:00
Janice Collins e89d0d2e14 Migrate test block 11 to Dart 2.0.
Interesting items in this block:
- Manually merged iterable_generate_test changes from both trees and
dropped some typeAssertionsEnabled/checked mode checking.

BUG=
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/3000543002 .
2017-08-16 10:16:42 -07:00