dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

645 Commits

Author SHA1 Message Date
Stephen Adams c6a01283c1 Remove U+180E from whitespace in js_runtime and tests 
BUG= https://github.com/dart-lang/sdk/issues/28983
R=alanknight@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2733353002 .
 2017-03-13 20:18:19 -07:00
Stephen Adams 129f9dbb4c Update status for ff + jsshell list_test 
TBR=nweiz@google.com
BUG=

Review-Url: https://codereview.chromium.org/2744743002 .
 2017-03-09 16:28:39 -08:00
Alan Knight 8d5015556e Update test status for Firefox 52/Issue 28983 
BUG=

Review URL: https://codereview.chromium.org/2732963006 .
 2017-03-07 16:52:28 -08:00
Asger Feldthaus 3a7529a363 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d6c90a6b3d6d1be5095e12a0a633305e1d5db2a
Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 17:11:19 +01:00
Asger Feldthaus e7b9672b3e Revert "Remove status file sections for the CPS IR." 
This reverts commit 2d6c90a6b3.

BUG=

Review-Url: https://codereview.chromium.org/2720283002 .
 2017-02-28 17:08:04 +01:00
Asger Feldthaus 2d6c90a6b3 Remove status file sections for the CPS IR. 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2720513006 .
 2017-02-28 14:40:06 +01:00
Sigmund Cherem 91796be231 Add mode to test.dart to run dart2js with kernel, and include initial set of 
failures in status files

BUG=
R=efortuna@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2688413004 .
 2017-02-14 14:37:23 -08:00
Ryan Macnak cfe5e5f075 Include metadata in AOT to expand inline frames in stack traces and provide line numbers. 
Also fix stack trace collection to always include invisible frames. It can happen that a visible function is inlined into an invisible function, and we don't expand inlined frames until we print a stack trace.

dart2js product x64:
compile time: 12.459s
VMIsolate(CodeSize): 152292
Isolate(CodeSize): 3343117
ReadOnlyData(CodeSize): 3728928
Instructions(CodeSize): 8677600
Total(CodeSize): 15901937
->
compile time: 14.195s (+13%)
VMIsolate(CodeSize): 174034
Isolate(CodeSize): 3892418 (+16%)
ReadOnlyData(CodeSize): 5036320 (+35%)
Instructions(CodeSize): 8682624
Total(CodeSize): 17785396 (+12%)

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2687143005 .
 2017-02-13 10:27:36 -08:00
Natalie Weizenbaum 8de3c35cc2 [Gardening] Mark a test as flaky on Dart2js. (#28713) 
corelib/list_unmodifiable_test fails flakily on dart2js.

See #28712
 2017-02-10 15:05:40 -08:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
 2017-02-06 13:26:39 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Matthias Hausner dfde15a8be Gardening: mark regexp pcre_test slow/timeout in precompiled code 
This test seems to be slow in any configuration. There are old bugs,
e.g. 21593 and 22008 that mention the slowness and flakiness, but there
are no takers to either fix the regexp code or make the test smaller.

Note: in precompiled mode, the regular expression code is interpreted, and thus actually slower than in the JIT version of the test.

BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624733005 .
 2017-01-10 13:03:49 -08:00
Regis Crelier dc0605012f Move Null type to the Bottom in the VM (fixes #28025). 
Fix wrong comments.

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2608373002 .
 2017-01-05 10:05:31 -08:00
Florian Loitsch 59ffd06f15 Update status file. 
Review-Url: https://codereview.chromium.org/2598183002 .
 2016-12-23 11:51:28 +01:00
Johnni Winther dd1a470dda No luck at status-bingo 
Review-Url: https://codereview.chromium.org/2600503002 .
 2016-12-22 15:27:52 +01:00
Johnni Winther f6b5361adb Support for Null as bottom in dart2js 
Closes #28026

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2595363002 .
 2016-12-22 15:01:33 +01:00
Kasper Lund 0efa6cfda0 Revert "Update status" 
This reverts commit 5fdc195aa1 and follows
the revert of the dart2js support for null-as-bottom.

TBR'ed.

R=johnniwinter@google.com
BUG=

Review-Url: https://codereview.chromium.org/2592373002 .
 2016-12-22 09:53:14 +01:00
Johnni Winther 5fdc195aa1 Update status 
Review-Url: https://codereview.chromium.org/2594013002 .
 2016-12-21 16:36:35 +01:00
Harry Terkelsen c78814326c Update jsshell to 50.0 
R=sra@google.com

Review URL: https://codereview.chromium.org/2552123003 .
 2016-12-06 16:58:15 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'. 
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
 2016-12-01 16:47:33 -08:00
William Hesse e2a48dbf38 Update status for failing tests 
BUG=https://github.com/dart-lang/sdk/issues/27925
R=eernst@google.com

Review URL: https://codereview.chromium.org/2536183002 .
 2016-11-29 14:26:27 +01:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
 2016-11-28 16:32:41 +01:00
William Hesse 4bfe727db6 Update status for Firefox 50 
BUG=https://github.com/dart-lang/sdk/issues/27873
BUG=https://github.com/dart-lang/sdk/issues/27872
BUG=https://github.com/dart-lang/sdk/issues/27871
BUG=https://github.com/dart-lang/sdk/issues/27867
R=sortie@google.com

Review URL: https://codereview.chromium.org/2526493004 .
 2016-11-23 09:49:01 +01:00
John McCutchan 50b47360bd Update more status files for hot reload bots 
BUG=

Review URL: https://codereview.chromium.org/2500343003 .
 2016-11-15 07:34:03 -08:00
Ryan Macnak 3658a16e47 DBC: When calling DRT_OptimizeInvokedFunction, patch the stack to have a stub instead of the to-be-optimized function as the caller. 
Fixes #27746

R=fschneider@google.com, zra@google.com

Review URL: https://codereview.chromium.org/2473213002 .
 2016-11-04 09:51:02 -07:00
Florian Schneider 6fa4a54bba DBC: Fix smi shl with large (>word-size) shift counts 
Insert check to guard against large shift counts.

Integer shifts with shift counts greater or equal than the number
of bits per word are undefined behavior in C/C++.

Fixes #27474.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2474103003 .
 2016-11-04 12:16:34 +01:00
Florian Schneider de6b131857 Temporarily skip flaky tests for DBC 
BUG=#27746

Review URL: https://codereview.chromium.org/2477753002 .
 2016-11-03 15:08:42 +01:00
Florian Schneider 44418359e0 DBC: Handle constants correctly in the optimizing backend 
We don't always allocate a register for constants in optimized code. Instead
they are copied into registes as needed by parallel moves at the use site.

Fixes #27731.

R=vegorov@google.com

Review URL: https://codereview.chromium.org/2477653002 .
 2016-11-03 12:24:05 +01:00
Ryan Macnak d8bb15f915 Mark failing DBC tests. 
Issue #27731
Issue #27732
Issue #27733

R=zra@google.com

Review URL: https://codereview.chromium.org/2465253007 .
 2016-11-02 15:28:57 -07:00
Florian Schneider 6d66f3dea8 VM: Make optimized try-catch work in DBC. 
The catch entry block has all locals in fixed locations
(Rj) where j = kNumberOfRegisters - i for parameter i.

This means we reserve a range of DBC registers at the top-end of the frame.
Those registers are blocked for general allocation to avoid any overlap
with the rest of the registers that are allocated from the bottom.

Each optimized frame with a try-catch will be kNumberOfRegisters wide.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org/2388093003 .
 2016-10-13 11:36:23 -07:00
Florian Schneider 8a7dabe522 Temporarily update status for 2 tests on SIMDBC. 
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org/2388363002 .
 2016-10-04 09:25:44 -07:00
Sigmund Cherem fc0bf7a85b First set of test triage for fast-startup 
Review URL: https://codereview.chromium.org/2285823002 .
 2016-08-26 10:04:41 -07:00
Brian Wilkerson afd21330f7 Generalize the first argument in an assert to be an expression (issue 26865) 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2140673004 .
 2016-07-12 11:02:51 -07:00
John McCutchan ef71bc1834 Improve hot reload test mode 
- [x] Start reloading even earlier.
- [x] Keep the value of FLAG_reload_every per-isolate (so spawned isolates reload eagerly too).
- [x] Adjust the reload every back off curve to be linear in the beginning.
- [x] Cap the reload every threshold at 1,000,000
- [x] Test status file updates.
- [x] Stop disabling the background compiler / OSR when running tests.
- [x] Skip multi tests with compilation errors when reloading.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2133823002 .
 2016-07-11 12:29:13 -07:00
William Hesse c87a720c86 Update status for package_resource_test 
BUG=https://github.com/dart-lang/sdk/issues/26842
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org/2131263002 .
 2016-07-08 17:38:29 +02:00
Johnni Winther 4764bbc66f Update status for package_resource_test. 
Review URL: https://codereview.chromium.org/2130373002 .
 2016-07-08 16:18:41 +02:00
Ryan Macnak eb20b68e87 Add --hot-reload to the test harness. 
./tools/build.py -mdebug,release runtime
./tools/test.py -mdebug,release --checked --hot-reload

BUG=http://dartbug.com/26809
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2114083002 .
 2016-07-01 11:28:00 -07:00
Ryan Macnak ef8baa8760 Add test harness option for app snapshots with unoptimized code. 
./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs

Rename 'dart_product' runtime to 'dart_app'.

Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation.

Remove out-of-date scripts in tools/precompilation.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1992703005 .
 2016-05-26 10:37:47 -07:00
Lasse R.H. Nielsen fbf64bb7a5 Make Iterable.toList more efficient if the length is known. 
Add more tests. Fix (some) bugs found by tests.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1999793002.
 2016-05-23 10:00:19 +02:00
Stephen Adams 230824610f Split int_parse_radix_test into strong and non-strong parts. 
R=vsm@google.com

Review URL: https://codereview.chromium.org/1950413002 .
 2016-05-05 14:36:05 -07:00
Zachary Anderson 3d7202bad3 DBC: Adds simdbc64 target, adds arm64 arithmetic overflow logic 
There were differences between linux gcc, android gcc,
MacOS clang, and 32 vs. 64-bit w.r.t the __builtin
functions for detecting arithmetic overflow. I couldn't get
them all working at the same time. Instead, I removed them,
and changed to always use the inline assembly. This works
in all the configurations above.

This change also adds a simdbc64 target for building simdbc
for 64-bit, and sets up the android targets. simdbc targets
arm, and simdbc64 targets arm64. You can build them with:

$ ./tools/build.py -m release -a simdbc{64} --os=android runtime

R=iposva@google.com

Review URL: https://codereview.chromium.org/1904153003 .
 2016-04-25 12:48:34 -07:00
Vyacheslav Egorov ee0f608ce4 Dart Byte Code interpreter. 
This version is Clang/GCC only and does not support Windows because it uses computed goto's.

Only unoptimized mode is supported.

Architecture is described in constants_dbc.h and stack_frame_dbc.h.

R=fschneider@google.com, zra@google.com

Review URL: https://codereview.chromium.org/1858283002 .
 2016-04-18 23:02:01 +02:00
Ryan Macnak 36d0cfced8 Triage some precompilation failures, mostly related to the service isolate no longer being started. 
R=asiva@google.com

Review URL: https://codereview.chromium.org/1855473002 .
 2016-04-01 10:28:53 -07:00
Sigmund Cherem c5ae911e4e Update status on safari tests that started passing after the update. 
BUG=

Review URL: https://codereview.chromium.org/1843883002 .
 2016-03-29 17:37:03 -07:00
Sigmund Cherem 76a77d8b42 Skip tests in cpsir+checked mode until it is implemented 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/1780843002 .
 2016-03-09 17:21:49 -08:00
William Hesse f5d284ca9c Update status for a slow test and a crashing test. 
BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/1768193002 .
 2016-03-07 17:59:16 +01:00
William Hesse 7f9e4b7456 Update status for dart2js --cps_ir --host_checked. 
BUG=https://github.com/dart-lang/sdk/issues/25911
BUG=https://github.com/dart-lang/sdk/issues/24485
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1773523002 .
 2016-03-07 11:35:11 +01:00
Ryan Macnak 167616b83e Skip mirror tests more generally for $mode == product instead of $runtime == dart_product. 
Reduces failures in tools/test.py -mproduct.

R=asiva@google.com

Review URL: https://codereview.chromium.org/1760043002 .
 2016-03-03 10:06:59 -08:00
William Hesse 15f8618c1c Update status for dart2js host-checked mode tests. 
BUG=https://github.com/dart-lang/sdk/issues/25911

Review URL: https://codereview.chromium.org/1760173002 .
 2016-03-03 17:29:25 +01:00
Ryan Macnak 3fd5ffdbd4 Make tools/build.py -cprecompiler -rdart_precompiled green: 
- Create a separate compilation output directory for each VMOptions varient so they can run in parallel.
- Run both the snapshotter and assembler from the test harness instead of a wrapper script so crashes in the snapshotter are correctly identified by the test harness.
- Delete the assembly source for the precompiled shared library as we go to limit space required to run the test suite (now 61GB for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running precompilation tests.
- Don't look at a library prefix's import list during load(), it was removed by tree-shaking.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
- Update status file for remaining 4 failures under http://dartbug.com/25892.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/1732323005 .
 2016-03-01 15:19:11 -08:00