Robert Nystrom
a4d799c402
Migrate corelib/ tests starting with b-d to NNBD.
...
Note that cast_test.dart isn't migrated yet due to #39517 .
First patch set is just copying the tests over. The second patchset has
the actual meaningful changes.
Change-Id: I89233f20187b4305a776f865cde09a984423fa4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125920
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
2019-12-02 23:13:10 +00:00
Bob Nystrom
f6ca2c1d8f
Remove the Dart 1 tests.
...
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: William Hesse <whesse@google.com >
Reviewed-by: Terry Lucas <terry@google.com >
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2018-10-11 23:45:18 +00:00
Bob Nystrom
edee53f93d
Bring back the deleted 1.0 corelib tests.
...
What is dead may never die.
Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com >
2017-09-21 18:29:40 +00:00
Ben Konyi
3371365d8d
Migrate test block 3 to Dart 2.0.
...
No major changes were needed for this block.
BUG=
R=jcollins@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2977403002 .
2017-07-19 10:25:02 -07:00
Jacob Richman
2dcd56ef43
Format all tests.
...
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2771453003 .
2017-04-17 14:53:02 -07:00
lrn@google.com
989709f3a8
Reinstall previous behavior for Set and Queue toString.
...
A previous change made these omit elements to keep the toString length down.
That could break code that expects the original behavior.
This still avoids using IterableMixinWorkaround.
Add static toString methods on ListBase, SetBase, IterableBase so that users can
get the same behavior as our toString methods, and with the same cycle detection
safety.
Unify all collection toString methods in two methods:
- IterableBase.iterableToShortString
- IterableBase.iterableToFullString
R=floitsch@google.com
Review URL: https://codereview.chromium.org//297053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36616 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-26 06:08:20 +00:00
lrn@google.com
9976e03768
Remove uses of IterableMixinWorkaround outside of VM and dart2js lists.
...
Remaining uses are in:
- array.dart (VM)
- growable_array.dart (VM)
- typed_data.dart (VM)
- js_array.dart (Dart2js)
These need support from the VM and dart2js teams to remove.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//292323006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36553 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 09:39:09 +00:00
floitsch@google.com
e51764f89e
Fix some corelib tests.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org//55533002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29757 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 17:02:27 +00:00
floitsch@google.com
005ac979ee
Revert toString output changes of Queues, and LinkedLists.
...
Review URL: https://codereview.chromium.org//27028003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28520 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 15:40:50 +00:00
lrn@google.com
36d28b3f98
Change the toString method of IterableBase/IterableMixin to show some elements.
...
It always shows at least the first three and last two elements, unless the
iterable has more than 100 elements, in which case it's considered endless.
If there are room for more elements, within some limits, they are also included.
R=floitsch@google.com
Review URL: https://codereview.chromium.org//26481002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28504 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 10:56:17 +00:00
ajohnsen@google.com
24c200b76c
Fix 'collection' tests and co19 dartc/dart2js status files.
...
BUG=
Review URL: https://codereview.chromium.org//14135005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21343 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-12 10:28:29 +00:00
floitsch@google.com
8fd6d0aafd
Remove Expect from core library.
...
Committed: https://code.google.com/p/dart/source/detail?r=19755
Reverted: http://code.google.com/p/dart/source/detail?r=19756
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20996 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-05 19:43:16 +00:00
floitsch@google.com
5dc8107c53
Revert "Remove Expect from core library."
...
This reverts commit 19755.
Review URL: https://codereview.chromium.org//12743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19756 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 03:19:07 +00:00
floitsch@google.com
12dbd2fd70
Remove Expect from core library.
...
Review URL: https://codereview.chromium.org//12212016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19755 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-09 02:40:37 +00:00
floitsch@google.com
dd48256fe5
Remove deprecated StringBuffer.add, addAll and addCharCode.
...
Review URL: https://codereview.chromium.org//12473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19690 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-08 13:07:18 +00:00
lrn@google.com
3c0ac360e7
Remove deprecated string features.
...
Make String.codeUnits return a List.
Review URL: https://codereview.chromium.org//12282038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18960 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-25 10:48:09 +00:00
floitsch@google.com
1febeb689a
Move some core classes to collection library.
...
Review URL: https://codereview.chromium.org//11867024
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17352 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 13:34:02 +00:00
gram@google.com
cdb7da543b
Library syntax updates. Covers all remaining files in ~/tests aprt from ~/tests/language and ~/tests/standalone.
...
Review URL: https://codereview.chromium.org//11358203
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14815 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 22:45:18 +00:00
floitsch@google.com
e7c5e69beb
Make String.charCodes a getter.
...
Review URL: https://codereview.chromium.org//11263040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14078 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 14:25:43 +00:00
lrn@google.com
9f32f0674a
Add "contains" method to Collection.
...
This versions does not implement "contains" on DOM lists.
Review URL: https://codereview.chromium.org//11195039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13806 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 06:58:19 +00:00
lrn@google.com
ae9664a9cc
Revert "Add "contains" method to Collection."
...
Review URL: https://codereview.chromium.org//11186045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13769 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 10:55:02 +00:00
lrn@google.com
c3c2ae61c6
Add "contains" method to Collection.
...
Also added a Sequence interface to capture things with a length and
integer indexing. List and String implement that interface, and
there is a base skeleton class for collections that are Sequences.
BUG=1030
Review URL: https://codereview.chromium.org//11169004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13766 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-18 08:48:11 +00:00
regis@google.com
adb534674c
Change core lib, dart2js, and more for new optional parameters syntax and semantics (new semantics is not enforced yet).
...
Review URL: https://codereview.chromium.org//11090016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13684 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-16 16:03:47 +00:00
iposva@google.com
fedcff55ed
- Change "static final" to "static const" in the tests/ directory.
...
Review URL: https://chromiumcodereview.appspot.com//10871071
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11350 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-24 22:21:20 +00:00
ager@google.com
722c1a3ce6
Deprecate Math object in corelib in favor of dart:math library.
...
Review URL: https://chromiumcodereview.appspot.com//10829459
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11155 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-22 14:33:01 +00:00
sigmund@google.com
d9eae90196
test rename overhaul: step 7 - corelib tests
...
Review URL: https://chromiumcodereview.appspot.com//10244009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7096 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-27 18:06:37 +00:00