dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

3219 Commits

Author SHA1 Message Date
Paul Berry 3476edfcdb Update status file for issue #31288 
Change-Id: I7275502ba13ab8256a47c2c0be8e5818f005335e
Reviewed-on: https://dart-review.googlesource.com/18902
Reviewed-by: William Hesse <whesse@google.com>
 2017-11-06 21:51:34 +00:00
Aske Simon Christensen e3c11c2703 Retain erroneous import, export and part (of) directives 
If the URI of a directive is invalid, use a special URI with a
scheme marking it as malformed. In the loader, treat a file with
an invalid URI as empty.

Order all dependencies (imports and exports) by source position to
allow the DietListener to match them up properly with metadata.

For the same reason, add imports and exports within parts to
dependencies even though they are not permitted here.

Closes https://github.com/dart-lang/sdk/issues/30997
Closes https://github.com/dart-lang/sdk/issues/31004

Change-Id: Ic7efd0da058c246531c165508b7474475b4bdad2
Reviewed-on: https://dart-review.googlesource.com/17901
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 12:55:19 +00:00
Dmitry Stefantsov 6ed3cd5a3d Change expectations for test top_level_main_t05 to Pass 
Bug:
Change-Id: If207e7dd5c7b04ee4e1a57acc3602a4cb925a8e0
Reviewed-on: https://dart-review.googlesource.com/17101
Reviewed-by: Karl Klose <karlklose@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2017-10-30 09:06:13 +00:00
Sigmund Cherem 5de1535e29 Status file updates: update tests status in co19 and observatory for recent 
change in deferred loading

Bug:
Change-Id: Iacedd855beb4e179838913bf9e4b54adb85eca87
Reviewed-on: https://dart-review.googlesource.com/16904
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-27 00:24:58 +00:00
Konstantin Shcheglov ccbed2d33c Parse metadata for part directives and resynthesize in Analyzer. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: Id869144a6fce170dbc74b0595b545238595be84d
Reviewed-on: https://dart-review.googlesource.com/15983
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-10-24 19:40:08 +00:00
Johnni Winther 2d1f92ac7f Revert "A test is now mysteriously passing." 
This reverts commit d0de522142.

Change-Id: I20e7ebe9dcd922ea40604a5022eaf1f767d99a98
Reviewed-on: https://dart-review.googlesource.com/15885
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-23 12:47:56 +00:00
Emily Fortuna 85c8a91bb1 Dart gardening: Update test statuses for vm_precomp and simarm64 Timeouts. 
Bug:
Change-Id: I4988c795eed2dfe88e56e8dea50cfc60b3466882
Reviewed-on: https://dart-review.googlesource.com/15764
Reviewed-by: Emily Fortuna <efortuna@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-10-20 21:59:18 +00:00
Bob Nystrom d0de522142 A test is now mysteriously passing. ¯\_(ツ)_/¯ 
Change-Id: I26a5b0fb12b0d291a359df1deaa627e172bde146
Reviewed-on: https://dart-review.googlesource.com/15642
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-10-20 18:00:24 +00:00
Jens Johansen c8b2183bb5 [kernel] Disallow const x = [] and const y = {} 
This CL makes fasta issue an error when trying to create a non-const
ListLiteral or MapLiteral in a context where const is required.

Bug:
Change-Id: I27ea151a38eb1198faa83a8cfa57453a4e225e1a
Reviewed-on: https://dart-review.googlesource.com/15460
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-20 09:38:57 +00:00
Konstantin Shcheglov 3fedd483f3 Parse metadata for import/export directives and resynthesize in Analyzer. 
R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30284
Change-Id: I57af6f4d58b6de39f13b9656af25f0be6949cf79
Reviewed-on: https://dart-review.googlesource.com/14363
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-10-19 16:35:17 +00:00
Erik Corry 880fb9ae84 Disable color-does-not-include-alpha_t01 FF test on Windows. 
R=whesse@google.com

Bug: 31161
Change-Id: Ic31dfe83643b3f4476578009848c3d0a38d3d8c0
Reviewed-on: https://dart-review.googlesource.com/15182
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-19 16:05:32 +00:00
William Hesse 601e822ce9 Update status for Chrome 62 stable 
Bug:
Change-Id: I3c554583dbd9fabc01664e21d86248768db551a4
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/14765
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-18 12:02:56 +00:00
Dan Rubel d11fb5ba20 Improve class method modifier recovery and error messages 
This streamlines checks for valid methods modifiers in fasta
and improves recovery and error messages when method modifiers
are out of order or invalid.

Change-Id: I045cc4d7cc15945354abe49827a770d346d234a3
Reviewed-on: https://dart-review.googlesource.com/14360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-10-18 01:30:55 +00:00
Aske Simon Christensen 8a2a9e4622 Reland "Error on setter having not exactly one parameter" 
Rewrite setter with invalid parameters into one with one parameter
and a body throwing a compile-time error.

Some analyzer tests fail until we sort out the expected form of the
generated kernel code in situations like this. This is tracked in
https://github.com/dart-lang/sdk/issues/31096

Closes https://github.com/dart-lang/sdk/issues/31069
Original CL: https://dart-review.googlesource.com/13080

Change-Id: I432240c33d6daf0ec6bfe2b73c609ab4762cda8c
Reviewed-on: https://dart-review.googlesource.com/14381
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-10-17 13:16:30 +00:00
Martin Kustermann 25dc42f5d8 Revert "Error on setter having not exactly one parameter" 
This reverts commit 4bb83e9311
This reverts commit f1b07b2789.

Reason for revert on analyzer bots:

    Analyzing pkg/analyzer...
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:625:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:625:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:626:13 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:635:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:635:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:636:13 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:645:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:645:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:646:13 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:655:9 • undefined_identifier
      error • Undefined name 'CompileTimeErrorCode' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:655:18 • undefined_identifier
      error • Undefined name 'source' at pkg/analyzer/test/generated/compile_time_error_code_kernel_test.dart:656:13 • undefined_identifier
    12 errors found.

Change-Id: Ie2035bf40e50c48f85b514c7a3786141cd0f2453
Reviewed-on: https://dart-review.googlesource.com/14061
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-10-16 16:32:13 +00:00
Aske Simon Christensen f1b07b2789 Error on setter having not exactly one parameter 
Rewrite setter with invalid parameters into one with one parameter
and a body throwing a compile-time error.

Some analyzer tests fail until we sort out the expected form of the
generated kernel code in situations like this. This is tracked in
https://github.com/dart-lang/sdk/issues/31096

Closes https://github.com/dart-lang/sdk/issues/31069
Change-Id: I65033709813671ecb933e6a4dc00d1ff3b504661
Reviewed-on: https://dart-review.googlesource.com/13080
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2017-10-16 15:07:49 +00:00
William Hesse 15c1a15e6c Update status for tests that fail on firefox after migration 
Bug:
Change-Id: Ia7de36399d44f6aeda826399df20cec6cecc3ec4
TBR=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/12980
Reviewed-by: William Hesse <whesse@google.com>
 2017-10-11 14:05:38 +00:00
Vyacheslav Egorov 3f9a4966e7 [VM] Fix typing issues in the typed_data.dart 
Bug: https://github.com/dart-lang/sdk/issues/31052
Change-Id: I6bc0454c8c27432ee6206267c04d114d47835046
Reviewed-on: https://dart-review.googlesource.com/12660
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-10-11 10:29:05 +00:00
Erik Ernst 63a4533602 Gardening: Adjusted status of tabindex-removal-from-focused-element_t01 
Change-Id: If3f285955b7f4037793517cace10e9f15d7473dd
Reviewed-on: https://dart-review.googlesource.com/12562
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-10-10 14:07:20 +00:00
Jens Johansen 89644d89d2 [kernel] Add check to constant evaluator; pass script on error more often. 
Change-Id: I655121953c7be2e6c3173a3c186339d31a9be7bc
Reviewed-on: https://dart-review.googlesource.com/11500
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 13:47:20 +00:00
Jens Johansen 5fff3689d6 [kernel] Report error instead of crashing in constant evaluator. 
Change-Id: I2c116cdc6add54194d0641631b3603313603c89e
Reviewed-on: https://dart-review.googlesource.com/11442
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-05 12:13:03 +00:00
danrubel a04c815a3c Fix test expectations after FF update on Linux 
Change-Id: Iee4021b1285fab5b3acc862d297b352788eafb0f
Reviewed-on: https://dart-review.googlesource.com/10741
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-10-03 21:30:48 +00:00
danrubel 8c939954e3 Fix test expectations after FF update on Linux 
Change-Id: I3b56b9a6d0ba33f6b884327e0e757e7581b19110
Reviewed-on: https://dart-review.googlesource.com/10660
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-10-03 18:48:20 +00:00
Erik Corry 0b039de61e Fix test expectations after FF update on Linux 
R=danrubel@google.com

Related: https://dart-review.googlesource.com/c/sdk/+/9541
Bug:
Change-Id: I68ab0408258681594de850b3fddd89083c4a0859
Reviewed-on: https://dart-review.googlesource.com/10560
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-10-03 16:24:07 +00:00
William Hesse 789525cc30 Update co19 status for windows firefox 56 
Bug:
Change-Id: Id7ec0cbba8bfd30de90e5ff2ea348206fa6320cf
Reviewed-on: https://dart-review.googlesource.com/9541
Reviewed-by: Jonas Termansen <sortie@google.com>
 2017-09-29 12:06:37 +00:00
Dan Rubel f0caee1b24 Improve import directive recovery and report analyzer errors 
- New handleRecoverImport event
    for clauses in import directive that are out of order
- New error codes for
    Duplicate prefix
    Prefix after combinator

Change-Id: I0fea7ad4b4014a0b8578d3982e0515fe85044854
Reviewed-on: https://dart-review.googlesource.com/7980
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-27 12:56:46 +00:00
Aske Simon Christensen fab74715fe Report error if a member has the same name as the enclosing class 
To recover properly from the error, change lookup priority in the Diet Listener from setter, field/getter/method, constructor to setter, constructor, field/method/getter.

Closes https://github.com/dart-lang/sdk/issues/29944
Change-Id: I3648501880e4e2059c386aa0032d37d0470aab96
Reviewed-on: https://dart-review.googlesource.com/7712
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-25 11:55:02 +00:00
Vyacheslav Egorov 9678113619 [VM] Fix incorrect range assignment for Uint32 ops. 
When replacing 64bit signed operations with unsigned 32bit ones
IntegerInstructionSelector::Replace would simply copy 64bit operation's
range onto uint32 op. This however is only correct for positive range,
non-positive ranges must become [0, kMaxUint32]. 

Fixes https://github.com/dart-lang/sdk/issues/30853

Bug:
Change-Id: I896b7828c29fe8f04a844cfb984295cb47ddaaf2
Reviewed-on: https://dart-review.googlesource.com/8020
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2017-09-25 10:09:32 +00:00
William Hesse 01d4faae5c Update co19 status for flaky test on dart2js-d8 
Bug: https://github.com/dart-lang/sdk/issues/30853
Change-Id: I9332f3d71046b47497ddddaa0a434d77430446c1
Reviewed-on: https://dart-review.googlesource.com/7760
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-22 16:30:50 +00:00
Dan Rubel 8fedf42184 fix out of order directive error codes 
Change-Id: I903d3e5e59b9d836c7dbe23c5610286437731cb2
Reviewed-on: https://dart-review.googlesource.com/7500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-22 13:06:15 +00:00
William Hesse 8762998d96 Update status for co19 test flaking on the dart2js-chrome CQ builder 
Bug: https://github.com/dart-lang/sdk/issues/30853
Change-Id: I80549a10ccab8481d427c181f591ad9714020ddf
R=bkonyi@google.com
Reviewed-on: https://dart-review.googlesource.com/7556
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-21 18:29:15 +00:00
Alexander Aprelev 02032850e5 Fix dartk checked tests 
Fix red https://build.chromium.org/p/client.dart.fyi/builders/vm-kernel-linux-release-x64-checked-be buildbot.

Change-Id: I7e5d6769d93802d397685d258f79c638aa4e2d45
Reviewed-on: https://dart-review.googlesource.com/4981
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-09-21 16:37:54 +00:00
Alexander Thomas c6d1edc4ec Disable co19 WebGL tests unless the builder_tag is set to run_webgl_tests to combat flakiness 
Bug: 29961
Change-Id: Ia5c0268a1b27181cef35e679e1410d104c345fc9
Reviewed-on: https://dart-review.googlesource.com/7360
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-20 17:01:47 +00:00
Florian Loitsch 1483fc16fb Update co19-status file with bug number. 
Change-Id: Id1a93dc120f15be82dfea91fe779f4993354a562
Reviewed-on: https://dart-review.googlesource.com/7320
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:51:56 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Alexander Thomas 851f689c7c Skip co19/LayoutTests/fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551_t01 test on dart2js/chrome 
Bug:
Change-Id: I8733b9aa42013315edd261eab9e147f3ec22c7d0
Reviewed-on: https://dart-review.googlesource.com/6960
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-19 13:33:23 +00:00
William Hesse 4a00f7b2d6 Update statuses for slow and flaky tests that affect the CQ. 
Bug: https://github.com/dart-lang/sdk/issues/30736
Change-Id: I297e49ff179121d32d3637a7a1800ab65f8e4572
Reviewed-on: https://dart-review.googlesource.com/5767
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-15 13:14:28 +00:00
William Hesse 947512e2c4 Update status for co19 test on Windows Firefox 
Bug:
Change-Id: I3ce71d760ad9950ee7db84c4274d2cb0a3134caf
Reviewed-on: https://dart-review.googlesource.com/5360
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-09-13 08:38:36 +00:00
Beeravolu Siva Chandra Reddy 004a515217 Populate library imports and exports when loading library from kernel. 
Change-Id: If6cc94aa186948caa8798212d6161da650ff2d8e
Reviewed-on: https://dart-review.googlesource.com/4381
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-09-12 10:44:49 +00:00
Emily Fortuna 47a3b0e937 Update comment in co19 test status. 
Bug:
Change-Id: Ia18a120f38daf3f2885c94ec366d03e175b608cb
Reviewed-on: https://dart-review.googlesource.com/4081
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-09-07 18:00:43 +00:00
Dmitry Stefantsov 57d61c9702 Mark vertical-scrollbar-in-rtl-doesnt-fire-onscroll_t01 as flaky 
The test
co19/LayoutTests/fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll_t01
sometimes flakes and has the outcome of Pass instead of RuntimeError.

Change-Id: I0c0fdf459fc79234069f3bbaf78fabc6ac5929b4
Reviewed-on: https://dart-review.googlesource.com/3888
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2017-09-07 11:42:56 +00:00
Emily Fortuna d0233a3b9a MOAR STATUS FILES FOR CO19 
Change-Id: I26c4291707fa8713f7417aee8bf9b07ff9b532be
Reviewed-on: https://dart-review.googlesource.com/3822
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-07 00:45:14 +00:00
Emily Fortuna 96acfc6561 Fix flakey status on ie11. Dart 'gardening' 
Bug:
Change-Id: I982078e67cffcc517a534428cc90ba61ed357a97
Reviewed-on: https://dart-review.googlesource.com/3794
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-07 00:11:29 +00:00
Emily Fortuna 293bd676ba MORE STATUS FILE FIXES! 
Bug:
Change-Id: I037b958eb8dd7812cc8d0aee0cb502d5fe821225
Reviewed-on: https://dart-review.googlesource.com/3793
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-07 00:02:59 +00:00
Emily Fortuna ec9c158e90 Test status for co19 
Bug:
Change-Id: I7880921111b8c15daafc74929d7500cbdce8eb36
Reviewed-on: https://dart-review.googlesource.com/3792
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 23:48:28 +00:00
Emily Fortuna 7b48f95748 co19 status file updatezzzz. 
TBR

Bug:
Change-Id: Icd5cd1c13abca0dfe4a3695b6d2319d80b57dff2
Reviewed-on: https://dart-review.googlesource.com/3788
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 23:19:25 +00:00
Emily Fortuna cc0eab5527 Status file fix. 
TBR

Bug:
Change-Id: I0b73b78e2a00c57f587d42a977dfd6644a7d28f5
Reviewed-on: https://dart-review.googlesource.com/3783
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 22:36:11 +00:00
Emily Fortuna 677950185c More status file updates. 
TBR 

Bug:
Change-Id: I18b779074482b5fc1a0451845b57933766723dc3
Reviewed-on: https://dart-review.googlesource.com/3782
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 22:32:33 +00:00
Emily Fortuna 0a36b589be Update test statuses from c019 tests. 
TBR

Bug:
Change-Id: I7e3c9ae36aae8bfd1bf9a2355ba8a65904d90106
Reviewed-on: https://dart-review.googlesource.com/3780
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-09-06 22:23:58 +00:00
William Hesse 9d5aa36a30 Update status for a flaky webgl co19 test on Chrome 
R=athom@google.com

Bug:
Change-Id: I72ea4a3d41f53c1194220c80ac6472bdab7aa522
Reviewed-on: https://dart-review.googlesource.com/3123
Reviewed-by: Alexander Thomas <athom@google.com>
 2017-09-05 15:31:15 +00:00