Commit Graph

3219 Commits

Author SHA1 Message Date
zundel@google.com b3ff2bb31e More co19 triage for dartc
Review URL: https://chromiumcodereview.appspot.com//9949068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6296 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-06 22:36:08 +00:00
zundel@google.com 4d40985460 Implement @runtime-error in co19 tests for static analysis (no runtime)
http://code.google.com/p/dart/issues/detail?id=2406

Review URL: https://chromiumcodereview.appspot.com//10010004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6243 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-05 19:39:38 +00:00
zundel@google.com ec609edb6d Adds fixes for the 'super' keyword used by itself in certain situations
Review URL: https://chromiumcodereview.appspot.com//9949016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6240 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-05 18:48:42 +00:00
zundel@google.com f3c3451cbf Show an error if a field has no getter defined in a getter context
http://code.google.com/p/dart/issues/detail?id=2408

Review URL: https://chromiumcodereview.appspot.com//9979004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6199 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-04 21:51:46 +00:00
zundel@google.com 969d4caa18 Make sure toplevel final fields are initialized
http://code.google.com/p/dart/issues/detail?id=2372

Review URL: https://chromiumcodereview.appspot.com//9982003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6184 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-04 18:05:12 +00:00
zundel@google.com 93396061da dartc triaging from last several co19 merges is now caught up
There are still some older issues with out issue numbers.
(I also sorted the file.)

Review URL: https://chromiumcodereview.appspot.com//9961004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6166 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-04 14:25:28 +00:00
zundel@google.com c4d9d56627 Dartc's 'can't use a type variable in static context' message now works the same way as 'NO_SUCH_TYPE'
The error message for can't use a type variable in a static
context is useful, but it was an unconditional error.  Really,
the message is just a more friendly version of 'NO_SUCH_TYPE' and
needs to work in the same way, being a warning in some contexts, and
a compile time error in others.

http://code.google.com/p/dart/issues/detail?id=2374

Review URL: https://chromiumcodereview.appspot.com//9963082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6146 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-03 20:32:23 +00:00
regis@google.com ab0a25eb1d Add missing type checks for top level static initializers (issue 1980 and
duplicates 1957, 2070, 2224).
Review URL: https://chromiumcodereview.appspot.com//9958091

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6145 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-03 20:23:30 +00:00
zundel@google.com 1553a3bc0d Triaged more co19 tests
Review URL: https://chromiumcodereview.appspot.com//9958113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6132 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-03 18:00:49 +00:00
turnidge@google.com e610ab662b Revert my last change due to problems on other platforms.
Review URL: https://chromiumcodereview.appspot.com//9968088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6129 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-03 17:51:20 +00:00
turnidge@google.com 11d29be5e1 Detect recursion during compilation of const constructors.
We now give a message like this:

    Illegal recursion in const constructor 'A.'.
Review URL: https://chromiumcodereview.appspot.com//9965081

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6128 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-03 17:32:39 +00:00
zundel@google.com 3eaaa6b255 dartc co19 bug triage
Review URL: https://chromiumcodereview.appspot.com//9969055

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6095 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-02 17:48:19 +00:00
regis@google.com 5282e44fb2 Use null type argument vector instead of vector of Dynamic for a generic raw
type when possible.
Fix type finalization of type parameters (always finalize in the context of the
class being parameterized and not in the enclosing class where the type
parameter is used).
Fix wrong generic optimization and added a test (a generic type instantiated
from a raw instantiator is not always raw).
Added printing of type argument vectors.
Review URL: https://chromiumcodereview.appspot.com//9939003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6068 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-30 22:16:52 +00:00
hausner@google.com 18d5cf7965 Fix two compile time const issues
- For equality expressions, the operands do not have to be of same
  type. (Issue 1671)

- Truncating division is allowed for any numerical type, not just
  integer. (Issue 1780) Spec has been updated accordingly and
  co19 issue 106 filed to fix faulty test.
Review URL: https://chromiumcodereview.appspot.com//9969023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6059 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-30 18:45:17 +00:00
hausner@google.com 50433eb7a9 Report error on missing factory class
Fixes issue 974. If an interface declares a constructor, it must
declare a factory class. Report compile-time error if the factory
class is missing.
Review URL: https://chromiumcodereview.appspot.com//9958018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6046 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-30 16:53:55 +00:00
srdjan@google.com 4ded3bfebe Allo fail and pass of precision tests (co19 issue 44) on all platforms.
Review URL: https://chromiumcodereview.appspot.com//9910017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5992 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-29 17:50:51 +00:00
srdjan@google.com f6f02451ce Change co19 test Skip -> Pass, Fail
Review URL: https://chromiumcodereview.appspot.com//9923015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5991 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-29 17:40:26 +00:00
srdjan@google.com c446c19fb7 Intrinsify methods early. Fix some bugs in trinsified code, mark one precision-related bug as SKIP since sometimes it may pass sometimes not.
Review URL: https://chromiumcodereview.appspot.com//9921017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5985 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-29 17:05:00 +00:00
ngeoffray@google.com 133b680241 Fix a bug where a block would be visited twice: by a non-dominating loop, and by its dominator.
Review URL: https://chromiumcodereview.appspot.com//9878001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5968 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-29 09:15:02 +00:00
floitsch@google.com 918a9681dd Correctly handle constness for list and map literals inside bodies.
Also parse const keyword for maps.

Review URL: https://chromiumcodereview.appspot.com//9802023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5944 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-28 18:16:39 +00:00
zundel@google.com e5ca48a7d5 Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries
Adds a new cmdline flags

--dart-sdk to point it at a directory where the dart library files are staged
--platform the name of the platform {dartium, vm, frog, dart2js}
to target with the analyzer

Committed: https://code.google.com/p/dart/source/detail?r=5885

Review URL: https://chromiumcodereview.appspot.com//9860009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5930 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-28 14:20:29 +00:00
floitsch@google.com 17ed6e5b3b Error out on compile-time constants if equality is tested on bad types.
Don't fold equality operation if left-hand side is a constructed object.

Review URL: https://chromiumcodereview.appspot.com//9866027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5919 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-28 00:31:19 +00:00
floitsch@google.com f8a6645fce super and this in compile-time constants.
Review URL: https://chromiumcodereview.appspot.com//9753001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5918 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-28 00:11:17 +00:00
floitsch@google.com bb546c7954 We handle cyclic references. No need to skip this test anymore.
Review URL: https://chromiumcodereview.appspot.com//9864026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5916 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-27 23:31:03 +00:00
efortuna@google.com c8e35dbeb1 Rename test.dart component to specify compiler + runtime.
Review URL: https://chromiumcodereview.appspot.com//9838068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5893 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-27 18:40:41 +00:00
zundel@google.com 1486f2602d Revert "Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries"
This reverts commit r5885 which works locally, but not on the builder

Review URL: https://chromiumcodereview.appspot.com//9865025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5886 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-27 17:04:03 +00:00
zundel@google.com b838d39acb Removes dartc reliance on its own libraries, now can be targeted at any implementation's libraries
Adds a new cmdline flags

--dart-sdk to point it at a directory where the dart library files are staged
--platform the name of the platform {dartium, vm, frog, dart2js}
to target with the analyzer

Review URL: https://chromiumcodereview.appspot.com//9860009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5885 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-27 16:25:54 +00:00
karlklose@google.com a52cc81e9e Allow constant folding of && and ||.
Review URL: https://chromiumcodereview.appspot.com//9810027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5865 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-27 07:47:01 +00:00
ahe@google.com 8f27098ffb Handle implicit closure of toString.
Review URL: https://chromiumcodereview.appspot.com//9835088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5820 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-26 09:47:18 +00:00
ahe@google.com 588e827484 Implement unlabeled continue.
Review URL: https://chromiumcodereview.appspot.com//9808109

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5808 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-25 20:21:46 +00:00
ahe@google.com 3a3162da27 "Implement" #resource tag and various restrictions on library definitions.
Review URL: https://chromiumcodereview.appspot.com//9838038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5804 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-24 08:51:37 +00:00
floitsch@google.com 711f3a8898 Visit parenthesized expressions in compile-time constants.
Also switch from unimplemented to error for non-recognized nodes.

Review URL: https://chromiumcodereview.appspot.com//9808092

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5799 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-23 23:53:05 +00:00
lrn@google.com 8fbc459057 Make continue work in do-while.
Review URL: https://chromiumcodereview.appspot.com//9810006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5781 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-23 14:52:39 +00:00
ahe@google.com 860ececd38 Triage co19 tests.
Review URL: https://chromiumcodereview.appspot.com//9837034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5780 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-23 14:06:30 +00:00
ahe@google.com f4819bf7ac Fix co19 crashes
Review URL: https://chromiumcodereview.appspot.com//9839004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5754 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-22 15:08:01 +00:00
ahe@google.com d690a9b04a Update co19 status for developer mode VM
Review URL: https://chromiumcodereview.appspot.com//9834007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5746 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-22 11:33:37 +00:00
ahe@google.com 503d5cf3c9 Update co19 to revision 164.
Review URL: https://chromiumcodereview.appspot.com//9834006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5745 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-22 11:23:49 +00:00
ager@google.com 2aba281fa6 Remove backwards compatibility 'win32' name from test status files.
Using win32 instead of windows was temporary to be compatible with
the old python script. That is now gone.

R=antonm@google.com
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9817019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5736 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-21 22:06:52 +00:00
ahe@google.com 4bbdf744dc Parse function expressions correctly.
Review URL: https://chromiumcodereview.appspot.com//9817006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5721 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-21 15:08:13 +00:00
ahe@google.com c2fdb5fdfd Implement unresolved super-send (but ignoring arguments).
Review URL: https://chromiumcodereview.appspot.com//9815003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5716 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-21 13:13:33 +00:00
ahe@google.com 49712da22a Implement super-send to non-function.
Review URL: https://chromiumcodereview.appspot.com//9753007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5710 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-21 10:22:24 +00:00
lrn@google.com d3d668d94b Change visitLoop to handleLoop that takes closures as arguments.
This allows easy reuse in for-in loops.

Review URL: https://chromiumcodereview.appspot.com//9753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5707 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-21 09:00:47 +00:00
floitsch@google.com d55be95ea3 Call the compile-time constant handler inside bodies.
Don't transform a const instantiation into a 'new'.

Review URL: https://chromiumcodereview.appspot.com//9703074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5706 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-21 07:14:36 +00:00
lrn@google.com 1a9a102810 Fix typo in expectations.
Review URL: https://chromiumcodereview.appspot.com//9755005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5679 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-20 11:13:09 +00:00
lrn@google.com 6124d2d373 Make string interpolations be compile-time-constants.
Based on StringInterpolation change that hasn't been committed yet.

Review URL: https://chromiumcodereview.appspot.com//9706018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5676 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-20 08:55:07 +00:00
cshapiro@google.com 62a5452feb Make failed capturing parenthesis produce null instead of "".
BUG=2068

Review URL: https://chromiumcodereview.appspot.com//9718015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5670 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-20 00:36:21 +00:00
cshapiro@google.com 86bd5e8827 Improve the replaceFirst, replaceAll and split methods.
An empty regular expression had caused split to loop infinitely.  Now,
the split method behaves like its namesake in ECMAScript and splits a
string along character boundaries.

The split, replaceFirst, and replaceAll methods only supported RegExp
and String patterns.  Now, these methods are implemented on top of the
allMatches method and work for all subinterfaces of Pattern.

BUG=2171

Review URL: https://chromiumcodereview.appspot.com//9689089

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5653 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-19 18:06:42 +00:00
ahe@google.com 07cee6c032 Resolve type Dynamic and implement black listing.
Review URL: https://chromiumcodereview.appspot.com//9724032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5648 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-19 16:22:09 +00:00
ahe@google.com dd96f32250 Rename leg -> dart2js.
Review URL: https://chromiumcodereview.appspot.com//9717033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5636 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-19 08:36:39 +00:00
floitsch@google.com 71b243f091 Compile initializers in right order.
Review URL: https://chromiumcodereview.appspot.com//9720030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5624 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-18 18:10:18 +00:00