Commit Graph

3219 Commits

Author SHA1 Message Date
karlklose@google.com 8255ab3f14 Emit compile-time error when a constant field is not initialized.
R=johnniwinther@google.com

BUG=12932

Review URL: https://codereview.chromium.org//25006002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28003 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-27 11:37:41 +00:00
hausner@google.com b0780d316b Check types of case expressions
Implement checks to make sure all case expressions are of the same type and other restrictions.

This change assumes that it's ok to use double values in switch expressions. Will verify with those who are in the know.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//24768004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27968 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 18:54:15 +00:00
ricow@google.com 4eba8e5c88 Remove flaky markers for v8 bug - this has already been fixed by a v8 roll
R=kustermann@google.com

Review URL: https://codereview.chromium.org//24517002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27931 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 06:47:20 +00:00
johnmccutchan@google.com b4a127cca3 Forgot a test in dart2dart.
BUG=

Review URL: https://codereview.chromium.org//24467003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27918 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 22:48:33 +00:00
johnmccutchan@google.com 83ea974c3e Mark Float32x4 clamp test as failing in dart2js and dart2dart
BUG=

Review URL: https://codereview.chromium.org//24648003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27917 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 22:10:13 +00:00
hausner@google.com 0ca53d0cef Fix dart2dart status
Review URL: https://codereview.chromium.org//24513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27896 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 17:39:30 +00:00
hausner@google.com 7eaea8b300 Discard first line of multiline string if only whitespace
R=iposva@google.com

Review URL: https://codereview.chromium.org//24493007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27895 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 17:26:55 +00:00
scheglov@google.com 7ce03ef926 New analyzer_experimental snapshot.
There are couple small changes in analyzer itself:

1. AnalysisCache.entrySet() to return Collection instead of Set - it is expensive to fill actual Set in Dart - hash code, equals, etc. We know there are no duplicates.

2. Matcher in TODO scrapper - there are no start(i) in Dart, I have to change implementation to translate it accurately.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//24481002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27889 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 16:02:19 +00:00
kustermann@google.com dfbf264f40 Automatically converted general Fail status file markers to one of the more specific markers
R=johnniwinther@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//23494066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27876 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 12:47:03 +00:00
scheglov@google.com a00bffa64a Spec changed for INVALID_OVERRIDE_REQUIRED
R=jwren@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23874024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27836 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 18:07:15 +00:00
johnmccutchan@google.com a15ab19004 Mark co19 tests as failing in dart2js and dart2dart
TBR=zra@google.com

Review URL: https://codereview.chromium.org//23889044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27832 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 17:29:38 +00:00
johnmccutchan@google.com dcda2adb90 Cleanup bit casting methods between SIMD types
R=zra@google.com

Review URL: https://codereview.chromium.org//24240020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27827 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 16:23:46 +00:00
kustermann@google.com 9e1ba8381e Status file update after adding new vm-linux-release-optcounter-threshold builder
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//23710088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27815 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 12:19:10 +00:00
karlklose@google.com 351b87248d Reapply: "Emit compile-time error on duplicate parameter names in typedefs."
BUG=7202
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//24326003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27798 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 06:56:51 +00:00
karlklose@google.com 86d169969c Emit compile-time error for 'static' formal parameters.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//23872035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27796 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 06:32:50 +00:00
kustermann@google.com 16d6be26cb Mark co19/LibTest/core/Uri/Uri_A06_t03 as timeout on ie9
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//24312008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27780 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 17:00:56 +00:00
karlklose@google.com 96785ff00a Emit compile-time errors for conflicting modifiers.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//23708057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27737 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 06:28:06 +00:00
scheglov@google.com 69ef133218 Report CTEC.CONST_NOT_INITIALIZED
https://code.google.com/p/dart/issues/detail?id=13408
https://code.google.com/p/dart/issues/detail?id=13018

partly https://code.google.com/p/dart/issues/detail?id=11124

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//24191008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27713 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 18:08:22 +00:00
scheglov@google.com 7832605f9a Triage new co19 failures.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//23531082

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27708 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 16:10:14 +00:00
kustermann@google.com 836336a3d5 Removed status file entries referring to non-existent files
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//24150005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27704 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 13:29:29 +00:00
karlklose@google.com 8de1962a75 Revert "Reapply r27640: "Emit compile-time error on duplicate parameter names in typedefs.""
This reverts commit r27693.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//23531079

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27696 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 10:35:20 +00:00
karlklose@google.com 6b6fefb220 Reapply r27640: "Emit compile-time error on duplicate parameter names in typedefs."
R=johnniwinther@google.com, ngeoffray@google.com

Review URL: https://codereview.chromium.org//24166003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27693 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 09:59:12 +00:00
lrn@google.com ba5aced9c9 Update dart2js parser to disallow repeated comparisons and prefix +.
Remove support for prefix plus on integer literals.
Remove support for (a < b < c) and (a == b == c) syntax.

BUG= http://dartbug.com/13223
R=ahe@google.com

Review URL: https://codereview.chromium.org//23450044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27692 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 08:59:38 +00:00
karlklose@google.com 7d44a6cead Emit a compile-time error on members with the name of their enclosing class.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//23948006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27689 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 08:02:40 +00:00
kustermann@google.com 6f01bfe3ca co19-roll: followup status file changes
R=ricow@google.com

Review URL: https://codereview.chromium.org//24241003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27660 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 13:42:45 +00:00
kustermann@google.com be1fc8ad2d co19-roll to r587
R=ricow@google.com

Review URL: https://codereview.chromium.org//23437044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27657 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 11:50:48 +00:00
karlklose@google.com 3546537ce5 Emit compile-time error on 'const' formal parameters.
R=ngeoffray@google.com
BUG=dartlang.com/5519

Review URL: https://codereview.chromium.org//24267002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27650 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 09:29:41 +00:00
karlklose@google.com d3b5fc21bb Check cycles in redirecting factories.
BUG=dartubg.com/10959
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//23452038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27645 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 08:16:56 +00:00
karlklose@google.com bb8afc57b4 Revert "Emit compile-time error on duplicate parameter names in typedefs."
This reverts commit r27640.

Review URL: https://codereview.chromium.org//24260002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27642 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 07:08:55 +00:00
karlklose@google.com b506b81ad0 Emit compile-time error on duplicate parameter names in typedefs.
BUG=dartbug.com/7202
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//23463032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27640 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-19 06:57:17 +00:00
johnniwinther@google.com 8e6c654b1a Check for uninitialized constant variables.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//23979004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27623 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 15:10:38 +00:00
johnniwinther@google.com 250e9bc383 Support general expressions as keys in literal maps.
R=ngeoffray@google.com

Review URL: https://codereview.chromium.org//22909056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27622 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 14:59:28 +00:00
kasperl@google.com ce874ffe22 More chrome-on-android status tweaking.
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23885007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27620 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 14:38:26 +00:00
kasperl@google.com dda7b89340 Another chrome-on-android status file tweak.
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23533059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27616 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 12:57:48 +00:00
lrn@google.com ee3dfa414f Change the order of bitwise operators and equality/relational operators.
Gives bitwise operators precedence above that of equality/relational operators.

This means that
  a & mask == something
no longer needs parentheses.

Since bitwise operators didn't work on booleans, and there are probably very few custom operator&'s that accept a boolean, this is expected to not break existing code.

BUG= http://dartbug.com/114
R=hausner@google.com, kasperl@google.com

Review URL: https://codereview.chromium.org//23710024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27613 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 12:32:47 +00:00
kasperl@google.com 212b749a90 More tweaking of chrome-on-android status files.
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//24148004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27607 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 11:16:30 +00:00
kasperl@google.com f77e810f81 First attempt at fixing the status file for chrome-on-android.
R=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//23653043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27601 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 09:56:33 +00:00
johnniwinther@google.com 6466a610b8 Check for cyclic reference in typedefs
This CL introduces a post-processing queue to the resolution phase which is processing immediately after the resolution queue has been closed.

The cyclic check of typedefs uses this post-processing queue to register the checking function during TypedefResolverVisitor.

R=ahe@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//13261008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27595 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-18 08:42:44 +00:00
johnniwinther@google.com 251e90e660 Support new import rules.
BUG=http://dartbug.com/12723
R=ahe@google.com

Review URL: https://codereview.chromium.org//23684057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27560 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 11:50:30 +00:00
johnniwinther@google.com d76a758d7c Handle exception from scanning.
BUG=http://dartbug.com/13328
R=ahe@google.com

Review URL: https://codereview.chromium.org//23742006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27547 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 06:42:18 +00:00
johnniwinther@google.com ef4ed3f828 Detect asynchronous dart2js crashes correctly.
BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org//24082005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27546 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-17 06:36:50 +00:00
zra@google.com 7f14b73c15 Triage of vm co19 issues.
R=iposva@google.com

Review URL: https://codereview.chromium.org//23931004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27527 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-16 19:42:58 +00:00
karlklose@google.com a7f31f635a Emit compile-time error for incorrectly used optional parameters.
BUG=dartbug.com/13183
R=ahe@google.com

Review URL: https://codereview.chromium.org//23456030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27513 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-16 08:14:33 +00:00
hausner@google.com bbcf74a569 Make "as" a built-in identifier aka pseudo keyword
Fixes issues 12551, 13021

R=regis@google.com

Review URL: https://codereview.chromium.org//23542041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27461 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 23:45:41 +00:00
hausner@google.com 417e20b15f Detect illegal class member names
Make it a compile time error if a class member has the same name
as the class.

Fixes issue 13236.

Review URL: https://codereview.chromium.org//23513044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27446 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 20:44:34 +00:00
brianwilkerson@google.com 6cc1cc0e63 Fix for issue 13272
R=jwren@google.com

Review URL: https://codereview.chromium.org//23578028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27441 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 18:11:56 +00:00
ajohnsen@google.com eeefb3ec90 Return the correct port from Uri, when port is 0 and scheme is either http or https.
Also, always perform to-lower-case of scheme, as recommended by the
spec.

BUG=https://code.google.com/p/dart/issues/detail?id=13129
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//23766030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27431 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 13:27:59 +00:00
ajohnsen@google.com 3346013a47 Mark co19 file in analyzer status file as well.
BUG=

Review URL: https://codereview.chromium.org//23890019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27428 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 11:21:18 +00:00
ajohnsen@google.com 1dba2c2cab Change Uri methods taking a decode argument, to now take an encoding.
This finished the integration of dart:convert into Uri.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//24122002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27426 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 11:09:38 +00:00
ajohnsen@google.com 95f25327a9 Mark co19 test as broken.
BUG=

Review URL: https://codereview.chromium.org//23618044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27424 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 09:42:18 +00:00