aeae2b82bb
Fix expectation
...
TBR=asiva@google.com ,hausner@google.com
Review URL: https://codereview.chromium.org//48343007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29848 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 21:56:40 +00:00
1b87d7e2bd
Compile time error on forward references to functions
...
Like variables, names of functions must not be referenced
before they are declared.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//49253006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29835 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 18:53:58 +00:00
7cd5977b62
Re-land "Search for main in the exported names of the main library, not in the library itself."
...
BUG=
Review URL: https://codereview.chromium.org//57433004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29812 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 15:40:57 +00:00
59f34542e2
Removed status file entries which refer to non-existent tests
...
R=fschneider@google.com
Review URL: https://codereview.chromium.org//56123009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29811 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 15:28:44 +00:00
306f78c12b
Revert "Re-land "Search for main in the exported names of the main library, not in the library itself.""
...
This reverts commit 2323a2ca0c702657021f0cb2b532402eafd13d49.
R=johnniwinther@google.com
BUG=
Review URL: https://codereview.chromium.org//45763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29810 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 15:27:51 +00:00
660e5e5f15
Re-land "Search for main in the exported names of the main library, not in the library itself."
...
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//57853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29809 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 14:48:52 +00:00
857a995ce8
Revert "Search for main in the exported names of the main library, not in the library itself."
...
This reverts commit 74a865df6d58a87dce5a9d8c77cbc70c694ba50b.
TBR'ed.
R=johnniwinther@google.com
BUG=
Review URL: https://codereview.chromium.org//57843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29808 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 13:53:12 +00:00
b5c09ad8cc
Search for main in the exported names of the main library, not in the library itself.
...
R=johnniwinther@google.com
BUG=http://dartbug.com/14762
Review URL: https://codereview.chromium.org//49003012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29807 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 13:49:57 +00:00
1ddf0d9a53
Reapply "Set runtime type on list and map literals."
...
Reviewed as: https://chromiumcodereview.appspot.com/54293008/ .
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//56553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29798 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 10:25:25 +00:00
91ca330ac8
VM: Fix initialization of statics in presence of exceptions.
...
In a static- or top-level variable v
var v = expr
static v = expr
If the initializer expression expr throws, the VM throws a
CyclicInitializationError when loading v afterwards, even though
this has nothing to do with cyclic initialization.
I'm changing the way implicit static getters and static initializers are
compiled. Static initializers are invoked from static getters.
They look as follows:
get:v {
if (field.value === transition_sentinel) {
field.value = null;
throw new CyclicInitializationError();
}
if (field.value === sentinel) {
field.value = transition_sentinel;
init:v();
}
return field.value;
}
init:v {
try {
field.value = expr;
} catch {
if (field.value === transition_sentinel) {
field.value = null;
}
rethrow;
}
}
BUG=http://dartbug.com/5802
TEST=language/lazy_static3_test,
language/throwing_lazy_variable_test,
co19/Language/12_Expressions/30_Identifier_Reference_A08_t02
R=hausner@google.com
Review URL: https://codereview.chromium.org//54713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29797 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 10:08:47 +00:00
f469ae8d07
Issue 13241. Report StaticWarningCode.CONFLICTING_INSTANCE_METHOD_SETTER.
...
https://code.google.com/p/dart/issues/detail?id=13241
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//56773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29787 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-02 20:32:28 +00:00
673f342f5c
Suppress flake in co19/LibTest/async/Future/catchError_A03_t05 on ie9
...
BUG: 14712
R=floitsch@google.com
Review URL: https://codereview.chromium.org//55863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29784 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-02 00:49:38 +00:00
c96bc29ab5
Compile time error if name is used before variable is declared
...
Implement proper semantics if a name has been referenced in a
block and later a variable with that same name is declared.
Fix library code that was wrong.
Add new language test, delete a couple of tests that are
outdated, file co19 bug 649.
Dart2js and dart2dart are not yet implementing these compile-time
errors.
R=iposva@google.com
Review URL: https://codereview.chromium.org//51533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29770 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 21:28:31 +00:00
d4359631f7
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//51043010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29765 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 19:24:33 +00:00
12775b2ba7
Update co19 status file.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//54093005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29762 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 18:29:36 +00:00
ae32a9a2fc
Fix co19 status
...
TBR
Review URL: https://codereview.chromium.org//54823006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29724 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 07:26:24 +00:00
5f63715d47
SIMD shuffle API changes
...
R=srdjan@google.com , zra@google.com
Review URL: https://codereview.chromium.org//51373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29723 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-01 07:09:54 +00:00
1a4fb17016
Propagate stack traces.
...
BUG= http://dartbug.com/14331
BUG= http://dartbug.com/14265
R=lrn@google.com
Review URL: https://codereview.chromium.org//50453005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29684 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 17:39:10 +00:00
5a0291eeee
Mark dart2dart as failing.
...
BUG=
Review URL: https://codereview.chromium.org//50523017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29679 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 15:17:57 +00:00
ee6f22b91e
Fix co19-dartium status, couple of tests are marked as expected to Fail but they actually pass on dartium.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//52183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29621 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-31 01:24:21 +00:00
3fa7a61efc
Implement latest spec changes regarding malformed types (see issue 14006):
...
- a malformed type used in a is, as, or catch type test results in a dynamic
type error being thrown.
- a malformed type is not mapped to dynamic anymore.
For now, this applies to type tests in checked mode as well, but discussion is
still on-going.
R=hausner@google.com
Review URL: https://codereview.chromium.org//53583003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29608 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 23:30:32 +00:00
901e7aee6c
Followup status file update after co19-roll to r651
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//47023012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29603 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 22:39:17 +00:00
6029bd2f44
co19-roll to r651
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//53453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29596 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 22:16:51 +00:00
40b46785a4
Update co19 status for dart2js
...
Review URL: https://codereview.chromium.org//45313013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29565 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 17:19:40 +00:00
1d63cb85df
Fix status file dor dart2dart.
...
Review URL: https://codereview.chromium.org//51063003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29556 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 15:33:36 +00:00
36e2df1a1d
Mirrors overhaul.
...
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//23455028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29551 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 14:58:58 +00:00
f5ec8f25d3
Emit a compile-time error when using default values in a redirecting factory.
...
BUG=13663
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//51843005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29543 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 13:30:51 +00:00
0f1e8b4f53
Update status.
...
BUG=
Review URL: https://codereview.chromium.org//52453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29538 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 12:28:29 +00:00
6cb1a4b3da
Update co19 expectations - we don't allow null as an error in completer.
...
Review URL: https://codereview.chromium.org//52263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29521 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 09:49:25 +00:00
65379851a8
Implement stricter rule about self referencing typedefs (fix issue 13675).
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//49853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29460 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 17:04:21 +00:00
4c3fbbdcfe
Issue 13449. Bind parameters to arguments and check for function expression invocation.
...
https://code.google.com/p/dart/issues/detail?id=13449
Also some co19 triage.
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//49743005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29457 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 16:45:27 +00:00
5b0ac43e80
Fix bugs in StreamController.addStream.
...
Add optional 'cancelOnError' to addStream method. It still defaults
to true.
Resume the added stream when adding a listener (14332).
Handle cancel-on-error correctly, so the future completes as well (14334).
BUG= http://dartbug.com/14332 http://dartbug.com/14334
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//48733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29419 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-29 08:59:52 +00:00
044575d907
Any non-special \k is OK.
...
12.5 Strings
Otherwise, \k indicates the character k for any k not in {n; r; f; b; t; v; x; u}.
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//48273006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29398 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 21:40:16 +00:00
e02652a123
Throw CyclicInitializationError instead of string
...
For some reason, I had to regenerate the snapshot for test standalone/issue14236_source.dart. The checked-in snapshot crashed with my change. We don't know yet why. Siva is looking at this separately.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//38563005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29397 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 21:38:57 +00:00
9039835b60
New analyzer snapshot.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//49383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29384 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 19:46:48 +00:00
94ebff2225
Bugfix in test.dart, adding of specialized test outcomes for analyzer
...
This CL will:
- fix a bug in the legacy AnalyzerCommandOutputImpl class (in certain cases
we did not report that the analyzer was missing a warning).
- make the outcome of running the analyzer on a test be one of:
* CompileTimeError
* MissingCompileTimeError
* StaticWarning
* MissingStaticWarning
- Make status file updates using the new Expectation markers
- Remove support for '@static-clean':
Previously running the analyer on a test could either result in
'Pass' or in 'Fail'. The '@static-clean' annotation has been used
as a (poor) mechanism to distinguish between errors and warnings.
Having the 4 markers mentioned above means we can remove '@static-clean'
- Remove 100 lines of rotted legacy code in our testing scripts.
- Make a status file entry for every test that has analyzer errors or warnings
R=ricow@google.com
Review URL: https://codereview.chromium.org//46163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29350 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 10:39:38 +00:00
b194ffdee1
Update co19 status file for LibTest/typed_data/Float32x4/clamp_A02_t01.dart
...
BUG=13106
Review URL: https://codereview.chromium.org//46653005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29342 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 06:40:02 +00:00
c5d691f64c
Status fix for Dartium bots
...
TBR=asiva@google.com ,floitsch@google.com
Review URL: https://codereview.chromium.org//46183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29301 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:30:52 +00:00
e9b01ccf7b
Disallow explicit parameter default values in redirecting factory (issue 13662).
...
Add language test.
Fix usage in core lib.
R=hausner@google.com
Review URL: https://codereview.chromium.org//45833002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29298 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 23:02:48 +00:00
94405f34e8
Update status file with issue numbers.
...
Review URL: https://codereview.chromium.org//45203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29273 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:34:37 +00:00
6a72655d1b
Very simple version of Isolates.
...
R=ajohnsen@google.com , iposva@google.com , kasperl@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//27215002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29271 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 19:23:00 +00:00
d66aab045d
Followup status file update after co19-roll to r641
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//44293003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29270 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 18:33:21 +00:00
ab4a7a15d1
New analyzer_experimental snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//42863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29260 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 16:55:54 +00:00
032b90e480
Followup status file update after co19-roll to r641
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//44633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29258 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 16:26:33 +00:00
fb9a73d615
Add bug number to co19 status file
...
Review URL: https://codereview.chromium.org//44123003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29256 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 15:52:58 +00:00
746d924e59
co19-roll to r641
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//44263003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29255 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 15:07:10 +00:00
227a78d84a
Reduce co19-dartium.status and extend section condition in co19-co19.status and co19-runtime.status
...
Most of the failures on dartium are common with the VM.
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//44053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29247 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 12:14:47 +00:00
2fa425e089
Update status file, and fix unit tests.
...
Review URL: https://codereview.chromium.org//44033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29245 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 11:54:36 +00:00
3a01260611
Remove dart:json
...
BUG= http://dartbug.com/12843
R=floitsch@google.com , fschneider@google.com
Review URL: https://codereview.chromium.org//40323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29240 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 10:30:34 +00:00
c61ba5bd02
- Adjust for slower running bots.
...
Review URL: https://codereview.chromium.org//43593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29236 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 08:19:54 +00:00
vsm@google.com