Commit Graph

3219 Commits

Author SHA1 Message Date
Aske Simon Christensen f8a96b88e9 It is an error if a final field is not initialized.
Bug: https://github.com/dart-lang/sdk/issues/33022

This commit adds an error when a final field is not initialized at all
(and there is at least one generative constructor). A later commit
will add an error for the case where a field is initialized by some,
but not all, generative constructors.

A number of classes in the Dart2js and DDC support libraries use
uninitialized final fields to indicate getters in the corresponding
native classes. This commit adds a temporary whitelist for the
affected files, which can be removed when the fields have been
replaced by external getters.

This is tracked by https://github.com/dart-lang/sdk/issues/33762

Change-Id: I6b5cee230c7cd5554da2b61da7ebddb6b0b9396e
Reviewed-on: https://dart-review.googlesource.com/63781
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
2018-08-17 12:37:52 +00:00
Aske Simon Christensen f2766eb24e Disallow references to this in field initializers.
Fixes https://github.com/dart-lang/sdk/issues/33858

Change-Id: I619de64353ac5131d949d8e3898617435e9f6dcc
Reviewed-on: https://dart-review.googlesource.com/68920
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2018-08-10 11:12:58 +00:00
Samir Jindel 278d962a7f [vm/precomp] Update status files for Dart 1 AOT.
Change-Id: I0e861b66e0db56bb1b538f164bbcc98939570559
Reviewed-on: https://dart-review.googlesource.com/68884
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-08-08 12:22:43 +00:00
Aske Simon Christensen 72b2542d81 Mark tests with Dart 1 constants in const context failing in all configs.
Update Dart 1 status for 03df8b1eb8.

This should make the front-end legacy bot go green.

Change-Id: I8679da869ac1e03aa263fc8181869bf47880cc5a
Reviewed-on: https://dart-review.googlesource.com/67540
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-08-06 08:31:37 +00:00
William Hesse 46743f3868 Remove $runtime == drt sections and uses of drt from status files.
Change-Id: Iffd934a67668901176a84c9b01512711a011652d
Reviewed-on: https://dart-review.googlesource.com/67803
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-08-03 12:40:46 +00:00
Sigmund Cherem abe03023b3 Skip co19 in ie11 for now
The co19-1 suite is broken due to changes to ALL_CAPS constants.

Once ie11 bots are migrated to the test-matrix, they will be updated to run
co19-2 and this change will not be necessary.

TBR=whesse@google.com,johnniwinther@google.com

Change-Id: I16d1e0dd40cabf89c60fe2ddce596b74ba12e615
Reviewed-on: https://dart-review.googlesource.com/66660
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-25 17:08:15 +00:00
Mike Fairhurst 5c9c90f7e1 Revert "Check void usage and invalid returns"
This reverts commit 11001793a2.

Reason for revert: Doesn't allow void to void assignment. This is breaks a lot of packages.

Original change's description:
> Check void usage and invalid returns
> 
> Closes https://github.com/dart-lang/sdk/issues/30470
> 
> Change-Id: I2ed5b54c74e0bba2771036774bbe2197ce29109d
> Reviewed-on: https://dart-review.googlesource.com/65141
> Commit-Queue: Peter von der Ahé <ahe@google.com>
> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

TBR=ahe@google.com,dmitryas@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I78f479cf8b0824dd338ae43a5514f320fd112a3f
Reviewed-on: https://dart-review.googlesource.com/66040
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
2018-07-20 22:29:45 +00:00
Leaf Petersen e9fa236d6b Status fix for CONSTANTS
Change-Id: I99b445e3337012e9fbf660a58765af5ed03e5855
Reviewed-on: https://dart-review.googlesource.com/65571
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-07-18 18:20:47 +00:00
Leaf Petersen d715c5e052 Status file fix for CONSTANTS
Change-Id: Ic7f96b6511d9225bce807c1a988401c90311bdef
Reviewed-on: https://dart-review.googlesource.com/65569
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-07-18 17:55:22 +00:00
Lasse R.H. Nielsen f2402b3c08 Remove deprecated SDK constant declarations.
Change-Id: I0e4208b6fa957765403608103128c28562280657
Reviewed-on: https://dart-review.googlesource.com/51841
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-07-18 13:05:00 +00:00
Peter von der Ahé 11001793a2 Check void usage and invalid returns
Closes https://github.com/dart-lang/sdk/issues/30470

Change-Id: I2ed5b54c74e0bba2771036774bbe2197ce29109d
Reviewed-on: https://dart-review.googlesource.com/65141
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2018-07-18 10:18:52 +00:00
Dmitry Stefantsov 7d1f3b358a [fasta] Update test status after the fixes for #32613
Change-Id: Idd473d5105237bcb57c2c051e3a1903c041ec323
Reviewed-on: https://dart-review.googlesource.com/65323
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-07-18 10:00:08 +00:00
Zach Anderson d0510501d2 [build] Add -a kbc for interpreter
This CL adds support to build.py and test.py for building/testing
a VM with the interpreter on x64, e.g.:

$ ./tools/gn.py -m release -a x64 --bytecode
$ ./tools/build.py -m release -a x64 --bytecode runtime
$ ./tools/test.py -m release -a x64 -r vm -c dartkb language_2

Change-Id: I956d23790636609d4a2e71129481fcbd7afef9a0
Reviewed-on: https://dart-review.googlesource.com/65206
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-07-17 21:51:41 +00:00
Johnni Winther fadd6c0698 Update status for ie11
Change-Id: Ic6679377a913ad176048bc798cdd7633f97eb2e6
Reviewed-on: https://dart-review.googlesource.com/65301
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2018-07-17 08:28:15 +00:00
Dmitry Stefantsov 48a258a4a5 [Fasta] Additional override checks
Checks override on fields and for methods with type parameters.

Bug: 32613
Change-Id: Ia32d1080959bc706fd72a075fb6ba724fa93fd58
Reviewed-on: https://dart-review.googlesource.com/64542
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-07-16 15:00:05 +00:00
Dmitry Stefantsov 7d6cd21706 CFE and member conflict rules
See https://github.com/dart-lang/sdk/issues/32613
and https://github.com/dart-lang/sdk/issues/33235#issue-326617285

Bug: #32613, #33235, #33237
Change-Id: I0d1432185b6811137e31135ac2c7f58c4de2de6c
Reviewed-on: https://dart-review.googlesource.com/64500
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2018-07-16 14:09:01 +00:00
Sigmund Cherem 6f12cc3eb5 Fix FF and IE status to make bots green
TBR=johnniwinther@google.com

Change-Id: I675af39e5d04fd673ae97244d36c599cb25fd178
Reviewed-on: https://dart-review.googlesource.com/64246
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-09 23:21:26 +00:00
Johnni Winther acd8f345aa Update safari status
Change-Id: Ie3f8c9dbab19e6e714010b1ec1d839cf2b216594
Reviewed-on: https://dart-review.googlesource.com/64042
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2018-07-09 15:20:48 +00:00
Johnni Winther 1c673b1046 Include bounds in type literals
Change-Id: Ieb3e5b09e88c98f8943a6e7ca9031c8a6ab776e1
Reviewed-on: https://dart-review.googlesource.com/63820
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-07-09 12:24:04 +00:00
Sigmund Cherem b7b24e9bbe Update dart2js-strong status across several suites
Change-Id: I7550e3221bcfdb4f9281b2be96af8579848c5a69
Reviewed-on: https://dart-review.googlesource.com/63504
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-03 00:27:31 +00:00
Dan Rubel ee5fd81a93 Remove parser "synthetic_identifier_<#>"
This should fix https://github.com/dart-lang/sdk/issues/33157

Change-Id: I372d8b3f57388dea4e58673e4212fa69cfff2e72
Reviewed-on: https://dart-review.googlesource.com/63180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2018-07-02 17:51:15 +00:00
Sigmund Cherem a4b27057f0 Make bots green again: mostly status updates, but also fix check in custom-element upgrades
Change-Id: Ic5e5b58be60261c4843f00eb090e0c1e4ed7e093
Reviewed-on: https://dart-review.googlesource.com/63325
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-30 01:23:39 +00:00
Stephen Adams 05db72c331 update dart2js co19 status
TBR=sigmund@google.com

Change-Id: Idd384ec7a79c79645f29310d89eab1030edf414e
Reviewed-on: https://dart-review.googlesource.com/63020
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-29 03:08:08 +00:00
Stephen Adams 6e108d709c Include native classes needed for RTI
Closes #33627

Change-Id: I9ed6bf9941df6445209a64c29af8986e382b7c51
Reviewed-on: https://dart-review.googlesource.com/62521
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-28 23:16:28 +00:00
Stephen Adams d44e7e9b61 co19 firefox status update
TBR=sigmund@google.com

Change-Id: I4f49db74a0dd151badd4087b7e1851ae5441c597
Reviewed-on: https://dart-review.googlesource.com/62881
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-28 17:20:37 +00:00
Aske Simon Christensen 90e27b19ea Check for conflicts between a static setter and a constructor or static method.
Bug: https://github.com/dart-lang/sdk/issues/33237
Change-Id: I44c69f32039de9b024c942706e96bf1998217350
Reviewed-on: https://dart-review.googlesource.com/60583
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-06-28 11:47:33 +00:00
Aske Simon Christensen bd9aa5139a Error on cyclic constructor redirect.
Fixes https://github.com/dart-lang/sdk/issues/30856

Change-Id: Ib0cb851904fdcb12fff11bae92fe177739fe793f
Reviewed-on: https://dart-review.googlesource.com/60429
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-06-28 10:37:23 +00:00
William Hesse 37d9e79b1b Update co19 and co19 strong branch in DEPS
Change-Id: I0ab70e30f645efbf15e942e347be6d286d87b2c3
Reviewed-on: https://dart-review.googlesource.com/62141
Reviewed-by: Alexander Thomas <athom@google.com>
2018-06-27 16:19:21 +00:00
Kevin Millikin df2529d443 Detect when a class has a member that conflicts with a static one
In Dart 2 classes are not allowed to have an instance method, getter,
or setter that conflicts with a static method, getter, or setter
declared in the class.  Detect this at the start of top-level type
inference when we build an explicit interface for every class.

Change-Id: I39c1887a07fde0c40367d8f243a37f06dfbba353
Reviewed-on: https://dart-review.googlesource.com/60581
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2018-06-27 09:30:58 +00:00
Dmitry Stefantsov 4fe71ec275 [fasta] Report instantiate-to-bound failure due to non-simple bounds
Fixes #33208, #31810, #32416, #32417

Bug: http://dartbug.com/33208
Bug: http://dartbug.com/31810
Bug: http://dartbug.com/32416
Bug: http://dartbug.com/32417
Change-Id: Id178daf35be459fdefe04091bf929b5743d89e81
Reviewed-on: https://dart-review.googlesource.com/41264
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
2018-06-22 13:41:55 +00:00
Jens Johansen 6888bc2824 Compile time error for web int literals that cannot be represented exactly
Bug: #33351
Change-Id: I2b99858dfc276dc70c3a36c289030e801145af86
Reviewed-on: https://dart-review.googlesource.com/61180
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-06-22 10:47:54 +00:00
Jens Johansen 276598199e Make DDK interpret IntLiteral.value as uint64
As per bug #33351, and based upon what dart2js does.

Change-Id: I18fec2685b22b094d191f4c70a58553a9132b86c
Reviewed-on: https://dart-review.googlesource.com/60841
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-06-20 08:18:19 +00:00
William Hesse f1d44e39fa Update status for passing Windows Firefox co19 tests
Change-Id: If7d9aabe7a192be404e36f33cecf740cf392bc60
Reviewed-on: https://dart-review.googlesource.com/60844
Reviewed-by: Jens Johansen <jensj@google.com>
2018-06-19 08:10:41 +00:00
asiva bc7220a4fd [VM] Turn dart2 on by default on the command line VM
- make Dart2 the default option for the command line VM
- add option --no-preview-dart-2 as a fallback option to run dart1
- change test scripts to use the executable dart for testing dart2 mode instead of
pkg/vm/tool/dart2
- adjust numerous build and test configurations

Change-Id: Id813fa5b71a89c7ec9335d3f6e83cfc9f35f86e7
Reviewed-on: https://dart-review.googlesource.com/58240
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-06-18 22:31:32 +00:00
Alexander Markov 57c0fc9593 [vm/corelib] More cleanup in integer operations after _Bigint is removed
Change-Id: I41da6a37e554ffb8b77f51fda3fee5a15f2b8045
Reviewed-on: https://dart-review.googlesource.com/60441
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-06-18 18:16:51 +00:00
Johnni Winther b558a9c2f4 Handle missing compile-time errors
Closes #33468

Change-Id: I6da12012103ed465257335ce5bb81ba1fc54c81a
Reviewed-on: https://dart-review.googlesource.com/60500
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-18 07:34:46 +00:00
Aske Simon Christensen 309baedc72 Mark some frequently flaky co19 dart2js tests.
Change-Id: Ia30d9e7b3ffc4ebf83c0d9fc9e16c687f615b0f1
Reviewed-on: https://dart-review.googlesource.com/60260
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2018-06-15 08:16:04 +00:00
Aske Simon Christensen f20672e00a Parse name of factory as method name instead of constructor reference.
Report an error when a factory constructor has type parameters.

Report a better error than the old "couldn't find constructor" or
"illegal method name" when the name of a constructor does not match
the name of the enclosing class.

Fixes https://github.com/dart-lang/sdk/issues/31196

Change-Id: Ie46a5b4cbe07ba05ce2936e1f8f9ca2cad0208f7
Reviewed-on: https://dart-review.googlesource.com/57620
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
2018-06-11 09:55:24 +00:00
Alexander Thomas e0552b0cdd [gardening] Update status for chrome minified csp
TBR=whesse@google.com

Change-Id: I26e13bf513f9a498231b247b831d73fa02245492
Reviewed-on: https://dart-review.googlesource.com/59094
Reviewed-by: Alexander Thomas <athom@google.com>
2018-06-07 15:29:23 +00:00
Florian Loitsch 31e3441816 Fix bad status lines (wrong tests...)
Change-Id: Icc25dd8c915e4f99ff57dd39c08a0ea000144bea
Reviewed-on: https://dart-review.googlesource.com/58781
Reviewed-by: Florian Loitsch <floitsch@google.com>
2018-06-06 16:31:22 +00:00
Florian Loitsch 18828ac77a Mark some co19 tests as crashing.
Change-Id: I1d977b176dee5711a3b09ca7715171853994f3d7
Reviewed-on: https://dart-review.googlesource.com/58780
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-06-06 15:54:31 +00:00
Florian Loitsch 398ba13e4a Reapply "Make --sync-async the default for the VM."
Change-Id: I6e4da0da6c3f635d84380b384ae17fbb55587895
Reviewed-on: https://dart-review.googlesource.com/58721
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
2018-06-06 14:32:13 +00:00
Emily Fortuna 134e00fd73 Treat 64 bit ints as unsigned until conversion to JS.
Change-Id: Idb9c5d4a3562f59bc75a5bb7eef4b7af8f5df992
Reviewed-on: https://dart-review.googlesource.com/57714
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-06-06 00:28:28 +00:00
Ryan Macnak 53f7bb175e Revert "Make --sync-async the default for the VM."
This reverts commit 1ddf553eb6.

Reason for revert: Failing service tests

Original change's description:
> Make --sync-async the default for the VM.
> 
> Change-Id: Ic6d7bbc27835ea7b197cccf05724adb99e95dd51
> Reviewed-on: https://dart-review.googlesource.com/57580
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=vegorov@google.com,kustermann@google.com,floitsch@google.com

Change-Id: I062cb40badf0d1cf1808bee152fdd4074b00179d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/58380
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-06-04 21:04:20 +00:00
Florian Loitsch 1ddf553eb6 Make --sync-async the default for the VM.
Change-Id: Ic6d7bbc27835ea7b197cccf05724adb99e95dd51
Reviewed-on: https://dart-review.googlesource.com/57580
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-06-04 18:05:20 +00:00
Lasse R.H. Nielsen 315a186dc4 Better test error handler argument types.
Change-Id: I460a40dc9db096f3ae95602ba9c8dc86b4576c56
Reviewed-on: https://dart-review.googlesource.com/53208
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-06-01 12:26:37 +00:00
Dmitry Stefantsov 00f75adfaf Emit a compile-time error on incorrect types of initializing formals
Fixes #32526.

Bug: http://dartbug.com/32526
Change-Id: I1e4738937ade7592f7fb1d16bf485ad4ccd077c2
Reviewed-on: https://dart-review.googlesource.com/46801
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
2018-05-31 13:31:42 +00:00
Emily Fortuna e7bad54986 Make dart2js only run with 64 bit ints, not the larger ints from the vm.
Change-Id: I03887a0af963f1a8f68acff0428635fc130687f5
Reviewed-on: https://dart-review.googlesource.com/57041
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-30 17:21:49 +00:00
Dan Rubel b7336ab443 Improve field type argument recovery
This CL improves recovery when parsing field type arguments
and adds more tests for parsing type parameters and type arguments.

Change-Id: Ib6ee4081f898d0421d90a66de84d686206a06a8f
Reviewed-on: https://dart-review.googlesource.com/56682
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-05-29 16:30:46 +00:00
Alexander Thomas d28c5499fc [infra] Add support for app_jitk compiler to test.py (#33126)
* Add app_jitk configuration to test matrix.
* Skip it on non-Dart 2 test suites.

Change-Id: I05f75dbbd33d34a4acf4df1fe63104933d39d2fe
Reviewed-on: https://dart-review.googlesource.com/56113
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-05-28 11:54:56 +00:00