181efd76ee
Add missing null-tests to async error functions.
...
Also treat null errors comming out of Zone.errorCallback as
NullThrownError.
This should prevent, as was always the intention, any async error
from having a null value.
This is important for async/await syntax, where the distinction
between sync and async errors is removed.
(For Dart 2.0, we could just make null throwable).
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//598993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40673 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-25 11:00:49 +00:00
729aeb63a5
Temporary disable until co19 tests are updated for 38 roll
...
Reviewers=vsm@google.com
R=vsm@google.com
Review URL: https://codereview.chromium.org//599053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40630 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-24 15:55:38 +00:00
d57c4fb9d1
Update co19 webgl test status on Android content-shell.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//574693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40309 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 11:10:27 +00:00
603f3f8c58
Update status for android content_shell flaky test
...
BUG=dartbug.com/20956
R=ricow@google.com
Review URL: https://codereview.chromium.org//575433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40239 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 13:06:17 +00:00
2eb587b49d
Status fixes
...
TBR=terry@google.com ,leafp@google.com
Review URL: https://codereview.chromium.org//565213006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40222 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 22:02:03 +00:00
df319447f1
Remove suppressions for ie9
...
R=blois@google.com , whesse@google.com
Review URL: https://codereview.chromium.org//562883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40201 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 06:01:14 +00:00
e8b1664952
Skip co19/LibTest/collection/ListMixin/ListMixin_class_A01_t02 on dartium android
...
It is flaky timing out.
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//570553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40200 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 06:01:03 +00:00
183abe7207
Fix StoreIndexedInstr input representation requirements for Int32/Uint32 arrays.
...
Previous implementation changed input representation depending on the propagated type of the value which violated assumptions made by SelectRepresentations phase.
Instead of using tagged/mint input require unboxed Int32/Uint32 input and insert explicit truncating unboxing when building StoreIndexed operation in the optimizer. This also leads to strictly better code and opens possibilities for further optimizations.
Implement Int32/Uint32 representation support on all platforms. This includes boxing, unboxing and unboxed converter operations.
Merge BoxInt32/BoxUint32 and UnboxInt32/UnboxUint32 instruction sequences to minimize duplication.
Improve instruction sequences by utilizing CARRY flag set by smi untagging where possible (ARM, ia32, x86).
Enable all tests that were disabled by r40078, r40079.
BUG=http://dartbug.com/20875
R=fschneider@google.com , johnmccutchan@google.com , srdjan@google.com , zra@google.com
Review URL: https://codereview.chromium.org//552303005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40143 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 12:32:54 +00:00
9ff3cd3342
Fix wrong conversion from double to bigint in overriden operators of new bigint.
...
Fix ambiguous call to pow on Windows.
Fix big_integer_vm_test to use numbers large enough to actually be bigint.
Re-enable dart2js tests.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//559203003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40122 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 22:26:59 +00:00
9d36e86f25
Update Android content shell status for co19 empty library part test.
...
The test co19/Language/14_Libraries_and_Scripts/3_Parts_A01_t05 is timing out on android, but not consistently.
BUG=dartbug.com/20881
R=ricow@google.com
Review URL: https://codereview.chromium.org//556213003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40091 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 14:36:34 +00:00
1462d2bd71
- Disable tests failing on vm-linux-release-optcounter-threshold-be.
...
Review URL: https://codereview.chromium.org//553313003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40078 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 03:20:56 +00:00
a1939b4f41
Disable another multiplication test in dart2js.
...
Review URL: https://codereview.chromium.org//559713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40070 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 23:25:36 +00:00
db8e2acd73
Disable a multiplication test in dart2js.
...
R=srdjan@google.com
Review URL: https://codereview.chromium.org//562463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40066 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 22:50:40 +00:00
1c65618a75
Fix dartium debug status
...
TBR'ing to get the bots green.
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//549143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40040 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 16:49:30 +00:00
bb2aba6d4e
Mark co19/LibTest/core/DateTime/DateTime.now_A01_t02 as flaky on the vm
...
This is co19 issue 709:
https://code.google.com/p/co19/issues/detail?id=709
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//548303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39963 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 14:08:15 +00:00
457c8c33c7
Remove support for the DeferredLibrary annotation and remove tests of it
...
BUG= 18562
R=floitsch@google.com , hausner@google.com
Review URL: https://codereview.chromium.org//429883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39797 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-03 08:34:34 +00:00
8fec1f3241
Update dartium android status on co19 tests.
...
Save coredumps from crashes on pub bots.
BUG=
TBR=kustermann@google.com
Review URL: https://codereview.chromium.org//528793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39730 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-01 15:33:44 +00:00
7681f9304a
Update Dartium android co19 status.
...
Also fix whitespace
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//508013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39584 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 08:52:38 +00:00
6e637eb27f
Initializing a final instance is a runtime error
...
If a final instance variable is initialized at the point of declaration, it
is a runtime error if it is initialized again in a constructor’s initializer
list or by an initializing formal.
If any instance field is initialized more than once in the initializer list of
a constructor, or by an initializing formal parameter, it is a compile time
error.
Adding a new test to cover the expected runtime error.
Fixes issue 13335.
R=regis@google.com
Review URL: https://codereview.chromium.org//505033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39562 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-26 19:37:36 +00:00
dc1a1cdb2a
Attempt to reduce Dartium debug bot redness.
...
R=asiva@google.com
Review URL: https://codereview.chromium.org//502603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39504 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-22 20:49:42 +00:00
3d48991511
Update co19 status for dartium and android.
...
BUG=dartbug.com/19544
R=kustermann@google.com
Review URL: https://codereview.chromium.org//489383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39450 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-21 13:30:41 +00:00
94431a2a59
Update co19 status on dartium.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//473023004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39400 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 09:42:07 +00:00
e759a13406
Update co19 test status on dartium-android for r761 roll.
...
BUG=
TBR=kustermann@google.com
Review URL: https://codereview.chromium.org//484233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39371 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-19 15:53:32 +00:00
7d3eb10a8c
Update co19 status for dartium-android after roll to r761.
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//487703003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39369 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-19 14:08:31 +00:00
4b9da04080
Update co19 status after roll to r761
...
BUG=
R=kustermann@google.com
Review URL: https://codereview.chromium.org//488583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39368 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-19 12:38:04 +00:00
8f54a8b5bd
Update CO19 test suite to r761
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//487603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39367 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-19 11:33:27 +00:00
74889f5721
Refactor and simplify the dart2dart renamer and placeholder collector.
...
Also solves an issue where a local was renamed to dynamic.
BUG=19751, 13077, 12747, 12753
R=jgruber@google.com , johnniwinther@google.com
Review URL: https://codereview.chromium.org//448943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39326 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 10:39:14 +00:00
fccb33a355
Update status files to ensure dartium-debug builds are green on the bot.
...
R=rmacnak@google.com
Review URL: https://codereview.chromium.org//472953004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39303 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 16:59:31 +00:00
0a23613d60
Create an erroneous element for static private access.
...
BUG=http://dartbug.com/20458
R=karlklose@google.com
Review URL: https://codereview.chromium.org//451143004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39117 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-12 07:04:55 +00:00
0986f8b4c8
Deflake status files for Android content_shell tests.
...
R=ricow@google.com
Review URL: https://codereview.chromium.org//449423002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39033 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-08 09:54:58 +00:00
375471e79f
Ignore deferred loading from dart backend.
...
A warning will be printed instead of an error.
BUG=20109
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//438953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38849 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-04 08:18:35 +00:00
1b1570aa12
Status fixes for Dartium 37
...
Dependent on: https://chromiumcodereview.appspot.com/429073003/
R=ricow@google.com
Review URL: https://codereview.chromium.org//430713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38780 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 14:26:22 +00:00
84da0dbd3b
Disable tests which require cross frame access (same origin)
...
Several co19 tests assume that the result of window.open will be a window
(instead of a cross frame window), and try to perform illegal operations
on it. These are already disabled for dart2js. For dartium, these were
(incorrectly) working because of https://code.google.com/p/dart/issues/detail?id=20143 .
This CL disables these tests for Dartium. Depending on the resolution of
https://code.google.com/p/dart/issues/detail?id=20146 , they may later
be enabled.
BUG=https://code.google.com/p/dart/issues/detail?id=20143
R=jacobr@google.com
Review URL: https://codereview.chromium.org//411953003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38542 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-24 17:08:16 +00:00
3ecdc23873
Mark test as failing in old dart2dart backend only
...
BUG=
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//413713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38498 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-23 14:07:21 +00:00
06b816d668
Fix main handling in dart2js and add tests.
...
BUG=https://code.google.com/p/dart/issues/detail?id=5683
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//285903006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38187 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 11:53:25 +00:00
819f1cc91c
Mark test as failing.
...
Review URL: https://codereview.chromium.org//382073002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38135 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 22:08:18 +00:00
fad2195137
Mark tests as crashing.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//381903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38121 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 14:08:01 +00:00
974e9adeed
Dart2dart rename unresolved getters & Make IsCheck not be a primitive
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org//374413002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38113 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 10:37:56 +00:00
5720b9be2c
Update Android content_shell test status.
...
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//362323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37944 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 12:29:07 +00:00
c3208cc48c
Mark test as flaky on ie9.
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//367943004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37937 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 09:35:32 +00:00
7ebcbb131d
Mark 2 co19 tests as flaky on ie
...
The runtime error markers where removed in revision 37932, but they are actually flaky
Review URL: https://codereview.chromium.org//368813004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37934 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 07:32:59 +00:00
2e7ba20493
Update test expectations for two passing tests on IE9.
...
TBR=johnniwinther@google.com
Review URL: https://codereview.chromium.org//368803005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37932 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 06:31:46 +00:00
ab2fe30d18
Rewrite 'throw thrownException' with 'throw new AnalysisException(...)'
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//355203009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37917 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 22:15:57 +00:00
4140b865ad
Report an error from dart2dart when deferred loading is used.
...
R=asgerf@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//362743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37867 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 12:37:20 +00:00
59896fff4a
Change new Uri(query:"") to not add a query part.
...
This is for backwards compatibility.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//355013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37731 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 11:14:13 +00:00
b9d3d5bbae
Try to retain original structure of URI.
...
This changes URI.parse to retain empty autorities, queries and fragments.
That is: `Uri.parse("foo:///x?#")` will give a Uri with toString "foo:///x?#",
as opposed to the previous "foo:/".
It also makes a difference between passing "" and null to the Uri constructor.
We still omit empty user-info and default port values from the toString.
R=ajohnsen@google.com
Committed: https://code.google.com/p/dart/source/detail?r=37690
Review URL: https://codereview.chromium.org//352093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37728 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 09:41:30 +00:00
f2afbd9a62
Revert "Try to retain original structure of URI."
...
Breaks dart2js.
Review URL: https://codereview.chromium.org//335773003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37692 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-25 11:59:13 +00:00
0200cfcc67
Try to retain original structure of URI.
...
This changes URI.parse to retain empty autorities, queries and fragments.
That is: `Uri.parse("foo:///x?#")` will give a Uri with toString "foo:///x?#",
as opposed to the previous "foo:/".
It also makes a difference between passing "" and null to the Uri constructor.
We still omit empty user-info and default port values from the toString.
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//352093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37690 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-25 11:16:32 +00:00
f58745f751
Fix parsing and resolving of prefixed names
...
R=regis@google.com
Review URL: https://codereview.chromium.org//352523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37631 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-23 23:26:26 +00:00
0baf6ab684
Allow #[] and #[]= symbols.
...
BUG= http://dartbug.com/15653
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//346603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37481 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 09:29:17 +00:00
lrn@google.com